Re: [Lldb-commits] [PATCH] D24919: Adding a RegisterContextMinidump_x86_64 converter

dvlahovski added a comment. I tested this on the yet-to-be-submitted plugin code and it works fine on Linux (should work fine everywhere for that matter). I can do a backtrace, go up/down the stack frames and, of course, see all of the registers with `register read`

Re: [Lldb-commits] [PATCH] D24919: Adding a RegisterContextMinidump_x86_64 converter

labath added a comment. lgtm, after Zachary is happy. https://reviews.llvm.org/D24919 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D24919: Adding a RegisterContextMinidump_x86_64 converter

dvlahovski added inline comments. Comment at: source/Plugins/Process/minidump/RegisterContextMinidump_x86_64.cpp:49 @@ +48,3 @@ +writeRegister(source_data, result_base, _info[lldb_cs_x86_64], 2); + } + sizeof(uint16_t), sizeof(uint32_t), etc ?

Re: [Lldb-commits] [PATCH] D24919: Adding a RegisterContextMinidump_x86_64 converter

amccarth added inline comments. Comment at: source/Plugins/Process/minidump/RegisterContextMinidump_x86_64.cpp:1 @@ +1,2 @@ +//===-- Registers_x86_64.cpp *- C++ -*-===// +// Should match file name. Comment

Re: [Lldb-commits] [PATCH] D24919: Adding a RegisterContextMinidump_x86_64 converter

zturner added inline comments. Comment at: source/Plugins/Process/minidump/RegisterContextMinidump_x86_64.cpp:49 @@ +48,3 @@ +writeRegister(source_data, result_base, _info[lldb_cs_x86_64], 2); + } + dvlahovski wrote: > sizeof(uint16_t), sizeof(uint32_t),

Re: [Lldb-commits] [PATCH] D24919: Adding a RegisterContextMinidump_x86_64 converter

dvlahovski added inline comments. Comment at: source/Plugins/Process/minidump/RegisterContextMinidump_x86_64.cpp:47-48 @@ +46,4 @@ + + if (*context_flags & uint32_t(MinidumpContext_x86_64_Flags::Control)) { +writeRegister(source_data, result_base, _info[lldb_cs_x86_64], 2);

[Lldb-commits] [lldb] r282408 - Remove ancient icc decorators

Author: labath Date: Mon Sep 26 09:34:02 2016 New Revision: 282408 URL: http://llvm.org/viewvc/llvm-project?rev=282408=rev Log: Remove ancient icc decorators Nobody is running the test suite with icc, so we have no idea if they pass. But the bug they link to has definitely been fixed. Modified:

Re: [Lldb-commits] [PATCH] D24919: Adding a RegisterContextMinidump_x86_64 converter

labath added inline comments. Comment at: source/Plugins/Process/minidump/MinidumpParser.h:42 @@ -41,1 +41,3 @@ + const uint8_t *GetBaseAddr(); + Replace these two functions with `llvm::ArrayRef GetData() const` Comment at:

Re: [Lldb-commits] [PATCH] D24919: Adding a RegisterContextMinidump_x86_64 converter

zturner added inline comments. Comment at: source/Plugins/Process/minidump/RegisterContextMinidump_x86_64.cpp:46-47 @@ +45,4 @@ + source_data = source_data.drop_front(6 * 8); // p[1-6] home registers + const uint32_t *context_flags; + consumeObject(source_data,

[Lldb-commits] [PATCH] D24919: Adding a RegisterContextMinidump_x86_64 converter

dvlahovski created this revision. dvlahovski added reviewers: labath, zturner. dvlahovski added subscribers: amccarth, lldb-commits. Herald added subscribers: mgorny, beanz. This is a register context converter from Minidump to Linux reg context. This knows the layout of the register context in

Re: [Lldb-commits] [PATCH] D24919: Adding a RegisterContextMinidump_x86_64 converter

dvlahovski added a comment. I will fix the comments that Zachary made in the next revision https://reviews.llvm.org/D24919 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D24919: Adding a RegisterContextMinidump_x86_64 converter

dvlahovski updated this revision to Diff 72509. dvlahovski marked 4 inline comments as done. dvlahovski added a comment. Updating the CL regarding Pavel's comments https://reviews.llvm.org/D24919 Files: source/Plugins/Process/minidump/CMakeLists.txt

Re: [Lldb-commits] [PATCH] D24919: Adding a RegisterContextMinidump_x86_64 converter

dvlahovski added inline comments. Comment at: source/Plugins/Process/minidump/RegisterContextMinidump_x86_64.cpp:47-48 @@ +46,4 @@ + + if (*context_flags & uint32_t(MinidumpContext_x86_64_Flags::Control)) { +writeRegister(source_data, result_base, _info[lldb_cs_x86_64], 2);

[Lldb-commits] [lldb] r282432 - Fix serialization of Python breakpoint commands.

Author: jingham Date: Mon Sep 26 14:47:37 2016 New Revision: 282432 URL: http://llvm.org/viewvc/llvm-project?rev=282432=rev Log: Fix serialization of Python breakpoint commands. CommandData breakpoint commands didn't know whether they were Python or Command line commands, so they couldn't

[Lldb-commits] [lldb] r282434 - Added a setting that enables saving all .o files from a given JIT expression.

Author: spyffe Date: Mon Sep 26 15:18:51 2016 New Revision: 282434 URL: http://llvm.org/viewvc/llvm-project?rev=282434=rev Log: Added a setting that enables saving all .o files from a given JIT expression. This allows debugging of the JIT and other analyses of the internals of the expression

Re: [Lldb-commits] [PATCH] D17635: Continue after process exit

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Looks like patch was not committed. https://reviews.llvm.org/D17635 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D24936: Make FileSpec use StringRef.

zturner created this revision. zturner added a reviewer: clayborg. zturner added a subscriber: lldb-commits. zturner added a dependency: D24880: Add StringExtras join_items function. This patch depends on D24880 going in for the `join_items` function, but at least you can comment on it now.

[Lldb-commits] [lldb] r282445 - Fix an issue where LLDB would not accept the --description-verbosity option to 'po' without an argument after the StringRef refactoring

Author: enrico Date: Mon Sep 26 16:36:17 2016 New Revision: 282445 URL: http://llvm.org/viewvc/llvm-project?rev=282445=rev Log: Fix an issue where LLDB would not accept the --description-verbosity option to 'po' without an argument after the StringRef refactoring Fixes rdar://28480275

Re: [Lldb-commits] [PATCH] D24890: implement timeout sample support for Linux

This revision was automatically updated to reflect the committed changes. Closed by commit rL282436: added Linux support for test timeout sampling (authored by tfiala). Changed prior to commit: https://reviews.llvm.org/D24890?vs=72382=72553#toc Repository: rL LLVM

[Lldb-commits] [lldb] r282436 - added Linux support for test timeout sampling

Author: tfiala Date: Mon Sep 26 15:25:47 2016 New Revision: 282436 URL: http://llvm.org/viewvc/llvm-project?rev=282436=rev Log: added Linux support for test timeout sampling This is the Linux counterpart to the sampling support I added on the macOS side. This change also introduces zip-file

Re: [Lldb-commits] [PATCH] D24890: implement timeout sample support for Linux

tfiala added a comment. BTW, regarding this part: > On Ubuntu 16.04, the requisite support can be retrieved with: > > sudo apt-get install perf-tools-unstable This was incorrect. The perf tool was actually present even without the perf-tools-unstable on Ubuntu 16.04 x86_64. It is just

Re: [Lldb-commits] [PATCH] D24936: Make FileSpec use StringRef.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Watch the buildbots for failures, but this looks fine. We aren't changing how the strings for filename and directory are stored, just using StringRef to deliver the arguments.

Re: [Lldb-commits] [PATCH] D24629: Allow for tests to be disabled at runtime

labath added a comment. In https://reviews.llvm.org/D24629#550841, @fjricci wrote: > In https://reviews.llvm.org/D24629#550823, @tfiala wrote: > > > > > There is no reasonable thing we can base the expectation as the exact > > > > same device with a different cpu revision could support

Re: [Lldb-commits] [PATCH] D24890: implement timeout sample support for Linux

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D24890 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D24610: LLDB Arm Watchpoints: Use single hardware watchpoint slot to watch multiple bytes where possible

omjavaid updated this revision to Diff 72589. omjavaid added a comment. This is a new version of what seems to me fully implementing functionality we intend to have here. On a second thought nuking ClearHardwareWatchpoint function seems to be the wrong approach here. I spent some time taking

Re: [Lldb-commits] [PATCH] D13578: Allow generic arm ArchSpec to merge with specific arm ArchSpec; allow Cortex M0-7's to always force thumb mode

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in https://reviews.llvm.org/rL265377. Repository: rL LLVM https://reviews.llvm.org/D13578 ___ lldb-commits mailing

Re: [Lldb-commits] [PATCH] D13350: [lldb] Fix evaluation of qualified global variables

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Looks like patch was not committed. https://reviews.llvm.org/D13350 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13154: [MIPS] Use Address::GetAddressClass() instead of elf flags to decide address space of an address

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Looks like patch was not committed. Repository: rL LLVM https://reviews.llvm.org/D13154 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r282406 - Remove an ancient XFAIL from TestBuiltinTrap

Author: labath Date: Mon Sep 26 08:50:06 2016 New Revision: 282406 URL: http://llvm.org/viewvc/llvm-project?rev=282406=rev Log: Remove an ancient XFAIL from TestBuiltinTrap in refers to gcc-4.6. Hopefully noone is using that anymore, and I think there is a good chance it was fixed anyway.

Re: [Lldb-commits] [lldb] r282445 - Fix an issue where LLDB would not accept the --description-verbosity option to 'po' without an argument after the StringRef refactoring

Test would be nice, but otoh command line tests are discouraged. Maybe it will be easier to write this kind of test if we had a tool specifically for testing command line options similar to what I proposed with unwinding etc. oh well On Mon, Sep 26, 2016 at 2:45 PM Enrico Granata via lldb-commits

Re: [Lldb-commits] [PATCH] D14136: Refactor Windows process plugin to enable sharing of code between live and post-mortem debugging

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in https://reviews.llvm.org/rL251540. https://reviews.llvm.org/D14136 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D24952: Remove Args::m_argv

zturner created this revision. zturner added a reviewer: clayborg. zturner added subscribers: lldb-commits, LLDB. The `Args` class was trying to maintain two parallel argument vectors. One that owned the memory and contained `std::strings`, and one that contained `const char *`'s that could be

Re: [Lldb-commits] [PATCH] D24952: Remove Args::m_argv

zturner added a comment. Ignore the changes to `FileSpec`, it seems the two CLs I was working on got mixed together. https://reviews.llvm.org/D24952 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace updated this revision to Diff 72597. wallace added a comment. minor nits https://reviews.llvm.org/D24284 Files: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h Index: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace updated this revision to Diff 72596. wallace added a comment. This time I'm calculating the address of the exports header correctly because it is an RVA address. https://reviews.llvm.org/D24284 Files: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp

Re: [Lldb-commits] [lldb] r282445 - Fix an issue where LLDB would not accept the --description-verbosity option to 'po' without an argument after the StringRef refactoring

> On Sep 26, 2016, at 2:50 PM, Zachary Turner wrote: > > Test would be nice, but otoh command line tests are discouraged. Maybe it > will be easier to write this kind of test if we had a tool specifically for > testing command line options similar to what I proposed with

Re: [Lldb-commits] [lldb] r282445 - Fix an issue where LLDB would not accept the --description-verbosity option to 'po' without an argument after the StringRef refactoring

Oh cool. Is it not hooked up to the public waterfall? On Mon, Sep 26, 2016 at 3:02 PM Enrico Granata wrote: > On Sep 26, 2016, at 2:50 PM, Zachary Turner wrote: > > Test would be nice, but otoh command line tests are discouraged. Maybe it > will be easier

Re: [Lldb-commits] [lldb] r282445 - Fix an issue where LLDB would not accept the --description-verbosity option to 'po' without an argument after the StringRef refactoring

> On Sep 26, 2016, at 3:03 PM, Zachary Turner wrote: > > Oh cool. Is it not hooked up to the public waterfall? That's a really good question... It's marked @skipUnlessDarwin, but that's about all that is remarkable about it; I know about the failure because someone