Re: [Lldb-commits] Instruction emulation of arm64 'stp d8, d9, [sp, #-0x70]!' style instruction

2016-10-13 Thread Tamas Berghammer via lldb-commits
In case of Linux and Android we are using the qRegisterInfo packet and lldb-server fills it in based on the register definitions inside LLDB so for those targets it would be important to have all of the alias registers available. I don't have an AArch64-BE target at hand but I am pretty sure you

[Lldb-commits] [PATCH] D25569: Minidump plugin: memory stuff and filtering module list

2016-10-13 Thread Dimitar Vlahovski via lldb-commits
dvlahovski updated this revision to Diff 74551. dvlahovski added a comment. Forgot to run clang-format. Also changed a helper function in the tests to make it simpler. https://reviews.llvm.org/D25569 Files: source/Plugins/Process/minidump/MinidumpParser.cpp

[Lldb-commits] [PATCH] D25489: Use LLDB_SRC for relative paths

2016-10-13 Thread Todd Fiala via lldb-commits
tfiala added a comment. (Retro) LGTM. Repository: rL LLVM https://reviews.llvm.org/D25489 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D25570: [CMake] Populate LLDB.framework's headers directory

2016-10-13 Thread Chris Bieneman via lldb-commits
beanz created this revision. beanz added reviewers: tfiala, zturner, spyffe. beanz added a subscriber: lldb-commits. Herald added a subscriber: mgorny. This patch adds support for installing public headers in LLDB.framework, and symlinking the headers into the build directory. While writing the

[Lldb-commits] [PATCH] D25488: Fix test suite lookup path for LLDB.h

2016-10-13 Thread Todd Fiala via lldb-commits
tfiala added a comment. (Retro) LGTM. Repository: rL LLVM https://reviews.llvm.org/D25488 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D25569: Minidump plugin: memory stuff and filtering module list

2016-10-13 Thread Dimitar Vlahovski via lldb-commits
dvlahovski created this revision. dvlahovski added reviewers: labath, zturner. dvlahovski added subscribers: amccarth, lldb-commits. Herald added subscribers: modocache, mgorny, beanz. Now the Minidump parser can parse the: 1. MemoryInfoList - containing region info about memory ranges

[Lldb-commits] [PATCH] D25487: Fix building tests without system headers on Darwin

2016-10-13 Thread Todd Fiala via lldb-commits
tfiala added a comment. (Retro) yep, this looked fine. Repository: rL LLVM https://reviews.llvm.org/D25487 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D25490: [CMake] Cleanup check-lldb targets

2016-10-13 Thread Todd Fiala via lldb-commits
tfiala added a comment. (Retro) Ah nice, I like the generator expression you put in there. Repository: rL LLVM https://reviews.llvm.org/D25490 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D25570: [CMake] Populate LLDB.framework's headers directory

2016-10-13 Thread Chris Bieneman via lldb-commits
beanz added a comment. Worth noting, the CMake bug now has a fix in a pull request: https://gitlab.kitware.com/cmake/cmake/merge_requests/172 https://reviews.llvm.org/D25570 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r284182 - This test is passing on i386 now.

2016-10-13 Thread Jim Ingham via lldb-commits
Author: jingham Date: Thu Oct 13 20:03:03 2016 New Revision: 284182 URL: http://llvm.org/viewvc/llvm-project?rev=284182=rev Log: This test is passing on i386 now. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/objc/objc-class-method/TestObjCClassMethod.py Modified:

[Lldb-commits] [PATCH] D25570: [CMake] Populate LLDB.framework's headers directory

2016-10-13 Thread Todd Fiala via lldb-commits
tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D25570 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D23977: Support of lldb on Kfreebsd

2016-10-13 Thread Todd Fiala via lldb-commits
tfiala requested changes to this revision. tfiala added a comment. This revision now requires changes to proceed. Okay. I think we need a minor tweak, to drop the REQUIRED on the Backtrace usage. https://reviews.llvm.org/D23977 ___ lldb-commits

[Lldb-commits] [PATCH] D25592: [LLDB-MI] Minor cleanup of CMICmnLLDBUtilSBValue class

2016-10-13 Thread Ilia K via lldb-commits
ki.stfu requested changes to this revision. ki.stfu added inline comments. This revision now requires changes to proceed. Comment at: tools/lldb-mi/MICmnLLDBUtilSBValue.cpp:21-22 +static const char *kUnknownValue = "??"; +static const char *kCompositeValuePlaceholder =

[Lldb-commits] [lldb] r284114 - [lldb] Improve identification of Linux core dumps. Fix for bug #30485.

2016-10-13 Thread Richard Chamberlain via lldb-commits
Author: rnchamberlain Date: Thu Oct 13 07:11:00 2016 New Revision: 284114 URL: http://llvm.org/viewvc/llvm-project?rev=284114=rev Log: [lldb] Improve identification of Linux core dumps. Fix for bug #30485. Summary: ObjectFileELF::RefineModuleDetailsFromNote() identifies Linux core dumps by