labath created this revision.
labath added reviewers: eugene, davide.
Right now the test client is not parsing register values correctly,
which is manifesting itself in one test failing on 32-bit architectures
(pr36013). This parses the information from the qRegisterInfo packets
and stores it in
asmith added a comment.
How about this?
if (name == nullptr)
return false;
return ( (name[0] == '?') || (name[0] == '_' && name[1] == 'Z') );
Repository:
rL LLVM
https://reviews.llvm.org/D43059
___
lldb-commits mailing list
I think just remove the preprocessor block. Imagine debugging a Windows
target from a linux host. This function would return false as written
because the host wasn’t Windows
On Thu, Feb 8, 2018 at 12:18 PM Aaron Smith via Phabricator <
revi...@reviews.llvm.org> wrote:
> asmith added a comment.
>
Looks good (but for the _Z case, make sure its length is at least 2)
On Thu, Feb 8, 2018 at 12:33 PM Aaron Smith via Phabricator <
revi...@reviews.llvm.org> wrote:
> asmith added a comment.
>
> How about this?
>
> if (name == nullptr)
> return false;
>
> return ( (name[0] == '?') ||
stella.stamenova added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/process_attach/TestProcessAttach.py:49
os.mkdir(newdir)
-except OSError, e:
+except OSError as e:
if e.errno != os.errno.EEXIST:
asmith updated this revision to Diff 133467.
Repository:
rL LLVM
https://reviews.llvm.org/D42994
Files:
packages/Python/lldbsuite/test/functionalities/breakpoint/global_constructor/Makefile
packages/Python/lldbsuite/test/functionalities/breakpoint/move_nearest/Makefile
asmith updated this revision to Diff 133489.
asmith retitled this revision from "Add implementation for MSVC in
CPlusPlusLanguage::IsCPPMangledName" to "Recognize MSVC style mangling in
CPlusPlusLanguage::IsCPPMangledName".
https://reviews.llvm.org/D43059
Files:
asmith added a comment.
IsCPPMangledName() is a public method to determine if a symbol has a mangled
name.
This change is needed so that lldb can find symbols with MSVC style mangled
names.
Open to suggestions on a better way to deal with this...
Here are all the places it is used:
Author: adrian
Date: Thu Feb 8 13:52:28 2018
New Revision: 324655
URL: http://llvm.org/viewvc/llvm-project?rev=324655=rev
Log:
Rewrite testcase to not depend on Foundation implementation details.
TODO: Add a separate testcase testing *only* Foundation implementation details!
Added:
jingham added a comment.
We'd get into problems on a platform other than MSVC that uses ^? for symbol
names that aren't C++ mangled ones - or equivalently if MSVC uses ^_Z for
non-C++ mangled names.
It looks like everywhere we use this (or use GuessLanguage) we either turn
around and mangle
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
This lgtm. If this causes some tests that were previously skipped or xfailed
to start passing, you can unskip / unxfail them at the same time.
Comment at:
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324672: Recognize MSVC style mangling in
CPlusPlusLanguage::IsCPPMangledName (authored by asmith, committed by ).
aprantl created this revision.
aprantl added a reviewer: jingham.
This patch makes LLDB's clang module cache path customizable via `settings set
target.clang-modules-cache-path ` and uses it in the LLDB testsuite to
reuse the same location inside the build directory for LLDB and clang.
asmith created this revision.
asmith added reviewers: zturner, lldb-commits.
Herald added subscribers: hintonda, mgorny.
This is modeled after the clang and llvm lit tests.
Several properties have CMAKE_CFG_INTDIR as part of the path - this works
correctly when the cmake generator only supports
zturner added inline comments.
Comment at: lit/CMakeLists.txt:10-13
+string(REPLACE ${CMAKE_CFG_INTDIR} ${LLVM_BUILD_MODE} LLDB_TEST_C_COMPILER
${LLDB_TEST_C_COMPILER})
+string(REPLACE ${CMAKE_CFG_INTDIR} ${LLVM_BUILD_MODE} LLDB_TEST_CXX_COMPILER
${LLDB_TEST_CXX_COMPILER})
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
Think about whether it would be better to have GetClangModulesCachePath
calculate the fallback modules path rather than having the client do it?
Comment at:
zturner accepted this revision.
zturner added a comment.
Looks good. Wish this function took a `StringRef` so you could just say
`return name.startswith("?") || name.startswith("_Z")`
https://reviews.llvm.org/D43059
___
lldb-commits mailing list
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
Sorry for the delay on this one, looks good.
Repository:
rL LLVM
https://reviews.llvm.org/D42443
___
lldb-commits mailing list
labath added inline comments.
Comment at: packages/Python/lldbsuite/test/make/Makefile.rules:550
#--
$(DYLIB_OBJECTS) : CFLAGS += -DCOMPILING_LLDB_TEST_DLL
I think Zachary meant only when
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324590: Rewrite the flaky test_restart_bug test in a more
deterministic way (authored by labath, committed by ).
Herald
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
That seems extremely dodgy. Surely whether something is a mangled name does not
depend on the compiler we built lldb with. I am aware that we have many places
with _Z hardcoded, but
Author: labath
Date: Thu Feb 8 02:37:23 2018
New Revision: 324590
URL: http://llvm.org/viewvc/llvm-project?rev=324590=rev
Log:
Rewrite the flaky test_restart_bug test in a more deterministic way
Summary:
The test was trying to reproduce a bug in handling of two concurrent
events, which was
stella.stamenova added inline comments.
Comment at: lit/CMakeLists.txt:10-13
+string(REPLACE ${CMAKE_CFG_INTDIR} ${LLVM_BUILD_MODE} LLDB_TEST_C_COMPILER
${LLDB_TEST_C_COMPILER})
+string(REPLACE ${CMAKE_CFG_INTDIR} ${LLVM_BUILD_MODE} LLDB_TEST_CXX_COMPILER
stella.stamenova added inline comments.
Comment at: lit/CMakeLists.txt:10-13
+string(REPLACE ${CMAKE_CFG_INTDIR} ${LLVM_BUILD_MODE} LLDB_TEST_C_COMPILER
${LLDB_TEST_C_COMPILER})
+string(REPLACE ${CMAKE_CFG_INTDIR} ${LLVM_BUILD_MODE} LLDB_TEST_CXX_COMPILER
asmith updated this revision to Diff 133561.
asmith added a comment.
Minor cleanup before commit
https://reviews.llvm.org/D42443
Files:
lit/SymbolFile/PDB/Inputs/FuncSymbols.cpp
lit/SymbolFile/PDB/Inputs/FuncSymbolsTestMain.cpp
lit/SymbolFile/PDB/Inputs/SimpleTypesTest.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL324707: [SymbolFilePDB] Add support for function symbols
(authored by asmith, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42443?vs=133561=133562#toc
Repository:
rL LLVM
The problem is that CMAKE_CFG_INTDIR evaluates to something very common,
like “Debug” or “Release”, and replacing a common string like that in a
path creates more problems than it solves in my opinion. What if your build
dir is C:\src\LLDBDebugger\out\Debug\clang.exe? Debug appears twice in this
labath added a comment.
The change seems fine to me, and I don't really have anything to add to the
things that were said already.
Testing the completion of things that require a target/module/etc. will be a
bit tricky, but that's something we should figure out anyway to have more
targeted
28 matches
Mail list logo
