[Lldb-commits] [PATCH] D47021: Fix PathMappingList for relative and empty paths after recent FileSpec normalization changes

clayborg updated this revision to Diff 147587. clayborg added a comment. - Fixed Pavel's issues - If user specifies "" as the first directory in PathMappingList, it will match "." - User can specify "/" as the first directory to remap all absolute paths - Fixed FileSpec::IsAbsolute() and added

[Lldb-commits] [PATCH] D46889: [DWARF] Extract indexing code into a separate class hierarchy

labath added a comment. In https://reviews.llvm.org/D46889#1104882, @aemerson wrote: > In https://reviews.llvm.org/D46889#1104823, @aprantl wrote: > > > Thanks for jumping on this Amara — I just wanted to point out that we > > ususally don't revert lldb changes that only break the lldb-xcode

Re: [Lldb-commits] [PATCH] D46889: [DWARF] Extract indexing code into a separate class hierarchy

> On May 18, 2018, at 11:25 AM, Amara Emerson via Phabricator > wrote: > > aemerson added a comment. > > In https://reviews.llvm.org/D46889#1104823, @aprantl wrote: > >> Thanks for jumping on this Amara — I just wanted to point out that we >> ususally don't revert

[Lldb-commits] [PATCH] D46889: [DWARF] Extract indexing code into a separate class hierarchy

aemerson added a comment. In https://reviews.llvm.org/D46889#1104823, @aprantl wrote: > Thanks for jumping on this Amara — I just wanted to point out that we > ususally don't revert lldb changes that only break the lldb-xcode bot if they > pass on the lldb-cmake bot at the same time. When this

Re: [Lldb-commits] [PATCH] D46889: [DWARF] Extract indexing code into a separate class hierarchy

Thanks for jumping on this Amara — I just wanted to point out that we ususally don't revert lldb changes that only break the lldb-xcode bot if they pass on the lldb-cmake bot at the same time. When this happens it usually means that the lldb Xcode project must be updated and it's too much to

[Lldb-commits] [PATCH] D46889: [DWARF] Extract indexing code into a separate class hierarchy

aprantl added subscribers: jingham, jasonmolenda, labath. aprantl added a comment. Thanks for jumping on this Amara — I just wanted to point out that we ususally don't revert lldb changes that only break the lldb-xcode bot if they pass on the lldb-cmake bot at the same time. When this happens

[Lldb-commits] [PATCH] D47062: Suggest lldb-dotest to reproduce a failure.

aprantl added inline comments. Comment at: packages/Python/lldbsuite/test/dosep.py:122 print("[%s FAILED]%s" % (name, timeout_str), file=sys.stderr) -print("Command invoked: %s" % ' '.join(command), file=sys.stderr) +print("Reproduce with:

[Lldb-commits] [PATCH] D46889: [DWARF] Extract indexing code into a separate class hierarchy

aemerson reopened this revision. aemerson added a comment. This revision is now accepted and ready to land. Hi Pavel, I reverted this in r332730 due to the bot breaking. Please have a look and commit again when ready. Thanks, Amara Repository: rL LLVM https://reviews.llvm.org/D46889

[Lldb-commits] [PATCH] D47062: Suggest lldb-dotest to reproduce a failure.

JDevlieghere marked an inline comment as done. JDevlieghere added a comment. In https://reviews.llvm.org/D47062#1104558, @davide wrote: > Can you commit the whitespace fixes separately? Sure. Comment at: packages/Python/lldbsuite/test/dosep.py:122 print("[%s

[Lldb-commits] [PATCH] D46889: [DWARF] Extract indexing code into a separate class hierarchy

aemerson added a comment. This caused a failure in green dragon: http://green.lab.llvm.org/green/job/lldb-xcode/6644 Can you please fix or revert this change, thanks. Repository: rL LLVM https://reviews.llvm.org/D46889 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D47062: Suggest lldb-dotest to reproduce a failure.

aprantl added inline comments. Comment at: packages/Python/lldbsuite/test/dosep.py:122 print("[%s FAILED]%s" % (name, timeout_str), file=sys.stderr) -print("Command invoked: %s" % ' '.join(command), file=sys.stderr) +print("Reproduce with:

[Lldb-commits] [PATCH] D47062: Suggest lldb-dotest to reproduce a failure.

davide added a comment. Can you commit the whitespace fixes separately? Repository: rL LLVM https://reviews.llvm.org/D47062 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D46889: [DWARF] Extract indexing code into a separate class hierarchy

This revision was automatically updated to reflect the committed changes. Closed by commit rL332719: [DWARF] Extract indexing code into a separate class hierarchy (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r332719 - [DWARF] Extract indexing code into a separate class hierarchy

Author: labath Date: Fri May 18 07:15:46 2018 New Revision: 332719 URL: http://llvm.org/viewvc/llvm-project?rev=332719=rev Log: [DWARF] Extract indexing code into a separate class hierarchy Summary: This places the `if(m_using_apple_tables)` branches inside the SymbolFileDWARF class behind an

[Lldb-commits] [PATCH] D47064: Add some apple-tables lookup tests

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM! Comment at: lit/SymbolFile/DWARF/find-basic-function.cpp:17 // RUN: FileCheck --check-prefix=EMPTY %s +// +// RUN: clang %s -g -c -o %t

[Lldb-commits] [PATCH] D47064: Add some apple-tables lookup tests

labath created this revision. labath added reviewers: JDevlieghere, clayborg. Herald added subscribers: ioeric, ilya-biryukov, aprantl. Now that we are able to parse MachO files everywhere, we can write some cross-platform tests for handling of apple accelerator tables. This reruns the same

[Lldb-commits] [PATCH] D47062: Suggest lldb-dotest to reproduce a failure.

JDevlieghere created this revision. JDevlieghere added reviewers: labath, davide, aprantl. Rather than trying to figure out what arguments to pass to `dotest.py`, suggest using `lldb-dotest`. Athough this obviously won't work for all invocations (i.e. when you're passing custom arguments to

[Lldb-commits] [lldb] r332710 - Add back #ifdef __APPLE__ to RegisterContextDarwin_xxx::NumSupportedHardwareWatchpoints

Author: labath Date: Fri May 18 05:54:21 2018 New Revision: 332710 URL: http://llvm.org/viewvc/llvm-project?rev=332710=rev Log: Add back #ifdef __APPLE__ to RegisterContextDarwin_xxx::NumSupportedHardwareWatchpoints It turns out these class still contained some os-specific functionality, but I

[Lldb-commits] [lldb] r332702 - Make ObjectFileMachO work on non-darwin platforms

Author: labath Date: Fri May 18 04:35:46 2018 New Revision: 332702 URL: http://llvm.org/viewvc/llvm-project?rev=332702=rev Log: Make ObjectFileMachO work on non-darwin platforms Summary: Before this patch we were unable to write cross-platform MachO tests because the parsing code did not compile

[Lldb-commits] [PATCH] D46934: Make ObjectFileMachO work on non-darwin platforms

This revision was automatically updated to reflect the committed changes. Closed by commit rL332702: Make ObjectFileMachO work on non-darwin platforms (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D46934 Files:

[Lldb-commits] [PATCH] D47021: Fix PathMappingList for relative and empty paths after recent FileSpec normalization changes

labath added a comment. Although it may not seem that way from the number of comments, the change looks good to me. The main thing is the moving of the test file, as that will fail in the cmake build. And it also looks like some code can be simplified if my assumption about not converting ""

[Lldb-commits] [lldb] r332700 - Fix _NSCFBoolean data formatter.

Author: jdevlieghere Date: Fri May 18 02:14:45 2018 New Revision: 332700 URL: http://llvm.org/viewvc/llvm-project?rev=332700=rev Log: Fix _NSCFBoolean data formatter. In r265181 the test for the NSCFBoolean data formatter was removed. Later, in r279353 and r279446 a new implementation was

[Lldb-commits] [PATCH] D47014: Fix _NSCFBoolean data formatter.

This revision was automatically updated to reflect the committed changes. Closed by commit rL332700: Fix _NSCFBoolean data formatter. (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D47014?vs=147312=147449#toc Repository: rL LLVM