xiaobai added a comment.
Looks good
Comment at: cmake/modules/LLDBFramework.cmake:41
+add_custom_target(lldb-framework-headers
+ DEPENDS ${framework_headers}
+ COMMAND ${LLDB_SOURCE_DIR}/scripts/framework-header-fix.sh
keith wrote:
> xiaobai wrote:
> > This
keith added a comment.
No problem! Yes please! :)
https://reviews.llvm.org/D49779
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
xiaobai accepted this revision.
xiaobai added a comment.
This revision is now accepted and ready to land.
Awesome! Thank you so much for your patience and contribution. :)
Do you need somebody to commit this for you?
https://reviews.llvm.org/D49779
EugeneBi added a comment.
In https://reviews.llvm.org/D49685#1176399, @labath wrote:
> In https://reviews.llvm.org/D49685#1175413, @EugeneBi wrote:
>
> > In https://reviews.llvm.org/D49685#1174770, @labath wrote:
> >
> > > Could you also add a test for this?
> >
> >
> > I never ran LLDB tests,
xiaobai added inline comments.
Comment at: cmake/modules/LLDBFramework.cmake:41
+add_custom_target(lldb-framework-headers
+ DEPENDS ${framework_headers}
+ COMMAND ${LLDB_SOURCE_DIR}/scripts/framework-header-fix.sh
keith wrote:
> xiaobai wrote:
> > keith wrote:
keith added inline comments.
Comment at: cmake/modules/LLDBFramework.cmake:41
+add_custom_target(lldb-framework-headers
+ DEPENDS ${framework_headers}
+ COMMAND ${LLDB_SOURCE_DIR}/scripts/framework-header-fix.sh
xiaobai wrote:
> This should not just depend on
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338040: Dont print two errors for unknown commands.
(authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: teemperor
Date: Thu Jul 26 09:32:05 2018
New Revision: 338040
URL: http://llvm.org/viewvc/llvm-project?rev=338040=rev
Log:
Don't print two errors for unknown commands.
Summary:
We always print two error messages when we hit an unknown command. As the
function
xiaobai requested changes to this revision.
xiaobai added a comment.
This revision now requires changes to proceed.
I think this might actually not do what we want it to do. I've commented inline
with my concerns.
Comment at: cmake/modules/LLDBFramework.cmake:21
xiaobai added inline comments.
Comment at: cmake/modules/LLDBFramework.cmake:41
+add_custom_target(lldb-framework-headers
+ DEPENDS ${framework_headers}
+ COMMAND ${LLDB_SOURCE_DIR}/scripts/framework-header-fix.sh
keith wrote:
> xiaobai wrote:
> > keith wrote:
keith added inline comments.
Comment at: cmake/modules/LLDBFramework.cmake:41
+add_custom_target(lldb-framework-headers
+ DEPENDS ${framework_headers}
+ COMMAND ${LLDB_SOURCE_DIR}/scripts/framework-header-fix.sh
xiaobai wrote:
> keith wrote:
> > xiaobai wrote:
teemperor created this revision.
So far lldb is printing this when it finds an ambiguous command:
(lldb) g
Ambiguous command 'g'. Possible matches:
gdb-remote
gui
gdb-remote
gui
The duplicates come from the fact that we call the same query twice with
keith added inline comments.
Comment at: cmake/modules/LLDBFramework.cmake:41
+add_custom_target(lldb-framework-headers
+ DEPENDS ${framework_headers}
+ COMMAND ${LLDB_SOURCE_DIR}/scripts/framework-header-fix.sh
xiaobai wrote:
> keith wrote:
> > xiaobai wrote:
keith updated this revision to Diff 157547.
keith added a comment.
- Hoist LLDB.framework headers copy out of condition
https://reviews.llvm.org/D49779
Files:
cmake/modules/LLDBFramework.cmake
Index: cmake/modules/LLDBFramework.cmake
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
LG. thanks for improving the interface, I think all these cleanups are really
good.
https://reviews.llvm.org/D49866
___
lldb-commits mailing
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338043: Fix duplicate suggestions after an ambiguous command
(authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: teemperor
Date: Thu Jul 26 10:14:18 2018
New Revision: 338043
URL: http://llvm.org/viewvc/llvm-project?rev=338043=rev
Log:
Fix duplicate suggestions after an ambiguous command
Summary:
So far lldb is printing this when it finds an ambiguous command:
```
(lldb) g
Ambiguous command 'g'.
keith updated this revision to Diff 157525.
keith added a comment.
- Make headers a post build command
https://reviews.llvm.org/D49779
Files:
cmake/modules/LLDBFramework.cmake
Index: cmake/modules/LLDBFramework.cmake
===
---
apolyakov updated this revision to Diff 157533.
apolyakov retitled this revision from "[WIP] Re-implement MI
HandleProcessEventStateSuspended." to "[lldb-mi] Re-implement MI
HandleProcessEventStateSuspended.".
apolyakov added a comment.
It seems that it's impossible to get
keith added inline comments.
Comment at: cmake/modules/LLDBFramework.cmake:41
+add_custom_target(lldb-framework-headers
+ DEPENDS ${framework_headers}
+ COMMAND ${LLDB_SOURCE_DIR}/scripts/framework-header-fix.sh
xiaobai wrote:
> keith wrote:
> > xiaobai wrote:
apolyakov updated this revision to Diff 157512.
apolyakov added a comment.
Now tcp port is choosing by debugserver.
https://reviews.llvm.org/D49739
Files:
include/lldb/API/SBTarget.h
lit/lit.cfg
lit/tools/lldb-mi/target/inputs/main.c
Author: xiaobai
Date: Thu Jul 26 12:04:46 2018
New Revision: 338058
URL: http://llvm.org/viewvc/llvm-project?rev=338058=rev
Log:
Make framework-header-fix process copied headers
Summary:
Previously the framework-header-fix script would change the sources
before they were copied, leading to
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338058: Make framework-header-fix process copied headers
(authored by xiaobai, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D49779
Files:
xiaobai added a comment.
Tested this by invoking
cmake .. -G Ninja -DCMAKE_BUILD_TYPE=Debug -DLLDB_BUILD_FRAMEWORK=1 && ninja
lldb
The resulting framework appears to be the same as before.
https://reviews.llvm.org/D49888
___
lldb-commits
zturner added a comment.
In the meantime, perhaps you could request commit access :)
https://reviews.llvm.org/D49410
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
In the meantime, perhaps you could request commit access :)
On Thu, Jul 26, 2018 at 9:30 PM Aleksandr Urakov via Phabricator <
revi...@reviews.llvm.org> wrote:
> aleksandr.urakov added a comment.
>
> Thanks!
>
> I have created the corresponding patch for Clang (
> https://reviews.llvm.org/D49871,
aleksandr.urakov added a comment.
It would be great, thank you! I'll also do it on Monday, if it's already
possible.
https://reviews.llvm.org/D49410
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
aleksandr.urakov added a comment.
Thanks!
I have created the corresponding patch for Clang
(https://reviews.llvm.org/D49871, @rnk have accepted it. Can you commit this,
please? I have no commit access).
But current patch intersects with https://reviews.llvm.org/D49368, and I'm
preparing the
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
I am not sure what are the drawbacks of such a solution are. I guess the best
way to find out is to try it and see if you observe any strange behavior :)
I'm ok with that, for now.
xiaobai created this revision.
xiaobai added a reviewer: labath.
Herald added a subscriber: mgorny.
CMake has a bug in its ninja generator that prevents you from
installing targets that are built with framework support. Therefore, I want to
not rely on CMake's framework support.
Author: xiaobai
Date: Thu Jul 26 14:55:14 2018
New Revision: 338074
URL: http://llvm.org/viewvc/llvm-project?rev=338074=rev
Log:
Add back lldb-framework-headers target
In r338058 we removed the target `lldb-framework-headers`, which mean
lldb-framework no longer depended on `framework_headers`,
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks good. It would be nice to mention the name of that other function in the
commit message.
https://reviews.llvm.org/D49831
___
lldb-commits
labath added a comment.
Thanks for the explanation. This looks fine to me, though I would feel better
if someone else gave it a look too.
Comment at: source/Core/Highlighter.cpp:29
+ if (!m_prefix.empty())
+s << lldb_utility::ansi::FormatAnsiTerminalCodes(m_prefix);
+ s
labath added a comment.
The patch makes sense to me, though I can't say I'm that familiar with this
code.
The thing I'd really like to get rid of is the need to have `return
request.GetNumberOfMatches();` everywhere, but that's a fight for another day..
Comment at:
labath added inline comments.
Comment at: lit/lit.cfg:59
-debugserver = lit.util.which('debugserver', lldb_tools_dir)
+if platform.system() in ['Darwin']:
+debugserver = lit.util.which('debugserver', lldb_tools_dir)
apolyakov wrote:
> Do we have
labath added a comment.
In https://reviews.llvm.org/D49685#1175413, @EugeneBi wrote:
> In https://reviews.llvm.org/D49685#1174770, @labath wrote:
>
> > Could you also add a test for this?
>
>
> I never ran LLDB tests, not sure where they are and what they are.
> Also, how would you test that? I
apolyakov added inline comments.
Comment at: lit/tools/lldb-mi/target/inputs/target-select-so-path.py:8-11
+def get_free_port():
+s = socket.socket()
+s.bind(('', 0))
+return s.getsockname()[1]
labath wrote:
> This is still racy, because the port can
labath added inline comments.
Comment at: lit/tools/lldb-mi/target/inputs/target-select-so-path.py:8-11
+def get_free_port():
+s = socket.socket()
+s.bind(('', 0))
+return s.getsockname()[1]
apolyakov wrote:
> labath wrote:
> > This is still racy,
labath added inline comments.
Comment at: lit/tools/lldb-mi/target/inputs/target-select-so-path.py:8-11
+def get_free_port():
+s = socket.socket()
+s.bind(('', 0))
+return s.getsockname()[1]
apolyakov wrote:
> labath wrote:
> > apolyakov wrote:
> > >
kastiglione accepted this revision.
kastiglione added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D49776
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
apolyakov added inline comments.
Comment at: lit/tools/lldb-mi/target/inputs/target-select-so-path.py:8-11
+def get_free_port():
+s = socket.socket()
+s.bind(('', 0))
+return s.getsockname()[1]
labath wrote:
> apolyakov wrote:
> > labath wrote:
> > >
apolyakov added inline comments.
Comment at: lit/tools/lldb-mi/target/inputs/target-select-so-path.py:8-11
+def get_free_port():
+s = socket.socket()
+s.bind(('', 0))
+return s.getsockname()[1]
labath wrote:
> apolyakov wrote:
> > labath wrote:
> > >
42 matches
Mail list logo
