[Lldb-commits] [PATCH] D68606: [test] Split LLDB tests into filecheck, unittest and dotest.

thopre added a comment. Shouldn't the CMake target remain check-lldb-unit to be consistant with check-llvm-unit/check-clang-unit etc.? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68606/new/ https://reviews.llvm.org/D68606

[Lldb-commits] [PATCH] D68210: Object/minidump: Add support for the MemoryInfoList stream

labath updated this revision to Diff 223811. labath added a comment. Address review comments Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68210/new/ https://reviews.llvm.org/D68210 Files: include/llvm/BinaryFormat/Minidump.h

[Lldb-commits] [PATCH] D68606: [test] Split LLDB tests into filecheck, unittest and dotest.

JDevlieghere added a comment. Essentially this patch just moves all the filecheck tests in a directory called filecheck and renames the `Suite` and `Unit` directories to `dotest` and `unittests` respectively. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68606: [test] Split LLDB tests into filecheck, unittest and dotest.

jingham added a comment. This seems much clearer to me. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68606/new/ https://reviews.llvm.org/D68606 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D68606: [test] Split LLDB tests into filecheck, unittest and dotest.

JDevlieghere created this revision. JDevlieghere added reviewers: LLDB, labath, mgorny, teemperor, stella.stamenova, xiaobai, tatyana-krasnukha. Herald added subscribers: lldb-commits, thopre, arphaman, MaskRay, kbarton, arichardson, nemanjai, emaste. Herald added a reviewer: espindola. Herald

[Lldb-commits] [PATCH] D68547: exception handling in PythonDataObjects.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I am quite happy about how this is turning out to be. Thanks for taking your time to do this. Comment at:

[Lldb-commits] [PATCH] D68210: Object/minidump: Add support for the MemoryInfoList stream

jhenderson added inline comments. Comment at: lib/Object/Minidump.cpp:58 +MinidumpFile::getMemoryInfoList() const { + auto OptionalStream = getRawStream(StreamType::MemoryInfoList); + if (!OptionalStream) labath wrote: > jhenderson wrote: > > I probably should

[Lldb-commits] [lldb] r374030 - Revert "[lldb-server/android] Show more processes and package name when necessary"

Author: labath Date: Tue Oct 8 02:05:31 2019 New Revision: 374030 URL: http://llvm.org/viewvc/llvm-project?rev=374030=rev Log: Revert "[lldb-server/android] Show more processes and package name when necessary" This reverts r373758 because it causes several to test to be flaky (= failing ~90%

[Lldb-commits] [lldb] r374029 - Fix a -Wpedantic warning

Author: labath Date: Tue Oct 8 02:05:25 2019 New Revision: 374029 URL: http://llvm.org/viewvc/llvm-project?rev=374029=rev Log: Fix a -Wpedantic warning namespace-closing '}' don't need ';'. Modified: lldb/trunk/include/lldb/API/SBCommandReturnObject.h Modified:

[Lldb-commits] [PATCH] D68606: [test] Split LLDB tests into filecheck, unittest and dotest.

mstorsjo added a comment. > and finally rename `lit` to `tests` Shouldn't that be `test`, to be consistent with llvm/lld/clang and others? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68606/new/ https://reviews.llvm.org/D68606

[Lldb-commits] [PATCH] D68210: Object/minidump: Add support for the MemoryInfoList stream

labath added a comment. (ignore latest diff. I just realized it's totally bogus) Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68210/new/ https://reviews.llvm.org/D68210 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes by relaxing some checks

labath added a comment. Hi Walter, unfortunately my quick-fix ended up causing problems on mac os. I believe I have a solution to that, but it's going to be slightly more involved so, I'd like to get the patch reviewed first. I've reverted your patch for the time being to get the linux build

[Lldb-commits] [PATCH] D68609: Replace regex match with rfind (NFCish)

labath added inline comments. Comment at: lldb/source/Symbol/ObjectFile.cpp:85 // Check for archive file with format "/path/to/archive.a(object.o)" -char path_with_object[PATH_MAX * 2]; -module_sp->GetFileSpec().GetPath(path_with_object, -

[Lldb-commits] [PATCH] D68210: Object/minidump: Add support for the MemoryInfoList stream

labath updated this revision to Diff 223816. labath added a comment. use two phase checks Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68210/new/ https://reviews.llvm.org/D68210 Files: include/llvm/BinaryFormat/Minidump.h

Re: [Lldb-commits] [lldb] r373925 - ProcessInstanceInfoMatch: Don't match processes with no name if a name match was requested

On 08/10/2019 03:15, Jonas Devlieghere wrote: Hey Pavel, I've reverted your change in r374008. This was breaking TestProcessAttach and TestHelloWorld on Darwin. Thanks. I think I have a fix for that. I'll create a review soon. ___ lldb-commits

[Lldb-commits] [PATCH] D68210: Object/minidump: Add support for the MemoryInfoList stream

labath marked 2 inline comments as done. labath added inline comments. Comment at: unittests/Object/MinidumpTest.cpp:620 + }; + EXPECT_THAT_EXPECTED(cantFail(create(HeaderTooBig))->getMemoryInfoList(), + Failed()); jhenderson wrote: >

[Lldb-commits] [PATCH] D68210: Object/minidump: Add support for the MemoryInfoList stream

jhenderson accepted this revision. jhenderson added a comment. This revision is now accepted and ready to land. Thanks, LGTM (modulo the Minidump-specific details). Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68210/new/ https://reviews.llvm.org/D68210

[Lldb-commits] [PATCH] D68546: remove FILE* usage from ReportEventState() and HandleProcessEvent()

labath added a comment. Thanks for weighing in, Jim. My responses are inline. In D68546#1698430 , @jingham wrote: > SBProcess::ReportEventState was introduced in r112221, and SBStream was added > in r114188, so Pavel's speculation seems like a

[Lldb-commits] [PATCH] D68631: ProcessInstanceInfoMatch: Don't match processes with no name if a name match was requested, take 2

labath created this revision. labath added reviewers: JDevlieghere, teemperor, jingham. The previous attempt at making nameless process not match when searching for a given name failed because the macos implementation was depending on this detail in its partial matching strategy. Doing partial

[Lldb-commits] [PATCH] D68210: Object/minidump: Add support for the MemoryInfoList stream

This revision was automatically updated to reflect the committed changes. labath marked an inline comment as done. Closed by commit rG6e0b1ce48e3c: Object/minidump: Add support for the MemoryInfoList stream (authored by labath). Herald added a subscriber: hiraditya. Changed prior to commit:

[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip

compnerd added inline comments. Comment at: lit/CMakeLists.txt:64 ) +if(NOT LLDB_BUILT_STANDALONE) + list(APPEND LLDB_TEST_DEPS llvm-strip) JDevlieghere wrote: > xiaobai wrote: > > why not `if(TARGET llvm-strip)`? I think that expresses the intent more > >

[Lldb-commits] [PATCH] D68609: Replace regex match with rfind (NFCish)

This revision was automatically updated to reflect the committed changes. Closed by commit rGea6377505435: Replace regex match with rfind (NFCish) (authored by aprantl). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D68609?vs=223695=223887#toc Repository:

[Lldb-commits] [PATCH] D68612: [CMake] Track test dependencies with add_lldb_test_dependency

jankratochvil added a comment. On Linux OS (Fedora 30 x86_64) with GIT monorepo: After rL374000 : #rm -rf * cmake ~/redhat/llvm-monorepo2/llvm/ -DCMAKE_BUILD_TYPE=Release -DLLVM_USE_LINKER=gold -DLLVM_ENABLE_PROJECTS="lldb;clang;lld"

Re: [Lldb-commits] [PATCH] D67520: Add pretty printing of Clang "bitfield" enums

Taking a look > On Oct 8, 2019, at 9:47 AM, Stella Stamenova via Phabricator > wrote: > > stella.stamenova added a comment. > > It looks like this broke one of the tests on the Windows LLDB bot: > > http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/9628/steps/test/logs/stdio >

[Lldb-commits] [lldb] r374066 - Extract and simplify DumpEnumValue

Author: friss Date: Tue Oct 8 08:35:58 2019 New Revision: 374066 URL: http://llvm.org/viewvc/llvm-project?rev=374066=rev Log: Extract and simplify DumpEnumValue Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp URL:

[Lldb-commits] [lldb] r374067 - Add pretty printing of Clang "bitfield" enums

Author: friss Date: Tue Oct 8 08:35:59 2019 New Revision: 374067 URL: http://llvm.org/viewvc/llvm-project?rev=374067=rev Log: Add pretty printing of Clang "bitfield" enums Summary: Using enumerators as flags is standard practice. This patch adds support to LLDB to display such enum values

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

shafik added a comment. I reverted this change b/c the green dragon bots have been red for too long. When you fix the problem please make sure you add Differential Revision: https://reviews.llvm.org/D68354 to your commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D68558: [Testsuite] Get rid of most of the recursive shared library Makefiles

This revision was automatically updated to reflect the committed changes. Closed by commit rG3fb4e49a68f5: [Testsuite] Get rid of most of the recursive shared library Makefiles (authored by friss). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

Re: [Lldb-commits] [PATCH] D67520: Add pretty printing of Clang "bitfield" enums

So I should see this on my machine, but I don’t... > On Oct 8, 2019, at 10:06 AM, Shafik Yaghmour via Phabricator > wrote: > > shafik added a comment. > > See the same break on green dragon as well: >

[Lldb-commits] [PATCH] D68312: [gdb-remote] process properly effective uid

wallace closed this revision. wallace added a comment. already committed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68312/new/ https://reviews.llvm.org/D68312 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D68638: [lldb] Avoid resource leak

kwk created this revision. kwk added a reviewer: jankratochvil. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Before the pointer variable `args_dict` was assigned the result of an allocation with `new` and then `args_dict` is passed to `GetValueForKeyAsDictionary` which

[Lldb-commits] [lldb] r374069 - Simplify LZMA decoding by using ArrayRef::take_back

Author: kwk Date: Tue Oct 8 08:43:29 2019 New Revision: 374069 URL: http://llvm.org/viewvc/llvm-project?rev=374069=rev Log: Simplify LZMA decoding by using ArrayRef::take_back Summary: Follow-up for D66791#inline-616303 Reviewers: labath Subscribers: lldb-commits Tags: #lldb Differential

[Lldb-commits] [PATCH] D67520: Add pretty printing of Clang "bitfield" enums

shafik added a comment. See the same break on green dragon as well: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/2360/testReport/LLDB/SymbolFile_NativePDB/s_constant_cpp/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67520/new/

[Lldb-commits] [lldb] r374081 - Replace static const StringRef with StringRef (NFC)

Author: adrian Date: Tue Oct 8 09:29:36 2019 New Revision: 374081 URL: http://llvm.org/viewvc/llvm-project?rev=374081=rev Log: Replace static const StringRef with StringRef (NFC) Differential Revision: https://reviews.llvm.org/D68597 Modified:

[Lldb-commits] [lldb] r374082 - Replace regex match with rfind (NFCish)

Author: adrian Date: Tue Oct 8 09:29:39 2019 New Revision: 374082 URL: http://llvm.org/viewvc/llvm-project?rev=374082=rev Log: Replace regex match with rfind (NFCish) This change is mostly performance-neutral since our regex engine is fast, but it's IMHO slightly more readable. Also, matching

[Lldb-commits] [lldb] r374080 - Remove constructor and unused method (NFC).

Author: adrian Date: Tue Oct 8 09:29:33 2019 New Revision: 374080 URL: http://llvm.org/viewvc/llvm-project?rev=374080=rev Log: Remove constructor and unused method (NFC). Differential Revision: https://reviews.llvm.org/D68595 Modified:

[Lldb-commits] [PATCH] D67520: Add pretty printing of Clang "bitfield" enums

stella.stamenova added a comment. It looks like this broke one of the tests on the Windows LLDB bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/9628/steps/test/logs/stdio The bot was already red because of a change from yesterday, so you probably didn't get a notification.

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes by relaxing some checks

wallace added a comment. thanks, @labath ! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68289/new/ https://reviews.llvm.org/D68289 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D68647: Simplify LZMA decoding by using ArrayRef::take_back

kwk created this revision. kwk added a reviewer: labath. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Follow-up for D66791#inline-616303 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68647 Files:

[Lldb-commits] [PATCH] D68645: MinidumpYAML: Add support for the memory info list stream

clayborg added a comment. LGTM Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68645/new/ https://reviews.llvm.org/D68645 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r374077 - Revert "[platform process list] add a flag for showing the processes of all users"

Author: shafik Date: Tue Oct 8 09:24:28 2019 New Revision: 374077 URL: http://llvm.org/viewvc/llvm-project?rev=374077=rev Log: Revert "[platform process list] add a flag for showing the processes of all users" This reverts commit 080f35fb875f52c924ee37ed4d56a51fe7056afa. Conflicts:

[Lldb-commits] [PATCH] D68641: [LLDB] Fix for synthetic children memory leak

cameron314 added a comment. @aprantl No. A weak pointer would still fix the memory leak, but it's safe to use a raw pointer because we only reference objects which are in the same cluster as the synthetic children front-end itself. The other (leak-free) synthetic front-ends do this as well. We

[Lldb-commits] [PATCH] D68645: MinidumpYAML: Add support for the thread list stream

labath created this revision. labath added reviewers: amccarth, jhenderson, clayborg. Herald added a project: LLVM. The implementation is fairly straight-forward and uses the same patterns as the existing streams. The yaml form does not attempt to preserve the data in the "gaps" that can be

[Lldb-commits] [PATCH] D68647: Simplify LZMA decoding by using ArrayRef::take_back

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. LGTM. I don't know if there's a reasonable way to add a test with a non-zero backward_size, but if you can think of something, please add one. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D68605: ObjectFileMachO: Replace std::map with llvm::DenseMap (NFC)

labath added inline comments. Comment at: lldb/include/lldb/Utility/ConstString.h:441 protected: + template friend struct ::llvm::DenseMapInfo; + /// Only used by DenseMapInfo. You could declare the specific instantiation (DenseMapInfo) as a friend instead

[Lldb-commits] [PATCH] D68645: MinidumpYAML: Add support for the memory info list stream

labath added a comment. In D68645#1699705 , @JosephTremoulet wrote: > Nit: Title says "thread" rather than "memory info" Woops, sorry about that. Should be fixed now. Repository: rL LLVM CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68270: DWARFDebugLoc: Add a function to get the address range of an entry

labath marked 2 inline comments as done. labath added inline comments. Comment at: lib/DebugInfo/DWARF/DWARFDebugLoc.cpp:291-295 + EntryIterator Absolute = + getAbsoluteLocations( + SectionedAddress{BaseAddr, SectionedAddress::UndefSection}, +

[Lldb-commits] [PATCH] D68638: [lldb] Avoid resource leak

This revision was automatically updated to reflect the committed changes. Closed by commit rG6d7fb29914e3: [lldb] Avoid resource leak (authored by kwk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68638/new/ https://reviews.llvm.org/D68638 Files:

[Lldb-commits] [PATCH] D68641: [LLDB] Fix for synthetic children memory leak

aprantl added a comment. Disclaimer: I'm not familiar with this code. Would it be safe/better to store a weak pointer instead of a raw pointer? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68641/new/ https://reviews.llvm.org/D68641

[Lldb-commits] [lldb] r374076 - [Testsuite] Get rid of most of the recursive shared library Makefiles

Author: friss Date: Tue Oct 8 09:23:28 2019 New Revision: 374076 URL: http://llvm.org/viewvc/llvm-project?rev=374076=rev Log: [Testsuite] Get rid of most of the recursive shared library Makefiles Most of the secondary Makefiles we have are just a couple variable definitions and then an include

[Lldb-commits] [lldb] r374084 - ObjectFileMachO: Replace std::map with llvm::DenseMap (NFC)

Author: adrian Date: Tue Oct 8 09:59:24 2019 New Revision: 374084 URL: http://llvm.org/viewvc/llvm-project?rev=374084=rev Log: ObjectFileMachO: Replace std::map with llvm::DenseMap (NFC) This makes parsing the symbol table of clang marginally faster. (Hashtable versus tree). Differential

[Lldb-commits] [PATCH] D67520: Add pretty printing of Clang "bitfield" enums

This revision was automatically updated to reflect the committed changes. Closed by commit rG41ff39605ea1: Add pretty printing of Clang bitfield enums (authored by friss). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D67520?vs=223705=223877#toc Repository:

[Lldb-commits] [PATCH] D68622: IOHandler: fall back on File::Read if a FILE* isn't available.

labath added a comment. Even if we ignore the windows parts, there's still a lot of duplication here. The bits that extract a "complete" line from the buffer look like they could be factored into a separate function (`Optional GetCompleteLineFromCache(...)` ?). It would not hurt to split the

[Lldb-commits] [PATCH] D68641: [LLDB] Fix for synthetic children memory leak

cameron314 created this revision. cameron314 added reviewers: labath, jingham. cameron314 added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere, aprantl. This fixes a memory leak with several synthetic children front-ends. The lifetime of a ValueObject and all its

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

labath added a comment. In D62931#1697999 , @guiandrade wrote: > Thank you for looking into this, @labath > > I'd like to fix that, but I'm not sure if I understand the code well enough/ > it's not clear to me what the solution would look like. > > > I

[Lldb-commits] [PATCH] D68605: ObjectFileMachO: Replace std::map with llvm::DenseMap (NFC)

aprantl abandoned this revision. aprantl added a comment. Pavel correctly pointed out that this isn't necessarily correct, because the addresses could conflict with the Tombstone/Empty keys. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68605/new/ https://reviews.llvm.org/D68605

[Lldb-commits] [PATCH] D68595: Remove constructor and unused function (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGbde5a6a45a3c: Remove constructor and unused method (NFC). (authored by aprantl). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68597: Replace static const StringRef with StringRef (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG917b8df0e531: Replace static const StringRef with StringRef (NFC) (authored by aprantl). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D68597?vs=223664=223886#toc

[Lldb-commits] [PATCH] D68605: ObjectFileMachO: Replace std::map with llvm::DenseMap (NFC)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG8db229e28771: ObjectFileMachO: Replace std::map with llvm::DenseMap (NFC) (authored by aprantl). Herald added a project:

[Lldb-commits] [PATCH] D68641: [LLDB] Fix for synthetic children memory leak

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Cool. May be nice to put a comment on the pointer why this is safe. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68641/new/

[Lldb-commits] [lldb] r374046 - Tweak minidebuginfo-set-and-hit-breakpoint.test

Author: labath Date: Tue Oct 8 06:51:05 2019 New Revision: 374046 URL: http://llvm.org/viewvc/llvm-project?rev=374046=rev Log: Tweak minidebuginfo-set-and-hit-breakpoint.test On my system, llvm-objcopy was refusing to remove the .dynsym section because it was still referenced from .rela.plt.

[Lldb-commits] [PATCH] D68638: [lldb] Avoid resource leak

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM. Also, this whole function seems to have no tests. So if you find an easy way to test this, then please add a test to

[Lldb-commits] [PATCH] D68645: MinidumpYAML: Add support for the thread list stream

JosephTremoulet added a comment. Nit: Title says "thread" rather than "memory info" Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68645/new/ https://reviews.llvm.org/D68645 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D68647: Simplify LZMA decoding by using ArrayRef::take_back

kwk marked an inline comment as done. kwk added inline comments. Comment at: lldb/source/Host/common/LZMA.cpp:99 + , , nullptr, + InputBuffer.take_back(LZMA_STREAM_HEADER_SIZE - opts.backward_size) + .data(), labath wrote: > I think this

[Lldb-commits] [PATCH] D68647: Simplify LZMA decoding by using ArrayRef::take_back

kwk updated this revision to Diff 223865. kwk marked an inline comment as done. kwk added a comment. Fixup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68647/new/ https://reviews.llvm.org/D68647 Files: lldb/source/Host/common/LZMA.cpp Index:

[Lldb-commits] [PATCH] D68647: Simplify LZMA decoding by using ArrayRef::take_back

labath added inline comments. Comment at: lldb/source/Host/common/LZMA.cpp:99 + , , nullptr, + InputBuffer.take_back(LZMA_STREAM_HEADER_SIZE - opts.backward_size) + .data(), I think this should be + to preserve semantics, though I am not sure

[Lldb-commits] [PATCH] D68647: Simplify LZMA decoding by using ArrayRef::take_back

This revision was automatically updated to reflect the committed changes. kwk marked an inline comment as done. Closed by commit rG8970d88b65f0: Simplify LZMA decoding by using ArrayRef::take_back (authored by kwk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] r374071 - [lldb] Avoid resource leak

Author: kwk Date: Tue Oct 8 08:56:02 2019 New Revision: 374071 URL: http://llvm.org/viewvc/llvm-project?rev=374071=rev Log: [lldb] Avoid resource leak Summary: Before the pointer variable `args_dict` was assigned the result of an allocation with `new` and then `args_dict` is passed to

[Lldb-commits] [PATCH] D68549: make ConstString allocate memory in non-tiny chunks

aprantl added a comment. I assume you experimented with many different values, and these are the best tradeoff? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68549/new/ https://reviews.llvm.org/D68549 ___

[Lldb-commits] [PATCH] D68546: remove FILE* usage from ReportEventState() and HandleProcessEvent()

jingham added a comment. In D68546#1699390 , @labath wrote: > Thanks for weighing in, Jim. My responses are inline. > > In D68546#1698430 , @jingham wrote: > > > SBProcess::ReportEventState was introduced in

[Lldb-commits] [PATCH] D68549: make ConstString allocate memory in non-tiny chunks

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. This makes sense to me. We may need to make this configurable for low-memory hosts at some point. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68549/new/

[Lldb-commits] [PATCH] D68631: ProcessInstanceInfoMatch: Don't match processes with no name if a name match was requested, take 2

JDevlieghere added a comment. Looks reasonable to me, but I'll defer to the people that actually know this code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68631/new/ https://reviews.llvm.org/D68631 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna added a comment. @labath anything else for this one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 ___ lldb-commits mailing list

[Lldb-commits] [lldb] r374095 - Fix sign extension handling in DumpEnumValue

Author: friss Date: Tue Oct 8 10:59:02 2019 New Revision: 374095 URL: http://llvm.org/viewvc/llvm-project?rev=374095=rev Log: Fix sign extension handling in DumpEnumValue When an enumerator has an unsigned type and its high bit set, the code introduced in r374067 would fail to match it due to a

[Lldb-commits] [PATCH] D68270: DWARFDebugLoc: Add a function to get the address range of an entry

probinson added a comment. Do we care whether llvm-dwarfdump's output bears any similarities to the output from GNU readelf or objdump? There has been a push lately to get the LLVM "binutils" to behave more like GNU's, although AFAIK it hasn't gotten to the DWARF dumping part. Repository:

[Lldb-commits] [PATCH] D68658: LLDB: Use LLVM's type for minidump ExceptionStream

JosephTremoulet created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. JosephTremoulet added a parent revision: D68657: Update MinidumpYAML to use minidump::Exception for exception stream. JosephTremoulet added reviewers: labath, clayborg. The types defined

[Lldb-commits] [PATCH] D68641: [LLDB] Fix for synthetic children memory leak

cameron314 added a comment. Right, I'll add comments on the pointer declarations. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68641/new/ https://reviews.llvm.org/D68641 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D68546: remove FILE* usage from ReportEventState() and HandleProcessEvent()

lawrence_danna added a comment. So what's the conclusion here? Should `HandleProcessEvent` get a SBStream variant as well? I say "as well", because the `FileSP` variant is required in order to remove the python binding to the `FILE*` variant, and once we have the `FileSP` it seems like

[Lldb-commits] [PATCH] D68661: StopInfo/Mach: Delete PPC support

This revision was automatically updated to reflect the committed changes. vsk marked an inline comment as done. Closed by commit rG4805c817c3fa: StopInfo/Mach: Delete PPC support (authored by vsk). Herald added a project: LLDB. Changed prior to commit:

Re: [Lldb-commits] [PATCH] D68597: Replace static const StringRef with StringRef (NFC)

We actually call the libc++abi guard functions even for const static StringRefs, so that patch actually saves us a lot. > On Oct 7, 2019, at 11:43 PM, Adrian Prantl via Phabricator via lldb-commits > wrote: > > aprantl created this revision. > aprantl added a reviewer: JDevlieghere. > > I

[Lldb-commits] [PATCH] D68547: exception handling in PythonDataObjects.

lawrence_danna updated this revision to Diff 223900. lawrence_danna marked 2 inline comments as done. lawrence_danna added a comment. style fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68547/new/ https://reviews.llvm.org/D68547 Files:

[Lldb-commits] [PATCH] D68547: exception handling in PythonDataObjects.

This revision was automatically updated to reflect the committed changes. Closed by commit rG085328ba: exception handling in PythonDataObjects. (authored by lawrence_danna). Changed prior to commit: https://reviews.llvm.org/D68547?vs=223900=223901#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D68549: make ConstString allocate memory in non-tiny chunks

clayborg accepted this revision. clayborg added a comment. Nice! If we run into any issues we can make this a global debugger setting. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68549/new/ https://reviews.llvm.org/D68549

[Lldb-commits] [lldb] r374121 - Revert Trust the arange accelerator tables in dSYMs

Author: adrian Date: Tue Oct 8 14:34:22 2019 New Revision: 374121 URL: http://llvm.org/viewvc/llvm-project?rev=374121=rev Log: Revert Trust the arange accelerator tables in dSYMs This reverts r374117 (git commit 6399db2f6fd64fa250093368be40eb5ae3af513b) while inspecting bot breakage. Modified:

[Lldb-commits] [lldb] r374094 - exception handling in PythonDataObjects.

Author: lawrence_danna Date: Tue Oct 8 10:56:18 2019 New Revision: 374094 URL: http://llvm.org/viewvc/llvm-project?rev=374094=rev Log: exception handling in PythonDataObjects. Summary: Python APIs nearly all can return an exception. They do this by returning NULL, or -1, or some such value

[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip

gmittert updated this revision to Diff 223903. gmittert added a comment. Alright, rebased and added a comment to it Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68614/new/ https://reviews.llvm.org/D68614 Files: lit/CMakeLists.txt Index:

[Lldb-commits] [PATCH] D68641: [LLDB] Fix for synthetic children memory leak

shafik accepted this revision. shafik added a comment. LGTM Comment at: source/Plugins/Language/CPlusPlus/LibCxxBitset.cpp:34 std::vector m_elements; - ValueObjectSP m_first; + ValueObject* m_first = nullptr; CompilerType m_bool_type; I feel like each

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223902. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/API/SBFile.h

[Lldb-commits] [PATCH] D68541: Implement 'up' and 'down' shortcuts in lldb gui

llunak added a comment. In D68541#1698127 , @JDevlieghere wrote: > Would it be possible to add a test for this? Maybe you can extend > `TestGuiBasic.py`. I can, although to me it looks like a new test would be better. But first of all I wanted some

[Lldb-commits] [PATCH] D68546: remove FILE* usage from ReportEventState() and HandleProcessEvent()

lawrence_danna added a comment. In D68546#1699397 , @labath wrote: > Yeah, the %extends are somewhat ugly, but I also find the FileSP overloads in > the "public" sections of the SB classes unnerving too, because they are not > really public -- no user

[Lldb-commits] [PATCH] D61886: Support member functions construction and lookup in PdbAstBuilder

amccarth added a comment. Herald added a subscriber: JDevlieghere. Is this still an active review or has this been abandoned? Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:1047 +function_decl = m_clang.CreateFunctionDeclaration( parent,

[Lldb-commits] [PATCH] D68655: Trust the arange accelerator tables in dSYMs

aprantl added a comment. In D68655#1700314 , @jasonmolenda wrote: > Nice fix. The real cost of computing the aranges manually is expanding all > the line tables and calling GetContiguousFileAddressRanges on them. I wonder > if avoiding the full

[Lldb-commits] [PATCH] D68258: [Windows] Introduce a switch for the `lldb-server` mode on Windows

amccarth accepted this revision. amccarth added a comment. Given Pavel's comment, this LGTM. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68258/new/ https://reviews.llvm.org/D68258 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D68655: Trust the arange accelerator tables in dSYMs

This revision was automatically updated to reflect the committed changes. Closed by commit rG6399db2f6fd6: Trust the arange accelerator tables in dSYMs (authored by aprantl). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68134: [LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api

amccarth accepted this revision. amccarth added a comment. LGTM after one question. Comment at: lldb/lit/SymbolFile/PDB/udt-layout.test:1 REQUIRES: system-windows, lld RUN: %build --compiler=clang-cl --output=%t.exe %S/Inputs/UdtLayoutTest.cpp Is

[Lldb-commits] [lldb] r374096 - Reflow/fix doxygen comments.

Author: adrian Date: Tue Oct 8 11:04:49 2019 New Revision: 374096 URL: http://llvm.org/viewvc/llvm-project?rev=374096=rev Log: Reflow/fix doxygen comments. Modified: lldb/trunk/include/lldb/Symbol/ObjectFile.h Modified: lldb/trunk/include/lldb/Symbol/ObjectFile.h URL:

[Lldb-commits] [lldb] r374100 - [CMake] Fix building without python on Windows

Author: xiaobai Date: Tue Oct 8 11:38:46 2019 New Revision: 374100 URL: http://llvm.org/viewvc/llvm-project?rev=374100=rev Log: [CMake] Fix building without python on Windows Summary: find_python_libs_windows might set LLDB_DISABLE_PYTHON to ON. Unfortunately we do not re-check this variable

[Lldb-commits] [PATCH] D68655: Trust the arange accelerator tables in dSYMs

aprantl created this revision. aprantl added reviewers: jasonmolenda, jingham, friss. Herald added a subscriber: JDevlieghere. Herald added a reviewer: JDevlieghere. When ingesting aranges from a dSYM it makes sense to always trust the contents of the accelerator table since it always comes from

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

wallace closed this revision. wallace added a comment. this was reverted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68354/new/ https://reviews.llvm.org/D68354 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D68661: StopInfo/Mach: Delete PPC support

jingham added a comment. Yes, I don't think we need to support this anymore. Comment at: lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp:387 case 1: // EXC_BAD_ACCESS break; Might as well remove this break too. CHANGES SINCE LAST

  1   2   >