[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

jankratochvil added a comment. Fixed now by rL374322 , there was a regression - Linux Fedora 30 x86_64: == ERROR: test_exceptions (TestFileHandle.FileHandleTestCase)

[Lldb-commits] [lldb] r374322 - TestFileHandle.py: relax exception type checks

Author: labath Date: Thu Oct 10 05:07:30 2019 New Revision: 374322 URL: http://llvm.org/viewvc/llvm-project?rev=374322=rev Log: TestFileHandle.py: relax exception type checks the exceptions returned differ between swig4 (TypeError) and swig<=3 (NotImplementedError). Just check for the base

[Lldb-commits] [PATCH] D68696: [lldb][NFC] Remove strange bool parameter from Searcher::SearchCallback

This revision was automatically updated to reflect the committed changes. Closed by commit rG95e264fc8a93: [lldb][NFC] Remove strange bool parameter from Searcher::SearchCallback (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] r374313 - [lldb][NFC] Remove strange bool parameter from Searcher::SearchCallback

Author: teemperor Date: Thu Oct 10 04:26:51 2019 New Revision: 374313 URL: http://llvm.org/viewvc/llvm-project?rev=374313=rev Log: [lldb][NFC] Remove strange bool parameter from Searcher::SearchCallback Summary: The SearchCallback has a bool parameter that we always set to false, we never use

[Lldb-commits] [PATCH] D68773: [lldb] Fix out of bounds read in DataExtractor::GetCStr and add unit test that function.

This revision was automatically updated to reflect the committed changes. Closed by commit rG067bb1f546ef: [lldb] Fix out of bounds read in DataExtractor::GetCStr and add unit test that… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68645: MinidumpYAML: Add support for the memory info list stream

MaskRay accepted this revision. MaskRay added inline comments. Comment at: include/llvm/ObjectYAML/MinidumpYAML.h:111 + + explicit MemoryInfoListStream(std::vector Infos) + : Stream(StreamKind::MemoryInfoList, grimar wrote: > Maybe be more explicit here,

[Lldb-commits] [lldb] r374311 - [lldb] Fix out of bounds read in DataExtractor::GetCStr and add unit test that function.

Author: teemperor Date: Thu Oct 10 04:15:38 2019 New Revision: 374311 URL: http://llvm.org/viewvc/llvm-project?rev=374311=rev Log: [lldb] Fix out of bounds read in DataExtractor::GetCStr and add unit test that function. Summary: The `if (*cstr_end == '\0')` in the previous code checked if the

[Lldb-commits] [lldb] r374307 - [lldb][NFC] Use llvm::all_of instead of std::all_of in CppModuleConfiguration

Author: teemperor Date: Thu Oct 10 03:56:12 2019 New Revision: 374307 URL: http://llvm.org/viewvc/llvm-project?rev=374307=rev Log: [lldb][NFC] Use llvm::all_of instead of std::all_of in CppModuleConfiguration Modified:

[Lldb-commits] [PATCH] D68696: [lldb][NFC] Remove strange bool parameter from Searcher::SearchCallback

teemperor added a comment. Thanks for the explanation! Doesn't seem like removing this breaks Swift, so I'll land this. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68696/new/ https://reviews.llvm.org/D68696 ___

[Lldb-commits] [PATCH] D68723: Fix process launch failure on FreeBSD after r365761

devnexen added a comment. In D68723#1703379 , @MaskRay wrote: > In D68723#1703322 , @devnexen wrote: > > > @dim I LGTMed this but would it a real issue for you to take on a less > > disruptive approach proposed by

[Lldb-commits] [PATCH] D68773: [lldb] Fix out of bounds read in DataExtractor::GetCStr and add actually unit test that function.

teemperor created this revision. teemperor added a reviewer: labath. Herald added subscribers: lldb-commits, JDevlieghere, abidh. Herald added a project: LLDB. The `if (*cstr_end == '\0')` in the previous code checked if the previous loop terminated because it found a null terminator or because

[Lldb-commits] [PATCH] D68723: Fix process launch failure on FreeBSD after r365761

MaskRay added a comment. In D68723#1703322 , @devnexen wrote: > @dim I LGTMed this but would it a real issue for you to take on a less > disruptive approach proposed by MaskRay ? I think we should do what @labath suggested (changing Expected to

[Lldb-commits] [lldb] r374299 - s/@expectedFailure/@expectedFailureAll in TestFileHandle

Author: labath Date: Thu Oct 10 02:52:32 2019 New Revision: 374299 URL: http://llvm.org/viewvc/llvm-project?rev=374299=rev Log: s/@expectedFailure/@expectedFailureAll in TestFileHandle The test isn't using @expectedFailure correctly, which causes weird errors, at least with python2, at least

[Lldb-commits] [PATCH] D68770: [LLDB] [Driver] Use llvm::InitLLVM to do unicode argument conversion on Windows

mstorsjo created this revision. mstorsjo added reviewers: labath, amccarth, rnk. Herald added a project: LLDB. This avoids the currently MSVC specific codepath of using the wchar entry point and converting that to utf8. In the main lldb driver, we had this MSVC specific codepath, but in other

[Lldb-commits] [PATCH] D68723: Fix process launch failure on FreeBSD after r365761

devnexen added a comment. @dim I LGTMed this but would it a real issue for you to take on a less disruptive approach proposed by MaskRay ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68723/new/ https://reviews.llvm.org/D68723 ___

[Lldb-commits] [PATCH] D68723: Fix process launch failure on FreeBSD after r365761

devnexen added a comment. In D68723#1703098 , @MaskRay wrote: > In D68723#1703051 , @devnexen wrote: > > > LGTM otherwise. > > > I don't think this change should be reverted. It can just be repaired by > adding

[Lldb-commits] [PATCH] D68734: update SBDebugger::SetInputFile() etc to work on native Files

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks fine to me. The public-consumptionness of the FileSP overloads was also discussed in D68546 , and I currently do not see a better solution than this

[Lldb-commits] [PATCH] D68723: Fix process launch failure on FreeBSD after r365761

labath added a comment. I don't think having Expected members is a reasonable thing to do. If we want to keep the notion of validity explicit (which is consistent with the direction lldb is moving in), then I think the members should be Optional. The initialization code can take the Expected

[Lldb-commits] [PATCH] D68454: Fix the unwinding plan augmentation from x86 assembly

jarin added a comment. Thank you for the review! Could you also possibly commit the change for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68454/new/ https://reviews.llvm.org/D68454 ___

[Lldb-commits] [lldb] r374289 - [lldb][NFC] Use unique_ptr in DiagnosticManager to express ownership

Author: teemperor Date: Thu Oct 10 01:30:10 2019 New Revision: 374289 URL: http://llvm.org/viewvc/llvm-project?rev=374289=rev Log: [lldb][NFC] Use unique_ptr in DiagnosticManager to express ownership Modified: lldb/trunk/include/lldb/Expression/DiagnosticManager.h

[Lldb-commits] [PATCH] D68755: [test] Use a different module cache for Shell and API tests.

labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:316 -# Use a shared module cache when building in the default test build directory. -CLANG_MODULE_CACHE_DIR := $(shell echo "$(BUILDDIR)" | sed

[Lldb-commits] [PATCH] D68731: Remove CC autodetection from Makefile.rules

labath accepted this revision. labath added a comment. Yay CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68731/new/ https://reviews.llvm.org/D68731 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D68750: Implement serialization and deserialization of scripted points

teemperor added a comment. LGTM, thanks a lot! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68750/new/ https://reviews.llvm.org/D68750 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D68737: SBFile::GetFile: convert SBFile back into python native files.

labath added a comment. It looks pretty straight-forward. The two main comments I have are: - implement rtti to get rid of the `GetPythonObject` method on the base class - it looks like the implementations of new apis you're adding (GetOptions, mainly) have to go out of their way to ignore

[Lldb-commits] [PATCH] D68738: update TestRunCommandInterpreterAPI to use SBFile

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Makes sense to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68738/new/ https://reviews.llvm.org/D68738

[Lldb-commits] [PATCH] D68723: Fix process launch failure on FreeBSD after r365761

MaskRay added a comment. In D68723#1703051 , @devnexen wrote: > LGTM otherwise. I don't think this change should be reverted. It can just be repaired by adding some `(void)!xxx;` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68723/new/

[Lldb-commits] [PATCH] D68727: Allow pexpect tests to work in remote testsuite runs

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I don't see harm in adding this, but I am curious about what are you planning to use this for. My takeaway from all of the pexpect discussions we've had in the past was that pexpect should

[Lldb-commits] [PATCH] D68723: Fix process launch failure on FreeBSD after r365761

devnexen accepted this revision. devnexen added a comment. This revision is now accepted and ready to land. LGTM otherwise. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68723/new/ https://reviews.llvm.org/D68723 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D68723: Fix process launch failure on FreeBSD after r365761

devnexen added inline comments. Comment at: source/Plugins/Process/FreeBSD/ProcessMonitor.cpp:733 // Finally, start monitoring the child process for change in state. - m_monitor_thread = Host::StartMonitoringChildProcess( + auto monitor_thread =

[Lldb-commits] [PATCH] D68762: [LLDB] Fix when building with strict LLVM assertion checking on FreeBSD

devnexen abandoned this revision. devnexen added a comment. Just realised there was an existing PR addressing it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68762/new/ https://reviews.llvm.org/D68762 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D68762: [LLDB] Fix when building with strict LLVM assertion checking on FreeBSD

devnexen updated this revision to Diff 224256. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68762/new/ https://reviews.llvm.org/D68762 Files: lldb/source/Plugins/Process/FreeBSD/ProcessMonitor.cpp Index: lldb/source/Plugins/Process/FreeBSD/ProcessMonitor.cpp

[Lldb-commits] [PATCH] D68723: Fix process launch failure on FreeBSD after r365761

MaskRay added a comment. This was probably due to: Expected(Error Err) : HasError(true) #if LLVM_ENABLE_ABI_BREAKING_CHECKS // Expected is unchecked upon construction in Debug builds. , Unchecked(true) #endif { assert(Err && "Cannot create Expected

[Lldb-commits] [PATCH] D68762: [LLDB] Fix when building with strict LLVM assertion checking on FreeBSD

devnexen added a comment. With this I do not get segfault anymore. @dim I just looked up the patch on FreeBSD, if this approach is preferred, I ll go along. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68762/new/ https://reviews.llvm.org/D68762

[Lldb-commits] [PATCH] D68762: [LLDB] Fix when building with strict LLVM assertion checking on FreeBSD

devnexen created this revision. devnexen added reviewers: dim, jbeich. devnexen created this object with visibility "All Users". Herald added subscribers: lldb-commits, JDevlieghere, emaste. Herald added a project: LLDB. devnexen added a comment. With this I do not get segfault anymore. @dim I

<    1   2