[Lldb-commits] [lldb] 4f244bb - [lldb] Fix asan failures in data-formatter-objc tests

2020-01-16 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2020-01-16T09:59:07+01:00 New Revision: 4f244bba4f66b14382c446b62e122fa684b8db78 URL: https://github.com/llvm/llvm-project/commit/4f244bba4f66b14382c446b62e122fa684b8db78 DIFF:

[Lldb-commits] [PATCH] D72684: [lldb][NFC] Rename ClangASTContext to TypeSystemClang

2020-01-16 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. Herald added a subscriber: wuzish. Are there any objections against this? Otherwise I'll land this tomorrow. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72684/new/ https://reviews.llvm.org/D72684 ___

[Lldb-commits] [PATCH] D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions

2020-01-16 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. This seems like it could be useful. Some random questions inline.. Comment at: lldb/test/Shell/lit.cfg.py:42-46 if 'LLDB_CAPTURE_REPRODUCER' in os.environ: config.environment['LLDB_CAPTURE_REPRODUCER'] = os.environ[ 'LLDB_CAPTURE_REPRODUCER']

[Lldb-commits] [PATCH] D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions

2020-01-16 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Considered making this a python script? Comment at: lldb/tools/lldb-repro/lldb-repro.h.cmake:12 + +#cmakedefine LLDB_TEST_EXECUTABLE "${LLDB_TEST_EXECUTABLE}" + labath wrote: > Are you sure this will work fine with multi-config

[Lldb-commits] [lldb] 15a6df5 - [lldb/DWARF/test] Freshen up debug_names tests

2020-01-16 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2020-01-16T16:25:49+01:00 New Revision: 15a6df52efaa74308bfdcd03718a84ac893b40d8 URL: https://github.com/llvm/llvm-project/commit/15a6df52efaa74308bfdcd03718a84ac893b40d8 DIFF: https://github.com/llvm/llvm-project/commit/15a6df52efaa74308bfdcd03718a84ac893b40d8.diff

[Lldb-commits] [PATCH] D71575: [LLDB] Add ObjectFileWasm plugin for WebAssembly debugging

2020-01-16 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D71575#1822343 , @paolosev wrote: > In D71575#1821312 , @labath wrote: > > > Do you have commit access? > > > No, I certainly don't have commit access, this would be my first accepted >

[Lldb-commits] [lldb] 2664676 - [lldb/Scripts] Remove swig_bot_lib/__init__.py

2020-01-16 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-01-16T09:15:41-08:00 New Revision: 26646761e2bf41eebcf58e09a6f9bb85b94ec3f6 URL: https://github.com/llvm/llvm-project/commit/26646761e2bf41eebcf58e09a6f9bb85b94ec3f6 DIFF:

[Lldb-commits] [PATCH] D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions

2020-01-16 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere marked 4 inline comments as done. JDevlieghere added a comment. In D72823#1824152 , @labath wrote: > Considered making this a python script? I think that makes sense Comment at: lldb/test/Shell/lit.cfg.py:42-46 if

[Lldb-commits] [lldb] 81eaa3d - [lldb][NFC] Delete TestDataFormatterObjCNSDate.py

2020-01-16 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2020-01-16T17:28:07+01:00 New Revision: 81eaa3ddd060ab8486ed3fa349d23dbe8f00d8c5 URL: https://github.com/llvm/llvm-project/commit/81eaa3ddd060ab8486ed3fa349d23dbe8f00d8c5 DIFF:

Re: [Lldb-commits] [lldb] 8d2f252 - lldb: Run TestCrossDSOTailCalls.py and TestCrossObjectTailCalls.py on Darwin only

2020-01-16 Thread Pavel Labath via lldb-commits
On 15/01/2020 23:00, Vedant Kumar via lldb-commits wrote: > > Author: Vedant Kumar > Date: 2020-01-15T14:00:05-08:00 > New Revision: 8d2f252bb8e4d199be8498c4ee2245117ef08fd2 > > URL: > https://github.com/llvm/llvm-project/commit/8d2f252bb8e4d199be8498c4ee2245117ef08fd2 > DIFF: >

[Lldb-commits] [PATCH] D72855: Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well.

2020-01-16 Thread Nico Weber via Phabricator via lldb-commits
thakis added a comment. A very late follow-up to my question in D37272 :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72855/new/ https://reviews.llvm.org/D72855 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D72855: Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well.

2020-01-16 Thread Nico Weber via Phabricator via lldb-commits
thakis created this revision. thakis added a reviewer: rnk. Herald added a subscriber: mgorny. Herald added a project: LLVM. thakis added a comment. A very late follow-up to my question in D37272 :) When LLVM_APPEND_VC_REV=OFF is set, the current git hash is

[Lldb-commits] [PATCH] D72748: [lldb/IOHandler] Change the way we manage IO handler

2020-01-16 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. I didn't actually try it but I am pretty sure this will deadlock with nested lldb command files (running `command source` from a file that is itself being sourced). Changing the mutex to a recursive_mutex would fix that, but I don't believe it would make this fully

[Lldb-commits] [PATCH] D72650: [LLDB] Add SymbolVendorWasm plugin for WebAssembly debugging

2020-01-16 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72650/new/ https://reviews.llvm.org/D72650

[Lldb-commits] [PATCH] D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions

2020-01-16 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added inline comments. Comment at: lldb/test/Shell/lit.cfg.py:42-46 if 'LLDB_CAPTURE_REPRODUCER' in os.environ: config.environment['LLDB_CAPTURE_REPRODUCER'] = os.environ[ 'LLDB_CAPTURE_REPRODUCER'] +if 'LLDB_REPRO_CAPTURE' in os.environ: +

[Lldb-commits] [PATCH] D72650: [LLDB] Add SymbolVendorWasm plugin for WebAssembly debugging

2020-01-16 Thread Derek Schuff via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG9b3254dbf9f6: [LLDB] Add SymbolVendorWasm plugin for WebAssembly debugging (authored by paolosev, committed by dschuff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions

2020-01-16 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere updated this revision to Diff 238554. JDevlieghere added a comment. - Convert to Python - Integrate with lit CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72823/new/ https://reviews.llvm.org/D72823 Files: lldb/CMakeLists.txt lldb/test/Shell/Reproducer/lit.local.cfg

[Lldb-commits] [lldb] 5f8e412 - [lldb/test] Exted test for CMTime data formatter

2020-01-16 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-01-16T11:58:34-08:00 New Revision: 5f8e4121882b61d289237bb27636c76a030a9627 URL: https://github.com/llvm/llvm-project/commit/5f8e4121882b61d289237bb27636c76a030a9627 DIFF:

[Lldb-commits] [PATCH] D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions

2020-01-16 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added inline comments. Comment at: lldb/utils/lldb-repro/lldb-repro.py:1 +#!/usr/bin/env python + Could we add a top-level comment (and/or a Usage: message) that explains what this tool is used for? That's not really obvious for someone who hasn't read

[Lldb-commits] [PATCH] D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions

2020-01-16 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added inline comments. Comment at: lldb/tools/lldb-repro/lldb-repro.h.cmake:5 +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// aprantl wrote: > Out of curiosity, is the

[Lldb-commits] [lldb] c0d909a - Delete control character from comment. (NFC)

2020-01-16 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2020-01-16T10:44:07-08:00 New Revision: c0d909a1b12fd646f7dbca3cd098ff7e278d7446 URL: https://github.com/llvm/llvm-project/commit/c0d909a1b12fd646f7dbca3cd098ff7e278d7446 DIFF: https://github.com/llvm/llvm-project/commit/c0d909a1b12fd646f7dbca3cd098ff7e278d7446.diff

[Lldb-commits] [lldb] ee05138 - [lldb/test] Revert changes to debug-names-compressed.cpp

2020-01-16 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2020-01-16T18:56:26+01:00 New Revision: ee05138515abee2a349ad2fdc8320ab17ddfde12 URL: https://github.com/llvm/llvm-project/commit/ee05138515abee2a349ad2fdc8320ab17ddfde12 DIFF: https://github.com/llvm/llvm-project/commit/ee05138515abee2a349ad2fdc8320ab17ddfde12.diff

[Lldb-commits] [lldb] d34e415 - [LLDB] Convert Plugins/ObjectFile/wasm/ObjectFileWasm.h to unix line endings

2020-01-16 Thread Derek Schuff via lldb-commits
Author: Derek Schuff Date: 2020-01-16T09:38:37-08:00 New Revision: d34e4152e3e057b311d7d6c0c93dc30fa76aa94f URL: https://github.com/llvm/llvm-project/commit/d34e4152e3e057b311d7d6c0c93dc30fa76aa94f DIFF: https://github.com/llvm/llvm-project/commit/d34e4152e3e057b311d7d6c0c93dc30fa76aa94f.diff

[Lldb-commits] [PATCH] D72813: Fixes to lldb's eLaunchFlagLaunchInTTY feature on macOS

2020-01-16 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda added a comment. In D72813#1825006 , @clayborg wrote: > ok if this works for now that is fine. Just close the socket_fd when we fail > to write the pid to the socket and this is good to go. I mark it as close-on-exec so we don't need to

[Lldb-commits] [PATCH] D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions

2020-01-16 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere updated this revision to Diff 238597. JDevlieghere added a comment. Add a comment explaining the purpose of the utility. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72823/new/ https://reviews.llvm.org/D72823 Files: lldb/CMakeLists.txt

[Lldb-commits] [PATCH] D72813: Fixes to lldb's eLaunchFlagLaunchInTTY feature on macOS

2020-01-16 Thread Greg Clayton via Phabricator via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. ok if this works for now that is fine. Just close the socket_fd when we fail to write the pid to the socket and this is good to go. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] 9b3254d - [LLDB] Add SymbolVendorWasm plugin for WebAssembly debugging

2020-01-16 Thread Derek Schuff via lldb-commits
Author: Paolo Severini Date: 2020-01-16T09:36:17-08:00 New Revision: 9b3254dbf9f6624c772db7cfa7a3c29a0b94be8e URL: https://github.com/llvm/llvm-project/commit/9b3254dbf9f6624c772db7cfa7a3c29a0b94be8e DIFF:

Re: [Lldb-commits] [lldb] 15a6df5 - [lldb/DWARF/test] Freshen up debug_names tests

2020-01-16 Thread Adrian Prantl via lldb-commits
It looks like this broke on green dragon: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/5907/ http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/5907/testReport/junit/lldb-shell/SymbolFile_DWARF/debug_names_compressed_cpp/ Script: -- : 'RUN: at line 6';

[Lldb-commits] [PATCH] D72748: [lldb/IOHandler] Change the way we manage IO handler

2020-01-16 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere updated this revision to Diff 238684. JDevlieghere added a comment. Use recursive mutex CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72748/new/ https://reviews.llvm.org/D72748 Files: lldb/include/lldb/Core/Debugger.h lldb/source/Core/Debugger.cpp Index:

[Lldb-commits] [PATCH] D72898: [lldb] add to gdb to lldb doc

2020-01-16 Thread Cyndy Ishida via Phabricator via lldb-commits
cishida created this revision. cishida added a reviewer: JDevlieghere. Herald added subscribers: lldb-commits, ributzka, dexonsmith. Herald added a project: LLDB. - enabling and disabling a breakpoint were missing. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72898 Files:

[Lldb-commits] [PATCH] D72898: [lldb] add to gdb to lldb doc

2020-01-16 Thread Cyndy Ishida via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG24fca5cd7128: [lldb] add to gdb to lldb doc (authored by cishida). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72898/new/ https://reviews.llvm.org/D72898

[Lldb-commits] [lldb] d3d7666 - [lldb/CMake] Remove duplicate entry

2020-01-16 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-01-16T20:08:55-08:00 New Revision: d3d778a227cc4eed5a2e60a08a87f027cafb URL: https://github.com/llvm/llvm-project/commit/d3d778a227cc4eed5a2e60a08a87f027cafb DIFF:

[Lldb-commits] [PATCH] D72898: [lldb] add to gdb to lldb doc

2020-01-16 Thread Cyndy Ishida via Phabricator via lldb-commits
cishida updated this revision to Diff 238688. cishida added a comment. Updating to fix copy/paste error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72898/new/ https://reviews.llvm.org/D72898 Files: lldb/docs/use/map.rst Index:

[Lldb-commits] [lldb] 5ac6106 - [lldb] Re-add NSDate formatter

2020-01-16 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2020-01-17T08:56:05+01:00 New Revision: 5ac610668a7cbde4e8d7106b03ecb218b823fb5c URL: https://github.com/llvm/llvm-project/commit/5ac610668a7cbde4e8d7106b03ecb218b823fb5c DIFF:

[Lldb-commits] [PATCH] D72898: [lldb] add to gdb to lldb doc

2020-01-16 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with Jim's comment addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72898/new/ https://reviews.llvm.org/D72898

[Lldb-commits] [lldb] 25cf941 - [lldb/CMake] Set LLVM_HOST_TRIPLE from TARGET_TRIPLE in standalone builds.

2020-01-16 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-01-16T20:06:25-08:00 New Revision: 25cf941275edacd5199550fef638005f2ecfd35b URL: https://github.com/llvm/llvm-project/commit/25cf941275edacd5199550fef638005f2ecfd35b DIFF:

Re: [Lldb-commits] [lldb] 8d2f252 - lldb: Run TestCrossDSOTailCalls.py and TestCrossObjectTailCalls.py on Darwin only

2020-01-16 Thread Pavel Labath via lldb-commits
On 16/01/2020 23:49, v...@apple.com wrote: > I've reverted this and just xfailed the tests on arm/aarch64 in 6c4d37733. > I'll keep an eye on the bots. > > vedant > Thanks. ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D72898: [lldb] add to gdb to lldb doc

2020-01-16 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. There's a copy paste error in the first header. Other than that, this is fine, thanks for adding the entries! Comment at: lldb/docs/use/map.rst:613 + + Enable a breakpoint. + Shouldn't that be

[Lldb-commits] [PATCH] D72898: [lldb] add to gdb to lldb doc

2020-01-16 Thread pre-merge checks [bot] via Phabricator via lldb-commits
merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61936 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[Lldb-commits] [lldb] 24fca5c - [lldb] add to gdb to lldb doc

2020-01-16 Thread Cyndy Ishida via lldb-commits
Author: Cyndy Ishida Date: 2020-01-16T19:56:45-08:00 New Revision: 24fca5cd712800ef17fac8c6cc158f8075e014dc URL: https://github.com/llvm/llvm-project/commit/24fca5cd712800ef17fac8c6cc158f8075e014dc DIFF: https://github.com/llvm/llvm-project/commit/24fca5cd712800ef17fac8c6cc158f8075e014dc.diff

[Lldb-commits] [PATCH] D72898: [lldb] add to gdb to lldb doc

2020-01-16 Thread pre-merge checks [bot] via Phabricator via lldb-commits
merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61936 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[Lldb-commits] [lldb] 911a4c4 - [lldb/Test] Fix API tests for mutli-config generators

2020-01-16 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-01-16T22:25:55-08:00 New Revision: 911a4c4dda9b3e50d4b610d50cc6368433a67684 URL: https://github.com/llvm/llvm-project/commit/911a4c4dda9b3e50d4b610d50cc6368433a67684 DIFF:

[Lldb-commits] [lldb] e1f6b68 - [lldb/Cmake] Add a CMakeLists.txt to the utils directory...

2020-01-16 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-01-16T22:31:01-08:00 New Revision: e1f6b68d1fd117b92953d2e21567dd8dad759a8b URL: https://github.com/llvm/llvm-project/commit/e1f6b68d1fd117b92953d2e21567dd8dad759a8b DIFF:

[Lldb-commits] [lldb] 9dbd395 - [lldb] Remove ClangASTContext.h inclusion in Target.cpp

2020-01-16 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2020-01-16T22:43:10-08:00 New Revision: 9dbd395b9b8b5f0cb4d10fa05f6f3591d338e486 URL: https://github.com/llvm/llvm-project/commit/9dbd395b9b8b5f0cb4d10fa05f6f3591d338e486 DIFF: https://github.com/llvm/llvm-project/commit/9dbd395b9b8b5f0cb4d10fa05f6f3591d338e486.diff

[Lldb-commits] [PATCH] D72880: Fix a buffer-size bug when the first DW_OP_piece is undefined

2020-01-16 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl created this revision. aprantl added reviewers: davide, friss, jasonmolenda. Herald added a project: LLDB. Fix a buffer-size bug when the first DW_OP_piece is undefined and document the shortcomings of LLDB's partially defined DW_OP_piece handling. This would manifest as

[Lldb-commits] [PATCH] D72879: Add testing for DW_OP_piece and fix a bug with small Scalar values.

2020-01-16 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl created this revision. aprantl added reviewers: davide, friss, jasonmolenda. Herald added a project: LLDB. By switching to Scalars that are backed by explicitly-sized APInts we can avoid a bug that increases the buffer reserved for a small piece to the next-largest host integer type.

[Lldb-commits] [PATCH] D72855: Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well.

2020-01-16 Thread Reid Kleckner via Phabricator via lldb-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: llvm/cmake/modules/LLVMConfig.cmake.in:81 +set(LLVM_APPEND_VC_REV "@LLVM_APPEND_VC_REV@") + This here should make the standalone build configs

[Lldb-commits] [PATCH] D72880: Fix a buffer-size bug when the first DW_OP_piece is undefined

2020-01-16 Thread Vedant Kumar via Phabricator via lldb-commits
vsk added inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:2077 + // with the expression result, so the debugger can print missing + // members as "" or something. ::memset(curr_piece.GetBuffer().GetBytes(), 0,

[Lldb-commits] [PATCH] D72880: Fix a buffer-size bug when the first DW_OP_piece is undefined

2020-01-16 Thread Vedant Kumar via Phabricator via lldb-commits
vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. LGTM, this seems like a clear improvement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72880/new/ https://reviews.llvm.org/D72880

[Lldb-commits] [PATCH] D72855: Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well.

2020-01-16 Thread Nico Weber via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGfb5fafb23cc2: Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well. (authored by thakis). Herald added projects: clang, LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D72879: Add testing for DW_OP_piece and fix a bug with small Scalar values.

2020-01-16 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added a comment. > My understanding is that DW_OP_piece is still incomplete, right? DW_OP_piece should work (with the documented caveat about the undefined values) fine, what definitely doesn't yet work is the combination of DW_OP_piece and DW_OP_bit_piece. Repository: rG LLVM

[Lldb-commits] [lldb] 6c4d377 - lldb: xfail TestCrossDSOTailCalls.py and TestCrossObjectTailCalls.py on arm/aarch64

2020-01-16 Thread Vedant Kumar via lldb-commits
Author: Vedant Kumar Date: 2020-01-16T14:48:51-08:00 New Revision: 6c4d37733403bf3fda260f1b05fc899427a61cdc URL: https://github.com/llvm/llvm-project/commit/6c4d37733403bf3fda260f1b05fc899427a61cdc DIFF: https://github.com/llvm/llvm-project/commit/6c4d37733403bf3fda260f1b05fc899427a61cdc.diff

[Lldb-commits] [PATCH] D72880: Fix a buffer-size bug when the first DW_OP_piece is undefined

2020-01-16 Thread Adrian Prantl via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf55ab6f90b73: Fix a buffer-size bug when the first DW_OP_piece is undefined (authored by aprantl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72880/new/

[Lldb-commits] [PATCH] D72879: Add testing for DW_OP_piece and fix a bug with small Scalar values.

2020-01-16 Thread Adrian Prantl via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7b0d58e339b2: Add testing for DW_OP_piece and fix a bug with small Scalar values. (authored by aprantl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions

2020-01-16 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere updated this revision to Diff 238626. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72823/new/ https://reviews.llvm.org/D72823 Files: lldb/CMakeLists.txt lldb/test/Shell/Reproducer/lit.local.cfg lldb/test/Shell/helper/toolchain.py lldb/test/Shell/lit.cfg.py

[Lldb-commits] [PATCH] D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions

2020-01-16 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/utils/lldb-repro/lldb-repro.py:49 +# run again but this time every invocation of lldb replays the previously +# recorded session. +if __name__ == '__main__':

[Lldb-commits] [lldb] 2671df9 - [lldb/Debugger] Rename ExecuteIOHandlers to RunIOHandlers (NFC)

2020-01-16 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2020-01-16T16:45:47-08:00 New Revision: 2671df9bd675d4a1a07457dce748f4fe939e95fb URL: https://github.com/llvm/llvm-project/commit/2671df9bd675d4a1a07457dce748f4fe939e95fb DIFF:

[Lldb-commits] [PATCH] D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions

2020-01-16 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added inline comments. Comment at: lldb/utils/lldb-repro/lldb-repro.py:49 +# run again but this time every invocation of lldb replays the previously +# recorded session. +if __name__ == '__main__': Thanks! Sorry for being such a nuisance, but I think

Re: [Lldb-commits] [lldb] 8d2f252 - lldb: Run TestCrossDSOTailCalls.py and TestCrossObjectTailCalls.py on Darwin only

2020-01-16 Thread via lldb-commits
I've reverted this and just xfailed the tests on arm/aarch64 in 6c4d37733. I'll keep an eye on the bots. vedant > On Jan 16, 2020, at 6:58 AM, Pavel Labath wrote: > > On 15/01/2020 23:00, Vedant Kumar via lldb-commits wrote: >> >> Author: Vedant Kumar >> Date: 2020-01-15T14:00:05-08:00 >>

[Lldb-commits] [PATCH] D72879: Add testing for DW_OP_piece and fix a bug with small Scalar values.

2020-01-16 Thread Davide Italiano via Phabricator via lldb-commits
davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Looks great! Thanks Adrian. My understanding is that `DW_OP_piece` is still incomplete, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D72879: Add testing for DW_OP_piece and fix a bug with small Scalar values.

2020-01-16 Thread Vedant Kumar via Phabricator via lldb-commits
vsk accepted this revision. vsk added a comment. LGTM. In the future it'd be nice to maybe split out piece/bit_piece handling into their own self-contained functions, and maybe share more code between them. But landing this narrow fix now sounds good. Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 7b0d58e - Add testing for DW_OP_piece and fix a bug with small Scalar values.

2020-01-16 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2020-01-16T16:47:36-08:00 New Revision: 7b0d58e339b271e3b1d9dc14b781b57fa0262e3a URL: https://github.com/llvm/llvm-project/commit/7b0d58e339b271e3b1d9dc14b781b57fa0262e3a DIFF: https://github.com/llvm/llvm-project/commit/7b0d58e339b271e3b1d9dc14b781b57fa0262e3a.diff

[Lldb-commits] [lldb] f55ab6f - Fix a buffer-size bug when the first DW_OP_piece is undefined

2020-01-16 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2020-01-16T16:47:59-08:00 New Revision: f55ab6f90b7317a6bb85303a6102702bdae1199e URL: https://github.com/llvm/llvm-project/commit/f55ab6f90b7317a6bb85303a6102702bdae1199e DIFF: https://github.com/llvm/llvm-project/commit/f55ab6f90b7317a6bb85303a6102702bdae1199e.diff