[Lldb-commits] [lldb] fe73d36 - Fix lldb build failure due to clang mangler change

2020-03-07 Thread Yaxun Liu via lldb-commits 

Author: Yaxun (Sam) Liu
Date: 2020-03-08T00:38:30-05:00
New Revision: fe73d36f2326060ad4e8059cf9e18619084df5b3

URL: 
https://github.com/llvm/llvm-project/commit/fe73d36f2326060ad4e8059cf9e18619084df5b3
DIFF: 
https://github.com/llvm/llvm-project/commit/fe73d36f2326060ad4e8059cf9e18619084df5b3.diff

LOG: Fix lldb build failure due to clang mangler change

Added: 


Modified: 
lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp

Removed: 




diff  --git a/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp 
b/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
index 3b8c058c903a..47f1a852289a 100644
--- a/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
+++ b/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
@@ -8843,11 +8843,15 @@ ConstString TypeSystemClang::DeclGetMangledName(void 
*opaque_decl) {
 llvm::SmallVector buf;
 llvm::raw_svector_ostream llvm_ostrm(buf);
 if (llvm::isa(nd)) {
-  mc->mangleCXXCtor(llvm::dyn_cast(nd),
-Ctor_Complete, llvm_ostrm);
+  mc->mangleName(
+  clang::GlobalDecl(llvm::dyn_cast(nd),
+Ctor_Complete),
+  llvm_ostrm);
 } else if (llvm::isa(nd)) {
-  mc->mangleCXXDtor(llvm::dyn_cast(nd),
-Dtor_Complete, llvm_ostrm);
+  mc->mangleName(
+  clang::GlobalDecl(llvm::dyn_cast(nd),
+Dtor_Complete),
+  llvm_ostrm);
 } else {
   mc->mangleName(nd, llvm_ostrm);
 }



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D75810: [lldb] Add .clang-tidy with customization to readability-identifier-naming.{Function, Member, Parameter, Variable}Case

2020-03-07 Thread Fangrui Song via Phabricator via lldb-commits 
MaskRay created this revision.
MaskRay added reviewers: JDevlieghere, jingham, labath.
Herald added subscribers: lldb-commits, aheejin.
Herald added a project: LLDB.
MaskRay added a comment.

https://github.com/google/llvm-premerge-checks/issues/142 This should suppress 
the annoying `clang-tidy linux` diagnostics in `Diff Detail - Build Status`.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D75810

Files:
  lldb/.clang-tidy


Index: lldb/.clang-tidy
===
--- /dev/null
+++ lldb/.clang-tidy
@@ -0,0 +1,21 @@
+# Almost identical to the top-level .clang-tidy, except that
+# - FunctionCase uses CamelCase
+# - {Member,Parameter,Variable}Case use lower_case
+Checks: 
'-*,clang-diagnostic-*,llvm-*,misc-*,-misc-unused-parameters,-misc-non-private-member-variables-in-classes,readability-identifier-naming'
+CheckOptions:
+  - key: readability-identifier-naming.ClassCase
+value:   CamelCase
+  - key: readability-identifier-naming.EnumCase
+value:   CamelCase
+  - key: readability-identifier-naming.FunctionCase
+value:   CamelCase
+  - key: readability-identifier-naming.MemberCase
+value:   lower_case
+  - key: readability-identifier-naming.ParameterCase
+value:   lower_case
+  - key: readability-identifier-naming.UnionCase
+value:   CamelCase
+  - key: readability-identifier-naming.VariableCase
+value:   lower_case
+  - key: readability-identifier-naming.IgnoreMainLikeFunctions
+value:   1


Index: lldb/.clang-tidy
===
--- /dev/null
+++ lldb/.clang-tidy
@@ -0,0 +1,21 @@
+# Almost identical to the top-level .clang-tidy, except that
+# - FunctionCase uses CamelCase
+# - {Member,Parameter,Variable}Case use lower_case
+Checks: '-*,clang-diagnostic-*,llvm-*,misc-*,-misc-unused-parameters,-misc-non-private-member-variables-in-classes,readability-identifier-naming'
+CheckOptions:
+  - key: readability-identifier-naming.ClassCase
+value:   CamelCase
+  - key: readability-identifier-naming.EnumCase
+value:   CamelCase
+  - key: readability-identifier-naming.FunctionCase
+value:   CamelCase
+  - key: readability-identifier-naming.MemberCase
+value:   lower_case
+  - key: readability-identifier-naming.ParameterCase
+value:   lower_case
+  - key: readability-identifier-naming.UnionCase
+value:   CamelCase
+  - key: readability-identifier-naming.VariableCase
+value:   lower_case
+  - key: readability-identifier-naming.IgnoreMainLikeFunctions
+value:   1
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D75810: [lldb] Add .clang-tidy with customization to readability-identifier-naming.{Function, Member, Parameter, Variable}Case

2020-03-07 Thread Fangrui Song via Phabricator via lldb-commits 
MaskRay added a comment.

https://github.com/google/llvm-premerge-checks/issues/142 This should suppress 
the annoying `clang-tidy linux` diagnostics in `Diff Detail - Build Status`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75810/new/

https://reviews.llvm.org/D75810



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 172d564 - [lldb] Un-XFAIL two tests on NetBSD

2020-03-07 Thread Michał Górny via lldb-commits 

Author: Michał Górny
Date: 2020-03-07T18:35:22+01:00
New Revision: 172d564c73810777e51b953dc7f73d5a3ca9aad0

URL: 
https://github.com/llvm/llvm-project/commit/172d564c73810777e51b953dc7f73d5a3ca9aad0
DIFF: 
https://github.com/llvm/llvm-project/commit/172d564c73810777e51b953dc7f73d5a3ca9aad0.diff

LOG: [lldb] Un-XFAIL two tests on NetBSD

Added: 


Modified: 
lldb/test/API/commands/expression/formatters/TestFormatters.py
lldb/test/API/lang/cpp/auto/TestCPPAuto.py

Removed: 




diff  --git a/lldb/test/API/commands/expression/formatters/TestFormatters.py 
b/lldb/test/API/commands/expression/formatters/TestFormatters.py
index 1fbc1ef82986..cd59e529c240 100644
--- a/lldb/test/API/commands/expression/formatters/TestFormatters.py
+++ b/lldb/test/API/commands/expression/formatters/TestFormatters.py
@@ -22,7 +22,6 @@ def setUp(self):
 '// Stop here')
 
 @skipIfFreeBSD  # llvm.org/pr24691 skipping to avoid crashing the test 
runner
-@expectedFailureNetBSD
 @expectedFailureAll(
 oslist=['freebsd'],
 bugnumber='llvm.org/pr19011 Newer Clang omits C1 complete object 
constructor')

diff  --git a/lldb/test/API/lang/cpp/auto/TestCPPAuto.py 
b/lldb/test/API/lang/cpp/auto/TestCPPAuto.py
index 0094db1c0681..c30de747e089 100644
--- a/lldb/test/API/lang/cpp/auto/TestCPPAuto.py
+++ b/lldb/test/API/lang/cpp/auto/TestCPPAuto.py
@@ -14,7 +14,6 @@ class CPPAutoTestCase(TestBase):
 @expectedFailureAll(
 compiler="gcc",
 bugnumber="GCC generates incomplete debug info")
-@expectedFailureNetBSD
 def test_with_run_command(self):
 """Test that auto types work in the expression parser"""
 self.build()



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits