[Lldb-commits] [lldb] f3cc4df - Revert "[CMake] Simplify CMake handling for zlib"

Author: Christian Kühnel Date: 2020-08-07T09:36:49+02:00 New Revision: f3cc4df51da4331b170065e01a6a80ee05ed0c23 URL: https://github.com/llvm/llvm-project/commit/f3cc4df51da4331b170065e01a6a80ee05ed0c23 DIFF:

[Lldb-commits] [lldb] dbf44b8 - [LLDB] Mark test_launch_simple as a no-debug-info test

Author: Jonas Devlieghere Date: 2020-08-06T23:18:37-07:00 New Revision: dbf44b833067cfe59056d07130e7afcb8fc149c7 URL: https://github.com/llvm/llvm-project/commit/dbf44b833067cfe59056d07130e7afcb8fc149c7 DIFF:

[Lldb-commits] [PATCH] D85514: [LLDB] Fix timeout value on expect_gdbremote_sequence

omjavaid created this revision. omjavaid added reviewers: JDevlieghere, labath. Herald added a subscriber: kristof.beyls. omjavaid requested review of this revision. D83904 seems to have changed timeout value on expect_gdbremote_sequence which was 120

[Lldb-commits] [PATCH] D85514: [LLDB] Fix timeout value on expect_gdbremote_sequence

JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py:706 self._pump_queues, -self.DEFAULT_TIMEOUT, +self.DEFAULT_TIMEOUT * 12, self.logger)

[Lldb-commits] [PATCH] D85537: [lldb] Store the Apple SDK in the configuration and use it to determine the platform.

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. JDevlieghere requested review of this revision. What the title says. This is part of upstreaming the last missing pieces to run the on-device test suite with the upstream repository. Repository: rLLDB LLDB

[Lldb-commits] [PATCH] D85265: Add a setting to always run all threads when stepping

friss added a comment. This LGTM. The only comment I had is about a comment you added on preexisting code: Comment at: lldb/source/Commands/CommandObjectThread.cpp:486-490 + // NonStopMode runs all threads down in the ProcessPlugin layer, but + // at this level we

[Lldb-commits] [lldb] f1d5257 - [lldb] Store the Apple SDK in dotest's configuration.

Author: Jonas Devlieghere Date: 2020-08-07T11:13:18-07:00 New Revision: f1d525734f86ac4b1a7bf80f3a82291864026de0 URL: https://github.com/llvm/llvm-project/commit/f1d525734f86ac4b1a7bf80f3a82291864026de0 DIFF:

[Lldb-commits] [PATCH] D85265: Add a setting to always run all threads when stepping

friss added inline comments. Comment at: lldb/source/Commands/CommandObjectThread.cpp:486-490 + // NonStopMode runs all threads down in the ProcessPlugin layer, but + // at this level we need to pretend we are actually only running this + // thread. So

[Lldb-commits] [PATCH] D85542: lldbutil: add a retry mechanism for the ios simulator

aprantl created this revision. aprantl added reviewers: JDevlieghere, jingham, jasonmolenda, friss. aprantl requested review of this revision. We've been seeing this failure on green dragon when the system is under high load. Unfortunately this is outside of LLDB's control.

[Lldb-commits] [PATCH] D85539: [lldb] Extend builder to pass the TRIPLE spec to Make

JDevlieghere created this revision. JDevlieghere added reviewers: LLDB, jasonmolenda, davide, friss. JDevlieghere requested review of this revision. This is needed to build the test binaries for iOS. This is part of upstreaming the last missing pieces to run the on-device test suite with the

[Lldb-commits] [PATCH] D85537: [lldb] Store the Apple SDK in the configuration and use it to determine the platform.

friss accepted this revision. friss added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85537/new/ https://reviews.llvm.org/D85537 ___ lldb-commits

[Lldb-commits] [PATCH] D85539: [lldb] Extend builder to pass the TRIPLE spec to Make

JDevlieghere added a comment. In D85539#2203247 , @friss wrote: > `lldbremote.py` looks awfully Apple-specific, yet it is going to be called > from the generic code. Is that not an issue? It's not an issue because it checks for the Apple SDK, but I

[Lldb-commits] [PATCH] D85537: [lldb] Store the Apple SDK in the configuration and use it to determine the platform.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf1d525734f86: [lldb] Store the Apple SDK in dotests configuration. (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D85542: lldbutil: add a retry mechanism for the ios simulator

JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:824 +while (retry and error.Fail() and + isinstance(error.GetCString(), six.string_types) and + "Unable to boot the Simulator" in error.GetCString()):

[Lldb-commits] [PATCH] D85265: Add a setting to always run all threads when stepping

jingham updated this revision to Diff 283945. jingham added a comment. Clarify comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85265/new/ https://reviews.llvm.org/D85265 Files: lldb/bindings/interface/SBThreadPlan.i

[Lldb-commits] [PATCH] D85265: Add a setting to always run all threads when stepping

jingham added inline comments. Comment at: lldb/source/Commands/CommandObjectThread.cpp:486-490 + // NonStopMode runs all threads down in the ProcessPlugin layer, but + // at this level we need to pretend we are actually only running this + // thread. So

[Lldb-commits] [PATCH] D85539: [lldb] Extend builder to pass the TRIPLE spec to Make

friss added a comment. `lldbremote.py` looks awfully Apple-specific, yet it is going to be called from the generic code. Is that not an issue? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85539/new/ https://reviews.llvm.org/D85539

[Lldb-commits] [PATCH] D85542: lldbutil: add a retry mechanism for the ios simulator

aprantl added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:824 +while (retry and error.Fail() and + isinstance(error.GetCString(), six.string_types) and + "Unable to boot the Simulator" in error.GetCString()):

[Lldb-commits] [PATCH] D85542: lldbutil: add a retry mechanism for the ios simulator

aprantl updated this revision to Diff 283995. aprantl added a comment. Address review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85542/new/ https://reviews.llvm.org/D85542 Files: lldb/packages/Python/lldbsuite/test/lldbutil.py Index:

[Lldb-commits] [PATCH] D85542: lldbutil: add a retry mechanism for the ios simulator

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with the comments addressed. Thanks for fixing this! Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:822 +# Unfortunate workaround for the

[Lldb-commits] [lldb] e3eb3cf - [lldb] Only check for --apple-sdk argument on Darwin

Author: Jonas Devlieghere Date: 2020-08-07T13:05:42-07:00 New Revision: e3eb3cf5501c6b97b5baa2d66193f2d610492be6 URL: https://github.com/llvm/llvm-project/commit/e3eb3cf5501c6b97b5baa2d66193f2d610492be6 DIFF:

[Lldb-commits] [PATCH] D85537: [lldb] Store the Apple SDK in the configuration and use it to determine the platform.

omjavaid reopened this revision. omjavaid added a comment. This revision is now accepted and ready to land. This breaks LLDB arm-linux buildbot http://lab.llvm.org:8011/builders/lldb-arm-ubuntu/builds/2651 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D84815: [LLDB] Improve PDB discovery

amccarth updated this revision to Diff 284025. amccarth added a comment. Added test to check locating the PDB either in the original build directory or adjacent to the executable. I tried but failed to make a negative test. LLDB sends the errors message to stderr when the `target modules dump

[Lldb-commits] [PATCH] D85265: Add a setting to always run all threads when stepping

jingham updated this revision to Diff 284031. jingham added a comment. reduce comment to the part appropriate to this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85265/new/ https://reviews.llvm.org/D85265 Files:

[Lldb-commits] [PATCH] D85539: [lldb] Extend builder to pass the TRIPLE spec to Make

JDevlieghere updated this revision to Diff 284010. JDevlieghere added a comment. - Simplify things a bit more - Add a comment explaining that the triple spec is only relevant with an Apple SDK CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85539/new/ https://reviews.llvm.org/D85539

[Lldb-commits] [PATCH] D85537: [lldb] Store the Apple SDK in the configuration and use it to determine the platform.

JDevlieghere closed this revision. JDevlieghere added a comment. Fixed by `e3eb3cf5501c6b97b5baa2d66193f2d610492be6` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85537/new/ https://reviews.llvm.org/D85537

[Lldb-commits] [PATCH] D85542: lldbutil: add a retry mechanism for the ios simulator

This revision was automatically updated to reflect the committed changes. Closed by commit rG968cba8e89f7: lldbutil: add a retry mechanism for the ios simulator (authored by aprantl). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D85542?vs=283995=284020#toc

[Lldb-commits] [lldb] 968cba8 - lldbutil: add a retry mechanism for the ios simulator

Author: Adrian Prantl Date: 2020-08-07T13:28:46-07:00 New Revision: 968cba8e89f7226f325b04278d3b5dff7d4ebc36 URL: https://github.com/llvm/llvm-project/commit/968cba8e89f7226f325b04278d3b5dff7d4ebc36 DIFF: https://github.com/llvm/llvm-project/commit/968cba8e89f7226f325b04278d3b5dff7d4ebc36.diff

[Lldb-commits] [PATCH] D85265: Add a setting to always run all threads when stepping

jingham added inline comments. Comment at: lldb/source/Commands/CommandObjectThread.cpp:486-490 + // NonStopMode runs all threads down in the ProcessPlugin layer, but + // at this level we need to pretend we are actually only running this + // thread. So

[Lldb-commits] [PATCH] D85265: Add a setting to always run all threads when stepping

friss accepted this revision. friss added a comment. This revision is now accepted and ready to land. Sure. As I said I know this is unrelated to the path. this LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85265/new/

[Lldb-commits] [lldb] 38b419e - Factor out reference-counting code from PlatformApple*

Author: Adrian Prantl Date: 2020-08-07T14:25:32-07:00 New Revision: 38b419eb9330c1f1bcec31764f57e932c07fb42c URL: https://github.com/llvm/llvm-project/commit/38b419eb9330c1f1bcec31764f57e932c07fb42c DIFF: https://github.com/llvm/llvm-project/commit/38b419eb9330c1f1bcec31764f57e932c07fb42c.diff

[Lldb-commits] [lldb] a97dfdc - [lldb] Assert the process has exited before we gets its output.

Author: Jonas Devlieghere Date: 2020-08-07T15:06:38-07:00 New Revision: a97dfdc30b5bdec7d6cdcb9f421ef5a288495420 URL: https://github.com/llvm/llvm-project/commit/a97dfdc30b5bdec7d6cdcb9f421ef5a288495420 DIFF:

[Lldb-commits] [PATCH] D85514: [LLDB] Fix timeout value on expect_gdbremote_sequence

omjavaid updated this revision to Diff 284068. omjavaid added a comment. Fixed as suggested by @JDevlieghere CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85514/new/ https://reviews.llvm.org/D85514 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py

[Lldb-commits] [lldb] d3dfd8c - Add a setting to force stepping to always run all threads.

Author: Jim Ingham Date: 2020-08-07T14:47:31-07:00 New Revision: d3dfd8cec44072302818c34193d898903dbaef8f URL: https://github.com/llvm/llvm-project/commit/d3dfd8cec44072302818c34193d898903dbaef8f DIFF: https://github.com/llvm/llvm-project/commit/d3dfd8cec44072302818c34193d898903dbaef8f.diff

[Lldb-commits] [PATCH] D85265: Add a setting to always run all threads when stepping

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd3dfd8cec440: Add a setting to force stepping to always run all threads. (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES