[Lldb-commits] [PATCH] D89925: [lldb] Fix a regression introduced by D75730

jasonmolenda added a comment. So in this patch you're setting the limit to be the size of the range (for someone who did 'disass -s 0x100 -e 0x200' they would be requesting 100 instructions) but the disassembly returned would be limited by the byte range requested, so this works OK. The

[Lldb-commits] [PATCH] D89925: [lldb] Fix a regression introduced by D75730

jasonmolenda added a comment. (*cough* "requesting 256 instructions", wrote too quickly, or rather I am speaking in gdb RSP and don't always prefix my base16 numbers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89925/new/

[Lldb-commits] [PATCH] D89925: [lldb] Fix a regression introduced by D75730

JDevlieghere added a comment. In D89925#2346290 , @jasonmolenda wrote: > So in this patch you're setting the limit to be the size of the range (for > someone who did 'disass -s 0x100 -e 0x200' they would be requesting 100 > instructions) but the

[Lldb-commits] [PATCH] D89925: [lldb] Fix a regression introduced by D75730

JDevlieghere created this revision. JDevlieghere added reviewers: labath, jingham. Herald added a subscriber: pengfei. Herald added a project: LLDB. JDevlieghere requested review of this revision. In a new Range class was introduced to simplify and the Disassembler API and reduce duplication. It

[Lldb-commits] [PATCH] D89874: [lldb] Unify x86 watchpoint implementation on Linux and NetBSD (and future FreeBSD plugin) [WIP]

mgorny updated this revision to Diff 299800. mgorny added a comment. Migrate NetBSD plugin as well. This implied adding `ClearWatchpointHit()` as a virtual method to the base class. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89874/new/ https://reviews.llvm.org/D89874 Files:

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

zequanwu marked an inline comment as done. zequanwu added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PDB/ObjectFilePDB.cpp:176-197 + switch (dbi_stream->getMachineType()) { + case PDB_Machine::Amd64: +spec.SetTriple("x86_64-pc-windows"); +

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

zequanwu updated this revision to Diff 299826. zequanwu marked 4 inline comments as done. zequanwu added a comment. - address comments. - add tests. - move `loadPDBFile` from `SymbolFileNativePDB.cpp` to `ObjectFilePDB.cpp` and use it to create unique_ptr of `PDBFile` so that we can move it

[Lldb-commits] [PATCH] D89807: Fix "Unknown arguments specified" to if in lldb

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Sorry about the breakage. Comment at: lldb/cmake/modules/FindPythonAndSwig.cmake:51 "${SWIG_VERSION}" VERSION_LESS "4.0" AND WIN32 AND ( - ${MULTI_CONFIG} OR

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

labath added a comment. It sounds like that could be an artefact from how we parse function types from dwarf. I haven't checked if that's what happens in this particular case, but I know that we parse function types by just taking the function DIE (which describes the whole function, not just

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum added a comment. In D88483#2343694 , @labath wrote: > > It sounds like that could be an artefact from how we parse function types > from dwarf. I haven't checked if that's what happens in this particular case, > but I know that we parse

[Lldb-commits] [PATCH] D89859: Remove .svn from exclude list as we moved to git

sylvestre.ledru added a comment. ed if you want to approve it ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89859/new/ https://reviews.llvm.org/D89859 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D89859: Remove .svn from exclude list as we moved to git

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0784e17f1b4a: Remove .svn from exclude list as we moved to git (authored by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] 0784e17 - Remove .svn from exclude list as we moved to git

Author: Sylvestre Ledru Date: 2020-10-21T16:09:21+02:00 New Revision: 0784e17f1b4ac6b613ebf1fb1fb9b0dc9d0776ec URL: https://github.com/llvm/llvm-project/commit/0784e17f1b4ac6b613ebf1fb1fb9b0dc9d0776ec DIFF:

[Lldb-commits] [PATCH] D89874: [lldb] Unify x86 watchpoint implementation on Linux and NetBSD (and future FreeBSD plugin) [WIP]

labath added a comment. I like this, and I think this is in a pretty good shape as it stands. The thing I'm not sure of is the naming of the class. I'd probably name it something like NativeRegisterContext_x86 (and hope that it can include non-watchpoint functionality in the future). As it

[Lldb-commits] [PATCH] D89807: Fix "Unknown arguments specified" to if in lldb

This revision was automatically updated to reflect the committed changes. Closed by commit rG26459e6d8eeb: Fix Unknown arguments specified to if in lldb (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89807/new/

[Lldb-commits] [lldb] 26459e6 - Fix "Unknown arguments specified" to if in lldb

Author: Christopher Tetreault Date: 2020-10-21T07:24:53-07:00 New Revision: 26459e6d8eeb3c2e61c70d207de7e10a00b4ed1c URL: https://github.com/llvm/llvm-project/commit/26459e6d8eeb3c2e61c70d207de7e10a00b4ed1c DIFF:

[Lldb-commits] [PATCH] D89334: [lldb] Support Python imports relative the to the current file being sourced

JDevlieghere added a comment. In D89334#2344610 , @labath wrote: > In D89334#2341889 , @JDevlieghere > wrote: > >> In D89334#2341561 , @labath wrote: >> >>> I'm afraid

[Lldb-commits] [PATCH] D89874: [lldb] Unify x86 watchpoint implementation on Linux and NetBSD (and future FreeBSD plugin) [WIP]

mgorny updated this revision to Diff 299704. mgorny marked an inline comment as done. mgorny added a comment. Deleted unnecessary constructor and switched public/virtual order. More changes coming. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89874/new/

[Lldb-commits] [PATCH] D89874: [lldb] Unify x86 watchpoint implementation on Linux and NetBSD (and future FreeBSD plugin) [WIP]

mgorny marked 4 inline comments as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/Utility/WatchpointMixin_x86.cpp:9 + +#if defined(__i386__) || defined(__x86_64__) + labath wrote: > This class won't be using any os- or arch-specific

[Lldb-commits] [PATCH] D89477: [lldb] Port lldb gdb-server to libOption

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfa5fa63fd140: [lldb] Port lldb gdb-server to libOption (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] fa5fa63 - [lldb] Port lldb gdb-server to libOption

Author: Pavel Labath Date: 2020-10-21T16:16:18+02:00 New Revision: fa5fa63fd140f2d4bad0357839378606a583b32c URL: https://github.com/llvm/llvm-project/commit/fa5fa63fd140f2d4bad0357839378606a583b32c DIFF: https://github.com/llvm/llvm-project/commit/fa5fa63fd140f2d4bad0357839378606a583b32c.diff

[Lldb-commits] [PATCH] D89334: [lldb] Support Python imports relative the to the current file being sourced

labath added a comment. In D89334#2341889 , @JDevlieghere wrote: > In D89334#2341561 , @labath wrote: > >> I'm afraid you've lost me there. Yes, we turn relative paths into absolute >> ones, but I don't see how

[Lldb-commits] [PATCH] D89874: [lldb] Unify x86 watchpoint implementation on Linux and NetBSD (and future FreeBSD plugin) [WIP]

mgorny added a comment. In D89874#2344561 , @labath wrote: > I like this, and I think this is in a pretty good shape as it stands. The > thing I'm not sure of is the naming of the class. I'd probably name it > something like NativeRegisterContext_x86

[Lldb-commits] [PATCH] D89859: Remove .svn from exclude list as we moved to git

sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: serge-sans-paille. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, mgorny. Herald added a reviewer: bollu. Herald added projects: clang, LLDB, LLVM. sylvestre.ledru requested review of this revision. Herald

[Lldb-commits] [PATCH] D89859: Remove .svn from exclude list as we moved to git

emaste added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89859/new/ https://reviews.llvm.org/D89859 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

labath added a comment. I think this is a good start. See inline comments for details. In addition to the test for the "target symbols add" flow it would be good to have a separate test for the ObjectFilePDB functionality. You can look at existing tests in `test/Shell/ObjectFile` for

[Lldb-commits] [PATCH] D89875: [nfc] [lldb] Fix harmless slicing of DWARFDIE

jankratochvil created this revision. jankratochvil added a reviewer: labath. jankratochvil added a project: LLDB. Herald added subscribers: JDevlieghere, kristof.beyls. jankratochvil requested review of this revision. Is `return {...};` implicit ctor OK for LLDB? I have found only one line

[Lldb-commits] [PATCH] D89874: [lldb] Unify x86 watchpoint implementation on Linux and NetBSD (and future FreeBSD plugin) [WIP]

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:296 const ArchSpec _arch, NativeThreadProtocol _thread) -: NativeRegisterContextLinux(native_thread, +:

[Lldb-commits] [PATCH] D89875: [nfc] [lldb] Fix harmless slicing of DWARFDIE

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. > Is return {...}; implicit ctor OK for LLDB? I have found only one line > (return {sdk};) in rG5935227e11f5 > using >

[Lldb-commits] [PATCH] D85241: [intel-pt] Disable/Enable tracing to guarantee the trace is correct

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Sounds reasonable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85241/new/ https://reviews.llvm.org/D85241

[Lldb-commits] [PATCH] D89874: [lldb] Unify x86 watchpoint implementation on Linux and NetBSD (and future FreeBSD plugin) [WIP]

mgorny created this revision. mgorny added a reviewer: labath. Herald added subscribers: pengfei, krytarowski. mgorny requested review of this revision. This is a WIP on unifying the x86 watchpoint implementation that is used on Linux and NetBSD. For the initial version, I've copied the code

[Lldb-commits] [PATCH] D89874: [lldb] Unify x86 watchpoint implementation on Linux and NetBSD (and future FreeBSD plugin) [WIP]

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.h:110 - bool IsGPR(uint32_t reg_index) const; + bool IsGPROrDR(uint32_t reg_index) const; I have changed this to facilitate `WriteRegister()`.

[Lldb-commits] [lldb] 7bf066a - [nfc] [lldb] Fix harmless slicing of DWARFDIE

Author: Jan Kratochvil Date: 2020-10-21T15:49:53+02:00 New Revision: 7bf066a20f4bfd52a79ae7650632bb3925171104 URL: https://github.com/llvm/llvm-project/commit/7bf066a20f4bfd52a79ae7650632bb3925171104 DIFF:

[Lldb-commits] [PATCH] D89875: [nfc] [lldb] Fix harmless slicing of DWARFDIE

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7bf066a20f4b: [nfc] [lldb] Fix harmless slicing of DWARFDIE (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D89874: [lldb] Unify x86 watchpoint implementation on Linux and NetBSD (and future FreeBSD plugin) [WIP]

krytarowski added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:580 - if (IsGPR(reg_index)) + if (IsGPROrDR(reg_index)) return WriteRegisterRaw(reg_index, reg_value); Can we have `IsGPR(reg_index)

[Lldb-commits] [PATCH] D89874: [lldb] Unify x86 watchpoint implementation on Linux and NetBSD (and future FreeBSD plugin) [WIP]

mgorny added inline comments. Comment at: lldb/include/lldb/lldb-defines.h:57-58 #define LLDB_WATCH_ID_IS_VALID(uid) ((uid) != (LLDB_INVALID_WATCH_ID)) #define LLDB_WATCH_TYPE_READ (1u << 0) #define LLDB_WATCH_TYPE_WRITE (1u << 1) #define LLDB_WATCH_TYPE_IS_VALID(type)

[Lldb-commits] [PATCH] D89874: [lldb] Unify x86 watchpoint implementation on Linux and NetBSD (and future FreeBSD plugin) [WIP]

mgorny added a comment. For the record, I'm planning to `clang-format` the code at the very end. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89874/new/ https://reviews.llvm.org/D89874 ___ lldb-commits mailing list

[Lldb-commits] [lldb] d900b75 - [lldb] Fix windows build for fa5fa63fd140f

Author: Pavel Labath Date: 2020-10-21T17:51:11+02:00 New Revision: d900b755ed003967d1c9675b62293414831db1b6 URL: https://github.com/llvm/llvm-project/commit/d900b755ed003967d1c9675b62293414831db1b6 DIFF: https://github.com/llvm/llvm-project/commit/d900b755ed003967d1c9675b62293414831db1b6.diff

[Lldb-commits] [PATCH] D89874: [lldb] Unify x86 watchpoint implementation on Linux and NetBSD (and future FreeBSD plugin) [WIP]

mgorny updated this revision to Diff 299731. mgorny added a comment. Revamped the whole file to hopefully make it a bit less magical. - Moved all the constants into inline functions and one constexpr var. - Added more 'visual' comments what bits are touched. - Added comments about

[Lldb-commits] [PATCH] D89874: [lldb] Unify x86 watchpoint implementation on Linux and NetBSD (and future FreeBSD plugin) [WIP]

mgorny added reviewers: emaste, krytarowski. mgorny added a comment. Adding more people in case they wanted to chime in, as this code will be reused on FreeBSD and NetBSD too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89874/new/ https://reviews.llvm.org/D89874