[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

labath added a comment. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120972/new/ https://reviews.llvm.org/D120972 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D121442: [lldb] Don't overwrite the host arch (from qHostInfo) with the process arch (from qProcessInfo)

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. sounds like a good idea to me CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121442/new/ https://reviews.llvm.org/D121442 ___ lldb-commits

[Lldb-commits] [PATCH] D121030: [LLDB][NativePDB] Don't complete static members' types when completing a record type.

labath added a comment. This is cool, just one question about the test. Comment at: lldb/test/Shell/SymbolFile/NativePDB/local-variables.cpp:8-26 +class B; +class A { +public: +static const A constA; +static A a; +static B b; +int val = 1;

[Lldb-commits] [PATCH] D121443: [lldb] Add a getter for the process' system architecture

labath added inline comments. Comment at: lldb/source/Target/Process.cpp:2654 +ArchSpec Process::GetSystemArchitecture() { + return HostInfo::GetArchitecture(); +} This is only a good default for local process plugins. Since we have just one (windows) of those

[Lldb-commits] [PATCH] D121444: [lldb] Fix platform selection on Apple Silicon (again)

labath added a comment. > I wish I could make this distinction in the platform, but you need a > connected process to do this. Basically, what you're saying is that the ArchSpec alone is not sufficient to select the right platform. Instead of punching right through the layers, could we just

[Lldb-commits] [PATCH] D120810: [lldb] Remove the global platform list

labath added a comment. (I'm not going to land this immediately, since I've also learned that this breaks running the test suite against the qemu platform -- which works right now, but it seems that is mostly accidental. I will switch gears and make the qemu platform more test-suite compatible

Re: [Lldb-commits] [lldb] c604207 - lldb/ObjectFile, Disassembler: read some state from the executable

No test case? On 10/03/2022 22:42, Saleem Abdulrasool via lldb-commits wrote: Author: Saleem Abdulrasool Date: 2022-03-10T21:42:06Z New Revision: c6042076081025bc8060637b05fbeb24dbb82538 URL: https://github.com/llvm/llvm-project/commit/c6042076081025bc8060637b05fbeb24dbb82538 DIFF:

[Lldb-commits] [PATCH] D121443: [lldb] Add a getter for the process' system architecture

tschuett added inline comments. Comment at: lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.cpp:236 +ArchSpec NativeProcessWindows::GetSystemArchitecture() override; +return HostInfo::GetArchitecture(); +} two spaces? CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 530bc61 - [lldb] Fix typo in ProcessWindows.h

Author: Jonas Devlieghere Date: 2022-03-11T11:33:16-08:00 New Revision: 530bc619011a435080b52abff628d201389c05f9 URL: https://github.com/llvm/llvm-project/commit/530bc619011a435080b52abff628d201389c05f9 DIFF:

[Lldb-commits] [PATCH] D121481: Applying clang-tidy modernize-use-default-member-init over LLDB

shafik updated this revision to Diff 414715. shafik added a comment. Applying clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121481/new/ https://reviews.llvm.org/D121481 Files: lldb/source/API/SBBroadcaster.cpp lldb/source/API/SBListener.cpp

[Lldb-commits] [PATCH] D121484: [lldb] Plumb host architecture through platform selection

JDevlieghere created this revision. JDevlieghere added a reviewer: labath. Herald added a subscriber: emaste. Herald added a project: All. JDevlieghere requested review of this revision. Plumb host architecture through platform selection in preparation for D121444

[Lldb-commits] [PATCH] D121444: [lldb] Fix platform selection on Apple Silicon (again)

JDevlieghere updated this revision to Diff 414722. JDevlieghere added a comment. Check the host architecture in PlatformMacOSX CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121444/new/ https://reviews.llvm.org/D121444 Files: lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp

[Lldb-commits] [PATCH] D121226: [lldb] Removed scoped timer from ReadMemoryFromFileCache

kastiglione closed this revision. kastiglione added a comment. Merged in rG3ca91adef8e885d89658a540860d3cee8746b1d9 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121226/new/

[Lldb-commits] [PATCH] D121480: [lldb] Move Module::FindTypes scoped timer to SymbolFileDWARFDebugMap

kastiglione closed this revision. kastiglione added a comment. Merged in rG3ca91adef8e885d89658a540860d3cee8746b1d9 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121480/new/

[Lldb-commits] [PATCH] D121226: [lldb] Removed scoped timer from ReadMemoryFromFileCache

kastiglione reopened this revision. kastiglione added a comment. This revision is now accepted and ready to land. Ignore previous comment, wrong diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121226/new/ https://reviews.llvm.org/D121226

[Lldb-commits] [PATCH] D121443: [lldb] Add a getter for the process' system architecture

JDevlieghere updated this revision to Diff 414702. JDevlieghere marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121443/new/ https://reviews.llvm.org/D121443 Files: lldb/include/lldb/Target/Process.h

[Lldb-commits] [PATCH] D121443: [lldb] Add a getter for the process' system architecture

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.cpp:236 +ArchSpec NativeProcessWindows::GetSystemArchitecture() override; +return HostInfo::GetArchitecture(); +} tschuett wrote: > two spaces? I

[Lldb-commits] [PATCH] D121480: [lldb] Move Module::FindTypes scoped timer to SymbolFileDWARFDebugMap

kastiglione created this revision. kastiglione added reviewers: aprantl, augusto2112, JDevlieghere. kastiglione added projects: All, LLDB. kastiglione requested review of this revision. When debugging via debug map, `Module::FindTypes` is called for very frequently due to lookups happening over

[Lldb-commits] [PATCH] D121481: Applying clang-tidy modernize-use-default-member-init over LLDB

kastiglione added inline comments. Comment at: lldb/source/API/SBQueue.cpp:33 QueueImpl(const lldb::QueueSP _sp) - : m_thread_list_fetched(false), m_pending_items_fetched(false) { + { m_queue_wp = queue_sp; should you also run clang-format?

[Lldb-commits] [lldb] a6eeffa - [lldb] Include lldb/Host/HostInfo.h in ProcessWindows.cpp

Author: Jonas Devlieghere Date: 2022-03-11T12:34:41-08:00 New Revision: a6eeffa106a479b90059b3cfacbc7d2cd377c965 URL: https://github.com/llvm/llvm-project/commit/a6eeffa106a479b90059b3cfacbc7d2cd377c965 DIFF:

[Lldb-commits] [lldb] 94bda3a - [lldb] Removed scoped timer from ReadMemoryFromFileCache

Author: Dave Lee Date: 2022-03-11T12:46:38-08:00 New Revision: 94bda3aaa12192660cd8da3a7b3bf9749b2a2c44 URL: https://github.com/llvm/llvm-project/commit/94bda3aaa12192660cd8da3a7b3bf9749b2a2c44 DIFF: https://github.com/llvm/llvm-project/commit/94bda3aaa12192660cd8da3a7b3bf9749b2a2c44.diff

[Lldb-commits] [PATCH] D121226: [lldb] Removed scoped timer from ReadMemoryFromFileCache

This revision was automatically updated to reflect the committed changes. Closed by commit rG94bda3aaa121: [lldb] Removed scoped timer from ReadMemoryFromFileCache (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121226/new/

[Lldb-commits] [PATCH] D121444: [lldb] Fix platform selection on Apple Silicon (again)

JDevlieghere added a comment. In D121444#3375701 , @labath wrote: > In D121444#3375445 , @JDevlieghere > wrote: > >> In D121444#3374854 , @labath wrote: >> I wish I

[Lldb-commits] [PATCH] D121481: Applying clang-tidy modernize-use-default-member-init over LLDB

shafik created this revision. shafik added reviewers: aprantl, JDevlieghere, labath. Herald added a subscriber: arphaman. Herald added a project: All. shafik requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Applied

[Lldb-commits] [PATCH] D121487: [lldb] Require native for command-thread-siginfo.test

asahay created this revision. Herald added a project: All. asahay requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. command-thread-siginfo.test employs a subject with a call to wait, and thus requires system-linux. However, it's possible to

[Lldb-commits] [PATCH] D121443: [lldb] Add a getter for the process' system architecture

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.h:75 + ArchSpec Process::GetSystemArchitecture() override; + This should

[Lldb-commits] [lldb] 68099b1 - [lldb] Add a getter for the process' system architecture

Author: Jonas Devlieghere Date: 2022-03-11T10:58:04-08:00 New Revision: 68099b1d5c2c99ff79e56a9e183f1601835ea244 URL: https://github.com/llvm/llvm-project/commit/68099b1d5c2c99ff79e56a9e183f1601835ea244 DIFF:

[Lldb-commits] [PATCH] D121443: [lldb] Add a getter for the process' system architecture

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG68099b1d5c2c: [lldb] Add a getter for the process system architecture (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG

[Lldb-commits] [PATCH] D121444: [lldb] Fix platform selection on Apple Silicon (again)

labath added a comment. In D121444#3375445 , @JDevlieghere wrote: > In D121444#3374854 , @labath wrote: > >>> I wish I could make this distinction in the platform, but you need a >>> connected process to do

[Lldb-commits] [PATCH] D121480: [lldb] Move Module::FindTypes scoped timer to SymbolFileDWARFDebugMap

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121480/new/ https://reviews.llvm.org/D121480

[Lldb-commits] [lldb] 3ca91ad - [lldb] Move FindTypes scoped timer to SymbolFileDWARFDebugMap

Author: Dave Lee Date: 2022-03-11T12:40:06-08:00 New Revision: 3ca91adef8e885d89658a540860d3cee8746b1d9 URL: https://github.com/llvm/llvm-project/commit/3ca91adef8e885d89658a540860d3cee8746b1d9 DIFF: https://github.com/llvm/llvm-project/commit/3ca91adef8e885d89658a540860d3cee8746b1d9.diff

[Lldb-commits] [PATCH] D121442: [lldb] Don't overwrite the host arch (from qHostInfo) with the process arch (from qProcessInfo)

This revision was automatically updated to reflect the committed changes. Closed by commit rG4ef07e5ffe59: [lldb] Dont overwrite the host arch with the process arch (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 4ef07e5 - [lldb] Don't overwrite the host arch with the process arch

Author: Jonas Devlieghere Date: 2022-03-11T09:23:01-08:00 New Revision: 4ef07e5ffe59efa259bd84a7750718a5e62fa1ce URL: https://github.com/llvm/llvm-project/commit/4ef07e5ffe59efa259bd84a7750718a5e62fa1ce DIFF:

[Lldb-commits] [PATCH] D121408: Fixing DWARFExpression handling of ValueType::FileAddress case for DW_OP_deref_size

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Thanks! Comment at: lldb/source/Expression/DWARFExpression.cpp:962 +/// check_sectionoffset is true we consider LLDB_INVALID_ADDRESS a +/// success if

[Lldb-commits] [PATCH] D121443: [lldb] Add a getter for the process' system architecture

JDevlieghere updated this revision to Diff 414678. JDevlieghere added a comment. - Only return the host architecture in NativeProcessWindows CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121443/new/ https://reviews.llvm.org/D121443 Files: lldb/include/lldb/Target/Process.h

[Lldb-commits] [PATCH] D121408: Fixing DWARFExpression handling of ValueType::FileAddress case for DW_OP_deref_size

shafik updated this revision to Diff 414663. shafik marked 12 inline comments as done. shafik added a comment. Addressing comment - Adding documentation - Moving some more error handling into helper - Cleaning up the calling side CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D121408: Fixing DWARFExpression handling of ValueType::FileAddress case for DW_OP_deref_size

shafik added inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:948 +llvm::Optional +ResolveAndLoadFileAddress(ExecutionContext *exe_ctx, lldb::ModuleSP module_sp, + Status *error_ptr, const char *dw_op_type, aprantl

[Lldb-commits] [PATCH] D121444: [lldb] Fix platform selection on Apple Silicon (again)

JDevlieghere added a comment. In D121444#3374854 , @labath wrote: >> I wish I could make this distinction in the platform, but you need a >> connected process to do this. > > Basically, what you're saying is that the ArchSpec alone is not sufficient to

[Lldb-commits] [PATCH] D121494: [VFS] Rename `RedirectingFileSystem::dump` to `print`

bnbarham created this revision. bnbarham added a reviewer: dexonsmith. Herald added a project: All. bnbarham requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. The rest of LLVM uses `print` for the method taking the

[Lldb-commits] [PATCH] D121494: [VFS] Rename `RedirectingFileSystem::dump` to `print`

bnbarham added a comment. Herald added a subscriber: JDevlieghere. @dexonsmith it'll be faster to run the tests here than locally, so I figured I'd put the review up anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121494/new/

[Lldb-commits] [PATCH] D121494: [VFS] Rename `RedirectingFileSystem::dump` to `print`

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. I think you didn't upload the full patch, so I think the bots will fail, but once the bots are happy this LGTM (besides one nit inline). Comment at:

[Lldb-commits] [lldb] 0c0f6cf - [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

Author: Petr Hosek Date: 2022-03-11T15:43:01-08:00 New Revision: 0c0f6cfb7b9fab0ee69ef67ed95c194698c9d794 URL: https://github.com/llvm/llvm-project/commit/0c0f6cfb7b9fab0ee69ef67ed95c194698c9d794 DIFF: https://github.com/llvm/llvm-project/commit/0c0f6cfb7b9fab0ee69ef67ed95c194698c9d794.diff

[Lldb-commits] [PATCH] D121348: Don't try to get memory returns for ABIMacOSX_arm64

JDevlieghere added inline comments. Comment at: lldb/source/API/SBTarget.cpp:1596-1597 + if (target_sp) { +std::string abi_name(target_sp->GetABIName().str()); +ConstString const_name(abi_name.c_str()); +return const_name.GetCString(); I think

[Lldb-commits] [PATCH] D121494: [VFS] Rename `RedirectingFileSystem::dump` to `print`

bnbarham updated this revision to Diff 414770. bnbarham added a comment. Removed LLVM_DUMP_METHOD from .cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121494/new/ https://reviews.llvm.org/D121494 Files:

[Lldb-commits] [PATCH] D121426: [VFS] Update uses of getVFSFromYAML to use the new getVFSFromYAMLs API

bnbarham added inline comments. Comment at: llvm/include/llvm/Support/Error.h:1284 - StringRef getFileName() { return FileName; } + StringRef getFileName() const { return FileName; } Should this be in a change all by itself? Repository: rG LLVM Github

[Lldb-commits] [PATCH] D121426: [VFS] Update uses of getVFSFromYAML to use the new getVFSFromYAMLs API

bnbarham updated this revision to Diff 414718. bnbarham added a comment. Handle empty overlay file in clang tidy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121426/new/ https://reviews.llvm.org/D121426 Files:

[Lldb-commits] [PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0c0f6cfb7b9f: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D121426: [VFS] Update uses of getVFSFromYAML to use the new getVFSFromYAMLs API

bnbarham updated this revision to Diff 414751. bnbarham edited the summary of this revision. bnbarham added a comment. Update to single review dependency Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121426/new/ https://reviews.llvm.org/D121426

[Lldb-commits] [PATCH] D121426: [VFS] Update uses of getVFSFromYAML to use the new getVFSFromYAMLs API

bnbarham created this revision. bnbarham added reviewers: keith, dexonsmith, JDevlieghere, vsapsai. Herald added a subscriber: carlosgalvezp. Herald added a project: All. bnbarham requested review of this revision. Herald added projects: clang, LLDB, LLVM, clang-tools-extra. Herald added

[Lldb-commits] [PATCH] D121500: [lldb] Protect the debugger's output and error stream

JDevlieghere added a comment. In D121500#3376497 , @jingham wrote: > LGTM. It might be worthwhile to audit the uses of Debugger::GetErrorFile & > GetOutputFile to see which of them really should also be using the lockable > stream instead. That would

[Lldb-commits] [PATCH] D121500: [lldb] Protect the debugger's output and error stream

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM. It might be worthwhile to audit the uses of Debugger::GetErrorFile & GetOutputFile to see which of them really should also be using the lockable stream instead. That would be fine

[Lldb-commits] [PATCH] D121494: [VFS] Rename `RedirectingFileSystem::dump` to `print`

bnbarham updated this revision to Diff 414763. bnbarham added a comment. Herald added a subscriber: hiraditya. Added VFS.cpp, removed implementation from header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121494/new/

[Lldb-commits] [PATCH] D121348: Don't try to get memory returns for ABIMacOSX_arm64

jingham updated this revision to Diff 414765. jingham added a comment. At Pavel's request I extended this to the SysV_arm64 ABI. Since I don't want to have to guess which arch's are which ABI's, I exposed the ABI plugin's name and then used that in the test. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D121500: [lldb] Protect the debugger's output and error stream

JDevlieghere created this revision. JDevlieghere added reviewers: labath, jingham. Herald added a subscriber: kristof.beyls. Herald added a project: All. JDevlieghere requested review of this revision. This patch introduces a small utility called `LockableStream` to protect the debugger's output

[Lldb-commits] [PATCH] D121500: [lldb] Protect the debugger's output and error stream

JDevlieghere updated this revision to Diff 414775. JDevlieghere edited the summary of this revision. JDevlieghere added a comment. Rename utility class to `ThreadSafeStream`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121500/new/ https://reviews.llvm.org/D121500 Files:

[Lldb-commits] [PATCH] D121502: [lldb] Use the debugger's output stream for writing in HandleProgressEvent

JDevlieghere created this revision. JDevlieghere added reviewers: labath, jingham. Herald added a project: All. JDevlieghere requested review of this revision. Use the (thread safe) output stream to write progress events to the debugger's output. https://reviews.llvm.org/D121502 Files:

[Lldb-commits] [PATCH] D121511: [lldb] Report debugger diagnostics as events

JDevlieghere updated this revision to Diff 414801. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121511/new/ https://reviews.llvm.org/D121511 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/Core/DebuggerEvents.h lldb/source/Core/Debugger.cpp

[Lldb-commits] [PATCH] D121511: [lldb] Report debugger diagnostics as events

JDevlieghere created this revision. JDevlieghere added reviewers: clayborg, labath, jingham. Herald added a project: All. JDevlieghere requested review of this revision. Report warnings and errors through events instead of printing directly the to the debugger's error stream. Diagnostic events