[Lldb-commits] [lldb] c484857 - [lldb] Use =default in the ValueList class

Author: Pavel Labath Date: 2022-03-30T09:12:59+02:00 New Revision: c484857b2e77721a4235b0e2d53d335c09fc6af3 URL: https://github.com/llvm/llvm-project/commit/c484857b2e77721a4235b0e2d53d335c09fc6af3 DIFF: https://github.com/llvm/llvm-project/commit/c484857b2e77721a4235b0e2d53d335c09fc6af3.diff

[Lldb-commits] [PATCH] D122710: [lldb-vscode] Avoid a -Wunused-but-set-variable warning. NFC.

mstorsjo created this revision. mstorsjo added reviewers: labath, clayborg. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D122710 Files:

[Lldb-commits] [lldb] 1410a48 - [lldb] Remove vasprintf windows-compat implementation

Author: Pavel Labath Date: 2022-03-30T09:32:35+02:00 New Revision: 1410a4860eb2355f0c6e3274a937f7e382a59e5c URL: https://github.com/llvm/llvm-project/commit/1410a4860eb2355f0c6e3274a937f7e382a59e5c DIFF: https://github.com/llvm/llvm-project/commit/1410a4860eb2355f0c6e3274a937f7e382a59e5c.diff

[Lldb-commits] [PATCH] D122684: [lldb] Use the selected and host platform to disambiguate between fat binary architectures

labath accepted this revision. labath added a comment. Just this morning, I was (again) contemplating the idea of introducing some sort of numeric platform priorities. (We currently have a sort of a ternary system -- exact match, compatible match, no match). That would allow us to express

[Lldb-commits] [PATCH] D122710: [lldb-vscode] Avoid a -Wunused-but-set-variable warning. NFC.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. I think this qualifies as an obvious fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122710/new/

[Lldb-commits] [PATCH] D121844: Applying clang-tidy modernize-use-equals-default over LLDB

labath added inline comments. Comment at: lldb/source/Core/Value.cpp:667 -const ValueList ::operator=(const ValueList ) { +const ValueList ::operator=(const ValueList ) { // NOLINT(modernize-use-equals-default) m_values = rhs.m_values; shafik wrote: >

[Lldb-commits] [PATCH] D122716: [lldb/linux] Handle main thread exits

labath created this revision. labath added reviewers: mgorny, DavidSpickett. Herald added a subscriber: krytarowski. Herald added a project: All. labath requested review of this revision. Herald added a project: LLDB. This patch handles the situation where the main thread exits (through the

[Lldb-commits] [lldb] 21c5bb0 - Recommit [lldb/test] Make category-skipping logic "platform"-independent

Author: Pavel Labath Date: 2022-03-30T17:16:37+02:00 New Revision: 21c5bb0a636c23ec75b13681c0a6fdb03ecd9c0d URL: https://github.com/llvm/llvm-project/commit/21c5bb0a636c23ec75b13681c0a6fdb03ecd9c0d DIFF: https://github.com/llvm/llvm-project/commit/21c5bb0a636c23ec75b13681c0a6fdb03ecd9c0d.diff

[Lldb-commits] [PATCH] D122684: [lldb] Use the selected and host platform to disambiguate between fat binary architectures

jingham added inline comments. Comment at: lldb/source/Target/Platform.cpp:1252 +if (selected_platform_sp) { + if (selected_platform_sp->IsCompatibleArchitecture( + arch, process_host_arch, false, nullptr)) { Why are you passing

[Lldb-commits] [PATCH] D122684: [lldb] Use the selected and host platform to disambiguate between fat binary architectures

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/Target/Platform.cpp:1252 +if (selected_platform_sp) { + if (selected_platform_sp->IsCompatibleArchitecture( + arch, process_host_arch, false,

[Lldb-commits] [PATCH] D122753: Fix NSIndexPathSyntheticFrontEnd::Impl::Clear() to only clear the active union member

shafik added a comment. I believe that `NSIndexPathSyntheticFrontEnd::Update()` also needs a fix in order to properly set the active member but I will do that as a separate fix since. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122753/new/ https://reviews.llvm.org/D122753

[Lldb-commits] [PATCH] D122684: [lldb] Use the selected and host platform to disambiguate between fat binary architectures

JDevlieghere added inline comments. Comment at: lldb/source/Target/Platform.cpp:1252 +if (selected_platform_sp) { + if (selected_platform_sp->IsCompatibleArchitecture( + arch, process_host_arch, false, nullptr)) { JDevlieghere wrote: >

[Lldb-commits] [PATCH] D122684: [lldb] Use the selected and host platform to disambiguate between fat binary architectures

jingham added inline comments. Comment at: lldb/source/Target/Platform.cpp:1252 +if (selected_platform_sp) { + if (selected_platform_sp->IsCompatibleArchitecture( + arch, process_host_arch, false, nullptr)) { jingham wrote: > Why are you

[Lldb-commits] [PATCH] D122753: Fix NSIndexPathSyntheticFrontEnd::Impl::Clear() to only clear the active union member

shafik created this revision. shafik added reviewers: labath, aprantl, JDevlieghere. Herald added a subscriber: arphaman. Herald added a project: All. shafik requested review of this revision. `NSIndexPathSyntheticFrontEnd::Impl::Clear()` currently calls `Clear()` on both unions members

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan updated this revision to Diff 419226. yinghuitan added a comment. Support debug map dwarf mode. Use zero symbol ability to skip SymbolFileOnDemand wrapping. Add new API tests for symbol on-demand which support multi-platform. Remove linux-only shell tests. Repository: rG LLVM

[Lldb-commits] [PATCH] D117559: [lldb] Remove forward-connect ability from lldb-server tests

labath added a comment. (Thanks for trying this out, I'm still thinking about the best way to move this forward.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117559/new/ https://reviews.llvm.org/D117559

[Lldb-commits] [PATCH] D122710: [lldb-vscode] Avoid a -Wunused-but-set-variable warning. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa37cb5ece513: [lldb-vscode] Avoid a -Wunused-but-set-variable warning. NFC. (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] a37cb5e - [lldb-vscode] Avoid a -Wunused-but-set-variable warning. NFC.

Author: Martin Storsjö Date: 2022-03-31T00:10:05+03:00 New Revision: a37cb5ece513cbed9059880a45838331460e42fb URL: https://github.com/llvm/llvm-project/commit/a37cb5ece513cbed9059880a45838331460e42fb DIFF:

[Lldb-commits] [PATCH] D122680: Add a setting to force overwriting commands in "command script add"

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122680/new/ https://reviews.llvm.org/D122680

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121967/new/ https://reviews.llvm.org/D121967 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D122753: Fix NSIndexPathSyntheticFrontEnd::Impl::Clear() to only clear the active union member

This revision was automatically updated to reflect the committed changes. Closed by commit rG14cad95d3823: [LLDB] Fix NSIndexPathSyntheticFrontEnd::Impl::Clear() to only clear the active… (authored by shafik). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] 14cad95 - [LLDB] Fix NSIndexPathSyntheticFrontEnd::Impl::Clear() to only clear the active union member

Author: Shafik Yaghmour Date: 2022-03-30T18:00:37-07:00 New Revision: 14cad95d38235df6c5fd5dd3da84b91fa69e7e74 URL: https://github.com/llvm/llvm-project/commit/14cad95d38235df6c5fd5dd3da84b91fa69e7e74 DIFF:

[Lldb-commits] [PATCH] D122767: [lldb] Improve documentation for some of the platform functions

JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. Herald added a project: All. JDevlieghere requested review of this revision. Improve the documentation for the platform functions that take a process host architecture as input. https://reviews.llvm.org/D122767 Files:

[Lldb-commits] [lldb] a114ec0 - [lldb] Change the way we pick a platform for fat binaries

Author: Jonas Devlieghere Date: 2022-03-30T15:30:05-07:00 New Revision: a114ec0c6dc052832ec3dc1f65c9e221e3272925 URL: https://github.com/llvm/llvm-project/commit/a114ec0c6dc052832ec3dc1f65c9e221e3272925 DIFF:

[Lldb-commits] [PATCH] D122684: [lldb] Use the selected and host platform to disambiguate between fat binary architectures

This revision was automatically updated to reflect the committed changes. Closed by commit rGa114ec0c6dc0: [lldb] Change the way we pick a platform for fat binaries (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D122753: Fix NSIndexPathSyntheticFrontEnd::Impl::Clear() to only clear the active union member

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122753/new/ https://reviews.llvm.org/D122753 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D121844: Applying clang-tidy modernize-use-equals-default over LLDB

shafik marked 3 inline comments as done. shafik added inline comments. Comment at: lldb/source/Core/Value.cpp:667 -const ValueList ::operator=(const ValueList ) { +const ValueList ::operator=(const ValueList ) { // NOLINT(modernize-use-equals-default) m_values =

[Lldb-commits] [PATCH] D122603: [intelpt] Refactor timestamps out of IntelPTInstruction

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. Some calculations are wrong, but overall this is good. We are very close! Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.cpp:112-113