[Lldb-commits] [PATCH] D154926: [lldb][AArch64] Add support for SME's SVE streaming mode registers

This revision was automatically updated to reflect the committed changes. Closed by commit rG03d8cd1d722d: [lldb][AArch64] Add support for SMEs SVE streaming mode registers (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D154930: [lldb][AArch64] Add the tpidr2 TLS register that comes with SME

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGefa43d785ee6: [lldb][AArch64] Add the tpidr2 TLS register that comes with SME (authored by DavidSpickett). Changed prior to commit:

[Lldb-commits] [PATCH] D156268: [lldb] Treat ARM64X images as ARM64.

antmo added a comment. In D156268#4534366 , @mstorsjo wrote: > I think this looks good. Did @antmo verify that it actually fixes the issue? > (It seems plausible, although there may be more similar cases hiding > somewhere?) Not yet. Struggling a bit

[Lldb-commits] [lldb] 03d8cd1 - [lldb][AArch64] Add support for SME's SVE streaming mode registers

Author: David Spickett Date: 2023-07-26T09:36:50+01:00 New Revision: 03d8cd1d722daad86c45e242eb7d75d0a88bb00c URL: https://github.com/llvm/llvm-project/commit/03d8cd1d722daad86c45e242eb7d75d0a88bb00c DIFF:

[Lldb-commits] [lldb] efa43d7 - [lldb][AArch64] Add the tpidr2 TLS register that comes with SME

Author: David Spickett Date: 2023-07-26T10:34:13+01:00 New Revision: efa43d785ee600ef4cc14589e4777264f0613ec9 URL: https://github.com/llvm/llvm-project/commit/efa43d785ee600ef4cc14589e4777264f0613ec9 DIFF:

[Lldb-commits] [PATCH] D156268: [lldb] Treat ARM64X images as ARM64.

antmo added a comment. I confirm that the 7 failed tests are now Ok CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156268/new/ https://reviews.llvm.org/D156268 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Michael137 updated this revision to Diff 544350. Michael137 added a comment. - Parameterize tests - Return bool to indicate SDK mismatch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156020/new/ https://reviews.llvm.org/D156020 Files:

[Lldb-commits] [lldb] 48feef2 - [lldb] Treat ARM64X images as ARM64.

Author: Jacek Caban Date: 2023-07-26T14:45:48+02:00 New Revision: 48feef277a24b1b9c0ff33267a91e70d9584012e URL: https://github.com/llvm/llvm-project/commit/48feef277a24b1b9c0ff33267a91e70d9584012e DIFF: https://github.com/llvm/llvm-project/commit/48feef277a24b1b9c0ff33267a91e70d9584012e.diff

[Lldb-commits] [PATCH] D156268: [lldb] Treat ARM64X images as ARM64.

This revision was automatically updated to reflect the committed changes. Closed by commit rG48feef277a24: [lldb] Treat ARM64X images as ARM64. (authored by jacek). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 011cc6d - [lldb-vsocde] Cleaning up the usage of the Separate helper in Options.td.

Author: John Harrison Date: 2023-07-26T15:27:17-04:00 New Revision: 011cc6d8bfba44ae7e057854c4e7110ae0a4ba37 URL: https://github.com/llvm/llvm-project/commit/011cc6d8bfba44ae7e057854c4e7110ae0a4ba37 DIFF: https://github.com/llvm/llvm-project/commit/011cc6d8bfba44ae7e057854c4e7110ae0a4ba37.diff

[Lldb-commits] [PATCH] D154990: [lldb-vsocde] Cleaning up the usage of the Separate helper in Options.td.

This revision was automatically updated to reflect the committed changes. Closed by commit rG011cc6d8bfba: [lldb-vsocde] Cleaning up the usage of the Separate helper in Options.td. (authored by ashgti, committed by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Michael137 updated this revision to Diff 544376. Michael137 added a comment. - Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156020/new/ https://reviews.llvm.org/D156020 Files: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp

[Lldb-commits] [PATCH] D156268: [lldb] Treat ARM64X images as ARM64.

jacek added a comment. Herald added a subscriber: JDevlieghere. Thanks for review and testing. I created https://github.com/llvm/llvm-project/issues/64131 for the backport. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156268/new/

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Michael137 updated this revision to Diff 544378. Michael137 added a comment. - EXPECT -> ASSERT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156020/new/ https://reviews.llvm.org/D156020 Files:

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:1363 + XcodeSDK sdk; + for (unsigned i = 0; i < sym_file->GetNumCompileUnits(); ++i) +if (auto

[Lldb-commits] [lldb] b0b2b6b - [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Author: Michael Buch Date: 2023-07-26T18:26:08+01:00 New Revision: b0b2b6bab4d25122b2259dfac500fd83d60fa154 URL: https://github.com/llvm/llvm-project/commit/b0b2b6bab4d25122b2259dfac500fd83d60fa154 DIFF: https://github.com/llvm/llvm-project/commit/b0b2b6bab4d25122b2259dfac500fd83d60fa154.diff

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

This revision was automatically updated to reflect the committed changes. Closed by commit rGb0b2b6bab4d2: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

RamNalamothu added a comment. In D156086#4536992 , @jasonmolenda wrote: > In D156086#4530507 , @RamNalamothu > wrote: > >> In D156086#4529791 , @jasonmolenda >> wrote:

[Lldb-commits] [PATCH] D155905: lldb RFC: Exposing set/get address masks, Fix*Address methods in SBProcess

jasonmolenda added inline comments. Comment at: lldb/include/lldb/API/SBProcess.h:415-416 + /// (unsigned long long) 0xfc00 + lldb::addr_t GetCodeAddressMask(); + lldb::addr_t GetDataAddressMask(); + clayborg wrote: > Will there only ever be two

[Lldb-commits] [PATCH] D156375: Fix lldb-vscode frame id integer overflow

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, kusmour, GeorgeHuyubo. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch

[Lldb-commits] [PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

MaskRay added a comment. It seems that a lldb specific test is needed. Adding a new method to `llvm/include/llvm/MC/MCInstrAnalysis.h` is fine with me, though I haven't checked the semantics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D155905: lldb RFC: Exposing set/get address masks, Fix*Address methods in SBProcess

clayborg added a comment. In D155905#4536917 , @jasonmolenda wrote: > Also interesting to consider if there should be an "Any" define. e.g. > > enum AddressMaskType { > eTypeCode = 0, > eTypeData, > eTypeHighmemCode, >

[Lldb-commits] [PATCH] D156375: Fix lldb-vscode frame id integer overflow

This revision was automatically updated to reflect the committed changes. Closed by commit rGca849352936d: Fix lldb-vscode frame id integer overflow (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156375/new/

[Lldb-commits] [lldb] ca84935 - Fix lldb-vscode frame id integer overflow

Author: Jeffrey Tan Date: 2023-07-26T16:12:41-07:00 New Revision: ca849352936dadadd232cf9ec74ac006ce410f51 URL: https://github.com/llvm/llvm-project/commit/ca849352936dadadd232cf9ec74ac006ce410f51 DIFF: https://github.com/llvm/llvm-project/commit/ca849352936dadadd232cf9ec74ac006ce410f51.diff

[Lldb-commits] [PATCH] D155107: Add support for llvm::MCInstPrinter::setPrintBranchImmAsAddress

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Looking at Ted's earlier riscv disassembly with this enabled, it is more readable, I'm surprised these instructions don't print this way by default like they are for other

[Lldb-commits] [PATCH] D155905: lldb RFC: Exposing set/get address masks, Fix*Address methods in SBProcess

jasonmolenda added a comment. In D155905#4537036 , @clayborg wrote: > > I like it the above approach with more enums for the high and low code/data. > Not sure if eTypeAny makes sense in the GetAddressMask(eTypeAny) scenario, > but I can see the

[Lldb-commits] [PATCH] D155905: lldb RFC: Exposing set/get address masks, Fix*Address methods in SBProcess

jasonmolenda added a comment. Also interesting to consider if there should be an "Any" define. e.g. enum AddressMaskType { eTypeCode = 0, eTypeData, eTypeHighmemCode, eTypeHighmemData, eTypeAny }; lldb::addr_t GetAddressMask(AddressMaskType mask_type); void

[Lldb-commits] [PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

jasonmolenda added a comment. In D156086#4530507 , @RamNalamothu wrote: > In D156086#4529791 , @jasonmolenda > wrote: > >> >> Does `isBranch` include other variants like `isUnconditionalBranch`? > > No.

[Lldb-commits] [PATCH] D156375: Fix lldb-vscode frame id integer overflow

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. We ran into this with a process that had many threads. No easy way to test this without creating a process with 8K threads. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST