@@ -1036,12 +1036,18 @@ void ObjectFilePECOFF::CreateSections(SectionList
&unified_section_list) {
m_sections_up->AddSection(header_sp);
unified_section_list.AddSection(header_sp);
+std::vector truncated_dwarf_sections;
const uint32_t nsects = m_sect_headers.
Author: Pavel Labath
Date: 2025-06-23T12:07:10+02:00
New Revision: 18f667d804144e74d3ba2c67ee6f3610916002a8
URL:
https://github.com/llvm/llvm-project/commit/18f667d804144e74d3ba2c67ee6f3610916002a8
DIFF:
https://github.com/llvm/llvm-project/commit/18f667d804144e74d3ba2c67ee6f3610916002a8.diff
@@ -178,11 +178,40 @@ ASTNodeUP DILParser::ParsePrimaryExpression() {
}
if (CurToken().Is(Token::l_paren)) {
-m_dil_lexer.Advance();
-auto expr = ParseExpression();
-Expect(Token::r_paren);
-m_dil_lexer.Advance();
-return expr;
+// Check in case thi
@@ -178,11 +178,40 @@ ASTNodeUP DILParser::ParsePrimaryExpression() {
}
if (CurToken().Is(Token::l_paren)) {
-m_dil_lexer.Advance();
-auto expr = ParseExpression();
-Expect(Token::r_paren);
-m_dil_lexer.Advance();
-return expr;
+// Check in case thi
@@ -173,6 +173,22 @@
help="Specify the C/C++ standard.",
)
+parser.add_argument(
DavidSpickett wrote:
Do these need to be build script arguments or is there a catch all
`--extra-args ...` that we could use instead?
Given that only this test requires the
@@ -173,6 +173,22 @@
help="Specify the C/C++ standard.",
)
+parser.add_argument(
DavidSpickett wrote:
That said, there's some pros to having all the compile flags in this file but I
have to assume there are tests passing arbitrary flags anyway.
https://
@@ -178,11 +178,40 @@ ASTNodeUP DILParser::ParsePrimaryExpression() {
}
if (CurToken().Is(Token::l_paren)) {
-m_dil_lexer.Advance();
-auto expr = ParseExpression();
-Expect(Token::r_paren);
-m_dil_lexer.Advance();
-return expr;
+// Check in case thi
Author: Pavel Labath
Date: 2025-06-23T11:31:26+02:00
New Revision: e7c1da7c8ef31c258619c1668062985e7ae83b70
URL:
https://github.com/llvm/llvm-project/commit/e7c1da7c8ef31c258619c1668062985e7ae83b70
DIFF:
https://github.com/llvm/llvm-project/commit/e7c1da7c8ef31c258619c1668062985e7ae83b70.diff
mstorsjo wrote:
> truncate the section names, as [sections in PE/COFF executable images can't
> be longer than 8
> bytes](https://learn.microsoft.com/en-us/windows/win32/debug/pe-format#section-table-section-headers).
First off, this probably meant to say "section names can't be longer than 8
https://github.com/DavidSpickett approved this pull request.
LGTM
Fix the tab completion if you want to, and if you don't, raise an issue for it.
https://github.com/llvm/llvm-project/pull/143126
___
lldb-commits mailing list
lldb-commits@lists.llvm.or
https://github.com/DavidSpickett approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/145301
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/145305
The only difference from the original PR are the added BRIEF and FULL_DOCS
arguments to define_property, which are required for cmake<3.23.
>From be3083de00796539976b1bbfe25f90693296bd89 Mon Sep 17 00:00:00 2001
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
The only difference from the original PR are the added BRIEF and FULL_DOCS
arguments to define_property, which are required for cmake<3.23.
---
Patch is 20.34 KiB, truncated to 20.00 KiB below, full version:
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/145301
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
Originally added for reproducers, it is now only used for test code.
While we could make it a test helper, I think that after #145015 it is
simple enough to not be needed.
Also squeeze in a change to make Con
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/145293
Originally added for reproducers, it is now only used for test code.
While we could make it a test helper, I think that after #145015 it is simple
enough to not be needed.
Also squeeze in a change to make Conne
https://github.com/DavidSpickett requested changes to this pull request.
The Linux CI failure is real and reproduces locally. I'm looking for a way to
make it work.
https://github.com/llvm/llvm-project/pull/145111
___
lldb-commits mailing list
lldb-co
Author: Pavel Labath
Date: 2025-06-23T10:51:26+02:00
New Revision: c5629f2b600488e1aee3f8c9f2266523b460367f
URL:
https://github.com/llvm/llvm-project/commit/c5629f2b600488e1aee3f8c9f2266523b460367f
DIFF:
https://github.com/llvm/llvm-project/commit/c5629f2b600488e1aee3f8c9f2266523b460367f.diff
@@ -106,6 +106,10 @@ class Socket : public IOObject {
static std::unique_ptr Create(const SocketProtocol protocol,
Status &error);
+ static llvm::Expected<
+ std::pair, std::unique_ptr>>
labath wrote:
Good idea.
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/145017
>From c4923f70478b5274e114642841fd9d3683b67d39 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Fri, 20 Jun 2025 10:29:23 +0200
Subject: [PATCH] [lldb] Use Socket::CreatePair for launching debugserver
This lets
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/145017
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Kazu Hirata
Date: 2025-06-22T16:31:34-07:00
New Revision: 9844085ea8132eae1086eaf55894db3904c189be
URL:
https://github.com/llvm/llvm-project/commit/9844085ea8132eae1086eaf55894db3904c189be
DIFF:
https://github.com/llvm/llvm-project/commit/9844085ea8132eae1086eaf55894db3904c189be.diff
L
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/143786
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett commented:
I've disabled a lot of tests on this bot for what was/is probably this issue,
so this will be a helpful warning I think.
https://github.com/llvm/llvm-project/pull/145175
___
lldb-commits mailing list
lldb-co
Author: Pavel Labath
Date: 2025-06-23T11:39:20+02:00
New Revision: 714b2fdf3a385e5b9a95c435f56b1696ec3ec9e8
URL:
https://github.com/llvm/llvm-project/commit/714b2fdf3a385e5b9a95c435f56b1696ec3ec9e8
DIFF:
https://github.com/llvm/llvm-project/commit/714b2fdf3a385e5b9a95c435f56b1696ec3ec9e8.diff
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/145175
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu`
running on `linaro-lldb-aarch64-ubuntu` while building `lldb` at step 6 "test".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/59/builds/19802
Here is the relevant piece of the b
Author: Ebuka Ezike
Date: 2025-06-23T10:32:46+01:00
New Revision: 5c22793eadd8758d589eafd1cbbb2897ab8b3c8b
URL:
https://github.com/llvm/llvm-project/commit/5c22793eadd8758d589eafd1cbbb2897ab8b3c8b
DIFF:
https://github.com/llvm/llvm-project/commit/5c22793eadd8758d589eafd1cbbb2897ab8b3c8b.diff
L
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/144543
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1071,6 +1077,15 @@ void ObjectFilePECOFF::CreateSections(SectionList
&unified_section_list) {
m_sections_up->AddSection(section_sp);
unified_section_list.AddSection(section_sp);
}
+
+if (!truncated_dwarf_sections.empty())
+ module_sp->ReportWarning
@@ -843,11 +843,28 @@ Status PluginManager::SaveCore(const lldb::ProcessSP
&process_sp,
}
// Check to see if any of the object file plugins tried and failed to save.
- // If none ran, set the error message.
- if (error.Success())
-error = Status::FromErrorString(
-
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/145301
See #144891 for details.
>From 7d1bbcc0f16a67612439dc3133c361f2582ac25b Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Mon, 23 Jun 2025 13:58:08 +0400
Subject: [PATCH] [lldb] Disable flaky TestDetachResu
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
See #144891 for details.
---
Full diff: https://github.com/llvm/llvm-project/pull/145301.diff
1 Files Affected:
- (modified) lldb/test/API/commands/process/detach-resumes/TestDetachResumes.py
(+5)
`
labath wrote:
> LGTM
>
> I think we must mention in the description the main functional change that
> now we are always using --fd for gdbserver on Windows instead of the back
> connection.
Thanks. Good point, updated the PR description.
https://github.com/llvm/llvm-project/pull/145017
_
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/145015
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/145055
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/145055
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/da-viper closed
https://github.com/llvm/llvm-project/pull/144954
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath commented:
If the test you found the anonymous namespace issue it is explicitly testing
the handling of anonymous namespaces, then this is fine. However, if it's doing
that as a side-effect of testing something else, then it may be nice to have an
explicit test case f
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/144998
>From 2c54344a0bf7c7937166820ae0ada92c4e4445cb Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 29 Jan 2025 12:15:35 +
Subject: [PATCH 1/8] [lldb][DWARFASTParserClang] Support constant index
encodi
@@ -52,6 +52,34 @@ TCPSocket::TCPSocket(NativeSocket socket, bool should_close)
TCPSocket::~TCPSocket() { CloseListenSockets(); }
+llvm::Expected<
+std::pair, std::unique_ptr>>
+TCPSocket::CreatePair() {
+ auto listen_socket_up = std::make_unique(true);
+ if (Status err
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/145015
>From 54ef8f5e1ff3f3ea28605ffb9a90f0b0aa6b52af Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Thu, 19 Jun 2025 21:44:02 +0200
Subject: [PATCH 1/2] [lldb] Add Socket::CreatePair
It creates a pair of connected
https://github.com/labath commented:
The code looks good. I just have issues with the test(s). Please, see inline
comments.
https://github.com/llvm/llvm-project/pull/143786
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.o
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/143786
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,26 @@
+#include
+
+struct NodeS;
+
+// Fake smart pointer definition.
+class smart_ptr {
+public:
+ NodeS *__ptr_;
labath wrote:
This is technically a reserved identifier. Let's just use `ptr`.
https://github.com/llvm/llvm-project/pull/143786
__
@@ -0,0 +1,32 @@
+import lldb
+
+
+class smartPtrSynthProvider:
+def __init__(self, valobj, dict):
+self.valobj = valobj
+
+def num_children(self):
+return 1
+
+def get_child_at_index(self, index):
+if index == 0:
+return self.valobj
labath wrote:
I have a bit of an issue with the test name and location, I think it sets up
the wrong expectations. The DIL should be language agnostic, so it shouldn't
work (only) with (c++) smart pointers. Even in c++ you have non-pointer types
that can be "
@@ -0,0 +1,34 @@
+"""
+Test DIL pointer dereferencing.
+"""
+
+import lldb
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test.decorators import *
+from lldbsuite.test import lldbutil
+
+import os
+import shutil
+import time
+
+
+class TestFrameVarDILPointerDereference(Tes
@@ -178,11 +178,40 @@ ASTNodeUP DILParser::ParsePrimaryExpression() {
}
if (CurToken().Is(Token::l_paren)) {
-m_dil_lexer.Advance();
-auto expr = ParseExpression();
-Expect(Token::r_paren);
-m_dil_lexer.Advance();
-return expr;
+// Check in case thi
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`cross-project-tests-sie-ubuntu-dwarf5` running on `doug-worker-1b` while
building `lldb` at step 4 "cmake-configure".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/163/builds/21408
Here is the rele
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/145305
>From be3083de00796539976b1bbfe25f90693296bd89 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Mon, 23 Jun 2025 12:13:54 +0200
Subject: [PATCH 1/2] Reapply "[lldb/cmake] Plugin layering enforcement
mechanism (
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/144731
>From 3c9a3e5e9af0c9d58783c11490bda473ada84ef3 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Wed, 18 Jun 2025 16:41:40 +0100
Subject: [PATCH 01/12] [lldb] upgrade HandleFrameFormatVariable callees t
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
`DWARFFormValue::ExtractValue` has nothing to extract for
`DW_FORM_implicit_const` since the value is stored in the abbreviation.
`DWARFFormValue` expects the user to have set the value of the implicit_con
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/144998
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/145301
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dmitry Vasilyev
Date: 2025-06-23T15:25:08+04:00
New Revision: 6d8d4cf9a46b3729732736ffe288f6b722d85121
URL:
https://github.com/llvm/llvm-project/commit/6d8d4cf9a46b3729732736ffe288f6b722d85121
DIFF:
https://github.com/llvm/llvm-project/commit/6d8d4cf9a46b3729732736ffe288f6b722d85121.dif
https://github.com/DavidSpickett approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/145305
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1036,12 +1036,18 @@ void ObjectFilePECOFF::CreateSections(SectionList
&unified_section_list) {
m_sections_up->AddSection(header_sp);
unified_section_list.AddSection(header_sp);
+std::vector truncated_dwarf_sections;
const uint32_t nsects = m_sect_headers.
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/144731
>From 3c9a3e5e9af0c9d58783c11490bda473ada84ef3 Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Wed, 18 Jun 2025 16:41:40 +0100
Subject: [PATCH 01/13] [lldb] upgrade HandleFrameFormatVariable callees t
https://github.com/Nerixyz updated
https://github.com/llvm/llvm-project/pull/145175
>From ebd8542451e1a0ecee83be48d4a630aff2ee3390 Mon Sep 17 00:00:00 2001
From: Nerixyz
Date: Sat, 21 Jun 2025 17:36:58 +0200
Subject: [PATCH] [LLDB] Warn about truncated DWARF section names on Windows
---
.../O
@@ -74,24 +74,48 @@ struct DemangledNameInfo {
return BasenameRange.second > BasenameRange.first;
}
+ /// Returns \c true if `BasenameRange` is empty.
+ bool isBasenameEmpty() const {
+return BasenameRange.first == BasenameRange.second;
charles-zab
DavidSpickett wrote:
The test waits forever trying to attach, the AsyncInterrupt doesn't stop it
doing that. I thought maybe these "threads" were not actually parallel so I
tried multiprocessing, same result (also I'm not sure this would work because
it uses a separate process).
I wonder if y
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/145305
>From be3083de00796539976b1bbfe25f90693296bd89 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Mon, 23 Jun 2025 12:13:54 +0200
Subject: [PATCH 1/3] Reapply "[lldb/cmake] Plugin layering enforcement
mechanism (
https://github.com/da-viper updated
https://github.com/llvm/llvm-project/pull/144364
>From 69545a26a9b1d7ee67818c2285bd942f94357203 Mon Sep 17 00:00:00 2001
From: Ebuka Ezike
Date: Mon, 16 Jun 2025 11:00:05 +0100
Subject: [PATCH 1/4] [lldb-dap] Fix source references
The protocol expects that `
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/145305
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/145328
`DWARFFormValue::ExtractValue` has nothing to extract for
`DW_FORM_implicit_const` since the value is stored in the abbreviation.
`DWARFFormValue` expects the user to have set the value of the implicit_const
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/145293
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/144731
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1372,6 +1373,36 @@ static void
LoadLibCxxFormatters(lldb::TypeCategoryImplSP cpp_category_sp) {
"${var.__y_} ${var.__m_} ${var.__wdl_}")));
}
+static void RegisterStdStringSummaryProvider(
+const lldb::TypeCategoryImplSP &category_sp, llvm::StringRef string_
@@ -74,24 +74,48 @@ struct DemangledNameInfo {
return BasenameRange.second > BasenameRange.first;
}
+ /// Returns \c true if `BasenameRange` is empty.
+ bool isBasenameEmpty() const {
+return BasenameRange.first == BasenameRange.second;
Michael137
https://github.com/Nerixyz edited
https://github.com/llvm/llvm-project/pull/145175
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Nerixyz updated
https://github.com/llvm/llvm-project/pull/145175
>From 39fa8adfc78c76a73ac1762eed31eecca789e8b6 Mon Sep 17 00:00:00 2001
From: Nerixyz
Date: Sat, 21 Jun 2025 17:36:58 +0200
Subject: [PATCH] [LLDB] Warn about truncated DWARF section names on Windows
---
.../O
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/128724
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1071,6 +1077,15 @@ void ObjectFilePECOFF::CreateSections(SectionList
&unified_section_list) {
m_sections_up->AddSection(section_sp);
unified_section_list.AddSection(section_sp);
}
+
+if (!truncated_dwarf_sections.empty())
+ module_sp->ReportWarning
@@ -173,6 +173,22 @@
help="Specify the C/C++ standard.",
)
+parser.add_argument(
Nerixyz wrote:
There are no extra arguments here (unless I missed them). At least
`--force-ms-link` would still need to be required because the script will use
`lld-link` i
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/145338
In the same way that memory regions may be known from a core file but not
readable, tag segments can also have no content. For example:
$ readelf --segments core
<...>
Program Headers:
Type Of
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
In the same way that memory regions may be known from a core file but not
readable, tag segments can also have no content. For example:
$ readelf --segments core
<...>
Program Headers:
Type
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/145338
>From 4b5a55eb2d7e8430eca4b76644b08fe705fbfec6 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Mon, 23 Jun 2025 14:29:53 +
Subject: [PATCH 1/2] [lldb][AArch64] Handle core file tag segments missing
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/145338
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/145338
>From 4b5a55eb2d7e8430eca4b76644b08fe705fbfec6 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Mon, 23 Jun 2025 14:29:53 +
Subject: [PATCH 1/3] [lldb][AArch64] Handle core file tag segments missing
@@ -173,6 +173,22 @@
help="Specify the C/C++ standard.",
)
+parser.add_argument(
DavidSpickett wrote:
Ok, these are fine then.
https://github.com/llvm/llvm-project/pull/145175
___
lldb-commits mailing list
lldb
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/145212
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
LGTM.
Whether it can be extended to other known sections, that's up to you, but in
its current DWARF specific form I like it.
https://github.com/llvm/llvm-project/pull/145175
___
lldb-commi
https://github.com/JDevlieghere approved this pull request.
LGTM. I would suggest making the title of this PR a bit more descriptive (e.g.
"Fix URL label in DAPError") before merging.
https://github.com/llvm/llvm-project/pull/145010
___
lldb-commits
@@ -1071,6 +1077,15 @@ void ObjectFilePECOFF::CreateSections(SectionList
&unified_section_list) {
m_sections_up->AddSection(section_sp);
unified_section_list.AddSection(section_sp);
}
+
+if (!truncated_dwarf_sections.empty())
+ module_sp->ReportWarning
DavidSpickett wrote:
Actually, add an entry to
https://github.com/llvm/llvm-project/blob/main/llvm/docs/ReleaseNotes.md#changes-to-lldb
as well.
It's not something I'd normally put in the release notes but it may appear in
existing workflows when people update. If it's in the release notes we
@@ -2,23 +2,35 @@
Test lldb-dap RestartRequest.
"""
-import os
-from lldbsuite.test.decorators import *
-from lldbsuite.test.lldbtest import line_number
+from typing import Dict, Any, List
+
import lldbdap_testcase
+from lldbsuite.test.decorators import skipIfWindows, skipIf,
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/145342
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Nerixyz updated
https://github.com/llvm/llvm-project/pull/145175
>From 72f30f6d2a1dfb5523bafd4a535b078b3de5cfc6 Mon Sep 17 00:00:00 2001
From: Nerixyz
Date: Sat, 21 Jun 2025 17:36:58 +0200
Subject: [PATCH] [LLDB] Warn about truncated DWARF section names on Windows
---
.../O
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/145328
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/145126
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -310,7 +310,7 @@ serveConnection(const Socket::SocketProtocol &protocol,
const std::string &name,
"DAP session (" + client_name +
") error: ");
}
-
+ io->Close();
da-vipe
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/139174
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/145010
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DrSergei updated
https://github.com/llvm/llvm-project/pull/145231
>From b3b919db7333ee20bc640e1b4b5a701891cc6443 Mon Sep 17 00:00:00 2001
From: Druzhkov Sergei
Date: Thu, 19 Jun 2025 15:50:27 +0300
Subject: [PATCH] [lldb-dap] Fix flaky test
---
lldb/test/API/tools/lldb-dap/
github-actions[bot] wrote:
@zyn-li Congratulations on having your first Pull Request (PR) merged into the
LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a
problem with a build,
Author: Zyn
Date: 2025-06-23T13:02:51-05:00
New Revision: ff865b639af05e366b108c7acb034e3d0e069376
URL:
https://github.com/llvm/llvm-project/commit/ff865b639af05e366b108c7acb034e3d0e069376
DIFF:
https://github.com/llvm/llvm-project/commit/ff865b639af05e366b108c7acb034e3d0e069376.diff
LOG: [lld
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/144815
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/145366
We can omit the call to Target::HasLoadedSections as Address::HasLoadedSections
already "does the right thing" and returns LLDB_INVALID_ADDRESS if no sections
are loaded.
>From 1df38e3639abcd0c009024e6d49
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
We can omit the call to Target::HasLoadedSections as Address::HasLoadedSections
already "does the right thing" and returns LLDB_INVALID_ADDRESS if no sections
are loaded.
---
Full diff: https://git
1 - 100 of 179 matches
Mail list logo
