[Lldb-commits] [lldb] [lldb] Implement DW_CFA_val_offset and DW_CFA_val_offset_sf (PR #150732)

2025-08-04 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. > I don't think the non-standard return pointer bit from > eh-frame-dwarf-unwind.test should be necessary but if I remove it, lldb > starts trying to read the code instead of using the CFI and it stops > unwinding correctly Yeah, that's be

[Lldb-commits] [lldb] [lldb] Implement DW_CFA_val_offset and DW_CFA_val_offset_sf (PR #150732)

2025-08-04 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,58 @@ +# Test handing of the dwarf val_offset() rule which can be used to reconstruct +# the value of a register that is neither in a live register or saved on the +# stack but is computable with CFA + offset. + +# UNSUPPORTED: system-windows, ld_new-bug +# REQUIRES: ta

[Lldb-commits] [lldb] [lldb] Implement DW_CFA_val_offset and DW_CFA_val_offset_sf (PR #150732)

2025-08-04 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/150732 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [libcxxabi] [lldb] [llvm] [DRAFT] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From b8f31ec8f556169a45370938cf28bd8582134a5c Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Sun, 3 Aug 2025 11:38:07 +0100 Subject: [PATCH 1/3] [clang][Attr] Remove 'literal label' form of AsmLabelAttr

[Lldb-commits] [lldb] [lldb] Include bit.h instead of SwapByteOrder.h (NFC) (PR #151903)

2025-08-04 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/151903 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix auto advance PC in `EmulateInstructionARM64` if PC >= 4G (PR #151460)

2025-08-04 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/151460 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix auto advance PC in `EmulateInstructionARM64` if PC >= 4G (PR #151460)

2025-08-04 Thread Pavel Labath via lldb-commits
@@ -13,15 +13,124 @@ #include "lldb/Core/Disassembler.h" #include "lldb/Target/ExecutionContext.h" #include "lldb/Utility/ArchSpec.h" +#include "lldb/Utility/RegisterValue.h" #include "Plugins/Instruction/ARM64/EmulateInstructionARM64.h" +#include "Plugins/Process/Utility/Re

[Lldb-commits] [lldb] [lldb] add TemplateRange and NameQualifiersRange to DemangledNameInfo (PR #150999)

2025-08-04 Thread Michael Buch via lldb-commits
@@ -92,6 +92,10 @@ void TrackingOutputBuffer::finalizeStart() { if (NameInfo.BasenameRange.second == 0) NameInfo.BasenameRange.second = getCurrentPosition(); + if (NameInfo.BasenameRange.second != NameInfo.ArgumentsRange.first) Michael137 wrote: Lets a

[Lldb-commits] [lldb] [lldb] add TemplateRange and NameQualifiersRange to DemangledNameInfo (PR #150999)

2025-08-04 Thread Michael Buch via lldb-commits
@@ -92,6 +92,10 @@ void TrackingOutputBuffer::finalizeStart() { if (NameInfo.BasenameRange.second == 0) NameInfo.BasenameRange.second = getCurrentPosition(); + if (NameInfo.BasenameRange.second != NameInfo.ArgumentsRange.first) +NameInfo.TemplateArgumentsRange = {Na

[Lldb-commits] [clang] [lldb] [Clang] Initial support for P2841 (Variable template and concept template parameters) (PR #150823)

2025-08-04 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-sie-win` running on `sie-win-worker` while building `clang,lldb` at step 7 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/46/builds/21161 Here

[Lldb-commits] [lldb] [lldb] Fix TLS support on Darwin platforms (PR #151601)

2025-08-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. Based on my reading of the relevant dyld change this makes sense, thanks! This does mean we won't handle the old TLS format correctly though right? https://github.com/llvm/llvm-project/pull/151601

[Lldb-commits] [clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-04 Thread Michael Buch via lldb-commits
Michael137 wrote: CC @AaronBallman for the Clang side of this https://github.com/llvm/llvm-project/pull/149827 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/149827 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/149827 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/149827 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/149827 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [clang][Attr] Remove 'literal label' form of AsmLabelAttr (PR #151858)

2025-08-04 Thread Corentin Jabot via lldb-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/151858 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/149827 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-04 Thread Aaron Ballman via lldb-commits
https://github.com/AaronBallman approved this pull request. Clang bits LGTM https://github.com/llvm/llvm-project/pull/149827 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NativePDB] Implement `FindNamespace` (PR #151950)

2025-08-04 Thread via lldb-commits
https://github.com/Nerixyz created https://github.com/llvm/llvm-project/pull/151950 `FindNamespace` was not implemented for `SymbolFileNativePDB`. Without it, it wasn't possible to lookup items through namespaces when evaluating expressions. This is mostly the same as in [SymbolFilePDB](https

[Lldb-commits] [lldb] [LLDB][NativePDB] Implement `FindNamespace` (PR #151950)

2025-08-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: nerix (Nerixyz) Changes `FindNamespace` was not implemented for `SymbolFileNativePDB`. Without it, it wasn't possible to lookup items through namespaces when evaluating expressions. This is mostly the same as in [SymbolFilePDB](https://gi

[Lldb-commits] [lldb] [lldb] Fix race condition in Process::WaitForProcessToStop() (PR #144919)

2025-08-04 Thread Pavel Labath via lldb-commits
labath wrote: Agreed. I think the right fix is to make sure that event gets consumed by the EvaluateExpression machinery. https://github.com/llvm/llvm-project/pull/144919 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org

[Lldb-commits] [clang] [lldb] [clang][Attr] Remove 'literal label' form of AsmLabelAttr (PR #151858)

2025-08-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/151858 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Update JSONTransport to use MainLoop for reading. (PR #148300)

2025-08-04 Thread Pavel Labath via lldb-commits
@@ -7,163 +7,104 @@ //===--===// #include "lldb/Host/JSONTransport.h" -#include "lldb/Utility/IOObject.h" #include "lldb/Utility/LLDBLog.h" #include "lldb/Utility/Log.h" -#include "lldb/Utility/SelectHelper

[Lldb-commits] [lldb] [lldb] Update JSONTransport to use MainLoop for reading. (PR #148300)

2025-08-04 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. Looks much better. Thanks. https://github.com/llvm/llvm-project/pull/148300 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Update JSONTransport to use MainLoop for reading. (PR #148300)

2025-08-04 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/148300 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Reimplment PyRun_String using the Python stable C API (PR #151761)

2025-08-04 Thread Pavel Labath via lldb-commits
@@ -1469,11 +1466,33 @@ python::runStringMultiLine(const llvm::Twine &string, const PythonDictionary &locals) { if (!globals.IsValid() || !locals.IsValid()) return nullDeref(); - PyObject *result = PyRun_String(NullTerminated(string), Py_file_i

[Lldb-commits] [lldb] 440a4de - [lldb][darwin] force BuiltinHeadersInSystemModules to be always false (#151535)

2025-08-04 Thread via lldb-commits
Author: Charles Zablit Date: 2025-08-04T11:39:15+02:00 New Revision: 440a4de55265c67cf41a77e40f96d7c18ed7590a URL: https://github.com/llvm/llvm-project/commit/440a4de55265c67cf41a77e40f96d7c18ed7590a DIFF: https://github.com/llvm/llvm-project/commit/440a4de55265c67cf41a77e40f96d7c18ed7590a.diff

[Lldb-commits] [lldb] [lldb][darwin] force BuiltinHeadersInSystemModules to be always false (PR #151535)

2025-08-04 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit closed https://github.com/llvm/llvm-project/pull/151535 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Update DIL handling of array subscripting. (PR #151605)

2025-08-04 Thread Pavel Labath via lldb-commits
@@ -323,47 +323,144 @@ Interpreter::Visit(const MemberOfNode *node) { m_expr, errMsg, node->GetLocation(), node->GetFieldName().size()); } + llvm::Expected Interpreter::Visit(const ArraySubscriptNode *node) { auto lhs_or_err = Evaluate(node->GetBase()); if (!lhs_

[Lldb-commits] [lldb] [LLDB] Update DIL handling of array subscripting. (PR #151605)

2025-08-04 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/151605 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Update DIL handling of array subscripting. (PR #151605)

2025-08-04 Thread Pavel Labath via lldb-commits
@@ -323,47 +323,144 @@ Interpreter::Visit(const MemberOfNode *node) { m_expr, errMsg, node->GetLocation(), node->GetFieldName().size()); } + llvm::Expected Interpreter::Visit(const ArraySubscriptNode *node) { auto lhs_or_err = Evaluate(node->GetBase()); if (!lhs_

[Lldb-commits] [lldb] [LLDB] Update DIL handling of array subscripting. (PR #151605)

2025-08-04 Thread Pavel Labath via lldb-commits
https://github.com/labath commented: I see the bitfield handling is reflected in the test case, but I don't see anything about handling of synthetic children or objc pointers. For the objc case, I'm very tempted to *not* copy that bit of code over, since it: a) is untested (or you wouldn't hav

[Lldb-commits] [lldb] [LLDB] Update DIL handling of array subscripting. (PR #151605)

2025-08-04 Thread Pavel Labath via lldb-commits
@@ -323,47 +323,144 @@ Interpreter::Visit(const MemberOfNode *node) { m_expr, errMsg, node->GetLocation(), node->GetFieldName().size()); } + llvm::Expected Interpreter::Visit(const ArraySubscriptNode *node) { auto lhs_or_err = Evaluate(node->GetBase()); if (!lhs_

[Lldb-commits] [lldb] [lldb] Guard SBFrame/SBThread methods against running processes (PR #152020)

2025-08-04 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- lldb/include/lldb/API/SBFrame.h lldb/include/lldb/H

[Lldb-commits] [lldb] [lldb] Guard SBFrame/SBThread methods against running processes (PR #152020)

2025-08-04 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/test/API/python_api/run_locker/TestRunLocker.py `` View th

[Lldb-commits] [lldb] [vscode-lldb] Fix race condition when changing lldb-dap arguments (PR #151828)

2025-08-04 Thread via lldb-commits
https://github.com/kusmour approved this pull request. https://github.com/llvm/llvm-project/pull/151828 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] added getName method in SBModule (PR #150331)

2025-08-04 Thread via lldb-commits
https://github.com/barsolo2000 updated https://github.com/llvm/llvm-project/pull/150331 >From b79edf938d49d03498ec3a9228344a684d0cbf6e Mon Sep 17 00:00:00 2001 From: Bar Soloveychik Date: Wed, 23 Jul 2025 15:17:29 -0700 Subject: [PATCH 1/8] [LLDB] added getName method in SBModule --- lldb/inc

[Lldb-commits] [lldb] [llvm] [lldb][windows] use Windows APIs to print to the console (PR #149493)

2025-08-04 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/149493 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a CMake option to build agains the Python limited API (PR #152034)

2025-08-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes This adds a CMake option (which defaults to OFF) to force building against the Python limited API. This makes iterating on #151617 easier and eventually will prevent us from regressing this configur

[Lldb-commits] [lldb] [lldb] Reimplement PythonObject::Dump using the limited API (PR #152055)

2025-08-04 Thread Med Ismail Bennani via lldb-commits
@@ -131,23 +132,30 @@ void StructuredPythonObject::Serialize(llvm::json::OStream &s) const { // PythonObject void PythonObject::Dump(Stream &strm) const { - if (m_py_obj) { -FILE *file = llvm::sys::RetryAfterSignal(nullptr, ::tmpfile); -if (file) { - ::PyObject_

[Lldb-commits] [lldb] [lldb] Use Python Bytes instead of Buffer for Binary I/O (NFC) (PR #152031)

2025-08-04 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. https://github.com/llvm/llvm-project/pull/152031 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a CMake option to build agains the Python limited API (PR #152034)

2025-08-04 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/152034 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Update JSONTransport to use MainLoop for reading. (PR #148300)

2025-08-04 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/148300 >From 7857cff5f79c603c72edb69f0c10294e5e042ebc Mon Sep 17 00:00:00 2001 From: John Harrison Date: Fri, 11 Jul 2025 14:24:42 -0700 Subject: [PATCH 1/7] [lldb] Update JSONTransport to use MainLoop for reading. Thi

[Lldb-commits] [lldb] [lldb] Use Python Bytes instead of Buffer for Binary I/O (NFC) (PR #152031)

2025-08-04 Thread Alex Langford via lldb-commits
@@ -1212,12 +1178,12 @@ class BinaryPythonFile : public PythonIOFile { num_bytes = 0; return Status(); } -auto pybuffer = PythonBuffer::Create(pybuffer_obj.get()); -if (!pybuffer) - // Cloning since the wrapped exception may still reference the PyTh

[Lldb-commits] [lldb] [lldb] Update JSONTransport to use MainLoop for reading. (PR #148300)

2025-08-04 Thread John Harrison via lldb-commits
@@ -7,163 +7,104 @@ //===--===// #include "lldb/Host/JSONTransport.h" -#include "lldb/Utility/IOObject.h" #include "lldb/Utility/LLDBLog.h" #include "lldb/Utility/Log.h" -#include "lldb/Utility/SelectHelper

[Lldb-commits] [lldb] [lldb] Use Python Bytes instead of Buffer for Binary I/O (NFC) (PR #152031)

2025-08-04 Thread Alex Langford via lldb-commits
https://github.com/bulbazord requested changes to this pull request. https://github.com/llvm/llvm-project/pull/152031 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Treat address found via function name as a callable address (PR #151973)

2025-08-04 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/151973 I discovered this building the lldb test suite with `-mthumb` set, so that all test programs are purely Arm Thumb code. When C++ expressions did a function lookup, they took a different path from C progr

[Lldb-commits] [lldb] [lldb] Treat address found via function name as a callable address (PR #151973)

2025-08-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes I discovered this building the lldb test suite with `-mthumb` set, so that all test programs are purely Arm Thumb code. When C++ expressions did a function lookup, they took a different path from C p

[Lldb-commits] [lldb] [lldb] Treat address found via function name as a callable address (PR #151973)

2025-08-04 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/151973 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] add TemplateRange and NameQualifiersRange to DemangledNameInfo (PR #150999)

2025-08-04 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/150999 >From 9b3551c6dbf8629c49f2bf3ed3f34e7b4e52e65f Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Mon, 28 Jul 2025 18:58:44 +0200 Subject: [PATCH 1/6] [lldb] add TemplateRange and NameQualifiersRange to

[Lldb-commits] [lldb] 147cfc8 - [lldb][DWARFIndex] Adapt DWARFIndex DIERefCallback to IterationAction (#152001)

2025-08-04 Thread via lldb-commits
Author: Michael Buch Date: 2025-08-04T18:44:42+01:00 New Revision: 147cfc89f05e8953fa8eaff7448353c817b17cc9 URL: https://github.com/llvm/llvm-project/commit/147cfc89f05e8953fa8eaff7448353c817b17cc9 DIFF: https://github.com/llvm/llvm-project/commit/147cfc89f05e8953fa8eaff7448353c817b17cc9.diff

[Lldb-commits] [lldb] [lldb][DWARFIndex] Adapt DWARFIndex DIERefCallback to IterationAction (PR #152001)

2025-08-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/152001 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Eliminate PyGILState_Check (NFC) (PR #152006)

2025-08-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/152006 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] ad623a8 - [lldb] Eliminate PyGILState_Check (NFC) (#152006)

2025-08-04 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-08-04T10:44:32-07:00 New Revision: ad623a813e6d9ffdef62270656245b35ffceda37 URL: https://github.com/llvm/llvm-project/commit/ad623a813e6d9ffdef62270656245b35ffceda37 DIFF: https://github.com/llvm/llvm-project/commit/ad623a813e6d9ffdef62270656245b35ffceda37.d

[Lldb-commits] [lldb] [lldb] add TemplateRange and NameQualifiersRange to DemangledNameInfo (PR #150999)

2025-08-04 Thread Charles Zablit via lldb-commits
@@ -92,6 +92,10 @@ void TrackingOutputBuffer::finalizeStart() { if (NameInfo.BasenameRange.second == 0) NameInfo.BasenameRange.second = getCurrentPosition(); + if (NameInfo.BasenameRange.second != NameInfo.ArgumentsRange.first) +NameInfo.TemplateArgumentsRange = {Na

[Lldb-commits] [lldb] [Minidump] Update Minidump file builder to continue when the Module's section cannot be found (PR #152009)

2025-08-04 Thread via lldb-commits
https://github.com/barsolo2000 created https://github.com/llvm/llvm-project/pull/152009 Instead of returning an error when: - it can't obtain section information from a module. - there are other issues calculating the size. Instead, when we encounter such an error we log the error and continue

[Lldb-commits] [lldb] [lldb] Fix TLS support on Darwin platforms (PR #151601)

2025-08-04 Thread Alex Langford via lldb-commits
bulbazord wrote: > This does mean we won't handle the old TLS format correctly though right? My understanding is that this should handle the "old" TLS format correctly. When I updated this code 2 years ago, I think I misunderstood the dyld implementation and this worked because of a coincidenc

[Lldb-commits] [lldb] [Minidump] Update Minidump file builder to continue when the Module's section cannot be found (PR #152009)

2025-08-04 Thread Jacob Lalonde via lldb-commits
@@ -308,38 +308,48 @@ Status MinidumpFileBuilder::AddModuleList() { // the llvm::minidump::Module's structures into helper data size_t size_before = GetCurrentDataEndOffset(); - // This is the size of the main part of the ModuleList stream. - // It consists of a module n

[Lldb-commits] [lldb] [Minidump] Update Minidump file builder to continue when the Module's section cannot be found (PR #152009)

2025-08-04 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond requested changes to this pull request. https://github.com/llvm/llvm-project/pull/152009 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [Minidump] Update Minidump file builder to continue when the Module's section cannot be found (PR #152009)

2025-08-04 Thread Jacob Lalonde via lldb-commits
@@ -308,38 +308,48 @@ Status MinidumpFileBuilder::AddModuleList() { // the llvm::minidump::Module's structures into helper data size_t size_before = GetCurrentDataEndOffset(); - // This is the size of the main part of the ModuleList stream. - // It consists of a module n

[Lldb-commits] [lldb] [LLDB][NativePDB] Allow type lookup in namespaces (PR #149876)

2025-08-04 Thread via lldb-commits
gulfemsavrun wrote: We started seeing a test failure (`lldb-api :: tools/lldb-dap/launch/TestDAP_launch.py`) after this patch: ``` 1754321883.282107115 (stdio) <-- {"body":{"category":"console","output":"(lldb) image dump sections a.out\n"},"event":"output","seq":0,"type":"event"} 1754321883.28

[Lldb-commits] [lldb] [lldb] Fix TLS support on Darwin platforms (PR #151601)

2025-08-04 Thread Med Ismail Bennani via lldb-commits
@@ -10,10 +10,12 @@ touch_shared(); // Create some TLS storage within the static executable. __thread int var_static = 44; +__thread int var_static2 = 22; void *fn_static(void *param) { var_static *= 2; + var_static2 *= 3; medismailben wrote: ind

[Lldb-commits] [lldb] [Minidump] Update Minidump file builder to continue when the Module's section cannot be found (PR #152009)

2025-08-04 Thread via lldb-commits
https://github.com/barsolo2000 edited https://github.com/llvm/llvm-project/pull/152009 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFIndex] Adapt DWARFIndex ObjC APIs to IterationAction (PR #151839)

2025-08-04 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/151839 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [vscode-lldb] Fix format (PR #151829)

2025-08-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/151829 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Eliminate PyGILState_Check (NFC) (PR #152006)

2025-08-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/152006 Eliminate calls to PyGILState_Check, which is not part of the Python Limited C API. In the Locker, we can use PyGILState_Ensure directly. We could do something similar to replace the assert, but I don't th

[Lldb-commits] [lldb] [lldb] Eliminate PyGILState_Check (NFC) (PR #152006)

2025-08-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Eliminate calls to PyGILState_Check, which is not part of the Python Limited C API. In the Locker, we can use PyGILState_Ensure directly. We could do something similar to replace the assert, but I d

[Lldb-commits] [lldb] [lldb] Eliminate PyGILState_Check (NFC) (PR #152006)

2025-08-04 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Part of https://github.com/llvm/llvm-project/issues/151617 https://github.com/llvm/llvm-project/pull/152006 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Eliminate PyGILState_Check (NFC) (PR #152006)

2025-08-04 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. https://github.com/llvm/llvm-project/pull/152006 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFIndex] Adapt DWARFIndex DIERefCallback to IterationAction (PR #152001)

2025-08-04 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/152001 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] c5c2570 - [lldb] Include bit.h instead of SwapByteOrder.h (NFC) (#151903)

2025-08-04 Thread via lldb-commits
Author: Kazu Hirata Date: 2025-08-04T07:40:28-07:00 New Revision: c5c2570d09de1a78f45a3a03a3167c35b05eae6e URL: https://github.com/llvm/llvm-project/commit/c5c2570d09de1a78f45a3a03a3167c35b05eae6e DIFF: https://github.com/llvm/llvm-project/commit/c5c2570d09de1a78f45a3a03a3167c35b05eae6e.diff L

[Lldb-commits] [lldb] [lldb] Include bit.h instead of SwapByteOrder.h (NFC) (PR #151903)

2025-08-04 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/151903 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From b8f31ec8f556169a45370938cf28bd8582134a5c Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Sun, 3 Aug 2025 11:38:07 +0100 Subject: [PATCH 1/4] [clang][Attr] Remove 'literal label' form of AsmLabelAttr

[Lldb-commits] [lldb] [vscode-lldb] Fix `yarn package` (PR #152002)

2025-08-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (royitaqi) Changes # Problem `yarn package` cannot be run twice in a row - the second time will error out: > Error: ENOENT: no such file or directory, stat '/llvm-project/lldb/tools/lldb-dap/out/lldb-dap.vsix' This error is also

[Lldb-commits] [lldb] [lldb] Reimplment PyRun_String using the Python stable C API (PR #151761)

2025-08-04 Thread Jonas Devlieghere via lldb-commits
@@ -1469,11 +1466,33 @@ python::runStringMultiLine(const llvm::Twine &string, const PythonDictionary &locals) { if (!globals.IsValid() || !locals.IsValid()) return nullDeref(); - PyObject *result = PyRun_String(NullTerminated(string), Py_file_i

[Lldb-commits] [lldb] [lldb][nfc] Use delegating ctor for ExecutionContext (PR #151987)

2025-08-04 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan created https://github.com/llvm/llvm-project/pull/151987 The ctor that takes a reference to ExecutionContextRef can be implemented in terms of the ctor that takes a pointer to that object, removing code duplication. >From c831152b699e1c4e4f6331a1feff356d7627c

[Lldb-commits] [lldb] [lldb][nfc] Use delegating ctor for ExecutionContext (PR #151987)

2025-08-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Felipe de Azevedo Piovezan (felipepiovezan) Changes The ctor that takes a reference to ExecutionContextRef can be implemented in terms of the ctor that takes a pointer to that object, removing code duplication. --- Full diff: https://gith

[Lldb-commits] [lldb] [lldb][NFC] Move SBThread::ResumeNewPlan out of the header (PR #151988)

2025-08-04 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan created https://github.com/llvm/llvm-project/pull/151988 This *private* method is only defined as a member class of SBThread so that it may be declared a `friend` of SBError and access a private constructor of SBError that takes a `Status`, which is an `lldb_p

[Lldb-commits] [lldb] [lldb][NFC] Move SBThread::ResumeNewPlan out of the header (PR #151988)

2025-08-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Felipe de Azevedo Piovezan (felipepiovezan) Changes This *private* method is only defined as a member class of SBThread so that it may be declared a `friend` of SBError and access a private constructor of SBError that takes a `Status`, whi

[Lldb-commits] [lldb] [vscode-lldb] Fix format (PR #151829)

2025-08-04 Thread via lldb-commits
https://github.com/royitaqi closed https://github.com/llvm/llvm-project/pull/151829 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] cd83444 - [vscode-lldb] Fix format (#151829)

2025-08-04 Thread via lldb-commits
Author: royitaqi Date: 2025-08-04T08:39:06-07:00 New Revision: cd834449a6d551cace6afad798ffad318f4ff325 URL: https://github.com/llvm/llvm-project/commit/cd834449a6d551cace6afad798ffad318f4ff325 DIFF: https://github.com/llvm/llvm-project/commit/cd834449a6d551cace6afad798ffad318f4ff325.diff LOG:

[Lldb-commits] [lldb] [vscode-lldb] Fix race condition when changing lldb-dap arguments (PR #151828)

2025-08-04 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/151828 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 7fb620a - Fix a deadlock in ModuleList when starting a standalone lldb client/server (#148774)

2025-08-04 Thread via lldb-commits
Author: qxy11 Date: 2025-08-04T08:43:49-07:00 New Revision: 7fb620a5cc02a511a019d6918b0993b4cbdea825 URL: https://github.com/llvm/llvm-project/commit/7fb620a5cc02a511a019d6918b0993b4cbdea825 DIFF: https://github.com/llvm/llvm-project/commit/7fb620a5cc02a511a019d6918b0993b4cbdea825.diff LOG: Fi

[Lldb-commits] [lldb] Fix a deadlock in ModuleList when starting a standalone lldb client/server (PR #148774)

2025-08-04 Thread via lldb-commits
https://github.com/qxy11 closed https://github.com/llvm/llvm-project/pull/148774 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][nfc] Use delegating ctor for ExecutionContext (PR #151987)

2025-08-04 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/151987 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] add TemplateRange and NameQualifiersRange to DemangledNameInfo (PR #150999)

2025-08-04 Thread Charles Zablit via lldb-commits
@@ -92,6 +92,10 @@ void TrackingOutputBuffer::finalizeStart() { if (NameInfo.BasenameRange.second == 0) NameInfo.BasenameRange.second = getCurrentPosition(); + if (NameInfo.BasenameRange.second != NameInfo.ArgumentsRange.first) +NameInfo.TemplateArgumentsRange = {Na

[Lldb-commits] [lldb] 0f08dc8 - [lldb] Use fully qualified name instead of namespace (NFC)

2025-08-04 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-08-04T09:22:25-07:00 New Revision: 0f08dc84405796c25c070ef57258309f66017984 URL: https://github.com/llvm/llvm-project/commit/0f08dc84405796c25c070ef57258309f66017984 DIFF: https://github.com/llvm/llvm-project/commit/0f08dc84405796c25c070ef57258309f66017984.d

[Lldb-commits] [lldb] [lldb][nfc] Use delegating ctor for ExecutionContext (PR #151987)

2025-08-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/151987 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Move SBThread::ResumeNewPlan out of the header (PR #151988)

2025-08-04 Thread via lldb-commits
https://github.com/jimingham approved this pull request. Yeah, that's weird to be a method because it acts on a thread that isn't necessarily the thread that is managed by the SBThread calling the method. That does sound more like it should be a free function. https://github.com/llvm/llvm-pro

[Lldb-commits] [lldb] [lldb][DWARFIndex] Adapt DWARFIndex GetTypes APIs to IterationAction (PR #151992)

2025-08-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/151992 >From 52184181acaff1c210b4edab9564c14da98d797c Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Sun, 3 Aug 2025 08:55:13 +0100 Subject: [PATCH 1/2] [lldb][DWARFIndex] Adapt DWARFIndex GetTypes APIs to Itera

[Lldb-commits] [lldb] 8f77fa7 - [lldb] Simplify Python Locker log messages (NFC)

2025-08-04 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-08-04T09:37:37-07:00 New Revision: 8f77fa7026de9f544778063fd9fe900d0804b863 URL: https://github.com/llvm/llvm-project/commit/8f77fa7026de9f544778063fd9fe900d0804b863 DIFF: https://github.com/llvm/llvm-project/commit/8f77fa7026de9f544778063fd9fe900d0804b863.d

[Lldb-commits] [clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-04 Thread Aaron Ballman via lldb-commits
AaronBallman wrote: > > Clang bits LGTM > > @AaronBallman Sorry for the back and forth but I had some of the Clang > changes not split into separate commits. Not sure if you looked at the entire > diff or just the Clang commits, but I split out one more commit just now just > in case I looke

[Lldb-commits] [clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-04 Thread Michael Buch via lldb-commits
Michael137 wrote: > Clang bits LGTM Sorry for the back and forth but I had some of the Clang changes not split into separate commits. Not sure if you looked at the entire diff or just the Clang commits, but I split out one more commit just now. https://github.com/llvm/llvm-project/pull/149827

[Lldb-commits] [lldb] cd8f348 - [clang][Attr] Remove 'literal label' form of AsmLabelAttr (#151858)

2025-08-04 Thread via lldb-commits
Author: Michael Buch Date: 2025-08-04T14:34:45+01:00 New Revision: cd8f348c69345755f559049f415ce8b6c0d6edc1 URL: https://github.com/llvm/llvm-project/commit/cd8f348c69345755f559049f415ce8b6c0d6edc1 DIFF: https://github.com/llvm/llvm-project/commit/cd8f348c69345755f559049f415ce8b6c0d6edc1.diff

[Lldb-commits] [clang] [lldb] [clang][Attr] Remove 'literal label' form of AsmLabelAttr (PR #151858)

2025-08-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/151858 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From b8f31ec8f556169a45370938cf28bd8582134a5c Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Sun, 3 Aug 2025 11:38:07 +0100 Subject: [PATCH 1/4] [clang][Attr] Remove 'literal label' form of AsmLabelAttr

[Lldb-commits] [clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-04 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From b8f31ec8f556169a45370938cf28bd8582134a5c Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Sun, 3 Aug 2025 11:38:07 +0100 Subject: [PATCH 1/4] [clang][Attr] Remove 'literal label' form of AsmLabelAttr

[Lldb-commits] [lldb] [llvm] [lldb][windows] use Windows APIs to print to the console (PR #149493)

2025-08-04 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/149493 >From 77bf2b7acb82ea930702c8b0587c019fd48dc0f2 Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Fri, 18 Jul 2025 12:29:31 +0200 Subject: [PATCH 1/8] [windows][lldb] force the console to use a UTF-8 cod

[Lldb-commits] [lldb] 37b6fbc - [lldb][DWARFIndex] Adapt DWARFIndex GetTypes APIs to IterationAction (#151992)

2025-08-04 Thread via lldb-commits
Author: Michael Buch Date: 2025-08-04T17:48:16+01:00 New Revision: 37b6fbc95b7dd623c8cfff04af1f1b787cf3d4cd URL: https://github.com/llvm/llvm-project/commit/37b6fbc95b7dd623c8cfff04af1f1b787cf3d4cd DIFF: https://github.com/llvm/llvm-project/commit/37b6fbc95b7dd623c8cfff04af1f1b787cf3d4cd.diff

  1   2   >