[Lldb-commits] [PATCH] D53368: [Symbol] Search symbols with name and type in a symbol file

aleksandr.urakov added a comment. Ping! Can you take a look, please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53368/new/ https://reviews.llvm.org/D53368 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

echristo added a comment. In D54747#1312161 , @ruiu wrote: > Thank you for the patch. > > What you are doing in this patch is not too complicated and makes sense to > me. That said, if actual size saving is not significant as you said in >

Re: [Lldb-commits] [PATCH] D54692: [Driver] Use libOption with tablegen.

Thanks, Zachary also pinged me on IRC. This was fixed in r347821. > On Nov 28, 2018, at 4:09 PM, Leonard Mosescu via Phabricator > wrote: > > lemo added a comment. > > I noticed a small problem, this change breaks "lldb -c ". The > inline comment explains the root cause. > > Thanks > > >

[Lldb-commits] [PATCH] D55038: [Reproducers] Change how reproducers are initialized.

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, aprantl, sgraenitz, labath. JDevlieghere added a project: LLDB. Herald added subscribers: teemperor, abidh, mgorny. This patch changes the way the reproducer is initialized. Rather than making changes at run time we now

[Lldb-commits] [lldb] r347821 - [driver] Fix --core/-c and add test

Author: jdevlieghere Date: Wed Nov 28 16:22:28 2018 New Revision: 347821 URL: http://llvm.org/viewvc/llvm-project?rev=347821=rev Log: [driver] Fix --core/-c and add test Because the optarg variable was shadowed we didn't notice we weren't extracting the value from the option. This patch fixes

[Lldb-commits] [PATCH] D54692: [Driver] Use libOption with tablegen.

lemo added a comment. I noticed a small problem, this change breaks "lldb -c ". The inline comment explains the root cause. Thanks Comment at: lldb/trunk/tools/driver/Driver.cpp:310 + if (args.hasArg(OPT_core)) { +SBFileSpec file(optarg); +if (file.Exists()) {

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

JDevlieghere added inline comments. Comment at: tools/debugserver/CMakeLists.txt:18 + + option(LLDB_USE_ENTITLEMENTS "When code signing, use entitlements if available" ON) + set(LLDB_CODESIGN_IDENTITY lldb_codesign CACHE STRING sgraenitz wrote: > JDevlieghere

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

sgraenitz added a comment. In-tree builds look good now. I successfully built and tested with these configurations: green dragon: xcrun cmake -GNinja -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=On -DLLVM_ENABLE_MODULES=On ../llvm my default: xcrun cmake -GNinja

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

MaskRay added a comment. If we decide to optimize DWARF garbage collection, something generic will be cool. This generic-abi thread has some discussion about that https://groups.google.com/d/msg/generic-abi/A-1rbP8hFCA/EDA7Sf3KBwAJ (e.g. using COMDAT but it seems challenging and it comes with

[Lldb-commits] [PATCH] D55032: [CMake] Fix standalone build for debugserver on macOS

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. This change looks fine to me. Have you considered creating something like a "debugserverStandalone.cmake" file similar to how LLDB standalone builds work? Might save us from some

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

sgraenitz marked an inline comment as done. sgraenitz added a comment. Thanks for having a look. Comment at: tools/debugserver/CMakeLists.txt:18 + + option(LLDB_USE_ENTITLEMENTS "When code signing, use entitlements if available" ON) + set(LLDB_CODESIGN_IDENTITY

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

ruiu added a comment. Thank you for the patch. What you are doing in this patch is not too complicated and makes sense to me. That said, if actual size saving is not significant as you said in https://github.com/rust-lang/rust/issues/56068#issuecomment-440160568, it may not be worth doing. It

[Lldb-commits] [PATCH] D55032: [CMake] Fix standalone build for debugserver on macOS

sgraenitz created this revision. sgraenitz added reviewers: xiaobai, beanz. Herald added a subscriber: mgorny. Quick-fix to avoid CMake config issue: CMake Error at /path/to/lldb/cmake/modules/AddLLDB.cmake:116 (add_dependencies): Cannot add target-level dependencies to non-existent

[Lldb-commits] [lldb] r347817 - [driver] Some NFC cleanup

Author: jdevlieghere Date: Wed Nov 28 14:39:17 2018 New Revision: 347817 URL: http://llvm.org/viewvc/llvm-project?rev=347817=rev Log: [driver] Some NFC cleanup This patch includes some small things I noticed while refactoring the driver but didn't want to include in that patch. Modified:

[Lldb-commits] [lldb] r347814 - Make standalone build find tabelgen

Author: jdevlieghere Date: Wed Nov 28 14:10:01 2018 New Revision: 347814 URL: http://llvm.org/viewvc/llvm-project?rev=347814=rev Log: Make standalone build find tabelgen The standalone build couldn't find tablegen because we didn't include it. This patch rectifies that. Modified:

[Lldb-commits] [PATCH] D43886: [lldb] Add GetCurrentException APIs to SBThread, add frame recognizer for objc_exception_throw for Obj-C runtimes

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB347813: [lldb] Add GetCurrentException APIs to SBThread, add frame recognizer for… (authored by kuba.brecka, committed by ). Herald added a subscriber: teemperor. Repository: rLLDB LLDB CHANGES

[Lldb-commits] [PATCH] D43886: [lldb] Add GetCurrentException APIs to SBThread, add frame recognizer for objc_exception_throw for Obj-C runtimes

kubamracek added a comment. Landed, thanks for the review! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43886/new/ https://reviews.llvm.org/D43886 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r347813 - [lldb] Add GetCurrentException APIs to SBThread, add frame recognizer for objc_exception_throw for Obj-C runtimes

Author: kuba.brecka Date: Wed Nov 28 14:01:52 2018 New Revision: 347813 URL: http://llvm.org/viewvc/llvm-project?rev=347813=rev Log: [lldb] Add GetCurrentException APIs to SBThread, add frame recognizer for objc_exception_throw for Obj-C runtimes This adds new APIs and a command to deal with

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

JDevlieghere added inline comments. Comment at: tools/debugserver/CMakeLists.txt:18 + + option(LLDB_USE_ENTITLEMENTS "When code signing, use entitlements if available" ON) + set(LLDB_CODESIGN_IDENTITY lldb_codesign CACHE STRING Why do we need to define this

[Lldb-commits] [PATCH] D43886: [lldb] Add GetCurrentException APIs to SBThread, add frame recognizer for objc_exception_throw for Obj-C runtimes

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This isn't an external API, so we can generalize it when we get around to extending the Recognizers to C++ exceptions. This is fine for now. Thanks for doing this! CHANGES SINCE LAST

[Lldb-commits] [PATCH] D43886: [lldb] Add GetCurrentException APIs to SBThread, add frame recognizer for objc_exception_throw for Obj-C runtimes

kubamracek updated this revision to Diff 175752. kubamracek added a comment. Updated patch. I've added a static `AppleObjCRuntime::GetExceptionThrowLocation()`, which returns the location of the exception throw breakpoint for the Obj-C runtime. I tried adding it as virtual method on

Re: [Lldb-commits] [PATCH] D54914: Add a generic build script for building test inferiors

Yea, I don't really want to fix it there though because the problem will just happen again. I think it should be done inside of ToolSubst. On Wed, Nov 28, 2018 at 12:59 PM Stella Stamenova via Phabricator < revi...@reviews.llvm.org> wrote: > stella.stamenova added a comment. > > It works for me

[Lldb-commits] [PATCH] D54914: Add a generic build script for building test inferiors

stella.stamenova added a comment. It works for me when you make the command: command='"%s"' % (sys.executable), I haven't tested it on Linux yet, but the tests work fine on Windows. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54914/new/ https://reviews.llvm.org/D54914

Re: [Lldb-commits] [PATCH] D54914: Add a generic build script for building test inferiors

I can repro this, so I'll work on a fix. On Wed, Nov 28, 2018 at 12:38 PM Stella Stamenova via Phabricator < revi...@reviews.llvm.org> wrote: > stella.stamenova added a comment. > > I ran the tests with this change and there are about a dozen new failures: > > 2018-11-28T20:25:29.2437909Z

[Lldb-commits] [PATCH] D54914: Add a generic build script for building test inferiors

stella.stamenova added a comment. I ran the tests with this change and there are about a dozen new failures: 2018-11-28T20:25:29.2437909Z 2018-11-28T20:25:29.2581909Z FAIL: LLDB :: SymbolFile/NativePDB/function-types-builtins.cpp (16962 of 45532)

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

sgraenitz updated this revision to Diff 175739. sgraenitz added a comment. Move code sign settings to LLDBConfig.cmake CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55013/new/ https://reviews.llvm.org/D55013 Files: cmake/modules/AddLLDB.cmake cmake/modules/LLDBConfig.cmake

[Lldb-commits] [PATCH] D48752: Quiet command regex instructions during batch execution

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Seems like we should just add a "bool interactive" as a second parameter to "IOHandlerActivated". Then it will be easy to find the other places that need to be fixed up.

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

sgraenitz updated this revision to Diff 175736. sgraenitz added a comment. Default identity for code signing must be lldb_codesign. Also remove the comment to deprecate LLDB_CODESIGN_IDENTITY in favor of LLVM_CODESIGNING_IDENTITY. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

sgraenitz updated this revision to Diff 175734. sgraenitz added a comment. Fix target directory for debugserver: it must not be LLVM_TOOLS_BINARY_DIR but LLVM_RUNTIME_OUTPUT_INTDIR. It's a difference in standalone builds of LLDB. LLVM_TOOLS_BINARY_DIR was wrong here as it points to the binary

[Lldb-commits] [lldb] r347796 - [unittests] Fix the File System Test on Windows

Author: stella.stamenova Date: Wed Nov 28 11:34:01 2018 New Revision: 347796 URL: http://llvm.org/viewvc/llvm-project?rev=347796=rev Log: [unittests] Fix the File System Test on Windows Two of the file system tests are failing on Windows - this updates them to expect the correct values after

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

sgraenitz created this revision. Herald added a subscriber: mgorny. The first patch had to be reverted as I missed a few details. This review continues from D54476 and I will add the required fixes. Change log: - Use llvm_codesign to sign debugserver with

[Lldb-commits] [PATCH] D55012: [CMake] Streamline code signing for debugserver #2

sgraenitz updated this revision to Diff 175730. sgraenitz added a comment. Move code sign settings to LLDBConfig.cmake + polishing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55012/new/ https://reviews.llvm.org/D55012 Files: CMakeLists.txt cmake/modules/LLDBConfig.cmake

[Lldb-commits] [PATCH] D55012: [CMake] Streamline code signing for debugserver #2

sgraenitz updated this revision to Diff 175729. sgraenitz added a comment. The default identity for code signing must be lldb_codesign. Also remove the comment to deprecate LLDB_CODESIGN_IDENTITY in favor of LLVM_CODESIGNING_IDENTITY. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D55012: [CMake] Streamline code signing for debugserver #2

sgraenitz updated this revision to Diff 175725. sgraenitz added a comment. Fix target directory for debugserver: it must not be LLVM_TOOLS_BINARY_DIR but LLVM_RUNTIME_OUTPUT_INTDIR. It's a difference in standalone builds of LLDB. LLVM_TOOLS_BINARY_DIR was wrong here as it points to the binary

[Lldb-commits] [PATCH] D55012: [CMake] Streamline code signing for debugserver #2

sgraenitz created this revision. Herald added subscribers: llvm-commits, mgorny. The first patch had to be reverted as I missed a few details. This review continues from https://reviews.llvm.org/D54476 and I will add the required fixes. Change log: - Use llvm_codesign to sign debugserver with

[Lldb-commits] [PATCH] D54751: [LLDB] - Fix setting the breakpoints when -gsplit-dwarf and DWARF 5 were used for building the executable.

clayborg accepted this revision. clayborg added inline comments. This revision is now accepted and ready to land. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:355-356 + if (addr_base == LLDB_INVALID_ADDRESS) +addr_base =

[Lldb-commits] [PATCH] D54914: Add a generic build script for building test inferiors

zturner added a comment. In D54914#1311137 , @labath wrote: > In D54914#1310337 , @zturner wrote: > > > In D54914#1309700 , @labath wrote: > > > > > I didn't look at the

[Lldb-commits] [PATCH] D55002: [NativePDB] Fix ast-reconstruction test on x86

leonid.mashinskiy created this revision. leonid.mashinskiy added reviewers: zturner, stella.stamenova. leonid.mashinskiy added a project: LLDB. Herald added a subscriber: lldb-commits. This patch fixes ast-reconstruction.cpp test on x86 platform. Repository: rLLDB LLDB

[Lldb-commits] [lldb] r347758 - Revert r347673 "Catch up with EvaluateAsInt() clang API change."

Author: hans Date: Wed Nov 28 06:30:18 2018 New Revision: 347758 URL: http://llvm.org/viewvc/llvm-project?rev=347758=rev Log: Revert r347673 "Catch up with EvaluateAsInt() clang API change." r347417 was re-committed in Clang. Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified:

[Lldb-commits] [PATCH] D54914: Add a generic build script for building test inferiors

labath added a comment. In D54914#1309901 , @aprantl wrote: > I would like to ask a general question that I (indirectly) also asked in > D54731 : Why do we want to implement support > for building inferiors in LIT-based

[Lldb-commits] [PATCH] D54914: Add a generic build script for building test inferiors

labath added a comment. In D54914#1310337 , @zturner wrote: > In D54914#1309700 , @labath wrote: > > > I didn't look at the code in detail, as most of it deals with windows > > stuff, and I don't know much about

[Lldb-commits] [PATCH] D54751: [LLDB] - Fix setting the breakpoints when -gsplit-dwarf and DWARF 5 were used for building the executable.

grimar marked an inline comment as done. grimar added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:355-356 + if (addr_base == LLDB_INVALID_ADDRESS) +addr_base = cu_die.GetAttributeValueAsUnsigned(m_dwarf, this, +

[Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

aleksandr.urakov added a comment. Thanks all! In D54942#1310224 , @zturner wrote: > Makes sense. Just curious, is the order file strictly necessary for this > test? `/Gy` is the same as `-ffunction-sections`, so there could be an > argument to be

[Lldb-commits] [PATCH] D53759: [PDB] Support PDB-backed expressions evaluation

aleksandr.urakov marked 2 inline comments as done. aleksandr.urakov added inline comments. Comment at: source/Core/RichManglingContext.cpp:134-135 get(m_cxx_method_parser)->GetBasename(); +if (!m_buffer.data()) + m_buffer = llvm::StringRef("", 0); return;

[Lldb-commits] [PATCH] D53759: [PDB] Support PDB-backed expressions evaluation

aleksandr.urakov updated this revision to Diff 175634. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53759/new/ https://reviews.llvm.org/D53759 Files: lit/SymbolFile/PDB/Inputs/ExpressionsTest.cpp lit/SymbolFile/PDB/Inputs/ExpressionsTest0.script