[Lldb-commits] [PATCH] D59681: Update the lldb driver to support the -O and -S options when passing --repl

nathawes created this revision. nathawes added reviewers: aprantl, jingham. Herald added a subscriber: abidh. Herald added a project: LLDB. At the moment when `--repl` is passed to `lldb` it silently ignores any commands passed via the options below: --one-line-before-file

[Lldb-commits] [lldb] r356725 - [Reproducers] Fix log statements

Author: jdevlieghere Date: Thu Mar 21 16:58:51 2019 New Revision: 356725 URL: http://llvm.org/viewvc/llvm-project?rev=356725=rev Log: [Reproducers] Fix log statements This isn't python where you can omit the index inside `{}`. Modified:

[Lldb-commits] [PATCH] D59651: Move DebugRanges() function from SymbolFileDWARF to DWARFContext

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Be nice to move DWARFContext out of the lldb_private namespace at some point, but I didn't catch this on other patches so this won't hold up this patch. Comment at:

[Lldb-commits] [PATCH] D59667: Regression test to ensure that we handling importing of anonymous enums correctly

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM, just clang format `main.cpp` before committing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59667/new/ https://reviews.llvm.org/D59667

[Lldb-commits] [PATCH] D59667: Regression test to ensure that we handling importing of anonymous enums correctly

shafik created this revision. shafik added reviewers: aprantl, teemperor, jingham. Herald added a reviewer: serge-sans-paille. Herald added a subscriber: jdoerfert. https://reviews.llvm.org/D51633 added error handling in the ASTImporter.cpp which uncovered an underlying bug in which we used the

[Lldb-commits] [PATCH] D59537: Instantiate 'std' templates explicitly in the expression evaluator

teemperor updated this revision to Diff 191770. teemperor added a comment. - Added more tests (contents from debug info for containers, vectors of vectors) - Import -> Import_New - Rebased on top of the updated parent commit, which means the StdModuleHandler is now much simpler. CHANGES SINCE

[Lldb-commits] [PATCH] D59537: Instantiate 'std' templates explicitly in the expression evaluator

teemperor marked 2 inline comments as done. teemperor added inline comments. Comment at: lldb/source/Symbol/StdModuleHandler.cpp:220 +case TemplateArgument::Type: { + QualType our_type = m_importer.Import(arg.getAsType()); +

[Lldb-commits] [lldb] r356711 - Makefile.rules: Normalize use of trailing slashes in path variables.

Author: adrian Date: Thu Mar 21 13:36:23 2019 New Revision: 356711 URL: http://llvm.org/viewvc/llvm-project?rev=356711=rev Log: Makefile.rules: Normalize use of trailing slashes in path variables. Modified: lldb/trunk/packages/Python/lldbsuite/test/make/Makefile.rules Modified:

[Lldb-commits] [PATCH] D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.

teemperor updated this revision to Diff 191765. teemperor retitled this revision from "[ASTImporter] Allow adding a import strategy to the ASTImporter" to "[ASTImporter] Add an ImportInternal method to allow customizing Import behavior.". teemperor edited the summary of this revision. teemperor

[Lldb-commits] [PATCH] D59606: [lldb] Add missing EINTR handling

This revision was automatically updated to reflect the committed changes. Closed by commit rL356703: [lldb] Add missing EINTR handling (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r356703 - [lldb] Add missing EINTR handling

Author: mgorny Date: Thu Mar 21 12:35:55 2019 New Revision: 356703 URL: http://llvm.org/viewvc/llvm-project?rev=356703=rev Log: [lldb] Add missing EINTR handling Differential Revision: https://reviews.llvm.org/D59606 Modified: lldb/trunk/source/Host/common/PseudoTerminal.cpp

[Lldb-commits] [PATCH] D59580: Use compatible print statements for Python2/3

serge-sans-paille added a comment. @davide : is that ok if I add you to a few other python compat related reviews? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59580/new/ https://reviews.llvm.org/D59580 ___

[Lldb-commits] [PATCH] D59580: Use compatible print statements for Python2/3

serge-sans-paille added a comment. validates fine on my side with py3 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59580/new/ https://reviews.llvm.org/D59580 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D59606: [lldb] Add missing EINTR handling

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp:255-258 +llvm::sys::RetryAfterSignal(-1, ::cfsetospeed, +, B115200); +

[Lldb-commits] [PATCH] D59291: [Object] Add basic minidump support

labath added a comment. In D59291#1438053 , @aprantl wrote: > Looks like this uncovered some UB: > > http://lab.llvm.org:8080/green/view/LLDB/job/lldb-sanitized/2050/testReport/junit/lldb-Suite/functionalities_postmortem_minidump-new/TestMiniDumpUUID_py/

[Lldb-commits] [PATCH] D59433: Fix UUID decoding from minidump files.

shafik added a comment. Herald added a subscriber: ormris. It looks like this commit introduced undefined behavior via a misaligned load see this log from lldb sanitized bot on green dragon

[Lldb-commits] [PATCH] D59651: Move DebugRanges() function from SymbolFileDWARF to DWARFContext

zturner created this revision. zturner added reviewers: JDevlieghere, clayborg, labath, aprantl. This should be the last non-dwo dependent piece to get over to `DWARFContext`. After this there will need to be some careful refactoring to get all knowledge of DWO-ness into the `DWARFContext`,

[Lldb-commits] [PATCH] D59611: Move the rest of the section loading over to DWARFContext

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rL356682: Move the rest of the sections over to DWARFContext. (authored by zturner, committed by ). Herald added a

[Lldb-commits] [lldb] r356682 - Move the rest of the sections over to DWARFContext.

Author: zturner Date: Thu Mar 21 09:34:58 2019 New Revision: 356682 URL: http://llvm.org/viewvc/llvm-project?rev=356682=rev Log: Move the rest of the sections over to DWARFContext. This is mostly mechanical, and just moves the remaining non-DWO related sections over to DWARFContext.

[Lldb-commits] [PATCH] D59611: Move the rest of the section loading over to DWARFContext

zturner added a comment. In D59611#1437044 , @clayborg wrote: > Use reference to DWARFContext instead of pointers? Apply to entire patch and > good to go Done. Since you conditionally LGTM'ed it based on that and I made that change I'll go ahead and

Re: [Lldb-commits] [lldb] r356643 - [Reproducers] Properly handle QEnvironment packets

Since we don't execute the binary we don't have to, but I agree it would the right thing to do, as something else could depend on it during replay. I'll address this once I figure out what's causing the flakiness on Linux. On Thu, Mar 21, 2019 at 1:32 AM Pavel Labath wrote: > On 21/03/2019

[Lldb-commits] [PATCH] D59291: [Object] Add basic minidump support

aprantl added a comment. Looks like this uncovered some UB: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-sanitized/2050/testReport/junit/lldb-Suite/functionalities_postmortem_minidump-new/TestMiniDumpUUID_py/ Repository: rL LLVM CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D59580: Use compatible print statements for Python2/3

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. This looks good to me as long as it doesn't break check-lldb (and from I quick look at the patch I doubt it does). Thanks for helping with this! Repository: rLLDB LLDB CHANGES SINCE LAST

[Lldb-commits] [PATCH] D59580: Use compatible print statements for Python2/3

serge-sans-paille added a comment. I didn't run the `check-lldb` target though, I'm doing that right now. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59580/new/ https://reviews.llvm.org/D59580 ___ lldb-commits

[Lldb-commits] [PATCH] D59580: Use compatible print statements for Python2/3

serge-sans-paille added a comment. @davide I first applied 2to3 systematically, then manually edited the diff so that it remains backward compatible with python2. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59580/new/ https://reviews.llvm.org/D59580

[Lldb-commits] [PATCH] D59588: Python 2/3 compat: iteritems vs items

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB356673: Workaround items/iteritems difference between Python2 and Python3 (authored by serge_sans_paille, committed by ). Changed prior to commit:

[Lldb-commits] [PATCH] D59587: Use explicit loop instead of map for Python 2/3 compat

This revision was automatically updated to reflect the committed changes. Closed by commit rL356672: Workaround Pythons map difference between Python2/3 (authored by serge_sans_paille, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D59585: python 2/3 compat: int vs long

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB356671: Portable int/long conversion across Python 2 / Python 3 (authored by serge_sans_paille, committed by ). Changed prior to commit: https://reviews.llvm.org/D59585?vs=191447=191689#toc

[Lldb-commits] [PATCH] D59583: python2/3 compat: exceptions

This revision was automatically updated to reflect the committed changes. Closed by commit rL356670: Portable exception value access across Python 2 / Python 3 (authored by serge_sans_paille, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [PATCH] D59606: [lldb] Add missing EINTR handling

mgorny updated this revision to Diff 191657. mgorny marked an inline comment as done. mgorny added a comment. Applied requested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59606/new/ https://reviews.llvm.org/D59606 Files: lldb/source/Host/common/PseudoTerminal.cpp

[Lldb-commits] [PATCH] D59606: [lldb] Add missing EINTR handling

mgorny marked 3 inline comments as done. mgorny added inline comments. Comment at: lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp:255-258 +llvm::sys::RetryAfterSignal(-1, ::cfsetospeed, +, B115200); +llvm::sys::RetryAfterSignal(-1,

[Lldb-commits] [PATCH] D59606: [lldb] Add missing EINTR handling

mgorny added a comment. Now, the curious thing is that so far I have 2 more test failures with this. I'll investigate closer, maybe it's just flakiness. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59606/new/ https://reviews.llvm.org/D59606

[Lldb-commits] [PATCH] D58972: Introduce the "Formats" module and move LinuxProcMaps parser to it

labath abandoned this revision. labath added a comment. minidump parser will go into llvm, which removes the main incentive for creating this new module. It's possible we may need something like this in the future, but should wait until there is a real use case for it. CHANGES SINCE LAST

[Lldb-commits] [PATCH] D58973: Move the minidump parser into the Formats module

labath abandoned this revision. labath added a comment. minidump parser will go into llvm/Object instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58973/new/ https://reviews.llvm.org/D58973 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D58976: Introduce core2yaml tool

labath abandoned this revision. labath added a comment. instead of a fresh tool, minidump support will be added to obj2yaml. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58976/new/ https://reviews.llvm.org/D58976 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D59634: Add minidump support to obj2yaml

labath created this revision. labath added reviewers: jhenderson, zturner, clayborg. Herald added a subscriber: mgorny. Herald added a project: LLVM. This patch adds the code needed to parse a minidump file into the MinidumpYAML model, and the necessary glue code so that obj2yaml can recognise

[Lldb-commits] [PATCH] D59482: [ObjectYAML] Add basic minidump generation support

jhenderson accepted this revision. jhenderson added a comment. Test updates LGTM. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59482/new/ https://reviews.llvm.org/D59482 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D59482: [ObjectYAML] Add basic minidump generation support

labath updated this revision to Diff 191653. labath added a comment. It occurred to me that the "invalid input" test cases could be easily rewritten in lit, as they don't require parsing of the generated binary (because there isn't one). In this update I just port those tests to lit, which

[Lldb-commits] [PATCH] D59291: [Object] Add basic minidump support

This revision was automatically updated to reflect the committed changes. Closed by commit rL356652: [Object] Add basic minidump support (authored by labath, committed by ). Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59291/new/ https://reviews.llvm.org/D59291

[Lldb-commits] [PATCH] D59606: [lldb] Add missing EINTR handling

labath added inline comments. Comment at: lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp:255-258 +llvm::sys::RetryAfterSignal(-1, ::cfsetospeed, +, B115200); +llvm::sys::RetryAfterSignal(-1, ::cfsetispeed, +, B115200);

[Lldb-commits] [PATCH] D59606: [lldb] Add missing EINTR handling

mgorny added inline comments. Comment at: lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp:255-258 +llvm::sys::RetryAfterSignal(-1, ::cfsetospeed, +, B115200); +llvm::sys::RetryAfterSignal(-1, ::cfsetispeed, +, B115200);

[Lldb-commits] [PATCH] D59606: [lldb] Add missing EINTR handling

mgorny updated this revision to Diff 191644. mgorny marked 5 inline comments as done. mgorny retitled this revision from "[lldb] [WIP/RFC] Add missing retries on EINTR" to "[lldb] Add missing EINTR handling". mgorny edited the summary of this revision. mgorny added a comment. Thanks for the

Re: [Lldb-commits] [lldb] r356643 - [Reproducers] Properly handle QEnvironment packets

On 21/03/2019 05:08, Jonas Devlieghere via lldb-commits wrote: Author: jdevlieghere Date: Wed Mar 20 21:08:31 2019 New Revision: 356643 URL: http://llvm.org/viewvc/llvm-project?rev=356643=rev Log: [Reproducers] Properly handle QEnvironment packets On Linux, a QEnvironment packet is sent for

[Lldb-commits] [PATCH] D59606: [lldb] [WIP/RFC] Add missing retries on EINTR

labath added a comment. I think this is fine, except for the things I pointed out inline. As for `SafelyCloseFileDescriptor` (wow) thing, I think we should use that, given that it's already there. I suggest making a separate patch for that. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

MaskRay added a comment. In D54747#1342666 , @rocallahan wrote: > Here are some results for the rusoto test in > https://github.com/rust-lang/rust/issues/56068#issue-382175735: > > | LLD | Binary size in bytes | > | LLD 6.0.1

[Lldb-commits] [PATCH] D59606: [lldb] [WIP/RFC] Add missing retries on EINTR

labath added inline comments. Comment at: lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp:255-258 +llvm::sys::RetryAfterSignal(-1, ::cfsetospeed, +, B115200); +llvm::sys::RetryAfterSignal(-1, ::cfsetispeed, +, B115200);

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

MaskRay added inline comments. Comment at: lld/ELF/MarkLive.cpp:192 + Sec->Live = true; + if (Sec->kind() != SectionBase::Kind::Regular && + Sec->kind() != SectionBase::Kind::Merge) This check can be changed to `!isa && !isa`. But do you just want to

[Lldb-commits] [PATCH] D59579: Use list comprehension instead of map/filter to prepare Python2/3 compat

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB356647: Use list comprehension instead of map/filter to prepare Python2/3 compat (authored by serge_sans_paille, committed by ). Changed prior to commit:

[Lldb-commits] [PATCH] D59606: [lldb] [WIP/RFC] Add missing retries on EINTR

mgorny updated this revision to Diff 191641. mgorny added a comment. Covered more callsites. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59606/new/ https://reviews.llvm.org/D59606 Files: lldb/source/Host/common/PseudoTerminal.cpp lldb/source/Host/common/Socket.cpp