[Lldb-commits] [PATCH] D69080: eliminate one form of PythonObject::Reset()

lawrence_danna updated this revision to Diff 225350. lawrence_danna added a comment. include move version too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69080/new/ https://reviews.llvm.org/D69080 Files:

[Lldb-commits] [PATCH] D69080: eliminate one form of PythonObject::Reset()

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, clayborg, labath, jingham. Herald added a project: LLDB. I'd like to eliminate all forms of Reset() and all public constructors on these objects, so the only way to make them is with Take<> and Retain<> and the

[Lldb-commits] [PATCH] D68963: delete SWIG typemaps for FILE*

This revision was automatically updated to reflect the committed changes. lawrence_danna marked an inline comment as done. Closed by commit rG0f783599a4c6: delete SWIG typemaps for FILE* (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] r375073 - delete SWIG typemaps for FILE*

Author: lawrence_danna Date: Wed Oct 16 18:35:22 2019 New Revision: 375073 URL: http://llvm.org/viewvc/llvm-project?rev=375073=rev Log: delete SWIG typemaps for FILE* Summary: The SWIG typemaps for FILE* are no longer used, so this patch deletes them. Reviewers: JDevlieghere, jasonmolenda,

[Lldb-commits] [PATCH] D68872: SBCommandReturnObject: change LLDB_RECORD_METHOD(..., FILE *, ...) to use LLDB_RECORD_DUMMY

This revision was automatically updated to reflect the committed changes. Closed by commit rG56ee31964f5a: SBCommandReturnObject: change LLDB_RECORD_METHOD(..., FILE *, ...) to use… (authored by MaskRay). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to

[Lldb-commits] [lldb] r375072 - SBCommandReturnObject: change LLDB_RECORD_METHOD(..., FILE *, ...) to use LLDB_RECORD_DUMMY

Author: maskray Date: Wed Oct 16 18:28:07 2019 New Revision: 375072 URL: http://llvm.org/viewvc/llvm-project?rev=375072=rev Log: SBCommandReturnObject: change LLDB_RECORD_METHOD(..., FILE *, ...) to use LLDB_RECORD_DUMMY POSIX says FILE is a typedef to a structure containing information about a

[Lldb-commits] [lldb] r375068 - [CMake] Make it possible to set the RPATH in add_lldb_exectable.

Author: jdevlieghere Date: Wed Oct 16 17:50:39 2019 New Revision: 375068 URL: http://llvm.org/viewvc/llvm-project?rev=375068=rev Log: [CMake] Make it possible to set the RPATH in add_lldb_exectable. Make it possible to pass a build and install RPATH to add_lldb_executable instead of having to

[Lldb-commits] [lldb] r375064 - [Reproducer] Set the working directory in the VFS

Author: jdevlieghere Date: Wed Oct 16 17:24:37 2019 New Revision: 375064 URL: http://llvm.org/viewvc/llvm-project?rev=375064=rev Log: [Reproducer] Set the working directory in the VFS Now that the VFS knows how to deal with virtual working directories, we can set the current working directory to

[Lldb-commits] [lldb] r375059 - [Reproducer] Capture the debugger's working directory

Author: jdevlieghere Date: Wed Oct 16 17:01:53 2019 New Revision: 375059 URL: http://llvm.org/viewvc/llvm-project?rev=375059=rev Log: [Reproducer] Capture the debugger's working directory This patch extends the reproducer to capture the debugger's current working directory. This information will

[Lldb-commits] [lldb] r375061 - [Reproducer] Support dumping the reproducer CWD

Author: jdevlieghere Date: Wed Oct 16 17:02:00 2019 New Revision: 375061 URL: http://llvm.org/viewvc/llvm-project?rev=375061=rev Log: [Reproducer] Support dumping the reproducer CWD Add support for dumping the current working directory with `reproducer dump -p cwd`. Added:

[Lldb-commits] [lldb] r375062 - Revert "make ConstString allocate memory in non-tiny chunks"

Author: teemperor Date: Wed Oct 16 17:02:32 2019 New Revision: 375062 URL: http://llvm.org/viewvc/llvm-project?rev=375062=rev Log: Revert "make ConstString allocate memory in non-tiny chunks" As discussed in https://reviews.llvm.org/D68549, the actual issue here seems to be that the

[Lldb-commits] [lldb] r375060 - [Reproducer] Add LoadBuffer<> helper (NFC)

Author: jdevlieghere Date: Wed Oct 16 17:01:57 2019 New Revision: 375060 URL: http://llvm.org/viewvc/llvm-project?rev=375060=rev Log: [Reproducer] Add LoadBuffer<> helper (NFC) Introduce a helper method named LoadBuffer in the Loader to abstract reading a reproducer file from disk. Modified:

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

jingham added a comment. As Greg said, iOS (and macOS as well, though less directly) have the notion of bundleID. At present, lldb doesn't directly use/figure out the bundle ID, though it could either from the binary itself or from debugserver, which does have to know that. As far as I know

[Lldb-commits] [PATCH] D68995: clean up the implementation of PythonCallable::GetNumArguments

lawrence_danna updated this revision to Diff 225316. lawrence_danna added a comment. fixup: VAR_KEYWORD Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68995/new/ https://reviews.llvm.org/D68995 Files:

[Lldb-commits] [PATCH] D69014: [LLDB] bugfix: command script add -f doesn't work for some callables

lawrence_danna added a comment. Also, @jingham, only the `#if` branch for python2 has easy access to the `__call__` attribute. We could test for it in python3 but it wouldn't do what you're thinking it would: In [1]: def f(): ...: return 1 ...:

[Lldb-commits] [PATCH] D68995: clean up the implementation of PythonCallable::GetNumArguments

lawrence_danna added a comment. In D68995#1710594 , @labath wrote: > Thanks for jumping onto this. Apart from the inline comments, I have one high > level question: What are the cases that the old method is wrong for? Was it > just builtin functions, or

[Lldb-commits] [PATCH] D68995: clean up the implementation of PythonCallable::GetNumArguments

lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp:58-61 + auto utf8 = str.AsUTF8(); + if (!utf8) +return utf8.takeError(); + return utf8.get(); labath wrote: > Btw, what are the reasons

[Lldb-commits] [PATCH] D69014: [LLDB] bugfix: command script add -f doesn't work for some callables

lawrence_danna updated this revision to Diff 225303. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69014/new/ https://reviews.llvm.org/D69014 Files:

[Lldb-commits] [PATCH] D68995: clean up the implementation of PythonCallable::GetNumArguments

lawrence_danna updated this revision to Diff 225302. lawrence_danna marked 8 inline comments as done. lawrence_danna added a comment. review fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68995/new/ https://reviews.llvm.org/D68995 Files:

[Lldb-commits] [PATCH] D69014: [LLDB] bugfix: command script add -f doesn't work for some callables

lawrence_danna updated this revision to Diff 225296. lawrence_danna marked 3 inline comments as done. lawrence_danna added a comment. review fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69014/new/ https://reviews.llvm.org/D69014 Files:

[Lldb-commits] [PATCH] D69014: [LLDB] bugfix: command script add -f doesn't work for some callables

lawrence_danna added a comment. fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69014/new/ https://reviews.llvm.org/D69014 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D69014: [LLDB] bugfix: command script add -f doesn't work for some callables

lawrence_danna updated this revision to Diff 225297. lawrence_danna added a comment. comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69014/new/ https://reviews.llvm.org/D69014 Files:

[Lldb-commits] [PATCH] D68134: [LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api

This revision was automatically updated to reflect the committed changes. Closed by commit rG13993a6f8681: [LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api. (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D69014: [LLDB] bugfix: command script add -f doesn't work for some callables

lawrence_danna added a comment. In D69014#1711400 , @jingham wrote: > IIUC, the only external change in this patch is that before if you > implemented your Python command using a class with an `__call__` method, it > would have to be the signature that

[Lldb-commits] [lldb] r375034 - [LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api. NFCI.

Author: mstorsjo Date: Wed Oct 16 12:39:56 2019 New Revision: 375034 URL: http://llvm.org/viewvc/llvm-project?rev=375034=rev Log: [LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api. NFCI. Differential Revision: https://reviews.llvm.org/D68134 Modified:

[Lldb-commits] [PATCH] D69031: [LLDB] [test] Use %clang_cl instead of build.py in a few tests

labath added inline comments. Comment at: lldb/test/Shell/SymbolFile/NativePDB/disassembly.cpp:6 +// RUN: %clang_cl --target=x86_64-windows-msvc -Od -Z7 -c /Fo%t.obj -- %s +// RUN: lld-link -debug:full -nodefaultlib -entry:main %t.obj -out:%t.exe -pdb:%t.pdb // RUN: env

[Lldb-commits] [PATCH] D69008: Add arm64_32 support

jasonmolenda closed this revision. jasonmolenda added a comment. committed in r375032 where I accidentally copied in the wrong phabracator URL, so lol. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69008/new/ https://reviews.llvm.org/D69008

[Lldb-commits] [lldb] r375032 - Add arm64_32 support to lldb, an ILP32 codegen

Author: jmolenda Date: Wed Oct 16 12:14:49 2019 New Revision: 375032 URL: http://llvm.org/viewvc/llvm-project?rev=375032=rev Log: Add arm64_32 support to lldb, an ILP32 codegen that runs on arm64 ISA targets, specifically Apple watches. Differential Revision: https://reviews.llvm.org/D68858

[Lldb-commits] [PATCH] D69014: [LLDB] bugfix: command script add -f doesn't work for some callables

lawrence_danna updated this revision to Diff 225284. lawrence_danna added a comment. added tests for __call__ objects, and a fix for python2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69014/new/ https://reviews.llvm.org/D69014 Files:

[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rG48a50ee0344d: [android/process list] support showing process arguments (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68293/new/

[Lldb-commits] [lldb] r375029 - [android/process list] support showing process arguments

Author: wallace Date: Wed Oct 16 11:47:05 2019 New Revision: 375029 URL: http://llvm.org/viewvc/llvm-project?rev=375029=rev Log: [android/process list] support showing process arguments Summary: The qfProcessInfo and qsProcessInfo packets currently don't set the processes' arguments, however

[Lldb-commits] [PATCH] D69031: [LLDB] [test] Use %clang_cl instead of build.py in a few tests

mstorsjo marked an inline comment as done. mstorsjo added inline comments. Comment at: lldb/test/Shell/SymbolFile/NativePDB/disassembly.cpp:6 +// RUN: %clang_cl --target=x86_64-windows-msvc -Od -Z7 -c /Fo%t.obj -- %s +// RUN: lld-link -debug:full -nodefaultlib -entry:main %t.obj

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

wallace marked an inline comment as done. wallace added inline comments. Comment at: lldb/source/Host/linux/Host.cpp:220-222 + if (process_info.GetNameAsStringRef().empty() && + !process_info.GetArg0().empty()) { +process_info.SetBundleID(process_info.GetArg0());

[Lldb-commits] [PATCH] D68961: Add support for DW_AT_export_symbols for anonymous structs

labath added a comment. In D68961#1711407 , @shafik wrote: > In D68961#1709708 , @clayborg wrote: > > > Have many compilers supported DW_AT_export_symbols for a while now? If not, > > are there any serious issues

[Lldb-commits] [PATCH] D69016: [lldb] move more things from python to cmake

This revision was automatically updated to reflect the committed changes. Closed by commit rG1d4a40751ff3: [lldb] move more things from python to cmake (authored by hhb). Changed prior to commit: https://reviews.llvm.org/D69016?vs=225151=225270#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

wallace updated this revision to Diff 225269. wallace added a comment. addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68293/new/ https://reviews.llvm.org/D68293 Files: lldb/docs/lldb-gdb-remote.txt

[Lldb-commits] [PATCH] D69058: [test] Add a .clang-format file for the shell test.

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added subscribers: teemperor, abidh, dexonsmith, mehdi_amini. Herald added a project: LLDB. The API tests have a `.clang-format` file that disables formatting altogether. While this is needed for some tests, it also

[Lldb-commits] [PATCH] D69019: [lldb] move package generation from python to cmake

hhb updated this revision to Diff 225268. hhb added a comment. Format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69019/new/ https://reviews.llvm.org/D69019 Files: lldb/CMakeLists.txt lldb/scripts/Python/createPythonInit.py

[Lldb-commits] [PATCH] D69019: [lldb] move package generation from python to cmake

hhb updated this revision to Diff 225266. hhb added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69019/new/ https://reviews.llvm.org/D69019 Files: lldb/CMakeLists.txt lldb/scripts/Python/createPythonInit.py

[Lldb-commits] [PATCH] D69031: [LLDB] [test] Use %clang_cl instead of build.py in a few tests

stella.stamenova added inline comments. Comment at: lldb/test/Shell/SymbolFile/NativePDB/disassembly.cpp:6 +// RUN: %clang_cl --target=x86_64-windows-msvc -Od -Z7 -c /Fo%t.obj -- %s +// RUN: lld-link -debug:full -nodefaultlib -entry:main %t.obj -out:%t.exe -pdb:%t.pdb // RUN:

[Lldb-commits] [lldb] r375024 - [lldb] move more things from python to cmake

Author: hhb Date: Wed Oct 16 11:00:21 2019 New Revision: 375024 URL: http://llvm.org/viewvc/llvm-project?rev=375024=rev Log: [lldb] move more things from python to cmake Summary: Move the copy of six.py, lldb.py and macosx/heap Reviewers: labath Subscribers: mgorny, lldb-commits Tags: #lldb

[Lldb-commits] [PATCH] D68671: Add the ability to pass extra args to a Python breakpoint command function

jingham marked an inline comment as done. jingham added inline comments. Comment at: lldb/include/lldb/Interpreter/ScriptInterpreter.h:469 + + virtual int GetNumArgumentsForCallable(const char *callable_name) { +return -1; labath wrote: > jingham wrote:

[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

wallace marked an inline comment as done. wallace added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:1941 +process_info.GetArguments().Clear(); +process_info.SetArg0(" "); +break;

[Lldb-commits] [PATCH] D68961: Add support for DW_AT_export_symbols for anonymous structs

shafik added a comment. In D68961#1709708 , @clayborg wrote: > Have many compilers supported DW_AT_export_symbols for a while now? If not, > are there any serious issues introduced here that would change debugger > behavior if this attribute is not

[Lldb-commits] [PATCH] D69014: [LLDB] bugfix: command script add -f doesn't work for some callables

jingham added a comment. IIUC, the only external change in this patch is that before if you implemented your Python command using a class with an `__call__` method, it would have to be the signature that took exe_ctx. Since this is now switching off of the number of arguments (less self) you

[Lldb-commits] [PATCH] D69016: [lldb] move more things from python to cmake

hhb added a comment. In D69016#1710466 , @mgorny wrote: > I'm not sure if I like the usage of `POST_BUILD` stuff (it provides less > control than separate targets) but overall this seems a good change. > Replacing ~250 lines of reinventing the wheel

[Lldb-commits] [PATCH] D68549: make ConstString allocate memory in non-tiny chunks

llunak added a comment. In D68549#1710986 , @teemperor wrote: > We could also just let the allocator take a parameter so that is increases > the growth size to do it every Nth slab (N=1 for us) and set a slightly > larger starting size. Heh, I wasn't

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

grimar added a comment. I've posted a change for yaml2obj/obj2yaml here: D69041 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68943/new/ https://reviews.llvm.org/D68943

[Lldb-commits] [PATCH] D69035: minidump: Refactor memory region computation code

labath planned changes to this revision. labath added a comment. Actually, it looks like the "follow-up" patch will be more complicated than I had hoped for, and so I am starting to wonder whether we shouldn't just have the unwinder check for section permissions himself (which would be a

[Lldb-commits] [PATCH] D69008: Add arm64_32 support

jasonmolenda added a comment. Thanks for looking it over, Pavel. It touches lots of different files, but the changes are so tiny in most cases, I didn't know who to set as a reviewer. ;) Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69008/new/

[Lldb-commits] [PATCH] D68549: make ConstString allocate memory in non-tiny chunks

teemperor added a comment. (Seems like my previous comment was cut off in the middle for some reason?) We could also just let the allocator take a parameter so that is increases the growth size to do it every Nth slab (N=1 for us) and set a slightly larger starting size. By the way, if I look

[Lldb-commits] [PATCH] D69035: minidump: Refactor memory region computation code

labath created this revision. labath added reviewers: clayborg, amccarth. Herald added subscribers: mgrang, mgorny. The goal of this refactor is to enable ProcessMinidump to take into account the loaded modules and their sections when computing the permissions of various ranges of memory, as

[Lldb-commits] [PATCH] D68134: [LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api

mstorsjo requested review of this revision. mstorsjo added a comment. Does anyone want to ack this one after updating it to not need changes to tests (as far as I know), by using new demangler options? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68134/new/

[Lldb-commits] [PATCH] D69031: [LLDB] [test] Use %clang_cl instead of build.py in a few tests

labath added a comment. It would be super-awesome if this worked, as this is exactly how the DWARF moral equivalents of these tests (e.g. test/Shell/SymbolFile/DWARF/debug-types.test) work. Let's see what Stella says about this. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D69031: [LLDB] [test] Use %clang_cl instead of build.py in a few tests

mstorsjo created this revision. mstorsjo added reviewers: labath, stella.stamenova, aleksandr.urakov, amccarth. Herald added subscribers: JDevlieghere, teemperor, abidh, kristof.beyls. Herald added a project: LLDB. This allows explicitly specifying the intended target architecture, for tests

[Lldb-commits] [PATCH] D68963: delete SWIG typemaps for FILE*

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:655 + auto new_file = PythonFile::FromFile(file, mode); + if (!new_file) +

[Lldb-commits] [PATCH] D68657: Update MinidumpYAML to use minidump::Exception for exception stream

JosephTremoulet marked an inline comment as done. JosephTremoulet added inline comments. Comment at: llvm/lib/ObjectYAML/MinidumpYAML.cpp:389 + for (size_t Index = 0; Index < Exception.MaxParameters; ++Index) { +SmallString<16> Name = formatv("Parameter {0}", Index); +

[Lldb-commits] [PATCH] D68549: make ConstString allocate memory in non-tiny chunks

labath added a comment. In D68549#1710744 , @llunak wrote: > Thinking more about this, maybe this is really not the right place and the > change should be done in BumpPtrAllocator? To me it seems rather unreasonable > that it would double the allocation

[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

labath added a comment. Looks pretty good, just two quick comments. Comment at: lldb/packages/Python/lldbsuite/test/commands/platform/process/TestProcessList.py:15-17 +exe_name = "TestProcess" # Must match Makefile + + You don't need this. This was present

[Lldb-commits] [PATCH] D68549: make ConstString allocate memory in non-tiny chunks

llunak added a comment. Thinking more about this, maybe this is really not the right place and the change should be done in BumpPtrAllocator? To me it seems rather unreasonable that it would double the allocation size only after 128 allocations. Surely by the time it has already allocated

[Lldb-commits] [PATCH] D68980: [LLDB] [test] Allow specifying the full arch for msvc/clang-cl in build.py

labath added a comment. Having proper "target" support is one way to go, though I am disappointed to see it go this way, particularly as nobody really knows why invoking clang-cl directly should not work, and so the main motivation seems to be a fear of potentially breaking something, without

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

labath added a comment. Thank you guys for jumping onto this. This will be very useful in lldb. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68943/new/ https://reviews.llvm.org/D68943 ___

[Lldb-commits] [PATCH] D68541: Implement 'up' and 'down' shortcuts in lldb gui

labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/commands/gui/basicdebug/TestGuiBasicDebug.py:31 +# which is not necessarily the order on the screen.) +self.child.timeout = 2 +self.child.send("s") # step

[Lldb-commits] [PATCH] D69016: [lldb] move more things from python to cmake

labath added a reviewer: JDevlieghere. labath accepted this revision. labath added a subscriber: JDevlieghere. labath added a comment. This revision is now accepted and ready to land. In D69016#1710380 , @davide wrote: > What are you trying to accomplish

[Lldb-commits] [PATCH] D69014: [LLDB] bugfix: command script add -f doesn't work for some callables

labath added a comment. The code itself looks fine to me. Jim, is this ok from a scripting/compatibility/whatnot perspective? Comment at: lldb/packages/Python/lldbsuite/test/commands/command/script/TestCommandScript.py:25 +if sys.version_info[:2] >= (3, 3) or

[Lldb-commits] [PATCH] D68995: clean up the implementation of PythonCallable::GetNumArguments

labath added a comment. Thanks for jumping onto this. Apart from the inline comments, I have one high level question: What are the cases that the old method is wrong for? Was it just builtin functions, or are there other cases too? Is it possible to fix it to work for builtings too? (okay,

[Lldb-commits] [PATCH] D68549: make ConstString allocate memory in non-tiny chunks

llunak added a comment. Oh, I somehow completely missed the fact that there are 256 of those :-/. In that case my numbers are way too much. Can you easily benchmark with different numbers? I think something like 131072 for BumpPtrAllocator (to still be large enough for the mmap threshold)

[Lldb-commits] [PATCH] D68980: [LLDB] [test] Allow specifying the full arch for msvc/clang-cl in build.py

mstorsjo updated this revision to Diff 225171. mstorsjo retitled this revision from "[LLDB] [test] Pass --target=-windows-msvc to clang-cl" to "[LLDB] [test] Allow specifying the full arch for msvc/clang-cl in build.py". mstorsjo edited the summary of this revision. mstorsjo added a comment.

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

grimar added a comment. In D68943#1710525 , @MaskRay wrote: > In D68943#1709998 , @grimar wrote: > > > Ok, I was able to debug it finally. > > > > I think we should add a .symtab in a few more cases implicitly. > >

[Lldb-commits] [PATCH] D68549: make ConstString allocate memory in non-tiny chunks

labath added a comment. Yeah, allocating 256MB sounds a bit too much, particularly for lldb-server (ideally, I'd remove ConstString from lldb-server completely, but that's a different story). The reason for 256 string pools was to avoid/reduce locking contention when accessing the pool, but

[Lldb-commits] [PATCH] D68657: Update MinidumpYAML to use minidump::Exception for exception stream

MaskRay added inline comments. Comment at: llvm/lib/ObjectYAML/MinidumpYAML.cpp:389 + for (size_t Index = 0; Index < Exception.MaxParameters; ++Index) { +SmallString<16> Name = formatv("Parameter {0}", Index); +support::ulittle64_t =

[Lldb-commits] [PATCH] D69008: Add arm64_32 support

labath added a comment. (looks good to me) Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69008/new/ https://reviews.llvm.org/D69008 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

labath added a reviewer: jingham. labath added subscribers: danalbert, jingham. labath added a comment. Introducing a "bundle" identifier as a first class concept sounds reasonable to me, particularly if that concept can be applied to more than one platform. But since we're talking about iOS,

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

MaskRay added a comment. In D68943#1709998 , @grimar wrote: > Ok, I was able to debug it finally. > > I think we should add a .symtab in a few more cases implicitly. > For example, when we have a SHT_RELA/SHT_REL section that has an empty Link, > i.e.

[Lldb-commits] [PATCH] D68541: Implement 'up' and 'down' shortcuts in lldb gui

llunak added a comment. In D68541#1710031 , @clayborg wrote: > Looks good! Can you please ACK also the other patches linked above that this one depends on? Or can I take the discussion here as being enough? > With a little work, "gui" mode can really

[Lldb-commits] [PATCH] D68910: python path should be platform-dependent

llunak added a comment. In D68910#1710147 , @hhb wrote: > This is fine for me. Actually it doesn't make any difference for all > platforms I tried... Out of curiosity, is it possible to share the > implementation of get_python_lib() in openSUSE? Thanks.

[Lldb-commits] [PATCH] D69016: [lldb] move more things from python to cmake

mgorny added a comment. I'm not sure if I like the usage of `POST_BUILD` stuff (it provides less control than separate targets) but overall this seems a good change. Replacing ~250 lines of reinventing the wheel with ~20 lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION