[Lldb-commits] [PATCH] D70764: build: reduce CMake handling for zlib

labath added a comment. Please take a look at D70519 for the issues with this approach. Also, while I do agree with you that we should not auto-select dependencies, I think this runs contrary to the llvm philosophy that the default built should "just work" (I

[Lldb-commits] [PATCH] D70745: [LLDB] [PECOFF] Look for the truncated ".eh_fram" section name

labath added a comment. I think you should be able to write a test with a yaml2obj + `lldb-test object-file`. That's how the equivalent elf functionality is tested (see `test/Shell/ObjectFile/ELF/section-types.yaml`). It won't check that the section is actually parsed properly, but I don't

[Lldb-commits] [PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

thakis added a comment. There's still one failing test on Windows after the fix attempt: http://45.33.8.238/win/3052/step_6.txt Please take a look and revert if it's not an easy fix. (And please watch bots after committing stuff.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D70764: build: reduce CMake handling for zlib

compnerd created this revision. compnerd added reviewers: beanz, smeenai. Herald added subscribers: lldb-commits, Sanitizers, hiraditya, mgorny. Herald added projects: clang, Sanitizers, LLDB, LLVM. Rather than handling zlib handling manually, use `find_package` from CMake to find zlib properly.

[Lldb-commits] [PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

MaskRay added a comment. The ugly path separator pattern `{{(/|)}}` appears in 60+ tests. Can we teach clang and other tools to 1. accept both `/` and `\` input 2. but only output `/` on Windows? We can probably remove `llvm::sys::path::Style::{windows,posix,native}` from

[Lldb-commits] [PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

MaskRay added a comment. Does this work on Windows? --- i/clang/test/Preprocessor/file_test.c +++ w/clang/test/Preprocessor/file_test.c @@ -1,8 +1,7 @@ -// XFAIL: system-windows // RUN: %clang -E -ffile-prefix-map=%p=/UNLIKELY_PATH/empty -c -o - %s | FileCheck %s // RUN: %clang -E

[Lldb-commits] [PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

MaskRay updated this revision to Diff 231142. MaskRay added a comment. Minimize diff in Options.td Properly rebase remapDIPath on top of D69213 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49466/new/

[Lldb-commits] [PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

MaskRay updated this revision to Diff 231140. MaskRay added a comment. Add back remapDIPath that was unintentionally deleted by D69213 , caught by a test. Small adjustment of the code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D65410: [PassManager] First Pass implementation at -O1 pass pipeline

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rGfd39b1bb20ce: Revert Revert As a follow-up to my initial mail to llvm-dev heres a first… (authored by echristo). Herald

[Lldb-commits] [PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

MaskRay added a comment. In D49466#1761044 , @thakis wrote: > There's still one failing test on Windows after the fix attempt: > http://45.33.8.238/win/3052/step_6.txt > > Please take a look and revert if it's not an easy fix. (And please watch bots >

[Lldb-commits] [PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

dankm added a comment. In D49466#1760860 , @MaskRay wrote: > Add back remapDIPath that was unintentionally deleted by D69213 > , caught by a test. > > Small adjustment of the code Right. Can't believe I missed that.

[Lldb-commits] [PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

This revision was automatically updated to reflect the committed changes. Closed by commit rG6c92cdff7225: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map (authored by dankm, committed by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

dankm added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49466/new/ https://reviews.llvm.org/D49466 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

MaskRay added a comment. In D49466#1760765 , @dankm wrote: > Ping? The tests need fixing... I can commit it. Now that we've migrated to the llvm monorepo, the git commit message can retain the author info properly... Repository: rG LLVM Github

[Lldb-commits] [PATCH] D70745: [LLDB] [PECOFF] Look for the truncated ".eh_fram" section name

amccarth added a comment. Is `.eh_frame` the only one that matters? Should this be more general and compare `const_sect_name` to the full name and the truncated name for any known section names? If the giant cascade of else-if were factored into a separate function, then a trivial unit test

[Lldb-commits] [PATCH] D70742: [LLDB] [Windows] Avoid using InitializeContext for allocating a CONTEXT. NFC.

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. That's fair. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70742/new/ https://reviews.llvm.org/D70742

[Lldb-commits] [PATCH] D70742: [LLDB] [Windows] Avoid using InitializeContext for allocating a CONTEXT. NFC.

mstorsjo marked an inline comment as done. mstorsjo added inline comments. Comment at: lldb/source/Plugins/Process/Windows/Common/RegisterContextWindows.cpp:158 + memset(_context, 0, sizeof(m_context)); + m_context.ContextFlags = kWinContextFlags; if (::SuspendThread(

[Lldb-commits] [PATCH] D70742: [LLDB] [Windows] Avoid using InitializeContext for allocating a CONTEXT. NFC.

amccarth added a comment. I'm good with the change, but have a couple small requests. I hope to hear from others, too, as this area is outside my wheelhouse. Comment at: lldb/source/Plugins/Process/Windows/Common/RegisterContextWindows.cpp:158 + memset(_context, 0,

[Lldb-commits] [PATCH] D70745: [LLDB] [PECOFF] Look for the truncated ".eh_fram" section name

mstorsjo created this revision. mstorsjo added reviewers: labath, amccarth. Herald added a project: LLDB. COFF section names can either be stored truncated to 8 chars, in the section header, or as a longer section name, stored separately in the string table. libunwind locates the .eh_frame

[Lldb-commits] [PATCH] D70742: [LLDB] [Windows] Avoid using InitializeContext for allocating a CONTEXT. NFC.

mstorsjo created this revision. mstorsjo added reviewers: labath, amccarth, asmith, aleksandr.urakov. Herald added a project: LLDB. InitializeContext is useful for allocating a CONTEXT struct in an unaligned byte buffer. In this case, we already have a CONTEXT we want to initialize, and we only

[Lldb-commits] [PATCH] D70647: RFC 3/3: Remove DWARFDIE dependency from functions moved by D70646

jankratochvil planned changes to this revision. jankratochvil marked 2 inline comments as done. jankratochvil added inline comments. Comment at: lldb/include/lldb/Symbol/TypeSystem.h:108-110 + virtual DWARFASTParser *GetDWARFParser(SymbolFileDWARF ) { +return nullptr; + }

[Lldb-commits] [PATCH] D70647: RFC 3/3: Remove DWARFDIE dependency from functions moved by D70646

jankratochvil updated this revision to Diff 231124. jankratochvil added a comment. Remove that dodgy new parameter `SymbolFileDWARF `. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70647/new/ https://reviews.llvm.org/D70647 Files:

[Lldb-commits] [PATCH] D70722: [lldb/IRExecutionUnit] Stop searching based on demangled names

labath created this revision. labath added reviewers: teemperor, JDevlieghere. Herald added a project: LLDB. labath added a parent revision: D70721: [lldb/cpluspluslanguage] Add constructor substitutor. This was causing problems on linux, where we'd end up calling the deleting destructor instead

[Lldb-commits] [PATCH] D70721: [lldb/cpluspluslanguage] Add constructor substitutor

labath created this revision. labath added reviewers: teemperor, JDevlieghere. Herald added a project: LLDB. This patch adds code which will substitute references to the full object constructors/destructors with their base object versions. Like all substitutions in this category, this operation

[Lldb-commits] [lldb] 5871cba - [lldb] Avoid snprintf in PlatformRemoteDarwinDevice

Author: Pavel Labath Date: 2019-11-26T15:16:26+01:00 New Revision: 5871cba86172c5bd947952a9441acf80332455ea URL: https://github.com/llvm/llvm-project/commit/5871cba86172c5bd947952a9441acf80332455ea DIFF: https://github.com/llvm/llvm-project/commit/5871cba86172c5bd947952a9441acf80332455ea.diff

[Lldb-commits] [lldb] 16144d2 - [lldb][NFC] Modernize string handling in DWARFASTParserClang::ParseTypeModifier

Author: Raphael Isemann Date: 2019-11-26T15:04:54+01:00 New Revision: 16144d2b21d90a0515be2fc9158cbaf828abd980 URL: https://github.com/llvm/llvm-project/commit/16144d2b21d90a0515be2fc9158cbaf828abd980 DIFF:

[Lldb-commits] [lldb] 290e43d - [lldb] Use llvm::format in AppleObjCRuntimeV2.cpp

Author: Pavel Labath Date: 2019-11-26T15:04:13+01:00 New Revision: 290e43ddb660db2e9b294e1e963222c08965d211 URL: https://github.com/llvm/llvm-project/commit/290e43ddb660db2e9b294e1e963222c08965d211 DIFF: https://github.com/llvm/llvm-project/commit/290e43ddb660db2e9b294e1e963222c08965d211.diff

[Lldb-commits] [lldb] 12284e5 - [lldb] fix a -Wcast-qual warning

Author: Pavel Labath Date: 2019-11-26T14:49:16+01:00 New Revision: 12284e54b483c2541eb09cd7c575f438970b66c1 URL: https://github.com/llvm/llvm-project/commit/12284e54b483c2541eb09cd7c575f438970b66c1 DIFF: https://github.com/llvm/llvm-project/commit/12284e54b483c2541eb09cd7c575f438970b66c1.diff

[Lldb-commits] [lldb] 6612fab - [lldb] remove a superfluous semicolon

Author: Pavel Labath Date: 2019-11-26T14:49:16+01:00 New Revision: 6612fabc47f16d265d169b5b73dc8070dde436a8 URL: https://github.com/llvm/llvm-project/commit/6612fabc47f16d265d169b5b73dc8070dde436a8 DIFF: https://github.com/llvm/llvm-project/commit/6612fabc47f16d265d169b5b73dc8070dde436a8.diff

[Lldb-commits] [PATCH] D70241: [lldb] remove unsigned Stream::operator<< overloads

This revision was automatically updated to reflect the committed changes. Closed by commit rG957d9a0335b8: [lldb] remove unsigned Stream::operator overloads (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70241/new/

[Lldb-commits] [lldb] 957d9a0 - [lldb] remove unsigned Stream::operator<< overloads

Author: Pavel Labath Date: 2019-11-26T14:24:28+01:00 New Revision: 957d9a0335b8199b01caec56574e72154c3a1226 URL: https://github.com/llvm/llvm-project/commit/957d9a0335b8199b01caec56574e72154c3a1226 DIFF: https://github.com/llvm/llvm-project/commit/957d9a0335b8199b01caec56574e72154c3a1226.diff

[Lldb-commits] [lldb] 9b06897 - [lldb/symbolvendorelf] Copy more sections from separate debug files

Author: Pavel Labath Date: 2019-11-26T14:19:46+01:00 New Revision: 9b06897009dc32313354559c969d6cf0a564ec06 URL: https://github.com/llvm/llvm-project/commit/9b06897009dc32313354559c969d6cf0a564ec06 DIFF: https://github.com/llvm/llvm-project/commit/9b06897009dc32313354559c969d6cf0a564ec06.diff

[Lldb-commits] [lldb] cdfecb8 - [lldb][NFC] Remove no longer unused variable in DWARFASTParserClang::ParseTypeFromDWARF

Author: Raphael Isemann Date: 2019-11-26T14:17:06+01:00 New Revision: cdfecb82ee27fabf927102a356acd298ddca8703 URL: https://github.com/llvm/llvm-project/commit/cdfecb82ee27fabf927102a356acd298ddca8703 DIFF:

[Lldb-commits] [lldb] 0181338 - [lldb][NFC] Simplify structure parsing code in DWARFASTParserClang::ParseTypeFromDWARF

Author: Raphael Isemann Date: 2019-11-26T14:01:12+01:00 New Revision: 0181338ddae26230d4067fdc00c2f7218f1d64d7 URL: https://github.com/llvm/llvm-project/commit/0181338ddae26230d4067fdc00c2f7218f1d64d7 DIFF:

[Lldb-commits] [lldb] 4023bd0 - [lldb] Add boilerplate to recognize the .debug_rnglists.dwo section

Author: Pavel Labath Date: 2019-11-26T13:58:26+01:00 New Revision: 4023bd05fcb4f75c6a11d661f407f8e0896176e2 URL: https://github.com/llvm/llvm-project/commit/4023bd05fcb4f75c6a11d661f407f8e0896176e2 DIFF: https://github.com/llvm/llvm-project/commit/4023bd05fcb4f75c6a11d661f407f8e0896176e2.diff

[Lldb-commits] [lldb] 30fc94b - [lldb][NFC] Extract type modifier parsing from DWARFASTParserClang::ParseTypeFromDWARF

Author: Raphael Isemann Date: 2019-11-26T13:53:06+01:00 New Revision: 30fc94be237f26d3127d8bbc872d9e3b82f03590 URL: https://github.com/llvm/llvm-project/commit/30fc94be237f26d3127d8bbc872d9e3b82f03590 DIFF:

[Lldb-commits] [PATCH] D70532: [lldb] Improve/fix base address selection in location lists

labath updated this revision to Diff 231041. labath added a comment. Rename to {cu,func}_{file,load}_addr as appropriate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70532/new/ https://reviews.llvm.org/D70532 Files:

[Lldb-commits] [PATCH] D70532: [lldb] Improve/fix base address selection in location lists

labath marked 4 inline comments as done. labath added inline comments. Comment at: lldb/include/lldb/Expression/DWARFExpression.h:88-89 /// - /// \param[in] process - /// The process to use when resolving the load address + /// \param[in] load_function_start + ///

[Lldb-commits] [lldb] 8f2b57d - [lldb][NFC] Extract enum parsing from DWARFASTParserClang::ParseTypeFromDWARF

Author: Raphael Isemann Date: 2019-11-26T12:30:06+01:00 New Revision: 8f2b57d257e87b0244f9883cd8075898005ba757 URL: https://github.com/llvm/llvm-project/commit/8f2b57d257e87b0244f9883cd8075898005ba757 DIFF:

[Lldb-commits] [lldb] 9493965 - [lldb][NFCI] Extract subroutine parsing from DWARFASTParserClang::ParseTypeFromDWARF

Author: Raphael Isemann Date: 2019-11-26T12:14:40+01:00 New Revision: 94939650b632cd44e518a9adeb16ab829375 URL: https://github.com/llvm/llvm-project/commit/94939650b632cd44e518a9adeb16ab829375 DIFF:

[Lldb-commits] [lldb] e8013ef - [lldb][NFC] Extract array type parsing from DWARFASTParserClang::ParseTypeFromDWARF

Author: Raphael Isemann Date: 2019-11-26T11:46:25+01:00 New Revision: e8013ef53ac0cd82f9c921abd0b2fa1aa8b2f20c URL: https://github.com/llvm/llvm-project/commit/e8013ef53ac0cd82f9c921abd0b2fa1aa8b2f20c DIFF:

[Lldb-commits] [lldb] 7047a3a - [lldb][NFC] Extract pointer to member type parsing from DWARFASTParserClang::ParseTypeFromDWARF

Author: Raphael Isemann Date: 2019-11-26T11:07:59+01:00 New Revision: 7047a3a729c6b2779b512269ff3eba88d8976d63 URL: https://github.com/llvm/llvm-project/commit/7047a3a729c6b2779b512269ff3eba88d8976d63 DIFF:

[Lldb-commits] [lldb] cfd9d39 - [lldb][NFC] NULL -> nullptr in DWARFASTParserClang::UpdateSymbolContextScopeForType

Author: Raphael Isemann Date: 2019-11-26T10:35:30+01:00 New Revision: cfd9d395674030d549de286d26c0f52020de26e6 URL: https://github.com/llvm/llvm-project/commit/cfd9d395674030d549de286d26c0f52020de26e6 DIFF:

[Lldb-commits] [PATCH] D70644: [DebugInfo] Support for DW_OP_implicit_pointer (llvm.dbg_derefval)

alok created this revision. alok added reviewers: aprantl, probinson, dblaikie, jmorse, jini.susan.george, SouraVX, awpandey. alok added projects: LLVM, debug-info. Herald added a reviewer: bollu. Herald added subscribers: llvm-commits, lldb-commits, jdoerfert, asbirlea, george.burgess.iv,