[Lldb-commits] [PATCH] D72107: [lldb/CMake] Autodetect Python dependency

mgorny added inline comments. Comment at: lldb/cmake/modules/FindPythonInterpAndLibs.cmake:2 +#.rst: +# FindPythonInterpndLibs +# --- Typo. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72107/new/

[Lldb-commits] [lldb] 4117c8c - Revert "[lldb/Command] Add --force option for `watchpoint delete` command"

Author: Med Ismail Bennani Date: 2020-01-03T02:14:45+01:00 New Revision: 4117c8c0194cdf59e229f6826e0908eb3f2bcfc6 URL: https://github.com/llvm/llvm-project/commit/4117c8c0194cdf59e229f6826e0908eb3f2bcfc6 DIFF:

[Lldb-commits] [lldb] d265c8b - [lldb/Python] Remove unused imports (NFC)

Author: Jonas Devlieghere Date: 2020-01-02T16:55:09-08:00 New Revision: d265c8bf0d1e6eed3c97dfb96f98712e5adc8bf7 URL: https://github.com/llvm/llvm-project/commit/d265c8bf0d1e6eed3c97dfb96f98712e5adc8bf7 DIFF:

[Lldb-commits] [lldb] 8580397 - [lldb/Python] Remove unused support file (NFC)

Author: Jonas Devlieghere Date: 2020-01-02T16:55:09-08:00 New Revision: 8580397f2e7d389940fbdd5575f26271df743aee URL: https://github.com/llvm/llvm-project/commit/8580397f2e7d389940fbdd5575f26271df743aee DIFF:

[Lldb-commits] [lldb] 3620e5f - [lldb/Command] Add --force option for `watchpoint delete` command

Author: Med Ismail Bennani Date: 2020-01-03T01:51:22+01:00 New Revision: 3620e5f28a4d2800fb6c325ec24b3d660e48b9ba URL: https://github.com/llvm/llvm-project/commit/3620e5f28a4d2800fb6c325ec24b3d660e48b9ba DIFF:

Re: [Lldb-commits] [lldb] 8612e92 - [lldb][NFC] Remove GetASTContext call in ClangDeclVendor

To further clarify all the member functions of CompilerDecl e.g.: GetMangledName(…) GetDeclContext(…) End up passing m_opaque_decl as an argument to a member function of m_type_system and in these member functions they unconditionally cast the argument to Decl* so why not make m_opaque_decl a

Re: [Lldb-commits] [lldb] 8612e92 - [lldb][NFC] Remove GetASTContext call in ClangDeclVendor

Apologies, m_opaque_decl member of CompilerDecl and operator < in CompilerDecl.h > On Jan 2, 2020, at 3:54 PM, Raphael “Teemperor” Isemann > wrote: > > Not sure if I can follow. What variable should just be a Decl* and what > operator > (Also yeah that reinterpret_cast could also be a

Re: [Lldb-commits] [lldb] 8612e92 - [lldb][NFC] Remove GetASTContext call in ClangDeclVendor

Not sure if I can follow. What variable should just be a Decl* and what operator On Jan 3, 2020, at 12:38 AM, Shafik Yaghmour wrote: > > I am not crazy about the reinterpret_cast although if we look inside > CompilerDecl impl we can see that basically it is always assuming it is a > Decl* and

Re: [Lldb-commits] [lldb] 8612e92 - [lldb][NFC] Remove GetASTContext call in ClangDeclVendor

I am not crazy about the reinterpret_cast although if we look inside CompilerDecl impl we can see that basically it is always assuming it is a Decl* and just C-style casts it as such. So why not just make it a Decl* Also operator<(…) is super sketchy doing a < on void* > On Dec 28, 2019, at

[Lldb-commits] [PATCH] D72107: [lldb/CMake] Autodetect Python dependency

JDevlieghere added a comment. In D72107#1802048 , @xiaobai wrote: > In D72107#1802029 , @JDevlieghere > wrote: > > > Do you mean forcing `LLDB_ENABLE_PYTHON` to on so that it fails in case the > > logic changes

[Lldb-commits] [PATCH] D70764: build: reduce CMake handling for zlib

compnerd closed this revision. compnerd added a comment. GIT 68a235d07f9 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70764/new/ https://reviews.llvm.org/D70764

[Lldb-commits] [PATCH] D71857: [NFC] Fixes -Wrange-loop-analysis warnings

Mordante added a comment. In D71857#1800663 , @MaskRay wrote: > However, I am afraid I don't like some of the fixes here. You can replace > `const auto` with `const auto &` and call that a fix... IMHO if the type is > not obvious, `const ConcreteType &`

[Lldb-commits] [PATCH] D70644: [DebugInfo] Support for DW_OP_implicit_pointer (llvm.dbg_derefval)

alok updated this revision to Diff 235919. alok added a comment. Rebased and updated. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70644/new/ https://reviews.llvm.org/D70644 Files: lldb/source/Expression/IRInterpreter.cpp llvm/docs/SourceLevelDebugging.rst

[Lldb-commits] [PATCH] D71857: [NFC] Fixes -Wrange-loop-analysis warnings

MaskRay added a comment. I really like the new feature. Thanks for making the efforts! However, I am afraid I don't like some of the fixes here. You can replace `const auto` with `const auto &` and call that a fix... IMHO if the type is not obvious, `const ConcreteType &` will be better. In

[Lldb-commits] [PATCH] D70644: [DebugInfo] Support for DW_OP_implicit_pointer (llvm.dbg_derefval)

alok updated this revision to Diff 235772. alok added a comment. Update to re-base and minor correction. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70644/new/ https://reviews.llvm.org/D70644 Files: lldb/source/Expression/IRInterpreter.cpp llvm/docs/SourceLevelDebugging.rst

[Lldb-commits] [PATCH] D71857: [NFC] Fixes -Wrange-loop-analysis warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rG8dc7b982b455: [NFC] Fixes -Wrange-loop-analysis warnings (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71857/new/

Re: [Lldb-commits] [lldb] fe8e25a - [lldb][NFC] Create type-safe function for creating a CompilerType from a QualType

Somehow your mail is missing examples after the ‘… like:’ but the method is named similar to the GetType* methods directly below it. Don’t really have an opinion about whether this should be GetType* or GetCompilerType* (though I wouldn’t add the ‘As’ to it though as that’s usually used for

[Lldb-commits] [PATCH] D72107: [lldb/CMake] Autodetect Python dependency

xiaobai added a comment. In D72107#1802029 , @JDevlieghere wrote: > Do you mean forcing `LLDB_ENABLE_PYTHON` to on so that it fails in case the > logic changes and Python isn't found? Yes, something like that. It looks like the previous expected

Re: [Lldb-commits] [lldb] fe8e25a - [lldb][NFC] Create type-safe function for creating a CompilerType from a QualType

Instead of GetType(...) I think GetCompilerType(…) is better or maybe even GetAsCompilerType(…). It adds a bit more context, we have so many types. It also feels a bit more consistent with methods like: > On Jan 2, 2020, at 2:55 AM, Raphael Isemann via lldb-commits > wrote: > > > Author:

[Lldb-commits] [PATCH] D72107: [lldb/CMake] Autodetect Python dependency

JDevlieghere added a comment. In D72107#1802001 , @xiaobai wrote: > It's nice to consolidate the logic into one place. I think you will probably > need to make an appropriate change on the buildbot side as well (if you > haven't done that already). Do

[Lldb-commits] [PATCH] D72107: [lldb/CMake] Autodetect Python dependency

xiaobai added a comment. It's nice to consolidate the logic into one place. I think you will probably need to make an appropriate change on the buildbot side as well (if you haven't done that already). Where is `FindPythonInterpAndLibs` being included? Repository: rLLDB LLDB CHANGES SINCE

[Lldb-commits] [PATCH] D72107: [lldb/CMake] Autodetect Python dependency

JDevlieghere created this revision. JDevlieghere added reviewers: labath, compnerd, xiaobai. Herald added a subscriber: mgorny. Herald added a project: LLDB. Python was the last remaining "optional" dependency for LLDB. This moves the code to find Python into `FindPythonInterpAndLibs` using the

[Lldb-commits] [lldb] f83801f - [lldb/CMake] Print whether an optional dependency was enabled.

Author: Jonas Devlieghere Date: 2020-01-02T13:40:01-08:00 New Revision: f83801fb2a4064d666cf8c17d716376a99e4a555 URL: https://github.com/llvm/llvm-project/commit/f83801fb2a4064d666cf8c17d716376a99e4a555 DIFF:

[Lldb-commits] [lldb] f38234e - [lldb/CMake] Fix variable naming in FindLibEdit

Author: Jonas Devlieghere Date: 2020-01-02T13:39:57-08:00 New Revision: f38234ed8b579230a3742317ffd5fb95514d9638 URL: https://github.com/llvm/llvm-project/commit/f38234ed8b579230a3742317ffd5fb95514d9638 DIFF:

[Lldb-commits] [PATCH] D71909: [lldb] Fix crash in AccessDeclContextSanity when copying FunctionTemplateDecl inside a record.

shafik added inline comments. Comment at: lldb/source/Symbol/ClangASTContext.cpp:1347 + if (decl_ctx->isRecord()) +func_tmpl_decl->setAccess(clang::AccessSpecifier::AS_public); Where is the method being added and why are we not setting the access there?

[Lldb-commits] [PATCH] D72086: [lldb] Fix that SBThread.GetStopDescription is returning strings with uninitialized memory at the end.

shafik added inline comments. Comment at: lldb/source/API/SBThread.cpp:337 + } else { // NULL dst passed in, return the length needed to contain the The `else` branch feels inconsistent with the change above. Especially the `+

[Lldb-commits] [lldb] 3ddfb04 - [lldb/CMake] Use PYTHON_LIBRARIES instead of PYTHON_LIBRARY

Author: Jonas Devlieghere Date: 2020-01-02T13:01:17-08:00 New Revision: 3ddfb04f41ac60529316f64ae5ab1a8ff1cce6e2 URL: https://github.com/llvm/llvm-project/commit/3ddfb04f41ac60529316f64ae5ab1a8ff1cce6e2 DIFF:

[Lldb-commits] [lldb] abb0075 - build: reduce CMake handling for zlib

Author: Saleem Abdulrasool Date: 2020-01-02T11:19:12-08:00 New Revision: abb00753069554c538f3d850897373d093389945 URL: https://github.com/llvm/llvm-project/commit/abb00753069554c538f3d850897373d093389945 DIFF:

[Lldb-commits] [PATCH] D72096: [lldb/Command] Add --force option for `watchpoint delete` command

friss added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_commands/TestWatchpointCommands.py:162-179 +self.build(dictionary=self.d) +self.setTearDownCleanup(dictionary=self.d) + +exe =

[Lldb-commits] [PATCH] D72096: [lldb/Command] Add --force option for `watchpoint delete` command

JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with the inline comment(s) addressed. Comment at: lldb/source/Commands/CommandObjectWatchpoint.cpp:463 + + return error; +}

[Lldb-commits] [PATCH] D72096: [lldb/Command] Add --force option for `watchpoint delete` command

mib created this revision. mib added reviewers: LLDB, teemperor. mib added a project: LLDB. Herald added a subscriber: lldb-commits. [lldb/Command] Add --force option for `watchpoint delete` command Currently, there is no option to delete all the watchpoint without LLDB asking for a

[Lldb-commits] [PATCH] D71906: [lldb][tests] Make it possible to expect failure for a whole category

JDevlieghere added a comment. If I understand correctly this is the equivalent of `skip-category` but you want to XFAIL the tests instead of skip them? Seems reasonable to me :-) Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71906/new/

[Lldb-commits] [PATCH] D72086: [lldb] Fix that SBThread.GetStopDescription is returning strings with uninitialized memory at the end.

teemperor created this revision. teemperor added a reviewer: labath. Herald added subscribers: lldb-commits, JDevlieghere, abidh. Herald added a project: LLDB. `SBThread.GetStopDescription` is a curious API as it takes a buffer length as a parameter that specifies how many bytes the buffer we

[Lldb-commits] [PATCH] D71909: [lldb] Fix crash in AccessDeclContextSanity when copying FunctionTemplateDecl inside a record.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ead00872929: [lldb] Fix crash in AccessDeclContextSanity when copying FunctionTemplateDecl… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 7ead008 - [lldb] Fix crash in AccessDeclContextSanity when copying FunctionTemplateDecl inside a record.

Author: Raphael Isemann Date: 2020-01-02T14:47:04+01:00 New Revision: 7ead00872929a994ac40fc2c99fce15968e2c5a6 URL: https://github.com/llvm/llvm-project/commit/7ead00872929a994ac40fc2c99fce15968e2c5a6 DIFF:

[Lldb-commits] [PATCH] D71909: [lldb] Fix crash in AccessDeclContextSanity when copying FunctionTemplateDecl inside a record.

teemperor added a comment. I'll land this now as its a pretty straightforward fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71909/new/ https://reviews.llvm.org/D71909 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D71906: [lldb][tests] Make it possible to expect failure for a whole category

teemperor added a comment. This LGTM but I'm not the right person to sign this off. I guess Pavel and Jonas know this code better. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71906/new/ https://reviews.llvm.org/D71906

[Lldb-commits] [lldb] a95f4c8 - [lldb][NFC] Remove unused variable in DWARFASTParserClang::ParseSingleMember

Author: Raphael Isemann Date: 2020-01-02T11:57:00+01:00 New Revision: a95f4c87842d76a9fce146b2f25e6c8079f6bbdc URL: https://github.com/llvm/llvm-project/commit/a95f4c87842d76a9fce146b2f25e6c8079f6bbdc DIFF:

[Lldb-commits] [lldb] fe8e25a - [lldb][NFC] Create type-safe function for creating a CompilerType from a QualType

Author: Raphael Isemann Date: 2020-01-02T11:54:45+01:00 New Revision: fe8e25a48a2a0f8f508499ba950181dba3d600b0 URL: https://github.com/llvm/llvm-project/commit/fe8e25a48a2a0f8f508499ba950181dba3d600b0 DIFF: