[Lldb-commits] [PATCH] D76736: [LLDB] Fix parsing of IPv6 host:port inside brackets

emrekultursay updated this revision to Diff 252499. emrekultursay edited the summary of this revision. emrekultursay added a comment. Added unit tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76736/new/ https://reviews.llvm.org/D76736 Files: lldb/source/Utility/UriParser.cpp

[Lldb-commits] [PATCH] D76736: [LLDB] Fix parsing of IPv6 host:port inside brackets

shafik added a reviewer: labath. shafik added a comment. We need tests it looks like `UriParserTest.cpp` is the right place. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76736/new/ https://reviews.llvm.org/D76736

Re: [Lldb-commits] [lldb] b4a6e63 - [lldb/Target] Rework the way the inferior environment is created

Here’s the bot log: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/15055/steps/test/logs/stdio > On Mar 24, 2020, at 5:10 PM, Adrian McCarthy wrote: > > Oh, and in case I wasn't clear: I re-enabled the test TestSettings.py > locally. > > On Tue, Mar 24, 2020 at 5:04 PM

Re: [Lldb-commits] [lldb] b4a6e63 - [lldb/Target] Rework the way the inferior environment is created

Oh, and in case I wasn't clear: I re-enabled the test TestSettings.py locally. On Tue, Mar 24, 2020 at 5:04 PM Adrian McCarthy wrote: > I took a stab at this, but I'm not seeing any new test failures. Can you > point me to the specific test and provide a log showing the failures? > > I've

Re: [Lldb-commits] [lldb] b4a6e63 - [lldb/Target] Rework the way the inferior environment is created

I took a stab at this, but I'm not seeing any new test failures. Can you point me to the specific test and provide a log showing the failures? I've been using `ninja check-lldb`, which runs (almost everything) and none of the failures I'm seeing are related to inherit-env. I assume the problem

[Lldb-commits] [PATCH] D76736: [LLDB] Fix parsing of IPv6 host:port inside brackets

emrekultursay created this revision. emrekultursay added a reviewer: LLDB. Herald added a project: LLDB. When using IPv6 host:port pairs, typically the host is put inside brackets, such as [2601:1234:...:0213]:, and the UriParser can handle this format. However, the Android infrastructure in

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

jankratochvil added inline comments. Comment at: lldb/source/Core/SourceManager.cpp:415 target->GetImages().ResolveSymbolContextForFilePath( file_spec.GetFilename().AsCString(), 0, check_inlines,

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

jankratochvil requested changes to this revision. jankratochvil added inline comments. This revision now requires changes to proceed. Comment at: lldb/cmake/modules/FindDebuginfod.cmake:59 +endif() \ No newline at end of file "No newline at end of file", this

[Lldb-commits] [PATCH] D76730: [RNBRemote/arm64] Remove a couple of unused functions

davide created this revision. davide added reviewers: jasonmolenda, LLDB. Herald added a subscriber: kristof.beyls. Jason, before submitting this I wanted to run it past you. https://reviews.llvm.org/D76730 Files: lldb/tools/debugserver/source/RNBRemote.cpp Index:

[Lldb-commits] [PATCH] D76729: Convert for loops to entry-based iteration

shivammittal99 updated this revision to Diff 252426. shivammittal99 added a comment. Run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76729/new/ https://reviews.llvm.org/D76729 Files: lldb/source/Commands/CommandObjectSettings.cpp

[Lldb-commits] [PATCH] D76729: Convert for loops to entry-based iteration

shivammittal99 created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Convert index-based loops marked TODO in CommandObjectSettings and CommandObjectTarget to entry-based. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76729 Files:

[Lldb-commits] [PATCH] D74636: [lldb-vscode] Add inheritEnvironment option

wallace abandoned this revision. wallace added a comment. With https://reviews.llvm.org/D76470, targets created by lldb-vscode by default are inheriting the debugger's environment. I don't need this change anymore. We can work on providing a flag that disables that default behavior, but that

[Lldb-commits] [lldb] 3e11d84 - [Darwin] Add another hint to find the kernel. NFC.

Author: Davide Italiano Date: 2020-03-24T13:04:36-07:00 New Revision: 3e11d84d9f77736af22f52753593c8214d76875a URL: https://github.com/llvm/llvm-project/commit/3e11d84d9f77736af22f52753593c8214d76875a DIFF:

[Lldb-commits] [PATCH] D76698: [lldb] Always log if acquiring packet sequence mutex fails

This revision was automatically updated to reflect the committed changes. Closed by commit rG0ccc4de42eae: [lldb] Always log if acquiring packet sequence mutex fails (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github

[Lldb-commits] [lldb] 03e29e2 - [lldb/DWARF] Reland: Use DW_AT_call_pc to determine artificial frame address

Author: Vedant Kumar Date: 2020-03-24T12:54:40-07:00 New Revision: 03e29e2c19a8e1f6a225b1878df3eed4e54891e5 URL: https://github.com/llvm/llvm-project/commit/03e29e2c19a8e1f6a225b1878df3eed4e54891e5 DIFF: https://github.com/llvm/llvm-project/commit/03e29e2c19a8e1f6a225b1878df3eed4e54891e5.diff

[Lldb-commits] [PATCH] D76687: [lldb][NFC] Always update m_cache_{hits/misses} in FormatCache

davide added a comment. Testcase? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76687/new/ https://reviews.llvm.org/D76687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] 0ccc4de - [lldb] Always log if acquiring packet sequence mutex fails

Author: Raphael Isemann Date: 2020-03-24T20:24:50+01:00 New Revision: 0ccc4de42eae92d5a7a1b67b29d7921c7f144b8d URL: https://github.com/llvm/llvm-project/commit/0ccc4de42eae92d5a7a1b67b29d7921c7f144b8d DIFF:

[Lldb-commits] [PATCH] D76685: [lldb] Don't dump the frame in SBTarget::EvaluateExpression in LLDB_CONFIGURATION_DEBUG

This revision was automatically updated to reflect the committed changes. Closed by commit rGaef982e35acd: [lldb] Dont dump the frame in SBTarget::EvaluateExpression in… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D76687: [lldb][NFC] Always update m_cache_{hits/misses} in FormatCache

This revision was automatically updated to reflect the committed changes. Closed by commit rG6b6a779ca8ce: [lldb][NFC] Always update m_cache_{hits/misses} in FormatCache (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D76337: [lldb/DWARF] Use DW_AT_call_pc to determine artificial frame address

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG6905394d1539: [lldb/DWARF] Use DW_AT_call_pc to determine artificial frame address (authored by vsk). Herald added a

[Lldb-commits] [lldb] 0a9b91c - Revert "[lldb/DWARF] Use DW_AT_call_pc to determine artificial frame address"

Author: Vedant Kumar Date: 2020-03-24T12:22:12-07:00 New Revision: 0a9b91c390b281e90e51d5839557c5a189dd5401 URL: https://github.com/llvm/llvm-project/commit/0a9b91c390b281e90e51d5839557c5a189dd5401 DIFF: https://github.com/llvm/llvm-project/commit/0a9b91c390b281e90e51d5839557c5a189dd5401.diff

[Lldb-commits] [PATCH] D76672: [lldb/Reproducers] Always collect the whole dSYM in the reproducer

jingham added a comment. Also, the dSYM bundle for a binary contains both the debug information and scripts that may be useful in debugging that binary - data formatters and the like. So even if the original debugging session crashed before they got around to using any of the facilities in

[Lldb-commits] [PATCH] D76697: [lldb] Remove Debug-only assert in AppleObjCTypeEncodingParser::BuildObjCObjectPointerType

davide added a comment. In D76697#1939731 , @JDevlieghere wrote: > According to the comment there is at least one valid reason for this code > path to trigger. An `lldb_assert` will encourage users to file bugs and I > think we have enough real issues

[Lldb-commits] [PATCH] D76672: [lldb/Reproducers] Always collect the whole dSYM in the reproducer

aprantl added a comment. In D76672#1939583 , @labath wrote: > In D76672#1939377 , @JDevlieghere > wrote: > > > In D76672#1938629 , @labath wrote: > > > > > It's not clear

[Lldb-commits] [lldb] 6b6a779 - [lldb][NFC] Always update m_cache_{hits/misses} in FormatCache

Author: Raphael Isemann Date: 2020-03-24T20:16:43+01:00 New Revision: 6b6a779ca8ce4025ed0a38fbcfcb6c07334ace57 URL: https://github.com/llvm/llvm-project/commit/6b6a779ca8ce4025ed0a38fbcfcb6c07334ace57 DIFF:

[Lldb-commits] [lldb] aef982e - [lldb] Don't dump the frame in SBTarget::EvaluateExpression in LLDB_CONFIGURATION_DEBUG

Author: Raphael Isemann Date: 2020-03-24T20:16:09+01:00 New Revision: aef982e35acd2a0c4f6064308601658745e78cfc URL: https://github.com/llvm/llvm-project/commit/aef982e35acd2a0c4f6064308601658745e78cfc DIFF:

[Lldb-commits] [lldb] 6905394 - [lldb/DWARF] Use DW_AT_call_pc to determine artificial frame address

Author: Vedant Kumar Date: 2020-03-24T12:02:03-07:00 New Revision: 6905394d153960ded3a7b884a9747ed2d4a6e8d8 URL: https://github.com/llvm/llvm-project/commit/6905394d153960ded3a7b884a9747ed2d4a6e8d8 DIFF: https://github.com/llvm/llvm-project/commit/6905394d153960ded3a7b884a9747ed2d4a6e8d8.diff

[Lldb-commits] [PATCH] D76697: [lldb] Remove Debug-only assert in AppleObjCTypeEncodingParser::BuildObjCObjectPointerType

JDevlieghere added a comment. According to the comment there is at least one valid reason for this code path to trigger. An `lldb_assert` will encourage users to file bugs and I think we have enough real issues that we can do without the additional noise. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D76337: [lldb/DWARF] Use DW_AT_call_pc to determine artificial frame address

vsk added a comment. I'll land this shortly if there aren't any objections. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76337/new/ https://reviews.llvm.org/D76337 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D76697: [lldb] Remove Debug-only assert in AppleObjCTypeEncodingParser::BuildObjCObjectPointerType

davide added a comment. I don't recall the details. Soft assertions. LLDB provides lldb_assert() as a soft alternative to cover the middle ground of situations that indicate a recoverable bug in LLDB. In a Debug configuration lldb_assert() behaves like assert(). In a Release configuration

[Lldb-commits] [PATCH] D76697: [lldb] Remove Debug-only assert in AppleObjCTypeEncodingParser::BuildObjCObjectPointerType

davide added a comment. Also, this was asserting already -- so it's not introducing any new `assert()`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76697/new/ https://reviews.llvm.org/D76697 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D76697: [lldb] Remove Debug-only assert in AppleObjCTypeEncodingParser::BuildObjCObjectPointerType

JDevlieghere added a comment. In D76697#1939634 , @davide wrote: > Please don't do this. I've seen that assertion triggering. If anything, you > might want to make a `lldbassert`. Did you investigate why the assertion triggered? Was it because of the

[Lldb-commits] [PATCH] D76672: [lldb/Reproducers] Always collect the whole dSYM in the reproducer

JDevlieghere added a comment. In D76672#1939583 , @labath wrote: > In D76672#1939377 , @JDevlieghere > wrote: > > > In D76672#1938629 , @labath wrote: > > > > > It's not

[Lldb-commits] [PATCH] D76697: [lldb] Remove Debug-only assert in AppleObjCTypeEncodingParser::BuildObjCObjectPointerType

davide added a comment. Please don't do this. I've seen that assertion triggering. If anything, you might want to make a `lldbassert`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76697/new/ https://reviews.llvm.org/D76697 ___

[Lldb-commits] [PATCH] D76672: [lldb/Reproducers] Always collect the whole dSYM in the reproducer

labath added a comment. In D76672#1939377 , @JDevlieghere wrote: > In D76672#1938629 , @labath wrote: > > > It's not clear to me why this is needed. > > > > I mean, if lldb touches any of the files inside the dsym

[Lldb-commits] [PATCH] Fix parsing of IPv6 host:port inside brackets

0001-Fix-parsing-of-IPv6-host-port-inside-brackets.patch Description: Binary data ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D76699: [lldb] Remove some debugging printfs from ITSession code

This revision was automatically updated to reflect the committed changes. Closed by commit rGb8dab9b3d5b9: [lldb] Remove some debugging printfs from ITSession code (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github

[Lldb-commits] [lldb] b8dab9b - [lldb] Remove some debugging printfs from ITSession code

Author: Raphael Isemann Date: 2020-03-24T18:09:27+01:00 New Revision: b8dab9b3d5b9b75f5ec9b8fed3e1c0586a82e3bf URL: https://github.com/llvm/llvm-project/commit/b8dab9b3d5b9b75f5ec9b8fed3e1c0586a82e3bf DIFF:

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

kwk marked 10 inline comments as done. kwk added a comment. @labath @jankratochvil @fche2 I've addressed all your comments and hope the patch is good to go now. Comment at: lldb/source/Host/common/DebugInfoD.cpp:43 + buildID.GetBytes().size() == +

[Lldb-commits] [PATCH] D76672: [lldb/Reproducers] Always collect the whole dSYM in the reproducer

aprantl added inline comments. Comment at: lldb/include/lldb/Utility/FileCollector.h:26 +private: + bool addDSYM(const llvm::Twine ); +}; This is something I've struggled with before. If I'm inheriting from an LLVM class do I use LLVM or LLDB naming schemes?

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk updated this revision to Diff 252353. kwk added a comment. - Add documentation for workaround on rejecting special build UUIDs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75750/new/ https://reviews.llvm.org/D75750 Files:

[Lldb-commits] [lldb] 1f80e51 - [lldb/Reproducers] Collect files imported by command script import

Author: Jonas Devlieghere Date: 2020-03-24T08:54:26-07:00 New Revision: 1f80e51546bf2bf77982fd013519631f4c86898b URL: https://github.com/llvm/llvm-project/commit/1f80e51546bf2bf77982fd013519631f4c86898b DIFF:

[Lldb-commits] [PATCH] D76626: [lldb/Reproducers] Collect files imported by command script import

This revision was automatically updated to reflect the committed changes. Closed by commit rG1f80e51546bf: [lldb/Reproducers] Collect files imported by command script import (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D74023: [RISCV] ELF attribute section for RISC-V

HsiangKai added a comment. In D74023#1938583 , @jhenderson wrote: > In D74023#1937220 , @HsiangKai wrote: > > > In D74023#1933427 , @jhenderson > > wrote: > > > > >

[Lldb-commits] [PATCH] D74023: [RISCV] ELF attribute section for RISC-V

HsiangKai updated this revision to Diff 252300. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74023/new/ https://reviews.llvm.org/D74023 Files: lld/ELF/InputFiles.cpp lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp

[Lldb-commits] [PATCH] D74023: [RISCV] ELF attribute section for RISC-V

HsiangKai marked 3 inline comments as done. HsiangKai added inline comments. Comment at: llvm/include/llvm/Support/ARMBuildAttributes.h:37 File = 1, CPU_raw_name = 4, CPU_name = 5, jhenderson wrote: >

[Lldb-commits] [PATCH] D74023: [RISCV] ELF attribute section for RISC-V

jhenderson added a comment. In D74023#1937220 , @HsiangKai wrote: > In D74023#1933427 , @jhenderson > wrote: > > > @HsiangKai, have you noticed that there are some test failures according to > > the harbourmaster

Re: [Lldb-commits] [lldb] b4a6e63 - [lldb/Target] Rework the way the inferior environment is created

I'll take a look this morning. On Tue, Mar 24, 2020 at 7:00 AM Pavel Labath wrote: > On 23/03/2020 17:17, Frédéric Riss via lldb-commits wrote: > > The new testing for “inherit-env=false” is failing on Windows. I skipped > the test for now. > > > > Could it be that it never worked there? (In

Re: [Lldb-commits] [lldb] b4a6e63 - [lldb/Target] Rework the way the inferior environment is created

On 23/03/2020 17:17, Frédéric Riss via lldb-commits wrote: > The new testing for “inherit-env=false” is failing on Windows. I skipped the > test for now. > > Could it be that it never worked there? (In which case XFail would be a > better resolution) > Does anyone have easy access to a Windows

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

labath added a comment. The code mostly fine for me, but this should be reviewed by properly by more people, once you're ready to take down the WIP tag. I am still not happy with the test case. Comment at: lldb/source/Host/common/DebugInfoD.cpp:43 +

[Lldb-commits] [PATCH] D76650: Data formatters: fix detection of C strings

This revision was automatically updated to reflect the committed changes. Closed by commit rG177dd63c8d74: Data formatters: fix detection of C strings (authored by jarin, committed by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 177dd63 - Data formatters: fix detection of C strings

Author: Jaroslav Sevcik Date: 2020-03-24T14:25:59+01:00 New Revision: 177dd63c8d742250dac6ea365e7c30f0fbab3257 URL: https://github.com/llvm/llvm-project/commit/177dd63c8d742250dac6ea365e7c30f0fbab3257 DIFF:

[Lldb-commits] [PATCH] D76699: [lldb] Remove some debugging printfs from ITSession code

teemperor created this revision. teemperor added a reviewer: LLDB. Herald added a subscriber: JDevlieghere. This seems only useful for debugging and it's just plainly printf'ing to the console instead of some log, so let's remove this. Repository: rLLDB LLDB https://reviews.llvm.org/D76699

[Lldb-commits] [PATCH] D76698: [lldb] Always log if acquiring packet sequence mutex fails

teemperor created this revision. teemperor added a reviewer: LLDB. Herald added a subscriber: JDevlieghere. Currently we only log in debug builds but I don't see why we would do this as this is neither expensive and seems useful. I looked into the git history of this code and it seems

[Lldb-commits] [PATCH] D76697: [lldb] Remove Debug-only assert in AppleObjCTypeEncodingParser::BuildObjCObjectPointerType

teemperor created this revision. teemperor added a reviewer: LLDB. Herald added a subscriber: JDevlieghere. teemperor updated this revision to Diff 252289. teemperor added a comment. - Upload correct diff. This assert only triggers in Debug builds (and not in Rel+Assert builds). Let's always

[Lldb-commits] [PATCH] D76697: [lldb] Remove Debug-only assert in AppleObjCTypeEncodingParser::BuildObjCObjectPointerType

teemperor updated this revision to Diff 252289. teemperor added a comment. - Upload correct diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76697/new/ https://reviews.llvm.org/D76697 Files:

[Lldb-commits] [PATCH] D76650: Data formatters: fix detection of C strings

jarin updated this revision to Diff 252276. jarin marked 2 inline comments as done. jarin added a comment. Addressed reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76650/new/ https://reviews.llvm.org/D76650 Files:

[Lldb-commits] [PATCH] D76650: Data formatters: fix detection of C strings

jarin added a comment. Thanks for the review! Could you possibly land this for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76650/new/ https://reviews.llvm.org/D76650 ___ lldb-commits mailing

[Lldb-commits] [lldb] 68687e7 - [lldb][NFC] Mark GetNextPersistentVariableName as overriden to silence warning

Author: Raphael Isemann Date: 2020-03-24T12:30:03+01:00 New Revision: 68687e75e7cb494796439f127a93ea03f2710551 URL: https://github.com/llvm/llvm-project/commit/68687e75e7cb494796439f127a93ea03f2710551 DIFF:

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

jankratochvil added a comment. In D76569#1938577 , @labath wrote: > I wouldn't be too worried about asan as a StringRef provides the same > lifetime guarantees (== none) as a const char *. That's true but ASAN failed for me for the first patch. But

[Lldb-commits] [PATCH] D76650: Data formatters: fix detection of C strings

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks for tracking this down! I only have a minor comment about the test character. Comment at:

[Lldb-commits] [PATCH] D76672: [lldb/Reproducers] Always collect the whole dSYM in the reproducer

labath added a comment. It's not clear to me why this is needed. I mean, if lldb touches any of the files inside the dsym bundle, then they should be automatically recorded already, right? And if it doesn't then it does not need them... It sounds to me like we are failing to capture some of

[Lldb-commits] [PATCH] D74636: [lldb-vscode] Add inheritEnvironment option

labath added a comment. In D74636#1938283 , @clayborg wrote: > I would either add the option to SBLaunchInfo so it can be specified, or > execute the command. If the target is created, it is setting a target > specific setting. If had to pick I would

[Lldb-commits] [PATCH] D76626: [lldb/Reproducers] Collect files imported by command script import

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This seems fine with a (fairly big) caveat that this approach will not work transitively loaded modules (== if the "command script import"ed module imports another module on its own).

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good. I wouldn't be too worried about asan as a StringRef provides the same lifetime guarantees (== none) as a const char *. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D76672: [lldb/Reproducers] Always collect the whole dSYM in the reproducer

JDevlieghere created this revision. JDevlieghere added reviewers: labath, arphaman, aprantl. JDevlieghere added a project: LLDB. Herald added subscribers: teemperor, abidh, dexonsmith, hiraditya, mgorny. JDevlieghere added a parent revision: D76671: [FileCollector] Add a method to add a whole

[Lldb-commits] [PATCH] D76111: Create basic SBEnvironment class

wallace added a comment. Thanks for the notice. I apologize for not doing everything correctly. I'm still trying to understand how all the different piece of the system works and I end up learning from the things that fail... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] e0279d7 - [lldb-vscode] Add missing launchCommands entry in the package.json

Author: Walter Erquinigo Date: 2020-03-23T23:21:30-07:00 New Revision: e0279d720a6eebd8508d4f102c684aee9fe9d100 URL: https://github.com/llvm/llvm-project/commit/e0279d720a6eebd8508d4f102c684aee9fe9d100 DIFF: