[Lldb-commits] [PATCH] D76808: Fix handling of bit-fields when there is a base class when parsing DWARF

aprantl added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2674 + // bit-field if this is the first field since the gap can be + // attributed to the memebers from the base class. This assumption +

[Lldb-commits] [PATCH] D76808: Fix handling of bit-fields when there is a base class when parsing DWARF

aprantl added inline comments. Comment at: lldb/test/API/lang/cpp/bitfields/main.cpp:90 + derived.b_a=2; + derived.d_a=1; clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76808/new/ https://reviews.llvm.org/D76808

[Lldb-commits] [PATCH] D76168: CPlusPlusNameParser does not handles templated operator< properly

aprantl added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusNameParser.cpp:333 + + // When we generate debug info we add template parameters to names. + // Since we don't add a space between the name and the template parameter in

[Lldb-commits] [PATCH] D76891: [lldb-vscode] fix breakpoint result ordering

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. LGTM as long as all test are passing! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76891/new/ https://reviews.llvm.org/D76891

[Lldb-commits] [PATCH] D76804: Add new LLDB setting: use-source-cache

emrekultursay updated this revision to Diff 253013. emrekultursay added a comment. - Apply code review comments from labath@ - Wipe source cache when user sets the property to false - Also expose set/get methods for use-source-cache in SBDebugger Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D76891: [lldb-vscode] fix breakpoint result ordering

wallace created this revision. wallace added reviewers: clayborg, aadsm, kusmour, labath. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The DAP specifies the following for the SetBreakpoints request: The breakpoints returned are in the same order as the elements of the

[Lldb-commits] [PATCH] D76808: Fix handling of bit-fields when there is a base class when parsing DWARF

shafik updated this revision to Diff 252984. shafik marked 4 inline comments as done. shafik added a comment. - Expanded comments - Adjusted conditionals CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76808/new/ https://reviews.llvm.org/D76808 Files:

[Lldb-commits] [PATCH] D76808: Fix handling of bit-fields when there is a base class when parsing DWARF

shafik added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2671 // If we have a gap between the last_field_end and the current // field we have an unnamed bit-field if

[Lldb-commits] [PATCH] D76814: Preserve ThreadPlanStacks for unreported threads

jingham added a comment. Addressed most of the review comments. I don't see that using file check would make the plan output checking any easier. The current function seems clear and easy to use. Trying to dynamically insert the passed in matches into a filecheck test file and then run file

[Lldb-commits] [PATCH] D76814: Preserve ThreadPlanStacks for unreported threads

jingham updated this revision to Diff 252982. jingham marked 2 inline comments as done. jingham added a comment. Addressed most of Pavel's review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76814/new/ https://reviews.llvm.org/D76814

[Lldb-commits] [PATCH] D76758: Augment lldb's symbol table with external symbols in Mach-O's dyld trie

jasonmolenda added a comment. In D76758#1944612 , @clayborg wrote: > So I know the mach-o symbol table parsing code is a mess already, but it > seems like this patch can be simpler if we make a std::set at > the top of ObjectFileMachO::ParseSymtab() and

[Lldb-commits] [PATCH] D76168: CPlusPlusNameParser does not handles templated operator< properly

shafik updated this revision to Diff 252941. shafik marked 4 inline comments as done. shafik added a comment. Addressing comments: - Adding more detailed comments - Adding test for cases that currently fail b/c we don't enable C++20 CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D76872: [intel-pt] Fix existing support in LLDB

wallace added a comment. His last activity was in Jun 2017. I hope he's still around. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76872/new/ https://reviews.llvm.org/D76872 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D76872: [intel-pt] Fix existing support in LLDB

wallace updated this revision to Diff 252936. wallace added a comment. update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76872/new/ https://reviews.llvm.org/D76872 Files: lldb/tools/intel-features/CMakeLists.txt

[Lldb-commits] [PATCH] D76872: [intel-pt] Fix existing support in LLDB

clayborg added a comment. Looks fine to me, but the original author should probably approve this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76872/new/ https://reviews.llvm.org/D76872 ___

[Lldb-commits] [PATCH] D76758: Augment lldb's symbol table with external symbols in Mach-O's dyld trie

clayborg added a comment. So I know the mach-o symbol table parsing code is a mess already, but it seems like this patch can be simpler if we make a std::set at the top of ObjectFileMachO::ParseSymtab() and every time we add a symbol that has a valid address value, add the file addr to this

[Lldb-commits] [PATCH] D76872: [intel-pt] fix python building

wallace created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. fix PT decoding Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76872 Files: lldb/tools/intel-features/CMakeLists.txt lldb/tools/intel-features/intel-pt/Decoder.cpp

[Lldb-commits] [PATCH] D76758: Augment lldb's symbol table with external symbols in Mach-O's dyld trie

jingham added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:1926 + bool IsSymbolAlreadyPresent() { +if (flags == LLDB_INVALID_ADDRESS) + return true; JDevlieghere wrote: > `return flags == LLDB_INVALID_ADDRESS`

[Lldb-commits] [PATCH] D76672: [lldb/Reproducers] Always collect the whole dSYM in the reproducer

JDevlieghere updated this revision to Diff 252898. JDevlieghere added a comment. Implement Pavel's suggestion CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76672/new/ https://reviews.llvm.org/D76672 Files: lldb/include/lldb/Utility/Reproducer.h

[Lldb-commits] [PATCH] D76827: [lldb/CMake] Fix `install` for multi-configuration generators.

This revision was automatically updated to reflect the committed changes. Closed by commit rG17e4c38739aa: [lldb/CMake] Fix `install` for multi-configuration generators. (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

emrekultursay updated this revision to Diff 252888. emrekultursay added a comment. Applied suggestions from labath@ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76806/new/ https://reviews.llvm.org/D76806 Files:

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

emrekultursay marked 3 inline comments as done. emrekultursay added a comment. In D76806#1943062 , @labath wrote: > It's not clear to me what is the user-visible effect of this. It sounds like > there should be one, but I don't know what it is... If

[Lldb-commits] [PATCH] D76827: [lldb/CMake] Fix `install` for multi-configuration generators.

JDevlieghere added a comment. In D76827#1944229 , @NathanielMcVicar wrote: > This patch resolved the issue for our VS build. Thanks! Unfortunately, I > don't have any way to test it for Xcode. Should I still accept the revision? I've tested it for

[Lldb-commits] [lldb] 17e4c38 - [lldb/CMake] Fix `install` for multi-configuration generators.

Author: Jonas Devlieghere Date: 2020-03-26T09:51:29-07:00 New Revision: 17e4c38739aa78638c783dac6c149858d1c0a550 URL: https://github.com/llvm/llvm-project/commit/17e4c38739aa78638c783dac6c149858d1c0a550 DIFF:

[Lldb-commits] [PATCH] D76758: Augment lldb's symbol table with external symbols in Mach-O's dyld trie

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:1990 import_name[0]) { + // add symbols that are reexport symbols with a valid import name + add_this_entry = true; aprantl wrote: >

[Lldb-commits] [PATCH] D76805: Fix SourceManager::SourceFileCache insertion

emrekultursay updated this revision to Diff 252881. emrekultursay marked 3 inline comments as done. emrekultursay added a comment. Applied labath@'s suggestions on test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76805/new/

[Lldb-commits] [PATCH] D76827: [lldb/CMake] Fix `install` for multi-configuration generators.

NathanielMcVicar added a comment. This patch resolved the issue for our VS build. Thanks! Unfortunately, I don't have any way to test it for Xcode. Should I still accept the revision? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76827/new/

[Lldb-commits] [PATCH] D76805: Fix SourceManager::SourceFileCache insertion

emrekultursay added a comment. > Does this actually depend on the other patch? It looks like an independent > fix we could commit separately. This bug seems to have existed forever. Fixing it means we will have source file cache enabled for the first time. If it causes any unforeseen issues,

[Lldb-commits] [PATCH] D76593: [lldb-vscode] Convert launch_info and attach_info to local variables

This revision was automatically updated to reflect the committed changes. Closed by commit rGa92673fe9a08: [lldb-vscode] Convert launch_info and attach_info to local variables (authored by anton.kolesov, committed by tatyana-krasnukha). Changed prior to commit:

[Lldb-commits] [PATCH] D76835: [lldb] Fix TestSettings.test_pass_host_env_vars on windows

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. The code is correct, so I'm approving, but I suggest a couple fixes to the comments before committing.. Comment at:

[Lldb-commits] [PATCH] D76835: [lldb] Fix TestSettings.test_pass_host_env_vars on windows

friss added a comment. Thanks for fixing this Pavel! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76835/new/ https://reviews.llvm.org/D76835 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] a92673f - [lldb-vscode] Convert launch_info and attach_info to local variables

Author: Anton Kolesov Date: 2020-03-26T18:48:40+03:00 New Revision: a92673fe9a08b5ed4f67cc52782bacc29cf945ec URL: https://github.com/llvm/llvm-project/commit/a92673fe9a08b5ed4f67cc52782bacc29cf945ec DIFF: https://github.com/llvm/llvm-project/commit/a92673fe9a08b5ed4f67cc52782bacc29cf945ec.diff

[Lldb-commits] [PATCH] D74023: [RISCV] ELF attribute section for RISC-V

jhenderson accepted this revision. jhenderson added a comment. This revision is now accepted and ready to land. I haven't really reviewed the funcional parts of this change in the attribute parser stuff, but everything else LGTM. Please wait for somebody else to review the attribute parser

[Lldb-commits] [PATCH] D74023: [RISCV] ELF attribute section for RISC-V

HsiangKai added a comment. I create a patch, D76819 , to apply clang-format to the ELF header file and ARM build attributes files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74023/new/

Re: [Lldb-commits] [lldb] b4a6e63 - [lldb/Target] Rework the way the inferior environment is created

On 25/03/2020 01:04, Adrian McCarthy wrote: > I took a stab at this, but I'm not seeing any new test failures. That is odd. I was doing some stuff on windows today, so I figured I'd take a stab at this. I was kind of right that the check in ProcessLauncher windows prevents us from passing an

[Lldb-commits] [PATCH] D74023: [RISCV] ELF attribute section for RISC-V

HsiangKai marked an inline comment as done. HsiangKai added inline comments. Comment at: llvm/lib/Support/ARMBuildAttrs.cpp:66-68 +const TagNameMap llvm::ARMBuildAttrs::ARMAttributeTags(tagData, + sizeof(tagData) / +

[Lldb-commits] [PATCH] D74023: [RISCV] ELF attribute section for RISC-V

HsiangKai updated this revision to Diff 252801. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74023/new/ https://reviews.llvm.org/D74023 Files: lld/ELF/InputFiles.cpp lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp

[Lldb-commits] [PATCH] D74023: [RISCV] ELF attribute section for RISC-V

HsiangKai added a comment. Harbormaster result: Unit tests pass. 64040 tests passed, 0 failed and 650 were skipped. clang-tidy fail. clang-tidy found 1 errors and 18 warnings. 0 of them are added as review comments why?. clang-format fail. Please format your changes with clang-format by

[Lldb-commits] [PATCH] D74023: [RISCV] ELF attribute section for RISC-V

MaskRay added a comment. I remember the patch caused many failures yesterday. The new diff is good. Comment at: llvm/unittests/Support/ELFAttributeParserTest.cpp:16 + +TagNameMap emptyTagNameMap; + `static const` Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D74023: [RISCV] ELF attribute section for RISC-V

HsiangKai updated this revision to Diff 252729. HsiangKai added a comment. Rebase on D76819 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74023/new/ https://reviews.llvm.org/D74023 Files:

[Lldb-commits] [PATCH] D74023: [RISCV] ELF attribute section for RISC-V

HsiangKai updated this revision to Diff 252710. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74023/new/ https://reviews.llvm.org/D74023 Files: lld/ELF/InputFiles.cpp lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp

[Lldb-commits] [PATCH] D76840: [lldb] Fix another crash in covariant type handling

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. To summarize IRC: I think the underlying cause here is that we get the Imported callback from the ASTImporter and then recursively start a completely new import process from that. I

[Lldb-commits] [PATCH] D76840: [lldb] Fix another crash in covariant type handling

labath created this revision. labath added reviewers: teemperor, shafik. Herald added a project: LLDB. teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. To summarize IRC: I think the underlying cause here is that we get the Imported

[Lldb-commits] [lldb] e22f0da - [lldb/breakpad] Fix register resolution on arm

Author: Pavel Labath Date: 2020-03-26T13:51:27+01:00 New Revision: e22f0dabcf976668d35595e17645095e97a8177a URL: https://github.com/llvm/llvm-project/commit/e22f0dabcf976668d35595e17645095e97a8177a DIFF: https://github.com/llvm/llvm-project/commit/e22f0dabcf976668d35595e17645095e97a8177a.diff

[Lldb-commits] [lldb] 2bfe2b8 - [lldb][testsuite] Check that process is launched successfully in inline tests

Author: Tatyana Krasnukha Date: 2020-03-26T15:05:30+03:00 New Revision: 2bfe2b878a62db5b008735401d376f68dd0e34ea URL: https://github.com/llvm/llvm-project/commit/2bfe2b878a62db5b008735401d376f68dd0e34ea DIFF:

[Lldb-commits] [lldb] ccf1c30 - [lldb][testsuite] Add lldb-server category

Author: Tatyana Krasnukha Date: 2020-03-26T15:05:30+03:00 New Revision: ccf1c30cde6e1e763e7c9cdd48a609a805166699 URL: https://github.com/llvm/llvm-project/commit/ccf1c30cde6e1e763e7c9cdd48a609a805166699 DIFF:

[Lldb-commits] [PATCH] D76697: [lldb] Replace debug-only assert in AppleObjCTypeEncodingParser::BuildObjCObjectPointerType with lldbassert

kwk added a comment. Let's summarize this. 1. In the old and the new version, the program is aborted with an `assert()` if the configuration is `LLDB_CONFIGURATION_DEBUG`. 2. In the old version, nothing happens, when the configuration is non-Debug. 3. In the new version, the assert in non-Debug

Re: [Lldb-commits] [lldb] b4a6e63 - [lldb/Target] Rework the way the inferior environment is created

On 25/03/2020 17:51, Adrian McCarthy via lldb-commits wrote: > > > On Wed, Mar 25, 2020 at 9:49 AM Adrian McCarthy > wrote: > > > > On Wed, Mar 25, 2020 at 9:10 AM Pavel Labath > wrote: > > On 25/03/2020 01:04, Adrian

[Lldb-commits] [PATCH] D76672: [lldb/Reproducers] Always collect the whole dSYM in the reproducer

labath added a comment. Wow. This is a lot more generic than I had mind. But at the same time, it does not seem generic enough. :( Like, for instance, using only component-based matching, one couldn't ignore `/usr/lib` while keeping `$BUILD/lib` or whatever. What I had in mind for your use

[Lldb-commits] [PATCH] D76736: [LLDB] Fix parsing of IPv6 host:port inside brackets

This revision was automatically updated to reflect the committed changes. Closed by commit rG57be22fa1797: [LLDB] Fix parsing of IPv6 host:port inside brackets (authored by emrekultursay, committed by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D76835: [lldb] Fix TestSettings.test_pass_host_env_vars on windows

labath created this revision. labath added reviewers: amccarth, friss. Herald added a project: LLDB. A defensive check in ProcessLauncherWindows meant that we would never attempt to launch a process with a completely empty environment -- the host environment would be used instead. Insted, I make

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

This revision was automatically updated to reflect the committed changes. Closed by commit rGdaed98e5b5d1: Convert CommandObjectCommands functions to return StringRefs (authored by shivammittal99, committed by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 57be22f - [LLDB] Fix parsing of IPv6 host:port inside brackets

Author: Emre Kultursay Date: 2020-03-26T11:35:54+01:00 New Revision: 57be22fa179703b78b1807217b72eaffa0c518bf URL: https://github.com/llvm/llvm-project/commit/57be22fa179703b78b1807217b72eaffa0c518bf DIFF:

[Lldb-commits] [lldb] daed98e - Convert CommandObjectCommands functions to return StringRefs

Author: Shivam Mittal Date: 2020-03-26T11:20:38+01:00 New Revision: daed98e5b5d1b4a2ab29b3f757b53519ed070439 URL: https://github.com/llvm/llvm-project/commit/daed98e5b5d1b4a2ab29b3f757b53519ed070439 DIFF: https://github.com/llvm/llvm-project/commit/daed98e5b5d1b4a2ab29b3f757b53519ed070439.diff

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

kwk marked 3 inline comments as done. kwk added a comment. @labath I made a signficant simplification of starting and killing the server. I hope you like that better. Comment at: lldb/source/Core/SourceManager.cpp:408 + if ((!file_spec.GetDirectory() &&

[Lldb-commits] [lldb] 703a856 - [lldb] Fix TestVSCode_completions for clang 159a9f7

Author: Pavel Labath Date: 2020-03-26T10:24:33+01:00 New Revision: 703a856a1005b651a9087ad16b6df2cc19883dc0 URL: https://github.com/llvm/llvm-project/commit/703a856a1005b651a9087ad16b6df2cc19883dc0 DIFF: https://github.com/llvm/llvm-project/commit/703a856a1005b651a9087ad16b6df2cc19883dc0.diff

[Lldb-commits] [PATCH] D76814: Preserve ThreadPlanStacks for unreported threads

labath added a comment. I still don't know much about thread plans, but I didn't see anything that would stand out. All my comments are fairly superficial. Comment at: lldb/source/Target/TargetProperties.td:183 Desc<"A path to a python OS plug-in module file that

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

shivammittal99 added a comment. Can someone please land this patch for me? I do not have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76569/new/ https://reviews.llvm.org/D76569 ___

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

labath added reviewers: labath, jingham. labath added a comment. It's not clear to me what is the user-visible effect of this. It sounds like there should be one, but I don't know what it is... Comment at: lldb/source/Core/SourceManager.cpp:175-176 - if

[Lldb-commits] [PATCH] D76805: Fix SourceManager::SourceFileCache insertion

labath accepted this revision. labath marked an inline comment as done. labath added a comment. This revision is now accepted and ready to land. Looks good. I'm just picking some nits in the test. I'm assuming that @jingham's comment refers to the other patch (and it more-or-less matches what I

[Lldb-commits] [PATCH] D76569: Convert CommandObjectCommands functions to return StringRefs

labath added a comment. In D76569#1942271 , @jankratochvil wrote: > The ASan GCC report was valid ( > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94299#c6 ) Ah, that is cute. :) Thanks for following this up. Now that the condition is gone (as it

[Lldb-commits] [PATCH] D76804: Add new LLDB setting: use-source-cache

labath added a reviewer: jingham. labath added a comment. Yeah, the differences between windows handling of memory mapped files is quite annoying (though I can't really say that the windows behavior is worse than randomly sending out SIGBUSes). The alternative (which is used in other tools

[Lldb-commits] [PATCH] D76758: Augment lldb's symbol table with external symbols in Mach-O's dyld trie

jasonmolenda updated this revision to Diff 252756. jasonmolenda added a comment. Update patch with Adrian's suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76758/new/ https://reviews.llvm.org/D76758 Files:

[Lldb-commits] [PATCH] D76758: Augment lldb's symbol table with external symbols in Mach-O's dyld trie

jasonmolenda marked 11 inline comments as done. jasonmolenda added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:4499 +std::sort(external_sym_trie_entries.begin(), + external_sym_trie_entries.end(), sort_by_address); +

[Lldb-commits] [PATCH] D76758: Augment lldb's symbol table with external symbols in Mach-O's dyld trie

jasonmolenda marked 2 inline comments as done. jasonmolenda added a comment. Thanks Adrian, great comments, incorporated most of them. The use of the block to search the trie entries when eliminating duplication between nlist/tries was a good idea, much cleaner now. Comment

[Lldb-commits] [PATCH] D76827: [lldb/CMake] Fix `install` for multi-configuration generators.

JDevlieghere created this revision. JDevlieghere added reviewers: stella.stamenova, NathanielMcVicar. Herald added a subscriber: mgorny. For multi-generator builds like MSVC and Xcode, the install source and destination of the `lldb-python-scripts` target contains configuration dependent paths