[Lldb-commits] [PATCH] D77107: [intel-pt] Implement a basic test case

clayborg added a comment. I am worried if this test will be flaky on loaded machines. Not sure how we can ever guarantee we will see processor traces with our stuff in it if the machine is busy running many tests or even doing other things. Comment at:

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

clayborg added a comment. Looks good as long as with we have "llvm::Optional request_path = {}" in the arguments for a function, that "{}" will turn into llvm::None and not an empty StringRef? Unclear to me. As long as this is what is happening and as long is this coding convention is used

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace updated this revision to Diff 253779. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76968/new/ https://reviews.llvm.org/D76968 Files:

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace marked an inline comment as done. wallace added inline comments. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:332 + + object.try_emplace("line", line); + clayborg wrote: > This should do what it was doing before: grab the source line only from the

[Lldb-commits] [PATCH] D77108: [lldb/DWARF] Fix evaluator crash when accessing empty stack

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. This is obviously good! Do you think that a similar error handling bug might exist in other cases that depend top-of-stack? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D77108: [lldb/DWARF] Fix evaluator crash when accessing empty stack

mib created this revision. mib added a reviewer: aprantl. mib added a project: LLDB. Herald added a subscriber: lldb-commits. This patch fixes a crash that happens on the DWARF expression evaluator when trying to access the top of the stack while it's empty. Signed-off-by: Med Ismail Bennani

[Lldb-commits] [PATCH] D77107: [intel-pt] Implement a basic test case

wallace updated this revision to Diff 253748. wallace added a comment. Added a stop command invocation in the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77107/new/ https://reviews.llvm.org/D77107 Files:

[Lldb-commits] [PATCH] D77107: [intel-pt] Implement a basic test case

wallace created this revision. wallace added reviewers: clayborg, labath, kusmour, aadsm. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. wallace updated this revision to Diff 253748. wallace added a comment. Added a stop command invocation in the test Depends on D76872

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. After reviewing more, we should just re-use CreateBreakpoint and add a "llvm::Optional request_path" argument. Then all breakpoints use the same function and we avoid duplicated

[Lldb-commits] [PATCH] D76672: [lldb/Reproducers] Always collect the whole dSYM in the reproducer

This revision was automatically updated to reflect the committed changes. Closed by commit rG38ddb49e5242: [lldb/Reproducers] Always collect the whole dSYM in the reproducer (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D76672?vs=252898=253718#toc Repository:

[Lldb-commits] [PATCH] D77096: Correct the duplicate pragma marks in CommandObjectTarget.cpp

shivammittal99 created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Resolve the two duplicated pragma marks in lldb/source/Commands/CommandObjectTarget.cpp Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77096 Files:

[Lldb-commits] [lldb] 38ddb49 - [lldb/Reproducers] Always collect the whole dSYM in the reproducer

Author: Jonas Devlieghere Date: 2020-03-30T15:16:50-07:00 New Revision: 38ddb49e5242920e44a982cff7bbe2e86bd23a69 URL: https://github.com/llvm/llvm-project/commit/38ddb49e5242920e44a982cff7bbe2e86bd23a69 DIFF:

[Lldb-commits] [lldb] 075b610 - Recommit "[lldb] Make TestExprDiagnostics.py pass again after enabling Fix-Its in test"

Author: Davide Italiano Date: 2020-03-30T14:24:06-07:00 New Revision: 075b610403a7d151ee9056aa490233bcd4248718 URL: https://github.com/llvm/llvm-project/commit/075b610403a7d151ee9056aa490233bcd4248718 DIFF:

[Lldb-commits] [lldb] 06bb7df - Recommit "[lldb] Make Fix-Its also apply to top-level expressions""

Author: Davide Italiano Date: 2020-03-30T14:24:06-07:00 New Revision: 06bb7df81c0ba01f7efab76779e2eb7d76615e3d URL: https://github.com/llvm/llvm-project/commit/06bb7df81c0ba01f7efab76779e2eb7d76615e3d DIFF:

[Lldb-commits] [lldb] 50f7153 - Revert "[lldb][NFC] Refactor Fix-It filter for warnings"

Author: Davide Italiano Date: 2020-03-30T14:12:11-07:00 New Revision: 50f7153ddb6e6dabcac6d16c8c908f1708f60d01 URL: https://github.com/llvm/llvm-project/commit/50f7153ddb6e6dabcac6d16c8c908f1708f60d01 DIFF:

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace updated this revision to Diff 253695. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76968/new/ https://reviews.llvm.org/D76968 Files:

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

aprantl added a comment. > In case of Apple platforms, this won't make a difference in practice, since > the support for that is implemented in PlatformDarwin (which all of these > inherit from), but it sounds like this will be a problem for the "linux" sdk > (assuming this is what I think it

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace updated this revision to Diff 253696. wallace added a comment. nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76968/new/

[Lldb-commits] [lldb] 55ed09d - Revert "[lldb] Make TestExprDiagnostics.py pass again after enabling Fix-Its in test"

Author: Davide Italiano Date: 2020-03-30T13:58:18-07:00 New Revision: 55ed09d32e2602eba1dbb8aba1985246739c3909 URL: https://github.com/llvm/llvm-project/commit/55ed09d32e2602eba1dbb8aba1985246739c3909 DIFF:

[Lldb-commits] [lldb] 10f633d - [TypeSystemClang] Add missing case in a switch. NFC'ish.

Author: Davide Italiano Date: 2020-03-30T13:53:53-07:00 New Revision: 10f633db86b523da17a820098e33f0caf70dbada URL: https://github.com/llvm/llvm-project/commit/10f633db86b523da17a820098e33f0caf70dbada DIFF:

[Lldb-commits] [lldb] fe5cb1c - Revert "[lldb] Make Fix-Its also apply to top-level expressions"

Author: Davide Italiano Date: 2020-03-30T13:23:58-07:00 New Revision: fe5cb1c25fd6c07bbe3c0c698f36b74e6d04946f URL: https://github.com/llvm/llvm-project/commit/fe5cb1c25fd6c07bbe3c0c698f36b74e6d04946f DIFF:

[Lldb-commits] [PATCH] D76872: [intel-pt] Fix existing support in LLDB

wallace updated this revision to Diff 253684. wallace added a comment. merge the commits of this diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76872/new/ https://reviews.llvm.org/D76872 Files: lldb/tools/intel-features/CMakeLists.txt

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. The description confused me a bit as I thought we were going to be doing some "CommandObjectSource::DumpLinesInSymbolContexts()" stuff somewhere. But this path is really just

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

clayborg added a comment. In D75750#1949678 , @fche2 wrote: > In D75750#1949527 , @labath wrote: > > > > > > > > > I am expecting that this feature will hook in very near to > > `DownloadObjectAndSymbolFile` for

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

clayborg added a comment. In D75750#1949527 , @labath wrote: > In D75750#1948273 , @clayborg wrote: > > > Currently we have a solution for macOS to locate symbol files in the > >

[Lldb-commits] [PATCH] D76945: [lldb/CMake] Make check-lldb-* work for the standalone build.

This revision was automatically updated to reflect the committed changes. Closed by commit rG63aaecd5bebc: [lldb/CMake] Make check-lldb-* work for the standalone build. (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

emrekultursay updated this revision to Diff 253651. emrekultursay added a comment. Fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76806/new/ https://reviews.llvm.org/D76806 Files: lldb/include/lldb/Core/SourceManager.h

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace updated this revision to Diff 253649. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76968/new/ https://reviews.llvm.org/D76968 Files:

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

emrekultursay updated this revision to Diff 253648. emrekultursay marked 6 inline comments as done. emrekultursay added a comment. PTAL. Applied suggested changes, thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76806/new/

[Lldb-commits] [lldb] 63aaecd - [lldb/CMake] Make check-lldb-* work for the standalone build.

Author: Jonas Devlieghere Date: 2020-03-30T11:38:37-07:00 New Revision: 63aaecd5bebc8cf2cd4b4f2b42183978fd30ddef URL: https://github.com/llvm/llvm-project/commit/63aaecd5bebc8cf2cd4b4f2b42183978fd30ddef DIFF:

[Lldb-commits] [PATCH] D76805: Fix SourceManager::SourceFileCache insertion

emrekultursay added a comment. In D76805#1949642 , @labath wrote: > Ok, that makes kind of sense, though I am left wondering if we really need > this feature, given that we have survived so long without noticing it is > missing... > > Am I understanding

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace marked 2 inline comments as done. wallace added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/breakpoint/TestVSCode_setBreakpoints.py:25-43 +source_basename = 'main.cpp' +source_path = os.path.join(os.getcwd(), source_basename) + +

[Lldb-commits] [PATCH] D76964: Fix an issue where the IgnoreName function was not allowing "Class" to be looked up inside a namespace or other class.

shafik added a comment. You also mentioned the `id` case failing as well. We should add that case to the test as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76964/new/ https://reviews.llvm.org/D76964

[Lldb-commits] [PATCH] D76964: Fix an issue where the IgnoreName function was not allowing "Class" to be looked up inside a namespace or other class.

aprantl added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp:582 +static const ConstString Class_name("Class"); +if (name == id_name || name == Class_name) { + // Only disallow using "id" and "Class" if we are searching

Re: [Lldb-commits] [lldb] 3806b38 - [LLDB] Initialize temporary token

Thank you for catching this and fixing it! > On Mar 30, 2020, at 7:13 AM, Benjamin Kramer via lldb-commits > wrote: > > > Author: Benjamin Kramer > Date: 2020-03-30T16:12:50+02:00 > New Revision: 3806b38045c08c674dc5db65bb06cf3dc34b9cc7 > > URL: >

[Lldb-commits] [lldb] 3788978 - Revert "[lldb] Fix TestSettings.test_pass_host_env_vars on windows"

Author: Pavel Labath Date: 2020-03-30T17:32:42+02:00 New Revision: 37889786b040bd2bc48e5a01c6b92de777564a8f URL: https://github.com/llvm/llvm-project/commit/37889786b040bd2bc48e5a01c6b92de777564a8f DIFF: https://github.com/llvm/llvm-project/commit/37889786b040bd2bc48e5a01c6b92de777564a8f.diff

[Lldb-commits] [PATCH] D74023: [RISCV] ELF attribute section for RISC-V

jhenderson added a comment. In D74023#1949261 , @HsiangKai wrote: > In D74023#1948388 , @MaskRay wrote: > > > The code generally looks good. For unittests, I think we can either make > > llvm-readobj -A canonical

[Lldb-commits] [PATCH] D74023: [RISCV] ELF attribute section for RISC-V

HsiangKai updated this revision to Diff 253553. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74023/new/ https://reviews.llvm.org/D74023 Files: lld/ELF/InputFiles.cpp lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp

[Lldb-commits] [PATCH] D74023: [RISCV] ELF attribute section for RISC-V

MaskRay added a comment. The code generally looks good. For unittests, I think we can either make llvm-readobj -A canonical or the unittests canonical. If we decide to place tests on one place, we should delete most tests on the other side. My current preference is that we use more of

[Lldb-commits] [PATCH] D74023: [RISCV] ELF attribute section for RISC-V

HsiangKai added a comment. In D74023#1948388 , @MaskRay wrote: > The code generally looks good. For unittests, I think we can either make > llvm-readobj -A canonical or the unittests canonical. If we decide to place > tests on one place, we should

[Lldb-commits] [PATCH] D74023: [RISCV] ELF attribute section for RISC-V

HsiangKai added a comment. @MaskRay, do you have any other comments about this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74023/new/ https://reviews.llvm.org/D74023 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D74023: [RISCV] ELF attribute section for RISC-V

MaskRay added inline comments. Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVELFStreamer.cpp:102 + +Streamer.emitIntValue(ELFAttrs::Format_Version, 1); + } `emitInt8` Comment at:

[Lldb-commits] [PATCH] D74023: [RISCV] ELF attribute section for RISC-V

HsiangKai marked an inline comment as done. HsiangKai added inline comments. Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVTargetStreamer.cpp:93 + StringRef String) { + OS << "\t.attribute\t" << Attribute << ", \"" << String

[Lldb-commits] [PATCH] D76835: [lldb] Fix TestSettings.test_pass_host_env_vars on windows

This revision was automatically updated to reflect the committed changes. labath marked an inline comment as done. Closed by commit rG908f78f3c198: [lldb] Fix TestSettings.test_pass_host_env_vars on windows (authored by labath). Changed prior to commit:

[Lldb-commits] [PATCH] D76835: [lldb] Fix TestSettings.test_pass_host_env_vars on windows

labath marked 4 inline comments as done. labath added inline comments. Comment at: lldb/source/Host/windows/ProcessLauncherWindows.cpp:41 + // double null. + if (env.empty()) { +buffer.push_back(0); amccarth wrote: > There would be no harm in always adding

[Lldb-commits] [lldb] 3806b38 - [LLDB] Initialize temporary token

Author: Benjamin Kramer Date: 2020-03-30T16:12:50+02:00 New Revision: 3806b38045c08c674dc5db65bb06cf3dc34b9cc7 URL: https://github.com/llvm/llvm-project/commit/3806b38045c08c674dc5db65bb06cf3dc34b9cc7 DIFF:

[Lldb-commits] [lldb] 908f78f - [lldb] Fix TestSettings.test_pass_host_env_vars on windows

Author: Pavel Labath Date: 2020-03-30T16:06:52+02:00 New Revision: 908f78f3c19805ee7386186072407a541c9fb167 URL: https://github.com/llvm/llvm-project/commit/908f78f3c19805ee7386186072407a541c9fb167 DIFF: https://github.com/llvm/llvm-project/commit/908f78f3c19805ee7386186072407a541c9fb167.diff

[Lldb-commits] [PATCH] D77044: Extend max register size to accommodate AArch64 SVE vector regs

danielkiss added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:2051 // Parse out the value. - uint8_t reg_bytes[32]; // big enough to support up to 256 bit ymmN register + uint8_t reg_bytes[256]; // big enough to

[Lldb-commits] [PATCH] D76840: [lldb] Fix another crash in covariant type handling

This revision was automatically updated to reflect the committed changes. Closed by commit rG7b00eeb53de0: [lldb] Fix another crash in covariant type handling (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76840/new/

[Lldb-commits] [PATCH] D76840: [lldb] Fix another crash in covariant type handling

labath added a comment. Thanks for the review, and a pointer to `CompleteTagDeclsScope`. While looking at this, I got some ideas on how to reduce the number of chained imports here (nothing magical -- just avoid importing the type if the base and derived return types are identical (no

[Lldb-commits] [lldb] 7b00eeb - [lldb] Fix another crash in covariant type handling

Author: Pavel Labath Date: 2020-03-30T16:00:21+02:00 New Revision: 7b00eeb53de06c7979fd2a88436c3387d0492ee8 URL: https://github.com/llvm/llvm-project/commit/7b00eeb53de06c7979fd2a88436c3387d0492ee8 DIFF: https://github.com/llvm/llvm-project/commit/7b00eeb53de06c7979fd2a88436c3387d0492ee8.diff

[Lldb-commits] [PATCH] D76814: Preserve ThreadPlanStacks for unreported threads

labath added inline comments. Comment at: lldb/source/Target/TargetProperties.td:183 Desc<"A path to a python OS plug-in module file that contains a OperatingSystemPlugIn class.">; + def PluginReportsAllThreads: Property<"plugin-reports-all-threads", "Boolean">, +

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

labath added a comment. In D76471#1947250 , @aprantl wrote: > I've reworked this a little based on your feedback. > > First, I've renamed `SDK` to `XcodeSDK`. An Xcode SDK is a fairly specific > concept and I'm not going to pretend that it makes sense to

[Lldb-commits] [lldb] 11a5cae - [lldb][NFC] Refactor Fix-It filter for warnings

Author: Raphael Isemann Date: 2020-03-30T14:01:16+02:00 New Revision: 11a5caee2aeae2546213366e7fc54095bb8163b9 URL: https://github.com/llvm/llvm-project/commit/11a5caee2aeae2546213366e7fc54095bb8163b9 DIFF:

[Lldb-commits] [lldb] 502a06f - [lldb] Make TestExprDiagnostics.py pass again after enabling Fix-Its in test

Author: Raphael Isemann Date: 2020-03-30T13:52:09+02:00 New Revision: 502a06fcdafa637a9890da16c2734bc1a36010f6 URL: https://github.com/llvm/llvm-project/commit/502a06fcdafa637a9890da16c2734bc1a36010f6 DIFF:

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

fche2 added a comment. In D75750#1949527 , @labath wrote: > > I am expecting that this feature will hook in very near to > `DownloadObjectAndSymbolFile` for downloading the debug info, but it's not > clear to me how would the source files fit in.

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

labath added inline comments. Comment at: lldb/test/API/commands/settings/use_source_cache/TestUseSourceCache.py:17 + +@skipIf(oslist=no_match(["windows"])) +def test_set_use_source_cache_false(self): Could you remove this decorator? The test is not

[Lldb-commits] [PATCH] D73206: Pass `CompileUnit *` along `DWARFDIE` for DWZ

jankratochvil added a comment. In D73206#1949516 , @labath wrote: > The main thing I don't like about the current state is the introduction of > user_id_t into the index classes. It forces a bunch of conversions for a flow > that really should be

[Lldb-commits] [PATCH] D76805: Fix SourceManager::SourceFileCache insertion

labath added a comment. In D76805#1944198 , @emrekultursay wrote: > > Does this actually depend on the other patch? It looks like an independent > > fix we could commit separately. > > This bug seems to have existed forever. Fixing it means we will have

[Lldb-commits] [PATCH] D77000: [LLDB] [PECOFF] Only use PECallFrameInfo on the one supported architecture

mstorsjo added a comment. In D77000#1949247 , @aleksandr.urakov wrote: > Hello! But does the format of an exception directory for aarch64 differ > completely from x86-64 one? As far as I know, it's pretty different yes. There's one format for arm32 as

[Lldb-commits] [PATCH] D77000: [LLDB] [PECOFF] Only use PECallFrameInfo on the one supported architecture

mstorsjo updated this revision to Diff 253548. mstorsjo retitled this revision from "[lldb] [PECOFF] Check that PECallFrameInfo operates on the expected architecture before interpreting RuntimeFunction structs" to "[LLDB] [PECOFF] Only use PECallFrameInfo on the one supported architecture".

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and ptrace support

omjavaid created this revision. omjavaid added reviewers: labath, clayborg, jankratochvil, jasonmolenda. Herald added subscribers: danielkiss, kristof.beyls, tschuett. Herald added a reviewer: rengolin. This patch adds support for AArch64 SVE register infos description and register access via

[Lldb-commits] [PATCH] D77042: [lldb] Make Fix-Its also apply to top-level expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rG83c81c0a4694: [lldb] Make Fix-Its also apply to top-level expressions (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D73206: Pass `CompileUnit *` along `DWARFDIE` for DWZ

labath added a comment. Overall, I think this is workable. The main thing I don't like about the current state is the introduction of user_id_t into the index classes. It forces a bunch of conversions for a flow that really should be simple. I guess that was to avoid main-cu-ificating the

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

labath added a comment. In D75750#1948273 , @clayborg wrote: > Currently we have a solution for macOS to locate symbol files in the > "lldb/source/Symbol/LocateSymbolFile.cpp" file in the > Symbols::LocateExecutableSymbolFile(...) function: > > static

[Lldb-commits] [lldb] 83c81c0 - [lldb] Make Fix-Its also apply to top-level expressions

Author: Raphael Isemann Date: 2020-03-30T11:50:57+02:00 New Revision: 83c81c0a469482888482983c302c09c02680ae7c URL: https://github.com/llvm/llvm-project/commit/83c81c0a469482888482983c302c09c02680ae7c DIFF:

[Lldb-commits] [PATCH] D77045: Add invalidate list to primary regs in arm64 register infos

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added subscribers: danielkiss, kristof.beyls. AArch64 reigster X and V registers are primary GPR and vector registers respectively. If these registers are modified their corresponding children w regs or s/d regs should be

[Lldb-commits] [PATCH] D77044: Extend max register size to accommodate AArch64 SVE vector regs

omjavaid created this revision. omjavaid added reviewers: labath, jankratochvil. Herald added subscribers: danielkiss, kristof.beyls, tschuett. Herald added a reviewer: rengolin. This patch increases maximum register size to 256 bytes to accommodate AArch64 SVE registers maximum possible size of

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

kwk updated this revision to Diff 253531. kwk added a comment. - Use file:// and require debuginfod 0.179 - simplify FindDebuginfod.cmake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75750/new/ https://reviews.llvm.org/D75750 Files:

[Lldb-commits] [PATCH] D77043: Fix process gdb-remote usage of value_regs/invalidate_regs

omjavaid created this revision. omjavaid added reviewers: labath, jankratochvil. Herald added subscribers: danielkiss, kristof.beyls. Herald added a reviewer: rengolin. Native register descriptions in LLDB specify lldb register numbers in value_regs and invalidate_regs lists. These register

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

labath added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/breakpoint/TestVSCode_setBreakpoints.py:25-43 +source_basename = 'main.cpp' +source_path = os.path.join(os.getcwd(), source_basename) + +new_source_folder =

[Lldb-commits] [PATCH] D77000: [lldb] [PECOFF] Check that PECallFrameInfo operates on the expected architecture before interpreting RuntimeFunction structs

labath added a comment. In D77000#1949247 , @aleksandr.urakov wrote: > Hello! But does the format of an exception directory for aarch64 differ > completely from x86-64 one? Can we somehow adopt the existing parser to > support it? If we can, I think

[Lldb-commits] [lldb] 767a97b - [lldb][NFC] Cleanup Fix-It code

Author: Raphael Isemann Date: 2020-03-30T11:02:44+02:00 New Revision: 767a97b22339350d1d1368ca5548f967e49a4c00 URL: https://github.com/llvm/llvm-project/commit/767a97b22339350d1d1368ca5548f967e49a4c00 DIFF:

[Lldb-commits] [PATCH] D76955: [lldb/Test] Decode stdout and stderr in case it contains UTF-8

labath added a comment. In D76955#1947160 , @JDevlieghere wrote: > Right, I didn't check whether out and err were strings or bytes. I'll see if > I can find a better solution or alternatively wrap it in a try-except. It might be simplest to wrap that

[Lldb-commits] [PATCH] D76945: [lldb/CMake] Make check-lldb-* work for the standalone build.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. sounds reasonable CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76945/new/ https://reviews.llvm.org/D76945 ___ lldb-commits mailing

[Lldb-commits] [lldb] 064ab22 - [lldb] Run TestFixIts on non-Darwin platforms

Author: Raphael Isemann Date: 2020-03-30T09:53:51+02:00 New Revision: 064ab22fb29be673fa2ac4ab3b28cc30f9371e9c URL: https://github.com/llvm/llvm-project/commit/064ab22fb29be673fa2ac4ab3b28cc30f9371e9c DIFF:

[Lldb-commits] [lldb] 53e7c8f - [lldb][NFC] Cleanup TestFixIts.py

Author: Raphael Isemann Date: 2020-03-30T09:40:03+02:00 New Revision: 53e7c8fdfaaa1172f7658aa5bb61a3282fb09a84 URL: https://github.com/llvm/llvm-project/commit/53e7c8fdfaaa1172f7658aa5bb61a3282fb09a84 DIFF:

[Lldb-commits] [PATCH] D77000: [lldb] [PECOFF] Check that PECallFrameInfo operates on the expected architecture before interpreting RuntimeFunction structs

aleksandr.urakov added a comment. Hello! But does the format of an exception directory for aarch64 differ completely from x86-64 one? Can we somehow adopt the existing parser to support it? If we can, I think that this check looks good (we encapsulate the difference inside `PECallFrameInfo`).