[Lldb-commits] [PATCH] D77287: Windows: add very basic support for `DoLoadImage`

compnerd created this revision. compnerd added reviewers: JDevlieghere, xiaobai. compnerd added a project: LLDB. Add some very basic support for `DoLoadImage` and `UnloadImage` for Windows. This was previously not implemented and would result in a failure at runtime that is hard to detect.

[Lldb-commits] [PATCH] D77241: update eArgTypeScriptLang description to mention lua

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks, LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77241/new/ https://reviews.llvm.org/D77241 ___ lldb-commits

[Lldb-commits] [lldb] af1b7d0 - Correct copy-pasteo in lua script language description

Author: Ed Maste Date: 2020-04-02T00:12:24-04:00 New Revision: af1b7d06d9e45c7e20540aa3bf81f1be5befaa0f URL: https://github.com/llvm/llvm-project/commit/af1b7d06d9e45c7e20540aa3bf81f1be5befaa0f DIFF: https://github.com/llvm/llvm-project/commit/af1b7d06d9e45c7e20540aa3bf81f1be5befaa0f.diff

[Lldb-commits] [lldb] 32672b8 - Revert "Preserve the owning module information from DWARF in the synthesized AST"

Author: Adrian Prantl Date: 2020-04-01T18:58:11-07:00 New Revision: 32672b877dc1e05bc4489f2f4598f5472bc60576 URL: https://github.com/llvm/llvm-project/commit/32672b877dc1e05bc4489f2f4598f5472bc60576 DIFF: https://github.com/llvm/llvm-project/commit/32672b877dc1e05bc4489f2f4598f5472bc60576.diff

[Lldb-commits] [PATCH] D75488: Preserve the owning module information from DWARF in the synthesized AST

This revision was automatically updated to reflect the committed changes. Closed by commit rG4354dfbdf5c8: Preserve the owning module information from DWARF in the synthesized AST (authored by aprantl). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D76814: Preserve ThreadPlanStacks for unreported threads

jingham marked 5 inline comments as done. jingham added inline comments. Comment at: lldb/source/Target/TargetProperties.td:183 Desc<"A path to a python OS plug-in module file that contains a OperatingSystemPlugIn class.">; + def PluginReportsAllThreads:

[Lldb-commits] [lldb] 4354dfb - Preserve the owning module information from DWARF in the synthesized AST

Author: Adrian Prantl Date: 2020-04-01T17:46:02-07:00 New Revision: 4354dfbdf5c8510a7ddff10ae67a28e16cf7cc79 URL: https://github.com/llvm/llvm-project/commit/4354dfbdf5c8510a7ddff10ae67a28e16cf7cc79 DIFF: https://github.com/llvm/llvm-project/commit/4354dfbdf5c8510a7ddff10ae67a28e16cf7cc79.diff

[Lldb-commits] [PATCH] D76814: Preserve ThreadPlanStacks for unreported threads

jingham updated this revision to Diff 254372. jingham added a comment. Add a variable backing the std::condition_variable in the source for the stepping test to catch spurious wakeups. AssertTrue -> AssertIn in the ThreadPlanList test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D77241: update eArgTypeScriptLang description to mention lua

emaste updated this revision to Diff 254369. emaste added a comment. reword CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77241/new/ https://reviews.llvm.org/D77241 Files: lldb/source/Interpreter/CommandObject.cpp Index: lldb/source/Interpreter/CommandObject.cpp

[Lldb-commits] [PATCH] D76964: Fix an issue where the IgnoreName function was not allowing "Class" to be looked up inside a namespace or other class.

clayborg updated this revision to Diff 254352. clayborg added a comment. Fixed patch reviewer suggestions and added a test for "id". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76964/new/ https://reviews.llvm.org/D76964 Files:

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

aprantl added a comment. In D76471#1954205 , @labath wrote: > I don't think that spreading this out over host and platform is convoluted. > In fact, I was going to propose something like that myself. However, it does > bring us back to the question of

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

aprantl updated this revision to Diff 254326. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76471/new/ https://reviews.llvm.org/D76471 Files: lldb/include/lldb/Core/Module.h lldb/include/lldb/Host/HostInfoBase.h lldb/include/lldb/Host/macosx/HostInfoMacOSX.h

[Lldb-commits] [PATCH] D77153: [lldb/DataFormatters] Display null C++ pointers as nullptr

friss added a comment. I was checking whether there is a way to catch null pointer before a type summary is even chosen. And found out that such logic exists, but only for Objective-C. Languages have a `IsNilReference()` virtual method that can tell whether a `ValueObject` is a nil reference.

[Lldb-commits] [lldb] f203100 - Reapply: [Host.mm] Check for the right macro instead of inlining it

Author: Vedant Kumar Date: 2020-04-01T15:23:07-07:00 New Revision: f203100ebe22bf97a4268a562cdbef22d14db915 URL: https://github.com/llvm/llvm-project/commit/f203100ebe22bf97a4268a562cdbef22d14db915 DIFF: https://github.com/llvm/llvm-project/commit/f203100ebe22bf97a4268a562cdbef22d14db915.diff

[Lldb-commits] [PATCH] D77153: [lldb/DataFormatters] Display null C++ pointers as nullptr

friss added a comment. In D77153#1954154 , @labath wrote: > It might be worth mentioning though that the title of the patch is somewhat > misleading -- I believe the `CXX` in `CXXFunctionSummaryFormat` refers to the > language the formatter is

[Lldb-commits] [PATCH] D77241: update eArgTypeScriptLang description to mention lua

JDevlieghere added inline comments. Comment at: lldb/source/Interpreter/CommandObject.cpp:1094 { eArgTypeScriptedCommandSynchronicity, "script-cmd-synchronicity", CommandCompletions::eNoCompletion, { nullptr, false }, "The synchronicity to use to run scripted commands

[Lldb-commits] [lldb] 064c634 - Revert "[intel-pt] Implement a basic test case"

Author: Walter Erquinigo Date: 2020-04-01T14:08:19-07:00 New Revision: 064c634ef3d44e7b50db86ec0d1f64e718b6dfe4 URL: https://github.com/llvm/llvm-project/commit/064c634ef3d44e7b50db86ec0d1f64e718b6dfe4 DIFF:

[Lldb-commits] [PATCH] D77186: [source maps] Ensure all valid source maps are added instead of failing with the first invalid one

wallace added a comment. Thanks for the heads up. I think I got a false impression of how comments after accept vs requesting changes work in this repo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77186/new/ https://reviews.llvm.org/D77186

[Lldb-commits] [lldb] c911cc6 - [intel-pt] Implement a basic test case

Author: Walter Erquinigo Date: 2020-04-01T13:44:03-07:00 New Revision: c911cc6c49394909a335c8d7baffcfd8bdcc424b URL: https://github.com/llvm/llvm-project/commit/c911cc6c49394909a335c8d7baffcfd8bdcc424b DIFF:

[Lldb-commits] [PATCH] D77241: update eArgTypeScriptLang description to mention lua

emaste created this revision. emaste added a reviewer: JDevlieghere. `--script-language python` and `--script-language lua` are now valid I went with lowercase to match the args https://reviews.llvm.org/D77241 Files: lldb/source/Interpreter/CommandObject.cpp Index:

[Lldb-commits] [PATCH] D77107: [intel-pt] Implement a basic test case

This revision was automatically updated to reflect the committed changes. Closed by commit rGf1242ec54306: [intel-pt] Implement a basic test case (authored by Walter Erquinigo wall...@fb.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77107/new/

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

emrekultursay updated this revision to Diff 254292. emrekultursay added a comment. Fix missing use of GetLastFile Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76806/new/ https://reviews.llvm.org/D76806 Files:

[Lldb-commits] [PATCH] D77186: [source maps] Ensure all valid source maps are added instead of failing with the first invalid one

MaskRay added a comment. In D77186#1955451 , @wallace wrote: > address comments @wallace labath made comments after the differential had been approved. So it looks like he may have further questions. It was probably better waiting for an explicit ack

[Lldb-commits] [lldb] 8ba8a4a - Revert "[intel-pt] Implement a basic test case"

Author: Walter Erquinigo Date: 2020-04-01T13:27:30-07:00 New Revision: 8ba8a4a14d417abd4a104c0f8b5ec289ed0a1b16 URL: https://github.com/llvm/llvm-project/commit/8ba8a4a14d417abd4a104c0f8b5ec289ed0a1b16 DIFF:

[Lldb-commits] [lldb] f1242ec - [intel-pt] Implement a basic test case

Author: Walter Erquinigo Date: 2020-04-01T13:19:15-07:00 New Revision: f1242ec54306c5fbdc9a907e936be899a0ad21ee URL: https://github.com/llvm/llvm-project/commit/f1242ec54306c5fbdc9a907e936be899a0ad21ee DIFF:

[Lldb-commits] [PATCH] D77186: [source maps] Ensure all valid source maps are added instead of failing with the first invalid one

This revision was automatically updated to reflect the committed changes. Closed by commit rG30350c254106: [source maps] Ensure all valid source maps are added instead of failing with… (authored by Walter Erquinigo walterme...@fb.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] 30350c2 - [source maps] Ensure all valid source maps are added instead of failing with the first invalid one

Author: Walter Erquinigo Date: 2020-04-01T13:01:40-07:00 New Revision: 30350c254106ce25b16b13f05e713ceb2b15ce09 URL: https://github.com/llvm/llvm-project/commit/30350c254106ce25b16b13f05e713ceb2b15ce09 DIFF:

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace updated this revision to Diff 254280. wallace marked 2 inline comments as done. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76968/new/ https://reviews.llvm.org/D76968 Files:

[Lldb-commits] [PATCH] D77186: [source maps] Ensure all valid source maps are added instead of failing with the first invalid one

wallace updated this revision to Diff 254268. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77186/new/ https://reviews.llvm.org/D77186 Files: lldb/source/Interpreter/OptionValuePathMappings.cpp

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

jingham accepted this revision. jingham added a comment. There was one missing use of GetLastFile (as opposed to doing it by hand.) Getting the default file is not used in any performance critical way that I'm aware of. It's mostly used for "break set -l" with no "-f" and list with no

[Lldb-commits] [PATCH] D77186: [source maps] Ensure all valid source maps are added instead of failing with the first invalid one

wallace marked 4 inline comments as done. wallace added inline comments. Comment at: lldb/source/Interpreter/OptionValuePathMappings.cpp:73 changed = true; +idx++; } else { labath wrote: > does this actually change anything?

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

emrekultursay updated this revision to Diff 254241. emrekultursay marked an inline comment as done. emrekultursay added a comment. use assertGreater instead of assertTrue(x>y) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76806/new/

[Lldb-commits] [PATCH] D77107: [intel-pt] Implement a basic test case

wallace marked an inline comment as done. wallace added inline comments. Comment at: lldb/test/API/tools/intel-features/intel-pt/test/main.cpp:2-8 + + Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. + See https://llvm.org/LICENSE.txt

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

ikudrin updated this revision to Diff 254207. ikudrin marked an inline comment as done. ikudrin added a comment. Thanks, @jhenderson, @labath! - Added a helper function `isKnownV5SectionID()`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75929/new/ https://reviews.llvm.org/D75929

[Lldb-commits] [PATCH] D77108: [lldb/DWARF] Fix evaluator crash when accessing empty stack

djtodoro added a comment. In D77108#1952818 , @aprantl wrote: > For the future, a clean solution would be extending the macros in Dwarf.def > to list the stack effects in the definitions of the DW_OP_*, for example > > // opcode, name, version, vendor,

[Lldb-commits] [PATCH] D77044: Extend max register size to accommodate AArch64 SVE vector regs

labath added a comment. Sounds fairly noncontroversial. I don't think we have too many of these objects floating around, but if it turns out we do, we could switch to a SmallVector to optimize for the common case of smaller registers. Comment at:

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and ptrace support

labath added a comment. > There is no physical hardware currently available to test SVE and we make use > of QEMU for the purpose of testing this feature. Are these registers presented in core files in any way? Would it be possible to at least test the `RegisterInfoPOSIX_arm64.h` changes that

[Lldb-commits] [PATCH] D72251: [RFC] Support SVE registers access on AArch64 Linux

labath added a comment. Thanks for splitting this up. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72251/new/ https://reviews.llvm.org/D72251 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D77045: Add invalidate list to primary regs in arm64 register infos

labath added a comment. This sounds like it could use a test case. Comment at: lldb/source/Plugins/Process/Utility/RegisterInfos_arm64.h:593-594 +#define STRINGIZE2(x) #x +#define STRINGIZE(x) STRINGIZE2(x) + What's up with the indirection? CHANGES SINCE

[Lldb-commits] [PATCH] D77043: Fix process gdb-remote usage of value_regs/invalidate_regs

labath added a reviewer: jasonmolenda. labath added a comment. I am still thinking this over, but for now I have two comments. First, could you re-upload the diff with full context (e.g. `git show -U`). That would make it a lot easier to review this. Second, would it be possible to change

[Lldb-commits] [PATCH] D73206: Pass `CompileUnit *` along `DWARFDIE` for DWZ

labath added a comment. The internal representation of DebugNames and Apple indexes is fixed by the relevant (pseudo-)standards, so we can't really change it. The question is how to efficiently (and cleanly) convert from the internal representation to some common thing. The conversion from

[Lldb-commits] [lldb] c9d1588 - Silent failing TestWatchpointCount.py aarch64/linux

Author: Muhammad Omair Javaid Date: 2020-04-01T16:31:37+05:00 New Revision: c9d15880542ef483470ee33dbd055b68396d4537 URL: https://github.com/llvm/llvm-project/commit/c9d15880542ef483470ee33dbd055b68396d4537 DIFF:

[Lldb-commits] [PATCH] D72251: [RFC] Support SVE registers access on AArch64 Linux

omjavaid abandoned this revision. omjavaid added a comment. Herald added a subscriber: danielkiss. Abandoned in favor of following patches and more to come as suggested by labath in separate patches. https://reviews.llvm.org/D77047 https://reviews.llvm.org/D77045

[Lldb-commits] [lldb] 9beba42 - [lldb][NFC] Modernize TestExprChar

Author: Raphael Isemann Date: 2020-04-01T13:24:21+02:00 New Revision: 9beba4245a77ae75db874146036b77fb76398e4c URL: https://github.com/llvm/llvm-project/commit/9beba4245a77ae75db874146036b77fb76398e4c DIFF:

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

jhenderson accepted this revision. jhenderson added a comment. Nothing else from me, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75929/new/ https://reviews.llvm.org/D75929 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks for doing this. This looks fine to me. @dblaikie, @jhenderson, do you have any additional comments? Comment at: llvm/lib/DebugInfo/DWARF/DWARFUnitIndex.cpp:38-39 +

[Lldb-commits] [PATCH] D76806: Remove m_last_file_sp from SourceManager

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I think this is fine now. Jim, do you have any more thoughts on this patchset? Comment at: lldb/test/API/commands/settings/use_source_cache/TestUseSourceCache.py:40 +

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

labath added a comment. In D75750#1953924 , @clayborg wrote: > The main issue is that the symbol vendors currently are ELF, macOS and WASM. > Right now we have one SymbolVendor for a triple, but I can see a SymbolVendor > wanting to use multiple symbol

[Lldb-commits] [PATCH] D77123: [lldb] Inherit host environment when running shell commands

This revision was automatically updated to reflect the committed changes. Closed by commit rG0ec88d031ad5: [lldb] Inherit host environment when running shell commands (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77123/new/

[Lldb-commits] [PATCH] D77000: [LLDB] [PECOFF] Only use PECallFrameInfo on the one supported architecture

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa786b881fc8: [lldb] [PECOFF] Only use PECallFrameInfo on the one supported architecture (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D75488: Preserve the owning module information from DWARF in the synthesized AST

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Ok, no more complaints from my side. LGTM Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:1256 + name, + parent_desc ?

[Lldb-commits] [PATCH] D77107: [intel-pt] Implement a basic test case

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/API/tools/intel-features/intel-pt/test/TestIntelPTSimpleBinary.py:50-54 +"rand", # We expect to see a reference to the rand

[Lldb-commits] [lldb] aa786b8 - [lldb] [PECOFF] Only use PECallFrameInfo on the one supported architecture

Author: Martin Storsjö Date: 2020-04-01T12:39:21+03:00 New Revision: aa786b881fc89a2a9883bff77912f2053126f95b URL: https://github.com/llvm/llvm-project/commit/aa786b881fc89a2a9883bff77912f2053126f95b DIFF:

[Lldb-commits] [lldb] 0ec88d0 - [lldb] Inherit host environment when running shell commands

Author: Pavel Labath Date: 2020-04-01T11:20:13+02:00 New Revision: 0ec88d031ad5abcd78068a8377494ec84ea6a1e1 URL: https://github.com/llvm/llvm-project/commit/0ec88d031ad5abcd78068a8377494ec84ea6a1e1 DIFF: https://github.com/llvm/llvm-project/commit/0ec88d031ad5abcd78068a8377494ec84ea6a1e1.diff

[Lldb-commits] [PATCH] D77186: [source maps] Ensure all valid source maps are added instead of failing with the first invalid one

labath added a comment. It seems somewhat odd for a command to return error (one of the effects of that for instance is to abort processing of batch scripts), but still perform some changes. It might be more appropriate to call those warnings. However, reporting warnings from here would

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. Thanks for the updates and for writing the test. The code looks fine to me, the "request changes" is for making sure the test follows best practices and is portable.

[Lldb-commits] [PATCH] D76471: Remap the target SDK directory to the host SDK directory

labath added a comment. I don't think that spreading this out over host and platform is convoluted. In fact, I was going to propose something like that myself. However, it does bring us back to the question of the "linux" sdk. A couple of comments ago you said: > The "Linux" SDK is a

[Lldb-commits] [lldb] 48a5bda - [lldb][NFC] Modernize TestXValuePrinting

Author: Raphael Isemann Date: 2020-04-01T10:20:52+02:00 New Revision: 48a5bdafba5e51244de627a50574d48c87a5249d URL: https://github.com/llvm/llvm-project/commit/48a5bdafba5e51244de627a50574d48c87a5249d DIFF:

[Lldb-commits] [lldb] edb0efc - [lldb][NFC] Modernize call-function tests

Author: Raphael Isemann Date: 2020-04-01T10:17:42+02:00 New Revision: edb0efca1e73ec5f791d9fe8c28f7c4c85a61c43 URL: https://github.com/llvm/llvm-project/commit/edb0efca1e73ec5f791d9fe8c28f7c4c85a61c43 DIFF:

[Lldb-commits] [lldb] fa1b602 - [lldb][NFC] Modernize TestCallUserAnonTypedef

Author: Raphael Isemann Date: 2020-04-01T10:06:59+02:00 New Revision: fa1b602ee6c3bd3dc245cbafe7534be5381e71e7 URL: https://github.com/llvm/llvm-project/commit/fa1b602ee6c3bd3dc245cbafe7534be5381e71e7 DIFF:

[Lldb-commits] [PATCH] D77197: [lldb] Allow expect_expr without a running target

This revision was automatically updated to reflect the committed changes. Closed by commit rG15f34ff2d897: [lldb] Allow expect_expr without a running target (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 15f34ff - [lldb] Allow expect_expr without a running target

Author: Raphael Isemann Date: 2020-04-01T09:39:24+02:00 New Revision: 15f34ff2d8976f9211c6112531355ed5e2a92ea0 URL: https://github.com/llvm/llvm-project/commit/15f34ff2d8976f9211c6112531355ed5e2a92ea0 DIFF:

[Lldb-commits] [PATCH] D77153: [lldb/DataFormatters] Display null C++ pointers as nullptr

labath added a comment. In D77153#1952952 , @friss wrote: > I haven't tested the libstdc++ part, would be great if someone could confirm > this works. This doesn't work work for libstdc++ (I get ``), presumably because the code uses the simple

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

jankratochvil added a comment. In D75750#1954086 , @clayborg wrote: > Another idea for the SymbolServers: be able to specify a source repository > (git, svn etc) and hash or revision ID. The symbol server can grab the source > from the repo and cache is

[Lldb-commits] [PATCH] D76964: Fix an issue where the IgnoreName function was not allowing "Class" to be looked up inside a namespace or other class.

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. LGTM minus some stylistic changes. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp:582 +static const ConstString

[Lldb-commits] [PATCH] D77153: [lldb/DataFormatters] Display null C++ pointers as nullptr

labath added a comment. It might be worth mentioning though that the title of the patch is somewhat misleading -- I believe the `CXX` in `CXXFunctionSummaryFormat` refers to the language the formatter is implemented in, not the language of the type itself. So this patch affects all types whose

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

clayborg added a comment. Another idea for the SymbolServers: be able to specify a source repository (git, svn etc) and hash or revision ID. The symbol server can grab the source from the repo and cache is locally for display. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION