[Lldb-commits] [lldb] 9206322 - [lldb/CMake] Fix typo that prevented regenerating the bindings

Author: Jonas Devlieghere Date: 2020-05-29T23:51:22-07:00 New Revision: 92063228f85bfe22a6dfe20bf01c99ffe6ff3130 URL: https://github.com/llvm/llvm-project/commit/92063228f85bfe22a6dfe20bf01c99ffe6ff3130 DIFF: https://github.com/llvm/llvm-project/commit/92063228f85bfe22a6dfe20bf01c99ffe6ff3130.d

[Lldb-commits] [lldb] 2388a09 - [lldb/Test] use GetLoadAddress from scripted thread plan

Author: Jonas Devlieghere Date: 2020-05-29T23:04:08-07:00 New Revision: 2388a096e7865c043e83ece4e26654bd3d1a20d5 URL: https://github.com/llvm/llvm-project/commit/2388a096e7865c043e83ece4e26654bd3d1a20d5 DIFF: https://github.com/llvm/llvm-project/commit/2388a096e7865c043e83ece4e26654bd3d1a20d5.d

[Lldb-commits] [PATCH] D80848: [lldb/Bindings] Raise a Runtime error when using SBAddress properties that rely on lldb.target

This revision was automatically updated to reflect the committed changes. Closed by commit rG0800529fe605: [lldb/Bindings] Raise exception when using properties that rely on lldb.target (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D

[Lldb-commits] [lldb] 0800529 - [lldb/Bindings] Raise exception when using properties that rely on lldb.target

Author: Jonas Devlieghere Date: 2020-05-29T22:11:21-07:00 New Revision: 0800529fe605a03e9da1aca241a377eebcaa8cad URL: https://github.com/llvm/llvm-project/commit/0800529fe605a03e9da1aca241a377eebcaa8cad DIFF: https://github.com/llvm/llvm-project/commit/0800529fe605a03e9da1aca241a377eebcaa8cad.d

[Lldb-commits] [PATCH] D80848: [lldb/Bindings] Raise a Runtime error when using SBAddress properties that rely on lldb.target

jingham added a comment. Looks even better. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80848/new/ https://reviews.llvm.org/D80848 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/l

[Lldb-commits] [PATCH] D80848: [lldb/Bindings] Raise a Runtime error when using SBAddress properties that rely on lldb.target

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/test/Shell/ScriptInterpreter/Python/Inputs/sbaddress.py:4 +def test(debugger, command, result, internal_dict): +print(int(lldb.SBAddress())) +return int(lldb.SBAddress()) -

[Lldb-commits] [PATCH] D80848: [lldb/Bindings] Raise a Runtime error when using SBAddress properties that rely on lldb.target

jingham added a comment. Ooh, test would be good. Just use it in a python command. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80848/new/ https://reviews.llvm.org/D80848 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://l

[Lldb-commits] [PATCH] D80848: [lldb/Bindings] Raise a Runtime error when using SBAddress properties that rely on lldb.target

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. I think "This resolves the SBAddress" is better than "This resolves SBAddress". Other than that LGTM. It would be convenient if you could reuse the _runtime_err_str in the doc strings, but

[Lldb-commits] [PATCH] D80848: [lldb/Bindings] Raise a Runtime error when using SBAddress properties that rely on lldb.target

JDevlieghere updated this revision to Diff 267393. JDevlieghere added a comment. Add test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80848/new/ https://reviews.llvm.org/D80848 Files: lldb/bindings/interface/SBAddress.i lldb/test/Shell/ScriptInterpreter/Python/Inputs/sbaddress.py

[Lldb-commits] [PATCH] D80848: [lldb/Bindings] Raise a Runtime error when using SBAddress properties that rely on lldb.target

JDevlieghere added a comment. Seems like this should be easy enough to test, let me add one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80848/new/ https://reviews.llvm.org/D80848 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D80848: [lldb/Bindings] Raise a Runtime error when using SBAddress properties that rely on lldb.target

JDevlieghere updated this revision to Diff 267386. JDevlieghere added a comment. Explicitly point to `GetLoadAddress` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80848/new/ https://reviews.llvm.org/D80848 Files: lldb/bindings/interface/SBAddress.i Index: lldb/bindings/interface/S

[Lldb-commits] [PATCH] D80848: [lldb/Bindings] Raise a Runtime error when using SBAddress properties that rely on lldb.target

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, jasonmolenda, labath. Several SBAddress properties use the `lldb.target` or `lldb.process` convenience variables which are only set under the interactive script interpreter. Unfortunately, users have been using these prop

[Lldb-commits] [lldb] 8d8f8b3 - [lldb/Test] Don't leak forked processes on Darwin

Author: Jonas Devlieghere Date: 2020-05-29T13:58:12-07:00 New Revision: 8d8f8b353175b50dfdb1e2d5f3c0ada0a4ad25ed URL: https://github.com/llvm/llvm-project/commit/8d8f8b353175b50dfdb1e2d5f3c0ada0a4ad25ed DIFF: https://github.com/llvm/llvm-project/commit/8d8f8b353175b50dfdb1e2d5f3c0ada0a4ad25ed.d

[Lldb-commits] [lldb] e6a404f - [lldb/CMake] Set both the BUILD and INSTALL RPATH on macOS (2/2)

Author: Jonas Devlieghere Date: 2020-05-29T12:22:51-07:00 New Revision: e6a404fbe7270d22541b45d48ca29fea5c3510aa URL: https://github.com/llvm/llvm-project/commit/e6a404fbe7270d22541b45d48ca29fea5c3510aa DIFF: https://github.com/llvm/llvm-project/commit/e6a404fbe7270d22541b45d48ca29fea5c3510aa.d

[Lldb-commits] [PATCH] D78801: [LLDB] Add class WasmProcess for WebAssembly debugging

jingham added a comment. In D78801#2062403 , @labath wrote: > In D78801#2050449 , @paolosev wrote: > > > Hello @clayborg , @labath, > > Any thoughts on this latest patch? :-) > > > Sorry about the delay. I think th

[Lldb-commits] [PATCH] D80519: [lldb/DWARF] Add support for pre-standard GNU call site attributes

vsk added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3740 + if (tail_call) +call_inst_pc = low_pc; + else labath wrote: > vsk wrote: > > I think this needs to be `call_inst_pc = low_pc - 1`, see > > `D

[Lldb-commits] [PATCH] D80755: Support build-ids of other sizes than 16 in UUID::SetFromStringRef

MaskRay added a comment. I haven't been paying close attention to this patch, but allowing 20 bytes makes sense. In GNU ld and gold, `--build-id` is `--build-id=sha1` (20 bytes). The 3 linkers (plus LLD) don't have a way to produce a build ID longer than 20 bytes. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D80659: [lldb-vscode] Redirect stderr and stdout to DAPs console message

aadsm added a comment. Absolutely, I'll look into that first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80659/new/ https://reviews.llvm.org/D80659 ___ lldb-commits mailing list lldb-commits@lists.l

[Lldb-commits] [lldb] c1a3329 - Let @skipUnlessUndefinedBehaviorSanitizer imply @skipIfAsan

Author: Adrian Prantl Date: 2020-05-29T09:45:43-07:00 New Revision: c1a33299768f8404dd7b83a6cfef7c1155786c6a URL: https://github.com/llvm/llvm-project/commit/c1a33299768f8404dd7b83a6cfef7c1155786c6a DIFF: https://github.com/llvm/llvm-project/commit/c1a33299768f8404dd7b83a6cfef7c1155786c6a.diff

[Lldb-commits] [PATCH] D80755: Support build-ids of other sizes than 16 in UUID::SetFromStringRef

jankratochvil added inline comments. Comment at: lldb/source/Utility/UUID.cpp:109 *this = fromData(bytes); -return str.size() - rest.size(); +return str.size(); } Now the return type could be `bool`. CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [lldb] 31a8e27 - Let @skipUnlessThreadSanitizer imply @skipIfAsan

Author: Adrian Prantl Date: 2020-05-29T09:43:58-07:00 New Revision: 31a8e27e1805e039d699afa890702e26a93e0b40 URL: https://github.com/llvm/llvm-project/commit/31a8e27e1805e039d699afa890702e26a93e0b40 DIFF: https://github.com/llvm/llvm-project/commit/31a8e27e1805e039d699afa890702e26a93e0b40.diff

[Lldb-commits] [PATCH] D80807: [lldb/Utility] Fix DecodeUUIDBytesFromString not to access past the input buffer

friss created this revision. friss added a reviewer: labath. Herald added a project: LLDB. friss added a comment. I would have committed this right away if it weren't for the slight change in behavior I wanted to point out. With this patch, if an input string ends with a `-`, it won't be consume

[Lldb-commits] [PATCH] D80807: [lldb/Utility] Fix DecodeUUIDBytesFromString not to access past the input buffer

friss added a comment. I would have committed this right away if it weren't for the slight change in behavior I wanted to point out. With this patch, if an input string ends with a `-`, it won't be consumed anymore. I suppose it doesn't matter. Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [PATCH] D80755: Support build-ids of other sizes than 16 in UUID::SetFromStringRef

jarin updated this revision to Diff 267241. jarin retitled this revision from "Support build-ids of other sizes than 16 in SBTarget::AddModule" to "Support build-ids of other sizes than 16 in UUID::SetFromStringRef". jarin edited the summary of this revision. Herald added subscribers: MaskRay, em

[Lldb-commits] [lldb] 977f001 - [lldb/test] Fix TestAppleSimulatorOSType when multiple runtimes are installed

Author: Fred Riss Date: 2020-05-29T08:30:04-07:00 New Revision: 977f00123a6d94c634d22356cae1da2a22f0e3df URL: https://github.com/llvm/llvm-project/commit/977f00123a6d94c634d22356cae1da2a22f0e3df DIFF: https://github.com/llvm/llvm-project/commit/977f00123a6d94c634d22356cae1da2a22f0e3df.diff LOG

[Lldb-commits] [PATCH] D80519: [lldb/DWARF] Add support for pre-standard GNU call site attributes

labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3740 + if (tail_call) +call_inst_pc = low_pc; + else vsk wrote: > I think this needs to be `call_inst_pc = low_pc - 1`, see > `DwarfCompileUnit::

[Lldb-commits] [PATCH] D80519: [lldb/DWARF] Add support for pre-standard GNU call site attributes

labath updated this revision to Diff 267179. labath marked an inline comment as done. labath added a comment. - add -1 - add -ggdb flavours for inline tail call tests, drop -glldb from the others. The choice is fairly arbitrary. I don't believe we should be doing combinatorial testing at this le

[Lldb-commits] [PATCH] D79586: Do not list adb devices when a device id is given

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ff2de4f0c60: Do not list adb devices when a device id is given (authored by emrekultursay, committed by labath). Changed prior to commit: https://reviews.llvm.org/D79586?vs=262684&id=267152#toc Reposi

[Lldb-commits] [PATCH] D80518: [lldb] Make "inline" tests more configurable

This revision was automatically updated to reflect the committed changes. Closed by commit rG2c22c1473569: [lldb] Make "inline" tests more configurable (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80518/new/ https://reviews.ll

[Lldb-commits] [PATCH] D78801: [LLDB] Add class WasmProcess for WebAssembly debugging

labath added a reviewer: jingham. labath added a comment. In D78801#2050449 , @paolosev wrote: > Hello @clayborg , @labath, > Any thoughts on this latest patch? :-) Sorry about the delay. I think that in terms of the design we've come as far as we can

[Lldb-commits] [lldb] 2c22c14 - [lldb] Make "inline" tests more configurable

Author: Pavel Labath Date: 2020-05-29T11:36:11+02:00 New Revision: 2c22c1473569352efa9326aa165cc451d39da015 URL: https://github.com/llvm/llvm-project/commit/2c22c1473569352efa9326aa165cc451d39da015 DIFF: https://github.com/llvm/llvm-project/commit/2c22c1473569352efa9326aa165cc451d39da015.diff

[Lldb-commits] [lldb] 7ff2de4 - Do not list adb devices when a device id is given

Author: Emre Kultursay Date: 2020-05-29T11:36:11+02:00 New Revision: 7ff2de4f0c60c5d13880440e85ef8edc78482a2f URL: https://github.com/llvm/llvm-project/commit/7ff2de4f0c60c5d13880440e85ef8edc78482a2f DIFF: https://github.com/llvm/llvm-project/commit/7ff2de4f0c60c5d13880440e85ef8edc78482a2f.diff

[Lldb-commits] [lldb] 5f02679 - [lldb][NFC] Remove a std::string->C string->StringRef conversion in ClangUserExpression

Author: Raphael Isemann Date: 2020-05-29T11:19:33+02:00 New Revision: 5f0267984792429d7b9ac574c17566b98527576e URL: https://github.com/llvm/llvm-project/commit/5f0267984792429d7b9ac574c17566b98527576e DIFF: https://github.com/llvm/llvm-project/commit/5f0267984792429d7b9ac574c17566b98527576e.dif

[Lldb-commits] [PATCH] D80659: [lldb-vscode] Redirect stderr and stdout to DAPs console message

labath added a comment. Btw, given that Richard has found some vscode code which already tries to send stderr to the console window https://github.com/microsoft/vscode/blob/master/src/vs/workbench/contrib/debug/node/debugAdapter.ts#L234, it would be good to first understand why doesn't that kic