[Lldb-commits] [PATCH] D80448: [lldb/Test] Add a trace method to replace (commented out) print statements.

mboehme added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80448/new/ https://reviews.llvm.org/D80448 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D80448: [lldb/Test] Add a trace method to replace (commented out) print statements.

aprantl added a comment. nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80448/new/ https://reviews.llvm.org/D80448 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D81119: [lldb] Fix SLEB128 decoding

shafik added a comment. I would also like to see a unit test, unless the DWARF test somehow covers as aspect that a unit test would and even in that case the unit test is still important. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81119/new/

[Lldb-commits] [PATCH] D81119: [lldb] Fix SLEB128 decoding

clayborg added a comment. Seems like it would be easier to add a unit test to lldb/unittests/Utility/DataExtractorTest.cpp. Then you can verify any edge case without having to make DWARF in a .s file? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

jingham added a comment. The one scenario I can think of where this might do the wrong thing is: 1. Hit breakpoint location 1.1 on thread A 2. Switch to thread B 3. Run a function on thread B, has to only run on thread B and has to actually run code in the target, like: (lldb) expr -a 0 --

[Lldb-commits] [PATCH] D80448: [lldb/Test] Add a trace method to replace (commented out) print statements.

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:510 +with recording(self, self.TraceOn()) as sbuf: +print(args, kwargs, file=sbuf) + mboehme wrote:

[Lldb-commits] [lldb] 5fa9c9d - [lldb/Test] Python <3.5 requires **kwargs to come last

Author: Jonas Devlieghere Date: 2020-06-03T14:54:39-07:00 New Revision: 5fa9c9d7f276b44b3da949382e0d0b5dbfd0ac8b URL: https://github.com/llvm/llvm-project/commit/5fa9c9d7f276b44b3da949382e0d0b5dbfd0ac8b DIFF:

[Lldb-commits] [lldb] 9caa34a - [lldb/Test] Remove un(used|needed|maintained) files from lldbsuite.

Author: Jonas Devlieghere Date: 2020-06-03T14:54:39-07:00 New Revision: 9caa34a24cb7d20a129143281cc0e1b2f44bd95c URL: https://github.com/llvm/llvm-project/commit/9caa34a24cb7d20a129143281cc0e1b2f44bd95c DIFF:

[Lldb-commits] [lldb] f4d4273 - Add a test for preserving state on the non-expr thread across expression evaluation.

Author: Jim Ingham Date: 2020-06-03T14:30:35-07:00 New Revision: f4d427326539f007b05378eaf66018c10b651ad0 URL: https://github.com/llvm/llvm-project/commit/f4d427326539f007b05378eaf66018c10b651ad0 DIFF: https://github.com/llvm/llvm-project/commit/f4d427326539f007b05378eaf66018c10b651ad0.diff

[Lldb-commits] [PATCH] D81119: [lldb] Fix SLEB128 decoding

davide added a comment. Greg & Pavel might have opinions on this patch. I'm not qualified to review it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81119/new/ https://reviews.llvm.org/D81119 ___

[Lldb-commits] [PATCH] D81119: [lldb] Fix SLEB128 decoding

jankratochvil created this revision. jankratochvil added reviewers: dblaikie, davide. jankratochvil added a project: LLDB. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. jankratochvil retitled this revision from "Fix SLEB128 decoding" to "[lldb] Fix SLEB128 decoding".

[Lldb-commits] [lldb] 7c1b060 - [IRInterpreter] Unused. Drive-by cleanup. NFCI.

Author: Davide Italiano Date: 2020-06-03T13:31:58-07:00 New Revision: 7c1b060c3c65cac50edec5cceb6653957c344d96 URL: https://github.com/llvm/llvm-project/commit/7c1b060c3c65cac50edec5cceb6653957c344d96 DIFF:

[Lldb-commits] [lldb] a23d0a0 - [lldb][NFC] Fix documentation formatting in ASTResultSynthesizer

Author: Raphael Isemann Date: 2020-06-03T21:34:23+02:00 New Revision: a23d0a06d4b7996a86c3d1a7e47a4e56d6181b10 URL: https://github.com/llvm/llvm-project/commit/a23d0a06d4b7996a86c3d1a7e47a4e56d6181b10 DIFF:

[Lldb-commits] [lldb] 7822b8a - [lldb/StringPrinter] Convert DecodedCharBuffer to a class, NFC

Author: Vedant Kumar Date: 2020-06-03T12:24:23-07:00 New Revision: 7822b8a817d85827110f3047f4ec63f6825743a4 URL: https://github.com/llvm/llvm-project/commit/7822b8a817d85827110f3047f4ec63f6825743a4 DIFF: https://github.com/llvm/llvm-project/commit/7822b8a817d85827110f3047f4ec63f6825743a4.diff

[Lldb-commits] [lldb] 4699a7e - [lldb/StringPrinter] Support strings with invalid utf8 sub-sequences

Author: Vedant Kumar Date: 2020-06-03T12:24:23-07:00 New Revision: 4699a7e23010b7c0df49b64f8bea63919825a787 URL: https://github.com/llvm/llvm-project/commit/4699a7e23010b7c0df49b64f8bea63919825a787 DIFF: https://github.com/llvm/llvm-project/commit/4699a7e23010b7c0df49b64f8bea63919825a787.diff

[Lldb-commits] [PATCH] D81058: [lldb/Interpreter] Color "error:" and "warning:" in the CommandReturnObject output.

JDevlieghere updated this revision to Diff 268258. JDevlieghere added a comment. Rebase on top of parent patches. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81058/new/ https://reviews.llvm.org/D81058 Files: lldb/include/lldb/Interpreter/CommandReturnObject.h

[Lldb-commits] [PATCH] D81010: [lldb/DWARF] Fix PC value for artificial tail call frames for the "GNU" case

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Lgtm. Comment at: lldb/source/Symbol/Function.cpp:321 llvm::ArrayRef> Function::GetTailCallingEdges() { // Call edges are sorted by return PC, and tail calling edges have

[Lldb-commits] [PATCH] D81032: [lldb/Test] Don't print 'command invoked'

This revision was automatically updated to reflect the committed changes. Closed by commit rG96e7d19a1f22: [lldb/Test] Dont print command invoked (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81032/new/

[Lldb-commits] [PATCH] D81058: [lldb/Interpreter] Color "error:" and "warning:" in the CommandReturnObject output.

amccarth added a comment. I'm just responding to the questions @labath raised without really looking at the details of the code. I agree that there's nothing wrong with having the ability to output color codes to a file, but it's a surprising default and experience tells me it would break a

[Lldb-commits] [lldb] 96e7d19 - [lldb/Test] Don't print 'command invoked'

Author: Jonas Devlieghere Date: 2020-06-03T09:35:09-07:00 New Revision: 96e7d19a1f22f5d2018377b70b4c98e0f59ea412 URL: https://github.com/llvm/llvm-project/commit/96e7d19a1f22f5d2018377b70b4c98e0f59ea412 DIFF:

[Lldb-commits] [PATCH] D80995: [Scalar] Fix assignment operator for long long.

This revision was automatically updated to reflect the committed changes. Closed by commit rG798644e0a452: [Scalar] Fix assignment operator for long long. (authored by werat, committed by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] a48c76c - [lldb/cmake] Tweak descriptions of swig rules

Author: Pavel Labath Date: 2020-06-03T13:26:25+02:00 New Revision: a48c76cf43806c30bab5e8eacd5a08058c83c578 URL: https://github.com/llvm/llvm-project/commit/a48c76cf43806c30bab5e8eacd5a08058c83c578 DIFF: https://github.com/llvm/llvm-project/commit/a48c76cf43806c30bab5e8eacd5a08058c83c578.diff

[Lldb-commits] [lldb] 798644e - [Scalar] Fix assignment operator for long long.

Author: Andy Yankovsky Date: 2020-06-03T13:26:25+02:00 New Revision: 798644e0a4524e73e1f95202951f10f2086217c3 URL: https://github.com/llvm/llvm-project/commit/798644e0a4524e73e1f95202951f10f2086217c3 DIFF:

Re: [Lldb-commits] [lldb] cbfae97 - [LLDB] Mark TestCreateDuringInstructionStep as flaky on Linux

On Tue, 2 Jun 2020 at 14:36, Pavel Labath wrote: > On 02/06/2020 11:10, Muhammad Omair Javaid via lldb-commits wrote: > > > > Author: Muhammad Omair Javaid > > Date: 2020-06-02T14:08:28+05:00 > > New Revision: cbfae97ca82b11ab2b54562055c49817baa1e26b > > > > URL: >

[Lldb-commits] [lldb] 884aaf7 - [LLDB] skip TestCreateDuringInstructionStep on arm/linux

Author: Muhammad Omair Javaid Date: 2020-06-03T16:18:41+05:00 New Revision: 884aaf7f645a27239923e21112c9817836c696df URL: https://github.com/llvm/llvm-project/commit/884aaf7f645a27239923e21112c9817836c696df DIFF:

[Lldb-commits] [lldb] c0ccb58 - [lldb] Pass fewer parameters by non-const reference to DWARFASTParserClang::ParseSingleMember

Author: Raphael Isemann Date: 2020-06-03T12:42:09+02:00 New Revision: c0ccb582c35f29df55ccc421dd5d03a7220456cf URL: https://github.com/llvm/llvm-project/commit/c0ccb582c35f29df55ccc421dd5d03a7220456cf DIFF:

[Lldb-commits] [PATCH] D81010: [lldb/DWARF] Fix PC value for artificial tail call frames for the "GNU" case

labath updated this revision to Diff 268102. labath added a comment. - Unpack the CallEdge structure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81010/new/ https://reviews.llvm.org/D81010 Files: lldb/include/lldb/Symbol/Function.h

[Lldb-commits] [PATCH] D81058: [lldb/Interpreter] Color "error:" and "warning:" in the CommandReturnObject output.

teemperor added inline comments. Comment at: lldb/include/lldb/Utility/Stream.h:417 +write(colorcode, len); + } + return *this; teemperor wrote: > Nit: This can all be `PutCString(colorcode)` (which handles the nullptr check > and the strlen).

[Lldb-commits] [PATCH] D81010: [lldb/DWARF] Fix PC value for artificial tail call frames for the "GNU" case

labath marked an inline comment as done. labath added inline comments. Comment at: lldb/include/lldb/Symbol/Function.h:332 - /// The address of the call instruction. Usually an invalid address, unless - /// this is a tail call. - lldb::addr_t call_inst_pc; + bool

[Lldb-commits] [PATCH] D81058: [lldb/Interpreter] Color "error:" and "warning:" in the CommandReturnObject output.

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. Let's talk about this more. I don't think we should cargo-cult code from llvm, especially when the cargo-culting won't actually work for the given use case. On windows, the

[Lldb-commits] [PATCH] D81058: [lldb/Interpreter] Color "error:" and "warning:" in the CommandReturnObject output.

labath added a reviewer: amccarth. labath added a comment. I'm wondering if it would be possible/acceptable to move the color-related code from `llvm::raw_fd_ostream` (where the `RawOstreamForward` code is copied from) into the `raw_ostream` base class (except that it would default to false, of

[Lldb-commits] [PATCH] D81058: [lldb/Interpreter] Color "error:" and "warning:" in the CommandReturnObject output.

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. That was also on my list but it seems you beat me to it. I couldn't resist some smaller nit-picks but otherwise this LGTM beside that. Comment at:

[Lldb-commits] [PATCH] D81032: [lldb/Test] Don't print 'command invoked'

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Your patches continue to bring me joy and happiness. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81032/new/ https://reviews.llvm.org/D81032

[Lldb-commits] [PATCH] D81058: [lldb/Interpreter] Color "error:" and "warning:" in the CommandReturnObject output.

JDevlieghere created this revision. JDevlieghere added reviewers: LLDB, labath, teemperor, clayborg. JDevlieghere added a project: LLDB. Herald added a subscriber: abidh. JDevlieghere added a parent revision: D81056: [Support] Replace 'DisableColors' boolean with 'ColorMode' enum. JDevlieghere

Re: [Lldb-commits] [lldb] 4c53d48 - [lldb/Test] Don't use the env to pass around configuration variables (NFC)

Woohoo! On 03/06/2020 01:50, Jonas Devlieghere via lldb-commits wrote: > > Author: Jonas Devlieghere > Date: 2020-06-02T16:49:58-07:00 > New Revision: 4c53d4801cbbb1b573e4ef758f93ead12e1f59a2 > > URL: > https://github.com/llvm/llvm-project/commit/4c53d4801cbbb1b573e4ef758f93ead12e1f59a2 >

[Lldb-commits] [PATCH] D80448: [lldb/Test] Add a trace method to replace (commented out) print statements.

mboehme added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:510 +with recording(self, self.TraceOn()) as sbuf: +print(args, kwargs, file=sbuf) + labath wrote: > JDevlieghere wrote: > > This should be > > ``` >