[Lldb-commits] [PATCH] D81783: [lldb] Remove indentation before help output.

JDevlieghere updated this revision to Diff 270564. JDevlieghere added a comment. Explicit `llvm::StringRef` -> `std::string` conversion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81783/new/ https://reviews.llvm.org/D81783 Files: lldb/source/Interpreter/CommandObject.cpp Index:

[Lldb-commits] [PATCH] D81783: [lldb] Remove indentation before help output.

JDevlieghere created this revision. JDevlieghere added reviewers: LLDB, jingham, labath, clayborg. JDevlieghere updated this revision to Diff 270564. JDevlieghere added a comment. Explicit `llvm::StringRef` -> `std::string` conversion. I always found it weird that there was this level of

[Lldb-commits] [lldb] ff058e7 - [lldb] Remove unnecessary c_str() in OutputFormattedHelpText calls (NFC)

Author: Jonas Devlieghere Date: 2020-06-12T21:13:21-07:00 New Revision: ff058e7331afb16108a8f888dff671ae0240268f URL: https://github.com/llvm/llvm-project/commit/ff058e7331afb16108a8f888dff671ae0240268f DIFF:

[Lldb-commits] [lldb] 58e34ed - [lldb] Small improvements in ValueObjectPrinter::PrintDecl (NFC)

Author: Jonas Devlieghere Date: 2020-06-12T21:05:05-07:00 New Revision: 58e34ede5bf741cfc47b3ebd573ae7dfdf9e9c02 URL: https://github.com/llvm/llvm-project/commit/58e34ede5bf741cfc47b3ebd573ae7dfdf9e9c02 DIFF:

[Lldb-commits] [PATCH] D81697: Add support for batch-testing to the LLDB testsuite.

bbli added a comment. - Ohh ok, guess I should have gotten the point about catching all exceptions recursively clarified before I began. - From looking at the code for `subTest`, the error catching functionality comes from `Outcome_object.testPartExecutor` context manager, and the rest seems

[Lldb-commits] [PATCH] D81612: [lldb/Test] Assert that no targets or global modules remain after a test completes.

This revision was automatically updated to reflect the committed changes. Closed by commit rGda601ea731ec: [lldb/Test] Assert that no targets or modules remain after a test completes. (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] da601ea - [lldb/Test] Assert that no targets or modules remain after a test completes.

Author: Jonas Devlieghere Date: 2020-06-12T15:17:44-07:00 New Revision: da601ea731ece45d8e4d283942f90dce5b2d386a URL: https://github.com/llvm/llvm-project/commit/da601ea731ece45d8e4d283942f90dce5b2d386a DIFF:

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum added a comment. In D80112#2090767 , @JDevlieghere wrote: > In D80112#2090723 , @fallkrum wrote: > > > Guys help me figure out what may be wrong. Executed below listed command > > and can't find my newly

[Lldb-commits] [lldb] 8f9eb70 - [lldb/Test] Fix unit test suffixes and add a CMake error.

Author: Jonas Devlieghere Date: 2020-06-12T14:18:27-07:00 New Revision: 8f9eb7035344715194d73272b2f15205ea362f58 URL: https://github.com/llvm/llvm-project/commit/8f9eb7035344715194d73272b2f15205ea362f58 DIFF:

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

JDevlieghere added a comment. In D80112#2090723 , @fallkrum wrote: > Guys help me figure out what may be wrong. Executed below listed command and > can't find my newly added unit tests ThreadTest, ProcessEventDataTest. Fixed in

[Lldb-commits] [PATCH] D81612: [lldb/Test] Assert that no targets or global modules remain after a test completes.

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Lgtm. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81612/new/ https://reviews.llvm.org/D81612 ___ lldb-commits mailing list

[Lldb-commits] [lldb] bfea1df - [lldb/Test] Fix unittest name

Author: Jonas Devlieghere Date: 2020-06-12T14:01:14-07:00 New Revision: bfea1df9f01393bac6d2ce6a45d3b764b01e9e9e URL: https://github.com/llvm/llvm-project/commit/bfea1df9f01393bac6d2ce6a45d3b764b01e9e9e DIFF:

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum added a comment. Guys help me figure out what may be wrong. Executed below listed command and can't find my newly added unit tests ThreadTest, ProcessEventDataTest. Ilyas-Mac-mini:Ninja ilya$ ./bin/llvm-lit --show-tests -sv ../../lldb/test/Unit -- Available Tests -- lldb-unit

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

gedatsu217 updated this revision to Diff 270454. gedatsu217 added a comment. I updated my codes according to your advice: Add if(GetUseAutosuggestion()) in IOHandlerSuggestion in IOHandler.cpp. (Is this not enough?) Add more keybinds for TypedCharacter. Return llvm::Optional in HandleSuggestion

[Lldb-commits] [PATCH] D81589: [lldb/SymbolFile] Don't parse the whole line table for the support files

This revision was automatically updated to reflect the committed changes. Closed by commit rG2b34632a5771: [lldb/SymbolFile] Dont parse the whole line table for the support files (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] 2b34632 - [lldb/SymbolFile] Don't parse the whole line table for the support files

Author: Jonas Devlieghere Date: 2020-06-12T09:39:17-07:00 New Revision: 2b34632a5771488ea62a30fdfcfc9d45060a7389 URL: https://github.com/llvm/llvm-project/commit/2b34632a5771488ea62a30fdfcfc9d45060a7389 DIFF:

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

gedatsu217 added inline comments. Comment at: lldb/source/Host/common/Editline.cpp:1244 +llvm::StringRef indent_chars = +"abcdefghijklmnopqrstuvwxzyABCDEFGHIJKLMNOPQRSTUVWXZY1234567890 "; +for (char c : indent_chars) { teemperor wrote: >

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

gedatsu217 added inline comments. Comment at: lldb/source/Core/Debugger.cpp:349 +bool Debugger::GetUseAutosuggestion() const { + const uint32_t idx = ePropertyShowAutosuggestion; teemperor wrote: > You declared the function, but you don't use it anywhere. You

[Lldb-commits] [lldb] a8c7555 - [lldb] Test creating persistent variables with $[digit] names

Author: Raphael Isemann Date: 2020-06-12T16:12:33+02:00 New Revision: a8c755545b0c4ace9a5fff55dc56258204a6b69d URL: https://github.com/llvm/llvm-project/commit/a8c755545b0c4ace9a5fff55dc56258204a6b69d DIFF:

[Lldb-commits] [lldb] f52e412 - [lldb][NFC] Modernize TestPersistentVariables

Author: Raphael Isemann Date: 2020-06-12T16:06:05+02:00 New Revision: f52e4129a7c748421543d6572806dfec2407bbd3 URL: https://github.com/llvm/llvm-project/commit/f52e4129a7c748421543d6572806dfec2407bbd3 DIFF:

[Lldb-commits] [PATCH] D81697: Add support for batch-testing to the LLDB testsuite.

labath added a comment. it looks like the official python unittest framework has grown support of a subtest feature, which seems to be very similar to what we want here. It may make more sense to update to a newer framework rather than

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

labath added inline comments. Comment at: lldb/source/Host/common/Editline.cpp:1051-1052 +unsigned char Editline::TypedCharacter(int ch) { + std::string typed = std::string(1, ch); + typed = typed[0]; + el_insertstr(m_editline, typed.c_str()); the second line

[Lldb-commits] [PATCH] D81200: [vscode] set default values for terminateDebuggee for the disconnect request

labath added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/disconnect/TestVSCode_disconnect.py:68 + +self.disconnect_and_check_no_output() labath wrote: > I'm confused as to why we're not expecting any output here. I was under the >

[Lldb-commits] [PATCH] D81654: [lldb] Don't print IRForTarget errors directly to the console

This revision was automatically updated to reflect the committed changes. Closed by commit rG91728b9172bf: [lldb] Dont print IRForTarget errors directly to the console (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D81589: [lldb/SymbolFile] Don't parse the whole line table for the support files

labath added a subscriber: teemperor. labath accepted this revision. labath added a comment. If this didn't show up on the lldb benchmark charts (https://teemperor.de/lldb-bench/static.html), it would be nice to add a benchmark for this. What exactly were you measuring here?

[Lldb-commits] [lldb] 91728b9 - [lldb] Don't print IRForTarget errors directly to the console

Author: Raphael Isemann Date: 2020-06-12T10:27:25+02:00 New Revision: 91728b9172bfd2a2eccc9dc2ef3462f931579aff URL: https://github.com/llvm/llvm-project/commit/91728b9172bfd2a2eccc9dc2ef3462f931579aff DIFF: