[Lldb-commits] [lldb] d6a5cce - [lldb/Test] Fix skipTestIfFn for fucntions that return a value

Author: Jonas Devlieghere Date: 2020-08-03T19:56:12-07:00 New Revision: d6a5cce0e7d65562f081569a61595e53cdb8d5d0 URL: https://github.com/llvm/llvm-project/commit/d6a5cce0e7d65562f081569a61595e53cdb8d5d0 DIFF:

[Lldb-commits] [lldb] a06c28d - Temporarily revert "[test] Exit with an error if no tests are run."

Author: Jordan Rupprecht Date: 2020-08-03T18:37:50-07:00 New Revision: a06c28df3e8c85ceb665d3d9a1ebc2853dfd87a9 URL: https://github.com/llvm/llvm-project/commit/a06c28df3e8c85ceb665d3d9a1ebc2853dfd87a9 DIFF:

[Lldb-commits] [PATCH] D85175: [test] Use abspath instead of realpath sometimes

rupprecht created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. rupprecht requested review of this revision. Herald added a subscriber: JDevlieghere. In these two cases, use of `os.path.realpath` is problematic: - The name of the compiler is significant

[Lldb-commits] [PATCH] D84576: Fix debugserver's qProcessInfo reporting of maccatalyst binaries

friss added a comment. This looks good outside of 2 cross-platform issues in the tests themselves. Comment at: lldb/test/API/macosx/macCatalyst/TestMacCatalyst.py:27 +self.expect("image list -t -b", +patterns=["x86_64.*-apple-ios.*-macabi a\.out"])

[Lldb-commits] [PATCH] D85169: [test] Exit with an error if no tests are run.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGadb5c23f8c0d: [test] Exit with an error if no tests are run. (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] adb5c23 - [test] Exit with an error if no tests are run.

Author: Jordan Rupprecht Date: 2020-08-03T16:32:12-07:00 New Revision: adb5c23f8c0d60eeec41dcbe21d1b26184e1c97d URL: https://github.com/llvm/llvm-project/commit/adb5c23f8c0d60eeec41dcbe21d1b26184e1c97d DIFF:

[Lldb-commits] [PATCH] D85169: [test] Exit with an error if no tests are run.

rupprecht added a comment. Thanks for the quick review! I have a few more boring changes coming up, but hopefully some interesting ones after that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85169/new/ https://reviews.llvm.org/D85169

[Lldb-commits] [PATCH] D85169: [test] Exit with an error if no tests are run.

JDevlieghere added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85169/new/ https://reviews.llvm.org/D85169 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D85169: [test] Exit with an error if no tests are run.

rupprecht updated this revision to Diff 282759. rupprecht added a comment. - Use logging.error - Remove trailing stop - Edit message to indicate that matching tests weren't found (user error) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85169/new/

[Lldb-commits] [PATCH] D85169: [test] Exit with an error if no tests are run.

JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:1043 +if configuration.suite.countTestCases() == 0: +print("error: did not discover any tests.") +exitTestSuite(1) MaskRay wrote: > JDevlieghere

[Lldb-commits] [PATCH] D85169: [test] Exit with an error if no tests are run.

MaskRay added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:1043 +if configuration.suite.countTestCases() == 0: +print("error: did not discover any tests.") +exitTestSuite(1) JDevlieghere wrote: > Maybe `did not

[Lldb-commits] [PATCH] D84555: [lldb-vscode ]Add Syntax Highlighting to Disassembly View

wallace added a comment. I don't think there's any easy way to test this. I was reading the VSCode documentation and there's no nice test framework for this. So at this point I'm okay with it without test, as it's very easy to check that it works by visual inspection. Repository: rG LLVM

[Lldb-commits] [PATCH] D85169: [test] Exit with an error if no tests are run.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:1043 +if configuration.suite.countTestCases() == 0: +print("error: did not discover

[Lldb-commits] [PATCH] D85169: [test] Exit with an error if no tests are run.

rupprecht created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. rupprecht requested review of this revision. Herald added a subscriber: JDevlieghere. If the test suite is misconfigured when it's run (a bad regexp, wrong test directory, etc.), the test

[Lldb-commits] [PATCH] D84263: [debugserver/Apple Silicon] Handoff connections when attaching to translated processes

davide closed this revision. davide added a comment. https://github.com/llvm/llvm-project/commit/57605758b5de3726eec1d6e587de1003af1ab5b7 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84263/new/ https://reviews.llvm.org/D84263 ___

[Lldb-commits] [PATCH] D85049: Unify the code that updates the ArchSpec after finding a fat binary with how it is done for a lean binary

aprantl added a comment. It would be nice to (in a follow-up-patch) clearly state what this function's goal is and then re-implement it with slightly fewer fallbacks. The code as it is is very convoluted. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85049/new/

[Lldb-commits] [PATCH] D84555: [lldb-vscode ]Add Syntax Highlighting to Disassembly View

clayborg added a comment. Looks better. Can we test this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84555/new/ https://reviews.llvm.org/D84555 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D84269: [lldb] Add some example type anotations to python.swig

lanza added a comment. Herald added a subscriber: JDevlieghere. Sounds good, just sent out a message to the mailing list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84269/new/ https://reviews.llvm.org/D84269

[Lldb-commits] [PATCH] D84791: [intel-pt] Fix python support and add a full python test

wallace abandoned this revision. wallace added a comment. Herald added a subscriber: JDevlieghere. After syncing up with Greg, we decided to redo this in a different way Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84791/new/

[Lldb-commits] [PATCH] D85158: [intel-pt] Refactor 3: refactor PTDecoder into SBPTProcess

wallace abandoned this revision. wallace added a comment. After syncing up with Greg, we decided to redo this in a different way Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85158/new/ https://reviews.llvm.org/D85158

[Lldb-commits] [PATCH] D85070: [intel-pt] Refactor 2: create a new folder structure

wallace abandoned this revision. wallace added a comment. After syncing up with Greg, we decided to redo this in a different way Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85070/new/ https://reviews.llvm.org/D85070

[Lldb-commits] [PATCH] D84810: [intel-pt] Simplify Python API configuration

wallace abandoned this revision. wallace added a comment. Herald added a subscriber: JDevlieghere. After syncing up with Greg, we decided to redo this in a different way Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84810/new/

[Lldb-commits] [PATCH] D85068: [intel-pt] Refactor 1: rename the namespace

wallace abandoned this revision. wallace added a comment. After syncing up with Greg, we decided to redo this in a different way Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85068/new/ https://reviews.llvm.org/D85068

[Lldb-commits] [PATCH] D84555: [lldb-vscode ]Add Syntax Highlighting to Disassembly View

aelitashen updated this revision to Diff 282720. aelitashen added a comment. Move everything to the right place Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84555/new/ https://reviews.llvm.org/D84555 Files:

[Lldb-commits] [PATCH] D85158: [intel-pt] Refactor 3: refactor PTDecoder into SBPTProcess

wallace created this revision. wallace added reviewers: clayborg, kusmour. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. wallace requested review of this revision. Herald added a subscriber: JDevlieghere. Depends on D85070 . I don't

[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

llunak added a comment. In D85145#2191421 , @teemperor wrote: > Btw, the highlighter supports any kind of delimiter string when > 'highlighting' source. So you could add a parameter for a custom highlighter > too and then pass a more convenient

[Lldb-commits] [PATCH] D84555: [lldb-vscode ]Add Syntax Highlighting to Disassembly View

wallace added a comment. Move the sample files to the syntaxes folder. Besides, the path /llvm/syntaxes/disassembly.json should just be syntaxes/disassembly.json. There's no need to have that llvm subfolder there Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D84555: [lldb-vscode ]Add Syntax Highlighting to Disassembly View

aelitashen updated this revision to Diff 282703. aelitashen added a comment. Herald added a subscriber: JDevlieghere. Cover ARM and ARM64 case in disassembly syntax highlighting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84555/new/

[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

teemperor added a reviewer: teemperor. teemperor added a comment. Btw, the highlighter supports any kind of delimiter string when 'highlighting' source. So you could add a parameter for a custom highlighter too and then pass a more convenient highlighter 'style' in to make the parsing simpler.

[Lldb-commits] [PATCH] D85145: Use syntax highlighting also in gui mode

llunak created this revision. llunak added a reviewer: clayborg. llunak requested review of this revision. Use the same functionality as the non-gui mode, the colors just need translating to curses colors. Repository: rLLDB LLDB https://reviews.llvm.org/D85145 Files:

[Lldb-commits] [PATCH] D84966: Remove special Hexagon packet traversal code

ted updated this revision to Diff 282640. ted added a comment. Fixed formatting flagged by Lint: Pre-merge checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84966/new/ https://reviews.llvm.org/D84966 Files:

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

gedatsu217 added a comment. >>> I don't think the value of m_previous_autosuggestion_size should only grow >>> (which is what this if is doing), as this way we just keep printing a >>> longer and longer space buffer over time. Just printing enough to clear the >>> buffer of the previous

[Lldb-commits] [PATCH] D85134: [lldb][AArch64] Correct compile options for Neon corefile

DavidSpickett added a reviewer: omjavaid. DavidSpickett added a comment. Originally added in https://reviews.llvm.org/D77793. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85134/new/ https://reviews.llvm.org/D85134

[Lldb-commits] [PATCH] D85134: [lldb][AArch64] Correct compile options for Neon corefile

DavidSpickett created this revision. Herald added subscribers: lldb-commits, danielkiss, kristof.beyls. Herald added a reviewer: rengolin. Herald added a project: LLDB. DavidSpickett requested review of this revision. Herald added a subscriber: JDevlieghere. SVE is not required, it has its own

[Lldb-commits] [PATCH] D85123: Truncate long lines/names if needed in lldb gui

llunak updated this revision to Diff 282607. llunak added a comment. Handle properly also the "<<< Thread 1: breakpoint 1.1" marker. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85123/new/ https://reviews.llvm.org/D85123 Files:

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

teemperor added a comment. In D81001#2190646 , @gedatsu217 wrote: > @skipIfAsan > @skipIfEditlineSupportMissing > def test_hidden_autosuggestion(self): > @skipIfAsan > @skipIfEditlineSupportMissing > def test_autosuggestion(self): >

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

gedatsu217 added a comment. @skipIfAsan @skipIfEditlineSupportMissing def test_hidden_autosuggestion(self): @skipIfAsan @skipIfEditlineSupportMissing def test_autosuggestion(self): self.launch(extra_args=["-o", "settings set show-autosuggestion true", "-o", "settings set

[Lldb-commits] [PATCH] D85123: Truncate long lines/names if needed in lldb gui

llunak created this revision. llunak added a reviewer: clayborg. llunak requested review of this revision. Without this, sources with long lines or variable names may overwrite panel frames, or even overrun to the following line. There's currently no way to scroll left/right in the views, so

[Lldb-commits] [PATCH] D84957: [lldb/Process/Windows] Attempt to kill exited/detached process in not error

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe97c693bb0ec: [lldb/Process/Windows] Attempting to kill exited/detached process in not an… (authored by tatyana-krasnukha). Changed prior to

[Lldb-commits] [lldb] e97c693 - [lldb/Process/Windows] Attempting to kill exited/detached process in not an error

Author: Tatyana Krasnukha Date: 2020-08-03T12:52:43+03:00 New Revision: e97c693bb0ece2d9a2b0db75034927405fe3bfdf URL: https://github.com/llvm/llvm-project/commit/e97c693bb0ece2d9a2b0db75034927405fe3bfdf DIFF:

[Lldb-commits] [PATCH] D84957: [lldb/Process/Windows] Attempt to kill exited/detached process in not error

tatyana-krasnukha added a comment. Thank you! I fixed the commit title and description as you suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84957/new/ https://reviews.llvm.org/D84957 ___

[Lldb-commits] [PATCH] D85107: Add a test for 'b' (toggle breakpoint)

llunak updated this revision to Diff 282543. llunak edited the summary of this revision. llunak added a comment. Removed use of curses python module, lldbexpect hardcodes TERM=vt100, so the escape sequence should be actually hardcoded too. The previous version didn't work e.g. in Linux console.

[Lldb-commits] [lldb] 18d4069 - fix lldb test on lib64 systems

Author: Luboš Luňák Date: 2020-08-03T11:19:07+02:00 New Revision: 18d4069503e729442158476960a797df963cf293 URL: https://github.com/llvm/llvm-project/commit/18d4069503e729442158476960a797df963cf293 DIFF: https://github.com/llvm/llvm-project/commit/18d4069503e729442158476960a797df963cf293.diff

[Lldb-commits] [PATCH] D85096: Fix lldb test on lib64 systems

This revision was automatically updated to reflect the committed changes. Closed by commit rG18d4069503e7: fix lldb test on lib64 systems (authored by llunak). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D81001: [lldb] Display autosuggestion part in gray if there is one possible suggestion

teemperor added a comment. Added some comments on the new code. Also we should be able to see these spaces in the pexpect output, so I guess we should be able to test this too? To make this special case less fragile to test, you can make a new subtest in the Test case by just defining a new

[Lldb-commits] [PATCH] D84886: Create LoopNestPass

TaWeiTu updated this revision to Diff 281985. TaWeiTu removed reviewers: jdoerfert, sstefan1, DavidTruby, aartbik, ftynse, baziotis, libc++. TaWeiTu removed projects: MLIR, libc-project, OpenMP, libc++, LLDB, Sanitizers. TaWeiTu added a comment. Propagate the requirement of MemorySSA from loop

[Lldb-commits] [lldb] 8aeb212 - [debugserver] Fix that is_dot_app is producing unused warnings

Author: Raphael Isemann Date: 2020-08-03T10:24:21+02:00 New Revision: 8aeb212887024a615ca02437cd12fa055bd54b6f URL: https://github.com/llvm/llvm-project/commit/8aeb212887024a615ca02437cd12fa055bd54b6f DIFF:

[Lldb-commits] [PATCH] D85107: Add a test for 'b' (toggle breakpoint)

llunak created this revision. llunak added a reviewer: clayborg. llunak requested review of this revision. The test needs the python curses module, to get the proper escape sequence to send the down key event. I'm not sure if it's ok to just use the module, or if some check for it should be

[Lldb-commits] [PATCH] D85106: Move TestGuiBasicDebug.py to lldb/test and update it

llunak created this revision. llunak added a reviewer: clayborg. llunak requested review of this revision. Between the time it was created and it was pushed upstream, 99451b4453688a94c6014cac233d371ab4cc342d has moved the