[Lldb-commits] [lldb] 2e5b701 - This test includes a source that will produce basic blocks and hence sections with -fbasic-block-sections=all.

Author: Sriraman Tallam Date: 2020-10-16T21:31:42-07:00 New Revision: 2e5b701d9306e45d37d370b1496bff9604605c93 URL: https://github.com/llvm/llvm-project/commit/2e5b701d9306e45d37d370b1496bff9604605c93 DIFF:

[Lldb-commits] [PATCH] D89179: New test to check if basic block sections produces the right back traces with lldb

This revision was automatically updated to reflect the committed changes. Closed by commit rG2e5b701d9306: This test includes a source that will produce basic blocks and hence sections… (authored by tmsriram). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

vsk added a comment. In D89283#2336120 , @wallace wrote: > @vsk, I agree with you regarding the files. At the moment our implementation > of intel-pt tracing doesn't support collecting a trace, but soon we'll do so. > Then, we'll be able to generate

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

clayborg added a comment. As I stated before we should be printing the disassembly for each instruction on the output lines. We should probably also normalize the address hex value to it doesn't change widths. Something like: [ 0] 0x0040065f: pushq %rbp [ 1] 0x0040065a:

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Instead of just seeing the address, we should disassemble the instruction at the address in this patch for clarity if it is available. If we can't read the opcode from the

[Lldb-commits] [PATCH] D89600: [lldb] Move copying of reproducer out of process

JDevlieghere created this revision. JDevlieghere added reviewers: labath, teemperor, vsk, jingham. Herald added a subscriber: dang. JDevlieghere requested review of this revision. For performance reasons the reproducers don't copy the files captured by the file collector until we decide that the

[Lldb-commits] [PATCH] D89589: [lldb] Implement ObjCExceptionThrowFrameRecognizer::GetName()

shafik added a comment. test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89589/new/ https://reviews.llvm.org/D89589 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

wallace updated this revision to Diff 298771. wallace added a comment. - Remove the llvm::consumeExpected function, as @vsk suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89283/new/ https://reviews.llvm.org/D89283 Files:

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

wallace added inline comments. Comment at: llvm/include/llvm/Support/Error.h:1016 +/// expected-producer might be more clearly refactored to return an Optional. +template inline void consumeExpected(Expected E) { + if (!E) vsk wrote: > Probably best to not

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

wallace added a comment. @vsk, I agree with you regarding the files. At the moment our implementation of intel-pt tracing doesn't support collecting a trace, but soon we'll do so. Then, we'll be able to generate these trace files on the fly as the tests run, so I imagine I'll be deleting these

[Lldb-commits] [PATCH] D89408: [trace] rename ThreadIntelPT to ThreadTrace

vsk added inline comments. Comment at: lldb/include/lldb/Target/ThreadTrace.h:34 + /// this thread was being executed. + ThreadTrace(Process , lldb::tid_t tid, const FileSpec trace_file) + : Thread(process, tid), m_trace_file(trace_file) {} wallace

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

wallace updated this revision to Diff 298768. wallace added a comment. removing unwanted changes in lldb/tools/intel-features/intel-pt/Decoder.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89283/new/ https://reviews.llvm.org/D89283 Files:

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

wallace added inline comments. Comment at: lldb/tools/intel-features/intel-pt/Decoder.cpp:301 + std::ofstream of("/tmp/multi-file.trace", std::ios::binary | std::ios::out); + for (auto bait : pt_buffer) vsk wrote: > Not sure what this is in aid of? I

[Lldb-commits] [PATCH] D89408: [trace] rename ThreadIntelPT to ThreadTrace

wallace added inline comments. Comment at: lldb/include/lldb/Target/ThreadTrace.h:34 + /// this thread was being executed. + ThreadTrace(Process , lldb::tid_t tid, const FileSpec trace_file) + : Thread(process, tid), m_trace_file(trace_file) {} vsk

[Lldb-commits] [PATCH] D89408: [trace] rename ThreadIntelPT to ThreadTrace

wallace updated this revision to Diff 298766. wallace added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89408/new/ https://reviews.llvm.org/D89408 Files: lldb/include/lldb/Target/ProcessTrace.h

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

vsk added a comment. I'm not sure if the current revision of the patch reflects the long-term testing strategy. But if so, I'm quite concerned about the proliferation of large binary files in the repo (like ld.so, or the raw trace binary itself). These are opaque blobs that are hard to

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

wallace marked 2 inline comments as done. wallace added inline comments. Comment at: lldb/test/API/commands/trace/TestTraceDumpInstructions.py:142-143 +substrs=['''thread #1: tid = 3842849, total instructions = 2 + [0] no memory mapped at this address + [1] no

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

wallace updated this revision to Diff 298762. wallace added a comment. Figured out how to show the addressed that failed to decode. Now the output in those cases is something like [ 4] no memory mapped at this address: 0x77df1950 This should address all of Greg's comments Repository:

[Lldb-commits] [PATCH] D89408: [trace] rename ThreadIntelPT to ThreadTrace

vsk added inline comments. Comment at: lldb/include/lldb/Target/ThreadTrace.h:34 + /// this thread was being executed. + ThreadTrace(Process , lldb::tid_t tid, const FileSpec trace_file) + : Thread(process, tid), m_trace_file(trace_file) {} `const

[Lldb-commits] [lldb] f16cecf - [lldb] Implement ObjCExceptionThrowFrameRecognizer::GetName()

Author: Dave Lee Date: 2020-10-16T14:24:03-07:00 New Revision: f16cecf3752a7c168293934d2ba6472a6b405694 URL: https://github.com/llvm/llvm-project/commit/f16cecf3752a7c168293934d2ba6472a6b405694 DIFF: https://github.com/llvm/llvm-project/commit/f16cecf3752a7c168293934d2ba6472a6b405694.diff

[Lldb-commits] [PATCH] D89589: [lldb] Implement ObjCExceptionThrowFrameRecognizer::GetName()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf16cecf3752a: [lldb] Implement ObjCExceptionThrowFrameRecognizer::GetName() (authored by kastiglione). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

wallace added a comment. nvm, libipt does report the addresses that failed to read, I'll quickly fix it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89283/new/ https://reviews.llvm.org/D89283 ___

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

wallace marked 8 inline comments as done. wallace added a comment. > When you are dumping instructions we are only showing one hex value. Is this > the instruction address or the opcode itself? That's the instruction load address. In a later diff I'll implement pretty-printing similar to the

[Lldb-commits] [PATCH] D89351: Move initialization of Variable::m_loc_is_const_data into constructor (NFC)

aprantl closed this revision. aprantl added a comment. landed in 9b1c06c0e84a9cc763e12b289becb5fc3c9d01ea CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89351/new/ https://reviews.llvm.org/D89351

[Lldb-commits] [PATCH] D89589: [lldb] Implement ObjCExceptionThrowFrameRecognizer::GetName()

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89589/new/ https://reviews.llvm.org/D89589

[Lldb-commits] [PATCH] D89589: [lldb] Implement ObjCExceptionThrowFrameRecognizer::GetName()

kastiglione created this revision. kastiglione added a reviewer: jingham. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. Herald added a subscriber: JDevlieghere. Implement `GetName` for `ObjCExceptionThrowFrameRecognizer`.

[Lldb-commits] [lldb] cf24508 - Add support for more OS types to AddClangModuleCompilationOptionsForSDKType()

Author: Adrian Prantl Date: 2020-10-16T11:43:22-07:00 New Revision: cf245086518efbdf96c2d86697298a8da5c97669 URL: https://github.com/llvm/llvm-project/commit/cf245086518efbdf96c2d86697298a8da5c97669 DIFF: https://github.com/llvm/llvm-project/commit/cf245086518efbdf96c2d86697298a8da5c97669.diff

[Lldb-commits] [PATCH] D89428: Add support for more OS types to AddClangModuleCompilationOptionsForSDKType()

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGcf245086518e: Add support for more OS types to AddClangModuleCompilationOptionsForSDKType() (authored by aprantl). Herald

[Lldb-commits] [PATCH] D89408: [trace] rename ThreadIntelPT to ThreadTrace

clayborg added a comment. LGTM. Pavel? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89408/new/ https://reviews.llvm.org/D89408 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Great start to this. Many comments inlined. When you are dumping instructions we are only showing one hex value. Is this the instruction address or the opcode itself?

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

wallace updated this revision to Diff 298673. wallace added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89283/new/ https://reviews.llvm.org/D89283 Files: lldb/include/lldb/Target/ProcessTrace.h

[Lldb-commits] [PATCH] D89408: [trace] rename ThreadIntelPT to TraceThread

wallace updated this revision to Diff 298671. wallace marked an inline comment as done. wallace added a comment. Herald added a subscriber: dexonsmith. Address all comments, including the renaming of the classes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D89408: [trace] rename ThreadIntelPT to TraceThread

wallace marked 4 inline comments as done. wallace added inline comments. Comment at: lldb/source/Target/TraceProcess.cpp:40 +bool TraceProcess::CanDebug(TargetSP target_sp, bool plugin_specified_by_name) { return plugin_specified_by_name; } labath wrote: >

[Lldb-commits] [PATCH] D89334: [lldb] Support Python imports relative the to the current file being sourced

labath added a comment. In D89334#2332452 , @JDevlieghere wrote: > In D89334#2331903 , @labath wrote: > >> In D89334#2330287 , @JDevlieghere >> wrote: >> >>> I guess then

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

mib accepted this revision. mib added a comment. LGTM provided that you address my last comments :) Also, please make sure that your patch is well formatted (`git clang-format HEAD~`) before submitting it. Thanks. Comment at: lldb/include/lldb/Symbol/Type.h:111-114 //

[Lldb-commits] [PATCH] D89155: [lldb] Minidump: check for .text hash match with directory

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd30797b4041f: [lldb] Minidump: check for .text hash match with directory (authored by JosephTremoulet). Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] d30797b - [lldb] Minidump: check for .text hash match with directory

Author: Joseph Tremoulet Date: 2020-10-16T09:32:08-04:00 New Revision: d30797b4041ffe215b92d376af60c4f26a0555ae URL: https://github.com/llvm/llvm-project/commit/d30797b4041ffe215b92d376af60c4f26a0555ae DIFF:

[Lldb-commits] [lldb] daae4a8 - [lldb] Modernize PseudoTerminal::OpenSecondary

Author: Pavel Labath Date: 2020-10-16T15:22:55+02:00 New Revision: daae4a84828b131395c531cd5604dc013d9073b6 URL: https://github.com/llvm/llvm-project/commit/daae4a84828b131395c531cd5604dc013d9073b6 DIFF: https://github.com/llvm/llvm-project/commit/daae4a84828b131395c531cd5604dc013d9073b6.diff

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

labath added a comment. In D82863#2331892 , @omjavaid wrote: > In D82863#2330122 , @labath wrote: > >> I started drafting an email to the gdb mailing list to try to clarify this >> thing. For that, I was

[Lldb-commits] [PATCH] D87442: [lldb] Show flags for memory regions

labath added a comment. In D87442#2332244 , @DavidSpickett wrote: > If you are wondering, the average number of flags for a Linux hello world's > memory regions is 8 so 8 lines of output. Here's an example I had that does > madvise. > > (lldb) memory

[Lldb-commits] [PATCH] D89477: [lldb] Port lldb gdb-server to libOption

labath updated this revision to Diff 298606. labath marked an inline comment as done. labath added a comment. address review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89477/new/ https://reviews.llvm.org/D89477 Files:

[Lldb-commits] [PATCH] D89477: [lldb] Port lldb gdb-server to libOption

labath marked 2 inline comments as done. labath added inline comments. Comment at: lldb/source/Utility/Args.cpp:178 +Args::Args(llvm::ArrayRef args) : Args() { + for (llvm::StringRef arg : args) JDevlieghere wrote: > Maybe StringList should have a ctor that

[Lldb-commits] [PATCH] D89408: [trace] rename ThreadIntelPT to TraceThread

labath added a comment. In D89408#2333502 , @wallace wrote: > Addressed the issues that @labath pointed out regarding the TraceProcess and > TraceThread: > > - These classes were not together > - TraceProcess was an optional plug-in, which would break

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum updated this revision to Diff 298596. fallkrum set the repository for this revision to rG LLVM Github Monorepo. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88483/new/

[Lldb-commits] [PATCH] D89477: [lldb] Port lldb gdb-server to libOption

DavidSpickett added inline comments. Comment at: lldb/tools/lldb-server/lldb-gdbserver.cpp:370 + If no target is selected a startup, the lldb-server can be directed to launch + or attach a process by the LLDB client. + `attach a process` -> `attach to a