[Lldb-commits] [PATCH] D99401: Fix .debug_aranges parsing issues introduced with llvm error handling in LLDB

clayborg added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugArangeSet.cpp:96 const uint32_t header_size = *offset_ptr - m_offset; const uint32_t tuple_size = m_header.addr_size << 1; uint32_t first_tuple_offset = 0;

[Lldb-commits] [PATCH] D99401: Fix .debug_aranges parsing issues introduced with llvm error handling in LLDB

yinghuitan added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugArangeSet.cpp:96 const uint32_t header_size = *offset_ptr - m_offset; const uint32_t tuple_size = m_header.addr_size << 1; uint32_t first_tuple_offset = 0;

[Lldb-commits] [lldb] 984e2f4 - [lldb] Prints error using WithColor::error in lldb-platform

Author: Jonas Devlieghere Date: 2021-03-29T15:45:33-07:00 New Revision: 984e2f440aa4c9c3603840e4f8f09073a54e4849 URL: https://github.com/llvm/llvm-project/commit/984e2f440aa4c9c3603840e4f8f09073a54e4849 DIFF:

[Lldb-commits] [PATCH] D99401: Fix .debug_aranges parsing issues introduced with llvm error handling in LLDB

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeee309068e6e: Fix .debug_aranges parsing issues. (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] eee3090 - Fix .debug_aranges parsing issues.

Author: Greg Clayton Date: 2021-03-29T15:34:36-07:00 New Revision: eee309068e6e02b6544b2c1809b3f672fa35b979 URL: https://github.com/llvm/llvm-project/commit/eee309068e6e02b6544b2c1809b3f672fa35b979 DIFF: https://github.com/llvm/llvm-project/commit/eee309068e6e02b6544b2c1809b3f672fa35b979.diff

[Lldb-commits] [PATCH] D99401: Fix .debug_aranges parsing issues introduced with llvm error handling in LLDB

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99401/new/ https://reviews.llvm.org/D99401

[Lldb-commits] [PATCH] D99401: Fix .debug_aranges parsing issues introduced with llvm error handling in LLDB

clayborg added a comment. I'd love to get this in as this affects many of our clients. Does anyone else have an issues with this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99401/new/ https://reviews.llvm.org/D99401

[Lldb-commits] [PATCH] D91679: [trace][intel-pt] Implement trace start and trace stop

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/docs/lldb-gdb-remote.txt:246-251 +// { +// "name": , +// Tracing technology name, e.g. intel-pt, arm-coresight. +//

[Lldb-commits] [PATCH] D99535: [lldb] Print stack trace when lldb-vscode crashes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG047cbfe2bbf2: [lldb] Print stack trace when lldb-vscode crashes (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM

[Lldb-commits] [lldb] 047cbfe - [lldb] Print stack trace when lldb-vscode crashes

Author: Jonas Devlieghere Date: 2021-03-29T14:20:59-07:00 New Revision: 047cbfe2bbf22a9da1bd27cafcee4eb1453965dc URL: https://github.com/llvm/llvm-project/commit/047cbfe2bbf22a9da1bd27cafcee4eb1453965dc DIFF:

[Lldb-commits] [PATCH] D99535: [lldb] Print stack trace when lldb-vscode crashes

JDevlieghere created this revision. JDevlieghere added reviewers: teemperor, clayborg, wallace. JDevlieghere requested review of this revision. Print LLVM's pretty stack trace when lldb-vscode crashes. Also removes the unnecessary call to `PrintStackTraceOnErrorSignal` in `lldb-server` as it's

[Lldb-commits] [PATCH] D99497: [LLDB] Fix sync issue in TestVSCode_launch.test_progress_events

clayborg added a comment. In D99497#2656502 , @labath wrote: > Isn't there a better way to ensure synchronization here? Maybe, executing > some command (setting a breakpoint, for instance), that will ensure that all > symbols have been parsed? That is

[Lldb-commits] [PATCH] D99497: [LLDB] Fix sync issue in TestVSCode_launch.test_progress_events

labath added a comment. Isn't there a better way to ensure synchronization here? Maybe, executing some command (setting a breakpoint, for instance), that will ensure that all symbols have been parsed? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99497/new/

[Lldb-commits] [PATCH] D99497: [LLDB] Fix sync issue in TestVSCode_launch.test_progress_events

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. lgtm! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99497/new/ https://reviews.llvm.org/D99497 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D99491: [LLDB] Fix cleanup error in TestVSCode_disconnect.test_launch

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Thanks for looking into this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99491/new/ https://reviews.llvm.org/D99491 ___

[Lldb-commits] [lldb] 10d02fb - [lldb][NFC] Fix -Wdocumentation issue in ModuleSpec.h/ThreadTrace.h

Author: Raphael Isemann Date: 2021-03-29T19:47:29+02:00 New Revision: 10d02fb15b2d03d7f7b5c372946f5cb0e74cb220 URL: https://github.com/llvm/llvm-project/commit/10d02fb15b2d03d7f7b5c372946f5cb0e74cb220 DIFF:

[Lldb-commits] [lldb] 32f252a - [lldb][NFC] Fix -Wdocumentation issue in ProcessMinidump

Author: Raphael Isemann Date: 2021-03-29T19:40:41+02:00 New Revision: 32f252a765d5f76cd1c84c20d55482ab4c86dfe0 URL: https://github.com/llvm/llvm-project/commit/32f252a765d5f76cd1c84c20d55482ab4c86dfe0 DIFF:

[Lldb-commits] [PATCH] D98529: [lldb] Strip pointer authentication codes from aarch64 pc.

justincohen added a comment. Can we move comments over to --> https://reviews.llvm.org/D98886, which has these changes implemented? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98529/new/ https://reviews.llvm.org/D98529

[Lldb-commits] [PATCH] D99448: [lldb] Move UpdateISAToDescriptorMap into ClassInfoExtractor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbf8cbfa65fc5: [lldb] Move UpdateISAToDescriptorMap into ClassInfoExtractor (NFC) (authored by JDevlieghere). Herald added a project: LLDB.

[Lldb-commits] [lldb] bf8cbfa - [lldb] Move UpdateISAToDescriptorMap into ClassInfoExtractor (NFC)

Author: Jonas Devlieghere Date: 2021-03-29T09:23:44-07:00 New Revision: bf8cbfa65fc5eb484013c43b26754b4612d5c6ee URL: https://github.com/llvm/llvm-project/commit/bf8cbfa65fc5eb484013c43b26754b4612d5c6ee DIFF:

[Lldb-commits] [lldb] 4d593ef - [lldb] Include llvm-config.h instead of config.h

Author: Jonas Devlieghere Date: 2021-03-29T08:58:51-07:00 New Revision: 4d593efd7f930c42be8553a5ba347e2d87503ad4 URL: https://github.com/llvm/llvm-project/commit/4d593efd7f930c42be8553a5ba347e2d87503ad4 DIFF:

[Lldb-commits] [PATCH] D99331: [TESTS] Fix TestInlineStepping with ccac compiler

vasilyev abandoned this revision. vasilyev added a comment. Resolved Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99331/new/ https://reviews.llvm.org/D99331 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 333885. Ericson2314 added a comment. 1. Updating D99484 : Use `GNUInstallDirs` to support custom installation dirs. # 2. Enter a brief description of the changes included in this update. 3. The first line is used as

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added a comment. @lebedev.ri Those are intentional. I changed `POLLY_INSTALL_PREFIX` and `COMPILER_RT_INSTALL_PATH` to be `""` instead of `${CMAKE_INSTALL_PREFIX}` by default. If if kept it more as it was, the GNU dir outside the prefix (as I needed to do) wouldn't work. I suppose

[Lldb-commits] [PATCH] D98822: [lldb] [Process] Watch for fork/vfork notifications

mgorny updated this revision to Diff 333834. mgorny added a comment. Fix wrongly using the debugged process' TID instead of PID. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98822/new/ https://reviews.llvm.org/D98822 Files: lldb/include/lldb/Host/common/NativeProcessProtocol.h

[Lldb-commits] [PATCH] D99331: [TESTS] Fix TestInlineStepping with ccac compiler

teemperor added a comment. So from what I understand this is resolved? If yes, can you abandon/close this revision (You can do this by selecting the "Abandon revision" action above the input field where you can comment). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 69e7b74 - [lldb][NFC] Add a test case for Objective-C properties with conflicting names

Author: Raphael Isemann Date: 2021-03-29T12:33:07+02:00 New Revision: 69e7b7457809bac02f3e6f7d643c4fb516b31616 URL: https://github.com/llvm/llvm-project/commit/69e7b7457809bac02f3e6f7d643c4fb516b31616 DIFF:

[Lldb-commits] [PATCH] D99491: [LLDB] Fix cleanup error in TestVSCode_disconnect.test_launch

omjavaid created this revision. omjavaid added reviewers: clayborg, labath. omjavaid requested review of this revision. TestVSCode_disconnect.test_launch fails with clean up error because disconnect gets called twice once from the test case and once from the tear down hook. This patch disables

[Lldb-commits] [PATCH] D99331: [TESTS] Fix TestInlineStepping with ccac compiler

vasilyev added a comment. Thanks for the comments! You are right, this is indeed fixed by https://github.com/llvm/llvm-project/commit/352f16db87f583ec7f55f8028647b5fd8616111f Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99331/new/

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

lebedev.ri added a comment. Thank you! The changes here look about reasonable to me. I have not checked if there are some changes that were missed. Usage of `CMAKE_INSTALL_FULL_` is suspect to me. Are you sure those are correct? Comment at:

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 created this revision. Herald added subscribers: libc-commits, libcxx-commits, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, kerbowa, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, csigg, antiagainst, shauheen, rriddle,

[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan added a comment. In D99426#2653949 , @MaskRay wrote: > In D99426#2653869 , > @abhina.sreeskantharajan wrote: > >> In D99426#2653725 , @MaskRay

[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan added a comment. In D99426#2653725 , @MaskRay wrote: > This touches a lot of files. I am a bit worried that it would not be easy for > a contributor to know OF_TextWithCRLF is needed to make SystemZ happy. > >> On SystemZ we need

[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

MaskRay added a comment. In D99426#2653869 , @abhina.sreeskantharajan wrote: > In D99426#2653725 , @MaskRay wrote: > >> This touches a lot of files. I am a bit worried that it would not be easy >> for a

[Lldb-commits] [PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc83cd8feef7e: [NFC] Reordering parameters in getFile and getFileOrSTDIN (authored by abhina.sreeskantharajan). Repository: rG LLVM Github

[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

MaskRay added a comment. This touches a lot of files. I am a bit worried that it would not be easy for a contributor to know OF_TextWithCRLF is needed to make SystemZ happy. > On SystemZ we need to open text files in text mode, Why can't it be served without CRLF translation? Repository:

[Lldb-commits] [PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

abhina.sreeskantharajan marked an inline comment as done. abhina.sreeskantharajan added inline comments. Comment at: llvm/lib/Support/MemoryBuffer.cpp:275 + return getFileAux( + Filename, /*MapSize=*/-1, 0, /*IsText=*/false, + /*RequiresNullTerminator=*/false,

[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan created this revision. Herald added subscribers: dexonsmith, wenlei, okura, kuter, cmtice, martong, steven_wu, gbedwell, hiraditya, qcolombet, MatzeB. Herald added a reviewer: bollu. Herald added a reviewer: JDevlieghere. Herald added a reviewer: andreadb. Herald added a

[Lldb-commits] [lldb] 3c95bdf - [lldb] Don't search for system specific strings in assert.test

Author: Raphael Isemann Date: 2021-03-29T10:46:14+02:00 New Revision: 3c95bdf9fa35f0fe2143ea859b624c8f09513adb URL: https://github.com/llvm/llvm-project/commit/3c95bdf9fa35f0fe2143ea859b624c8f09513adb DIFF:

[Lldb-commits] [PATCH] D98153: Some FormatEntity.cpp cleanup and unit testing

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks for the patch (and especially the unit test)! Some two nits left but feel free to fix those when merging. If you don't have commit access I can also do that, just let me

[Lldb-commits] [PATCH] D99462: [lldb] Fix Error/assert.test regression with symbols

This revision was automatically updated to reflect the committed changes. Closed by commit rG6bc1e69de270: [lldb] Fix Error/assert.test regression with symbols (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99462/new/

[Lldb-commits] [lldb] 6bc1e69 - [lldb] Fix Error/assert.test regression with symbols

Author: Jan Kratochvil Date: 2021-03-29T08:16:43+02:00 New Revision: 6bc1e69de270db8d7191200f54158e4192f997ba URL: https://github.com/llvm/llvm-project/commit/6bc1e69de270db8d7191200f54158e4192f997ba DIFF: