[Lldb-commits] [lldb] cf51bf7 - [lldb] Account for objc_debug_class_getNameRaw returning NULL

Author: Jonas Devlieghere Date: 2021-04-01T19:58:28-07:00 New Revision: cf51bf77b070f63391bacada5e166bfec2616989 URL: https://github.com/llvm/llvm-project/commit/cf51bf77b070f63391bacada5e166bfec2616989 DIFF:

[Lldb-commits] [PATCH] D99571: Update ProcessMachCore::DoLoadCore to handle binary hints with and without addresses

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG78a1412845b5: Handle all standalone combinations of LC_NOTEs w/

[Lldb-commits] [lldb] 78a1412 - Handle all standalone combinations of LC_NOTEs w/ & w/o addr & uuid

Author: Jason Molenda Date: 2021-04-01T18:59:36-07:00 New Revision: 78a1412845b5552465505889b69b5b11d9b20d35 URL: https://github.com/llvm/llvm-project/commit/78a1412845b5552465505889b69b5b11d9b20d35 DIFF: https://github.com/llvm/llvm-project/commit/78a1412845b5552465505889b69b5b11d9b20d35.diff

[Lldb-commits] [PATCH] D98289: [lldb] 2/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

dblaikie added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/DW_AT_range-DW_FORM_sec_offset.s:11 +# Failure was the block range 1..2 was not printed plus: +# error: DW_AT_range-DW_FORM_sec_offset.s.tmp {0x003f}: DIE has DW_AT_ranges(0xc) attribute, but range

[Lldb-commits] [PATCH] D98822: [lldb] [Process] Watch for fork/vfork notifications

mgorny added inline comments. Comment at: lldb/test/Shell/Subprocess/clone-follow-parent-wp.test:1 +# REQUIRES: native && (system-linux || system-netbsd) && (target-x86 || target-x86_64 || target-aarch64) && dbregs-set +# RUN: %clang_host -g %p/Inputs/clone.c -o %t

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Meinersbur added inline comments. Comment at: polly/cmake/CMakeLists.txt:82-96 +set(POLLY_INSTALL_PREFIX "") set(POLLY_CONFIG_LLVM_CMAKE_DIR "${LLVM_BINARY_DIR}/${LLVM_INSTALL_PACKAGE_DIR}") -set(POLLY_CONFIG_CMAKE_DIR "${POLLY_INSTALL_PREFIX}/${POLLY_INSTALL_PACKAGE_DIR}")

[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan updated this revision to Diff 334792. abhina.sreeskantharajan added a comment. Update comment in FileSystem.h for OF_TextWithCRLF Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99426/new/ https://reviews.llvm.org/D99426

[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan added a comment. In D99426#2664841 , @MaskRay wrote: > /// The file should be opened in text mode on platforms like z/OS that make > /// this distinction. > OF_Text = 1, > F_Text = 1, // For compatibility > > /// The

[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan added a comment. @MaskRay is there still any confusion about the problem this patch is trying to solve and concerns about the renaming? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99426/new/

[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

MaskRay added a comment. /// The file should be opened in text mode on platforms like z/OS that make /// this distinction. OF_Text = 1, F_Text = 1, // For compatibility /// The file should use a carriage linefeed '\r\n'. /// Only makes a difference on windows. OF_CRLF = 2,

[Lldb-commits] [PATCH] D99571: Update ProcessMachCore::DoLoadCore to handle binary hints with and without addresses

jasonmolenda added a comment. Thanks for the feedback Shafik, updated the patch and landing in a sec. Comment at: lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp:214 + if (FileSystem::Instance().Exists(module_spec.GetFileSpec())) { +module_sp.reset(new

[Lldb-commits] [PATCH] D99702: [lldb-vscode] Use LLVM's ScopeExit to ensure we always terminate the debugger

dblaikie added a comment. @wallace - minor inconvenience, but approving a patch in Phabricator without any textual comment does not result in an email to the list, making it look like a patch is being committed without approval - could you include some text in your Phab approvals, as it makes

[Lldb-commits] [PATCH] D98761: Fix "image lookup --address" Summary results for inline functions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2d733923b8d3: Fix image lookup --address Summary results for inline functions. (authored by clayborg). Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 2d73392 - Fix "image lookup --address" Summary results for inline functions.

Author: Greg Clayton Date: 2021-04-01T11:36:26-07:00 New Revision: 2d733923b8d32230d5af777dd1d84ae2c7fc968d URL: https://github.com/llvm/llvm-project/commit/2d733923b8d32230d5af777dd1d84ae2c7fc968d DIFF: https://github.com/llvm/llvm-project/commit/2d733923b8d32230d5af777dd1d84ae2c7fc968d.diff

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added inline comments. Comment at: compiler-rt/cmake/Modules/CompilerRTUtils.cmake:389 get_compiler_rt_target(${arch} target) -set(${install_dir} ${COMPILER_RT_INSTALL_PATH}/lib/${target} PARENT_SCOPE) +set(${install_dir}

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 334765. Ericson2314 added a comment. Rebase now that previous diff landed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files:

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 334576. Ericson2314 added a comment. Put on top of D99697 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files:

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 334713. Ericson2314 added a comment. Rebase on newer version of previous diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files:

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 marked an inline comment as not done. Ericson2314 added inline comments. Comment at: compiler-rt/cmake/Modules/CompilerRTUtils.cmake:389 get_compiler_rt_target(${arch} target) -set(${install_dir} ${COMPILER_RT_INSTALL_PATH}/lib/${target} PARENT_SCOPE) +

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

compnerd added inline comments. Comment at: clang/cmake/modules/AddClang.cmake:127 + LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}${LLVM_LIBDIR_SUFFIX} + ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}${LLVM_LIBDIR_SUFFIX} + RUNTIME DESTINATION

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

phosek added inline comments. Comment at: libcxx/cmake/Modules/HandleLibCXXABI.cmake:66 install(FILES "${LIBCXX_BINARY_INCLUDE_DIR}/${fpath}" -DESTINATION ${LIBCXX_INSTALL_HEADER_PREFIX}include/c++/v1/${dstdir} +DESTINATION

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

phosek added inline comments. Comment at: libcxx/cmake/Modules/HandleLibCXXABI.cmake:66 install(FILES "${LIBCXX_BINARY_INCLUDE_DIR}/${fpath}" -DESTINATION ${LIBCXX_INSTALL_HEADER_PREFIX}include/c++/v1/${dstdir} +DESTINATION

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

phosek added inline comments. Comment at: compiler-rt/cmake/Modules/CompilerRTUtils.cmake:389 get_compiler_rt_target(${arch} target) -set(${install_dir} ${COMPILER_RT_INSTALL_PATH}/lib/${target} PARENT_SCOPE) +set(${install_dir}

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

ldionne added inline comments. Comment at: libcxx/cmake/Modules/HandleLibCXXABI.cmake:66 install(FILES "${LIBCXX_BINARY_INCLUDE_DIR}/${fpath}" -DESTINATION ${LIBCXX_INSTALL_HEADER_PREFIX}include/c++/v1/${dstdir} +DESTINATION

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added inline comments. Comment at: clang/cmake/modules/AddClang.cmake:127 + LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}${LLVM_LIBDIR_SUFFIX} + ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}${LLVM_LIBDIR_SUFFIX} + RUNTIME DESTINATION

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

compnerd added inline comments. Comment at: clang/cmake/modules/AddClang.cmake:127 + LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}${LLVM_LIBDIR_SUFFIX} + ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}${LLVM_LIBDIR_SUFFIX} + RUNTIME DESTINATION

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

ldionne added a subscriber: phosek. ldionne added a comment. I am generally OK with the libcxx and libcxxabi changes. Comment at: compiler-rt/cmake/Modules/CompilerRTUtils.cmake:389 get_compiler_rt_target(${arch} target) -set(${install_dir}

[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan updated this revision to Diff 334220. abhina.sreeskantharajan added a comment. Specified z/OS in FileSystem.h comments, added an assertion in Window's Path.inc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99426/new/

[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan marked 2 inline comments as done. abhina.sreeskantharajan added inline comments. Comment at: llvm/include/llvm/Support/FileSystem.h:757 + /// OF_TextWithCRLF = OF_Text | OF_CRLF + OF_TextWithCRLF = 3, + amccarth wrote: > Nit: If it

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added inline comments. Comment at: clang/cmake/modules/AddClang.cmake:127 + LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}${LLVM_LIBDIR_SUFFIX} + ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}${LLVM_LIBDIR_SUFFIX} + RUNTIME DESTINATION

[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan added inline comments. Comment at: llvm/lib/Support/Windows/Path.inc:1086 - if (Flags & OF_Text) + if (Flags & OF_CRLF) CrtOpenFlags |= _O_TEXT; amccarth wrote: > I assume it would be weird to set `OF_CRLF` without also setting

[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

amccarth added a comment. I like the composability enabled by making `OF_Text` and `OF_CRLF` independent. I wonder, though, if there's a chokepoint where we could/should assert if the caller uses `OF_CRLF` without `OF_Text`, which would be suspicious. I'm not concerned by the number of files

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

compnerd added inline comments. Comment at: clang/cmake/modules/AddClang.cmake:127 + LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}${LLVM_LIBDIR_SUFFIX} + ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}${LLVM_LIBDIR_SUFFIX} + RUNTIME DESTINATION

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 334152. Ericson2314 added a comment. include(GNUInstallDirs) in each project unconditionally Before projects that might not be built standalone only included it when they were, but then we got into a situation where no project included it, and things

[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan updated this revision to Diff 334110. abhina.sreeskantharajan edited the summary of this revision. abhina.sreeskantharajan added a comment. Set OF_Text for llvm/tools/dsymutil/DwarfLinkerForBinary.cpp instead of OF_TextWithCRLF. This was also another file I recently

[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan added a comment. In D99426#2656582 , @MaskRay wrote: > In D99426#2656217 , @rnk wrote: > >> In D99426#2653725 , @MaskRay wrote: >> >>> This touches a

[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan updated this revision to Diff 333965. abhina.sreeskantharajan edited the summary of this revision. abhina.sreeskantharajan added a comment. mention OF_CRLF is Windows-only Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan updated this revision to Diff 333960. abhina.sreeskantharajan edited the summary of this revision. abhina.sreeskantharajan added a comment. Rebase + I updated the comments in FileSystem.h to be a bit more descriptive. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

rnk added a comment. In D99426#2653725 , @MaskRay wrote: > This touches a lot of files. I am a bit worried that it would not be easy for > a contributor to know OF_TextWithCRLF is needed to make SystemZ happy. Right, we need to separate text-ness for

[Lldb-commits] [PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

MaskRay added a comment. In D99426#2656217 , @rnk wrote: > In D99426#2653725 , @MaskRay wrote: > >> This touches a lot of files. I am a bit worried that it would not be easy >> for a contributor to know

[Lldb-commits] [PATCH] D99652: [lldb] Prevent that LLDB randomly crashes in CommandLineParser::addOption by initializing LLVM's command line parser

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG18dbe0f954a7: [lldb] Prevent that LLDB randomly crashes in CommandLineParser::addOption by… (authored by teemperor). Herald added a subscriber:

[Lldb-commits] [lldb] 18dbe0f - [lldb] Prevent that LLDB randomly crashes in CommandLineParser::addOption by initializing LLVM's command line parser

Author: Raphael Isemann Date: 2021-04-01T20:17:54+02:00 New Revision: 18dbe0f954a75f25bd57bba95dfa83cc5e2aa497 URL: https://github.com/llvm/llvm-project/commit/18dbe0f954a75f25bd57bba95dfa83cc5e2aa497 DIFF:

[Lldb-commits] [PATCH] D99694: Add support for getting signed ObjC tagged pointer values

shafik added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp:2494 + m_objc_debug_taggedpointer_payload_rshift); + return ClassDescriptorSP(new ClassDescriptorV2Tagged( + actual_class_descriptor_sp,

[Lldb-commits] [PATCH] D99694: Add support for getting signed ObjC tagged pointer values

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4d9039c8dc2d: Add support for fetching signed values from tagged pointers. (authored by jingham). Changed prior to commit:

[Lldb-commits] [lldb] 4d9039c - Add support for fetching signed values from tagged pointers.

Author: Jim Ingham Date: 2021-04-01T10:59:25-07:00 New Revision: 4d9039c8dc2d1f0be1b5ee486d5a83b1614b038a URL: https://github.com/llvm/llvm-project/commit/4d9039c8dc2d1f0be1b5ee486d5a83b1614b038a DIFF: https://github.com/llvm/llvm-project/commit/4d9039c8dc2d1f0be1b5ee486d5a83b1614b038a.diff

[Lldb-commits] [PATCH] D98289: [lldb] 2/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

clayborg added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:489 const llvm::Optional ::GetRnglist() { + if (GetVersion() >= 5 && !m_rnglist_table_done) { +m_rnglist_table_done = true; jankratochvil wrote: > `if

[Lldb-commits] [PATCH] D99746: [lldb/test] Respect --apple-sdk path when querying SDK info

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7d15fb577945: [lldb/test] Respect --apple-sdk path when querying SDK info (authored by vsk). Changed prior to commit:

[Lldb-commits] [lldb] 7d15fb5 - [lldb/test] Respect --apple-sdk path when querying SDK info

Author: Vedant Kumar Date: 2021-04-01T10:15:25-07:00 New Revision: 7d15fb5779452c5efbceb82ce0e1f8724a82d290 URL: https://github.com/llvm/llvm-project/commit/7d15fb5779452c5efbceb82ce0e1f8724a82d290 DIFF: https://github.com/llvm/llvm-project/commit/7d15fb5779452c5efbceb82ce0e1f8724a82d290.diff

[Lldb-commits] [PATCH] D99746: [lldb/test] Respect --apple-sdk path when querying SDK info

vsk added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:69 +# use it. +if configuration.apple_sdk is not None: +return configuration.apple_sdk JDevlieghere wrote: > This will also exclude the empty string. Thanks,

[Lldb-commits] [PATCH] D99746: [lldb/test] Respect --apple-sdk path when querying SDK info

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:69 +# use it. +if configuration.apple_sdk is not None: +return

[Lldb-commits] [PATCH] D99746: [lldb/test] Respect --apple-sdk path when querying SDK info

vsk created this revision. vsk added a reviewer: JDevlieghere. vsk requested review of this revision. Herald added a project: LLDB. Respect --apple-sdk if it's specified. If the SDK simply mounted from some disk image, and not actually installed, this is the only way to use it. Repository:

[Lldb-commits] [PATCH] D98761: Fix "image lookup --address" Summary results for inline functions.

clayborg added a comment. In D98761#2664375 , @clayborg wrote: > Anyone else have any issue with this patch? sorry, I didn't see the accepted part! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98761/new/

[Lldb-commits] [PATCH] D99744: [lldb] Update test.rst with a paragraph about pdb

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0c653d4c3d14: [lldb] Update test.rst with a paragraph about pdb (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] 0c653d4 - [lldb] Update test.rst with a paragraph about pdb

Author: Dave Lee Date: 2021-04-01T09:53:07-07:00 New Revision: 0c653d4c3d1426267337576ab202bb594144111c URL: https://github.com/llvm/llvm-project/commit/0c653d4c3d1426267337576ab202bb594144111c DIFF: https://github.com/llvm/llvm-project/commit/0c653d4c3d1426267337576ab202bb594144111c.diff

[Lldb-commits] [PATCH] D99744: [lldb] Update test.rst with a paragraph about pdb

kastiglione updated this revision to Diff 334734. kastiglione added a comment. s/lldb alias/pdb alias Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99744/new/ https://reviews.llvm.org/D99744 Files: lldb/docs/resources/test.rst Index:

[Lldb-commits] [PATCH] D99744: [lldb] Update test.rst with a paragraph about pdb

kastiglione updated this revision to Diff 334733. kastiglione added a comment. Indent source block Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99744/new/ https://reviews.llvm.org/D99744 Files: lldb/docs/resources/test.rst Index:

[Lldb-commits] [PATCH] D99744: [lldb] Update test.rst with a paragraph about pdb

kastiglione added inline comments. Comment at: lldb/docs/resources/test.rst:387 + +alias lldb self.dbg.HandleCommand("%*") + JDevlieghere wrote: > This should be indented to show up as code. thanks for catching it Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D98761: Fix "image lookup --address" Summary results for inline functions.

clayborg added a comment. Anyone else have any issue with this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98761/new/ https://reviews.llvm.org/D98761 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D99744: [lldb] Update test.rst with a paragraph about pdb

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks, this is super useful. LGTM modulo the inline comment. Comment at: lldb/docs/resources/test.rst:387 + +alias lldb self.dbg.HandleCommand("%*") +

[Lldb-commits] [PATCH] D99744: [lldb] Update test.rst with a paragraph about pdb

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, jingham. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Debugging tests sometimes involves debugging the Python source. This adds a paragraph to

[Lldb-commits] [PATCH] D99603: [lldb] [client] Support for multiprocess extension

mgorny updated this revision to Diff 334725. mgorny added a comment. Add some tests. @labath, I'd use some help now. When the stop reason includes wrong PID, the GDB exchange seems to enter a dead loop: b-remote.async> < 5> send packet: $c#63 b-remote.async> < 25> read packet:

[Lldb-commits] [lldb] 802c5ce - [lldb] Un-XFAIL TestAutoInstallMainExecutable on Windows

Author: Stella Stamenova Date: 2021-04-01T08:46:23-07:00 New Revision: 802c5ce364a21c54c1568c8791b1d5f36c11829e URL: https://github.com/llvm/llvm-project/commit/802c5ce364a21c54c1568c8791b1d5f36c11829e DIFF:

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. @omjavaid I get some new warnings when compiling this on x86: [732/1117] Building CXX object too.../RegisterContextDarwin_arm64.cpp.o In file included from

[Lldb-commits] [PATCH] D98289: [lldb] 2/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:489 const llvm::Optional ::GetRnglist() { + if (GetVersion() >= 5 && !m_rnglist_table_done) { +m_rnglist_table_done = true; `if (GetVersion() < 5) return

[Lldb-commits] [PATCH] D98289: [lldb] 2/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil updated this revision to Diff 334692. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98289/new/ https://reviews.llvm.org/D98289 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp

[Lldb-commits] [PATCH] D99653: [nfc] [lldb] 1/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:498-500 +llvm::Optional DWARFUnit::GetRnglist() { + return m_rnglist_table; +} clayborg wrote: > Return "const

[Lldb-commits] [PATCH] D99653: [nfc] [lldb] 1/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil updated this revision to Diff 334690. jankratochvil added a comment. The patch now requires D99731 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99653/new/ https://reviews.llvm.org/D99653 Files:

[Lldb-commits] [PATCH] D99603: [lldb] [client] Support for multiprocess extension

mgorny updated this revision to Diff 334686. mgorny marked an inline comment as done. mgorny added a comment. Changed `GetCurrentProcessAndThreadIDs()` to return the vector, and reformatted. Tests next. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99603/new/

[Lldb-commits] [PATCH] D99729: [lldb] Improve CPUInfo test predicate

DavidSpickett created this revision. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Use a with block for reading the cpuinfo file. When loading the file fails (or we're not on Linux) return an empty string. Since all the

[Lldb-commits] [PATCH] D97284: [lldb][AArch64] Add MTE CPU feature test predicate

DavidSpickett abandoned this revision. DavidSpickett added a comment. This is now redundant since Omair landed his changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97284/new/ https://reviews.llvm.org/D97284

[Lldb-commits] [lldb] bad5ee1 - [lldb] Make TestLoadUsingLazyBind work on linux

Author: Pavel Labath Date: 2021-04-01T14:49:42+02:00 New Revision: bad5ee15ea2e5a5aaaed9c9a5d9982e23cedba55 URL: https://github.com/llvm/llvm-project/commit/bad5ee15ea2e5a5aaaed9c9a5d9982e23cedba55 DIFF: https://github.com/llvm/llvm-project/commit/bad5ee15ea2e5a5aaaed9c9a5d9982e23cedba55.diff

[Lldb-commits] [lldb] 48e3da1 - [lldb] Rewrite TestAutoInstallMainExecutable logic

Author: Pavel Labath Date: 2021-04-01T14:20:20+02:00 New Revision: 48e3da13519dea3bd91ab7de656c7d46105c2c01 URL: https://github.com/llvm/llvm-project/commit/48e3da13519dea3bd91ab7de656c7d46105c2c01 DIFF: https://github.com/llvm/llvm-project/commit/48e3da13519dea3bd91ab7de656c7d46105c2c01.diff

[Lldb-commits] [lldb] fcea418 - [lldb] [test] Mark lldb-server multiprocess tests as LLGS cat

Author: Michał Górny Date: 2021-04-01T14:17:47+02:00 New Revision: fcea4181bbfbc15a27ad4d3c06a09b706b1d6c47 URL: https://github.com/llvm/llvm-project/commit/fcea4181bbfbc15a27ad4d3c06a09b706b1d6c47 DIFF: https://github.com/llvm/llvm-project/commit/fcea4181bbfbc15a27ad4d3c06a09b706b1d6c47.diff

Re: [Lldb-commits] [PATCH] D98482: [lldb] [server] Support for multiprocess extension

On Thu, 2021-04-01 at 11:14 +0200, Pavel Labath wrote: > I think the first two test just need the "llgs" test category, since > debugserver (obviously) does not support the extension. I don't see > TestGdbserverPort.test failing in the latest build on that page (and I'd > be surprised if this

[Lldb-commits] [PATCH] D99497: [LLDB] Fix sync issue in TestVSCode_launch.test_progress_events

This revision was automatically updated to reflect the committed changes. Closed by commit rGb468f0e165ed: [LLDB] Fix sync issue in TestVSCode_launch.test_progress_events (authored by omjavaid). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] b468f0e - [LLDB] Fix sync issue in TestVSCode_launch.test_progress_events

Author: Muhammad Omair Javaid Date: 2021-04-01T14:16:54+05:00 New Revision: b468f0e165ed67c5b1046b295b65e446afee62aa URL: https://github.com/llvm/llvm-project/commit/b468f0e165ed67c5b1046b295b65e446afee62aa DIFF:

[Lldb-commits] [PATCH] D99497: [LLDB] Fix sync issue in TestVSCode_launch.test_progress_events

omjavaid added a comment. I am going ahead and commit this change till we find a better way to fix the sync issue. sleep time set to 2s now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99497/new/ https://reviews.llvm.org/D99497 ___

Re: [Lldb-commits] [PATCH] D98482: [lldb] [server] Support for multiprocess extension

I think the first two test just need the "llgs" test category, since debugserver (obviously) does not support the extension. I don't see TestGdbserverPort.test failing in the latest build on that page (and I'd be surprised if this was related to that, so I suspect that was just flake. pl On

[Lldb-commits] [lldb] 88a5b35 - Revert "Revert "[LLDB] Arm64/Linux Add MTE and Pointer Authentication registers""

Author: Muhammad Omair Javaid Date: 2021-04-01T14:07:50+05:00 New Revision: 88a5b35d63f927db69ec953ff487a7ba2504a610 URL: https://github.com/llvm/llvm-project/commit/88a5b35d63f927db69ec953ff487a7ba2504a610 DIFF:

[Lldb-commits] [lldb] dd2a63e - Revert "Revert "[LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset""

Author: Muhammad Omair Javaid Date: 2021-04-01T14:10:14+05:00 New Revision: dd2a63e1ee53c1178d8e17a3763edc26d23f00a2 URL: https://github.com/llvm/llvm-project/commit/dd2a63e1ee53c1178d8e17a3763edc26d23f00a2 DIFF:

Re: [Lldb-commits] [PATCH] D98482: [lldb] [server] Support for multiprocess extension

Hi Michał, this commit has caused a test failure on the macos incremental CI bot, http://green.lab.llvm.org/green/blue/organizations/jenkins/lldb-cmake/activity Failed Tests (3): lldb-api :: tools/lldb-server/TestLldbGdbServer.py lldb-api ::

[Lldb-commits] [PATCH] D98822: [lldb] [Process] Watch for fork/vfork notifications

labath added a comment. In D98822#2658780 , @mgorny wrote: > What about debug registers on FreeBSD? This system is pretty unique because > child processes inherit dbregs from parent, and therefore we need to clear > them. GDB doesn't do that and

[Lldb-commits] [PATCH] D99603: [lldb] [client] Support for multiprocess extension

labath added a comment. I think this looks fine. Could you also create a gdb-client test case (you can ignore the default thread thingy)? Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:1131 bool

[Lldb-commits] [lldb] e1d4fb1 - [lldb] Fix build errors from 3bea7306e8

Author: Pavel Labath Date: 2021-04-01T09:01:35+02:00 New Revision: e1d4fb1ebfc612d65331f72bb0827d7206d4 URL: https://github.com/llvm/llvm-project/commit/e1d4fb1ebfc612d65331f72bb0827d7206d4 DIFF: https://github.com/llvm/llvm-project/commit/e1d4fb1ebfc612d65331f72bb0827d7206d4.diff

[Lldb-commits] [lldb] 3bea730 - [lldb] Fix compilation with gcc-6.5

Author: Pavel Labath Date: 2021-04-01T08:44:50+02:00 New Revision: 3bea7306e8669f94bacafae68748a9139cfc0b98 URL: https://github.com/llvm/llvm-project/commit/3bea7306e8669f94bacafae68748a9139cfc0b98 DIFF: https://github.com/llvm/llvm-project/commit/3bea7306e8669f94bacafae68748a9139cfc0b98.diff