[Lldb-commits] [PATCH] D100521: [lldb] Fix up code addresses in RegisterContextUnwind

JDevlieghere updated this revision to Diff 337991. JDevlieghere added a comment. Save a line or two CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100521/new/ https://reviews.llvm.org/D100521 Files: lldb/include/lldb/Target/ABI.h lldb/source/Plugins/ABI/AArch64/ABIAArch64.cpp

[Lldb-commits] [PATCH] D100521: [lldb] Fix up code addresses in RegisterContextUnwind

JDevlieghere added a comment. In D100521#2693669 , @jasonmolenda wrote: > This looks good. Jonas, what do you think about having FixDataAddress() > methods in the ABI's. We're going to be quickly sprinkling FixCodeAddress > calls throughout lldb at

[Lldb-commits] [PATCH] D100521: [lldb] Fix up code addresses in RegisterContextUnwind

JDevlieghere updated this revision to Diff 337989. JDevlieghere added a comment. Implement both `FixCodeAddress` and `FixDataAddress`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100521/new/ https://reviews.llvm.org/D100521 Files: lldb/include/lldb/Target/ABI.h

[Lldb-commits] [PATCH] D100521: [lldb] Fix up code addresses in RegisterContextUnwind

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. This looks good. Jonas, what do you think about having FixDataAddress() methods in the ABI's. We're going to be quickly sprinkling FixCodeAddress calls throughout lldb at places

[Lldb-commits] [PATCH] D100515: [lldb] Add GetCodeAddressMask and GetDataAddressMask to Process

jasonmolenda accepted this revision. jasonmolenda added a comment. I think we've heard from everyone involved with this & it's good to land. Thanks for bringing this home. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100515/new/ https://reviews.llvm.org/D100515

[Lldb-commits] [lldb] 9d4415d - Don't refer to allocation map entry after deallocating it

Author: Jason Molenda Date: 2021-04-15T20:16:38-07:00 New Revision: 9d4415d01d234efb5dd46bdcbb280c03e12a8101 URL: https://github.com/llvm/llvm-project/commit/9d4415d01d234efb5dd46bdcbb280c03e12a8101 DIFF: https://github.com/llvm/llvm-project/commit/9d4415d01d234efb5dd46bdcbb280c03e12a8101.diff

[Lldb-commits] [PATCH] D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files.

jingham added a comment. In D97786#2693381 , @cmtice wrote: > I had to revert this change because the test case broke the windows builder. > What's the right way to update/mark the test case so that it is only run on > appropriate architectures &

[Lldb-commits] [PATCH] D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files.

cmtice added a comment. I had to revert this change because the test case broke the windows builder. What's the right way to update/mark the test case so that it is only run on appropriate architectures & operating systems? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 042668d - Revert "[LLDB] Use path relative to binary for finding .dwo files."

Author: Caroline Tice Date: 2021-04-15T17:17:44-07:00 New Revision: 042668d092bb585e526023027faee8d28f968a76 URL: https://github.com/llvm/llvm-project/commit/042668d092bb585e526023027faee8d28f968a76 DIFF: https://github.com/llvm/llvm-project/commit/042668d092bb585e526023027faee8d28f968a76.diff

[Lldb-commits] [PATCH] D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files.

stella.stamenova added a comment. This broke the windows LLDB bot. Please fix it soon or revert. https://lab.llvm.org/buildbot/#/builders/83/builds/5685 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97786/new/ https://reviews.llvm.org/D97786

[Lldb-commits] [lldb] 8639e2a - [lldb] Raise a CrashLogParseException when failing to parse JSON crashlog

Author: Jonas Devlieghere Date: 2021-04-15T15:28:23-07:00 New Revision: 8639e2aaaffe1c58fbab238b25d49620ca86a76d URL: https://github.com/llvm/llvm-project/commit/8639e2aaaffe1c58fbab238b25d49620ca86a76d DIFF:

[Lldb-commits] [PATCH] D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb241f3cb292d: [LLDB] Use path relative to binary for finding .dwo files. (authored by cmtice). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] b241f3c - [LLDB] Use path relative to binary for finding .dwo files.

Author: Caroline Tice Date: 2021-04-15T14:43:47-07:00 New Revision: b241f3cb292d0ba1ad5a33b3bbd4a8a3a9c909dc URL: https://github.com/llvm/llvm-project/commit/b241f3cb292d0ba1ad5a33b3bbd4a8a3a9c909dc DIFF: https://github.com/llvm/llvm-project/commit/b241f3cb292d0ba1ad5a33b3bbd4a8a3a9c909dc.diff

[Lldb-commits] [PATCH] D100191: [lldb] [llgs] Support owning and detaching extra processes

mgorny added a comment. In D100191#2689489 , @labath wrote: > We should also start thinking about tests. I suppose the smallest piece of > functionality that could be usefully tested (with a lldb-server test) is > debugging a process that forks,

[Lldb-commits] [PATCH] D100515: [lldb] Add GetCodeAddressMask and GetDataAddressMask to Process

JDevlieghere added inline comments. Comment at: lldb/source/Target/Process.cpp:5569-5570 + + if (m_code_address_mask == 0) +return -1; // All bits are used for addressing. + jasonmolenda wrote: > pcc wrote: > > Is this part correct? (Same below.) In D100521

[Lldb-commits] [PATCH] D100521: [lldb] Fix up code addresses in RegisterContextUnwind

JDevlieghere updated this revision to Diff 337892. JDevlieghere added a comment. Check for mask == -1 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100521/new/ https://reviews.llvm.org/D100521 Files: lldb/source/Plugins/ABI/AArch64/ABIMacOSX_arm64.cpp

[Lldb-commits] [PATCH] D100418: [lldb] [MainLoop] Support multiple callbacks per signal

labath added a comment. Looks good, just add the test case. Comment at: lldb/source/Host/common/MainLoop.cpp:413-415 +llvm::SmallVector callbacks_to_run; +for (auto : it->second.callbacks) + callbacks_to_run.push_back(x); llvm::SmallVector

[Lldb-commits] [PATCH] D100515: [lldb] Add GetCodeAddressMask and GetDataAddressMask to Process

jasonmolenda added inline comments. Comment at: lldb/source/Target/Process.cpp:5569-5570 + + if (m_code_address_mask == 0) +return -1; // All bits are used for addressing. + pcc wrote: > Is this part correct? (Same below.) In D100521 you have > ``` > if

[Lldb-commits] [PATCH] D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Yes, thanks for bearing with me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97786/new/ https://reviews.llvm.org/D97786 ___

[Lldb-commits] [PATCH] D100384: [lldb/Plugins] Update ScriptedProcess Process Plugin

jingham added a comment. A bunch of little comments. I was also curious why you directly set the running private state, but use the async thread to generate the stopped events? Comment at: lldb/source/Plugins/Process/CMakeLists.txt:15 endif() +if (LLDB_ENABLE_PYTHON) +

[Lldb-commits] [PATCH] D100515: [lldb] Add GetCodeAddressMask and GetDataAddressMask to Process

justincohen accepted this revision. justincohen added a comment. This revision is now accepted and ready to land. > On Darwin, we use the same number of bits for both code and data, but given > the way ptrace() behaves on Linux, I'm guessing this may not be the case > everywhere. Should we

[Lldb-commits] [PATCH] D100515: [lldb] Add GetCodeAddressMask and GetDataAddressMask to Process

jasonmolenda added a comment. In D100515#2690972 , @omjavaid wrote: > > This looks very good and I have couple of highlights to make from > Linux/AArch64 perspective: > qHostInfo is not sufficient for mask calculation on Linux because both >

[Lldb-commits] [PATCH] D100500: Add setting to artifically delay communication with the debug server, in order ro simulate slow network conditions

aprantl added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemoteProperties.td:23 +DefaultUnsignedValue<0>, +Desc<"If greater than 0, sleep for packet-delay-multiplier * packet size nanoseconds for every packet sent or received.">; }

[Lldb-commits] [PATCH] D100515: [lldb] Add GetCodeAddressMask and GetDataAddressMask to Process

pcc added inline comments. Comment at: lldb/source/Target/Process.cpp:5569-5570 + + if (m_code_address_mask == 0) +return -1; // All bits are used for addressing. + Is this part correct? (Same below.) In D100521 you have ``` if (pc & pac_sign_extension)

[Lldb-commits] [PATCH] D100508: [lldb] Simplify output for skipped categories in dotest.py

rupprecht added a comment. > The motivation for this change is that sometimes engineers misidentify the > output of these messages as the cause for a test failure I have worked on one these checks and *still* gotten confused by the message, so thanks :) Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D100500: Add setting to artifically delay communication with the debug server, in order ro simulate slow network conditions

augusto2112 added a comment. Hey @jasonmolenda thanks for the input, and nice empirical experiment! Do you think simply adding a setting that sleeps by a constant amount would be enough to model this problem? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D100554: [lldb] [Process/NetBSD] Report fork/vfork events to LLGS

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. mgorny requested review of this revision. https://reviews.llvm.org/D100554 Files: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.h

[Lldb-commits] [PATCH] D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only

augusto2112 updated this revision to Diff 337735. augusto2112 added a comment. Updates all calls to ReadMemory to keep the current behavior. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100338/new/ https://reviews.llvm.org/D100338 Files:

[Lldb-commits] [PATCH] D100547: [lldb] [Process/FreeBSD] Report fork/vfork events to LLGS

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. mgorny requested review of this revision. https://reviews.llvm.org/D100547 Files: lldb/source/Plugins/Process/FreeBSD/NativeProcessFreeBSD.cpp lldb/source/Plugins/Process/FreeBSD/NativeProcessFreeBSD.h

[Lldb-commits] [PATCH] D100541: [lldb] [gdb-remote client] Support detaching by PID

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. mgorny requested review of this revision. https://reviews.llvm.org/D100541 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp

[Lldb-commits] [lldb] 0f3ed7a - [lldb] Fix incorrect test data in FileSpecTest.IsRelative

Author: Raphael Isemann Date: 2021-04-15T12:42:47+02:00 New Revision: 0f3ed7a48dba2eb3ad726fc8f513159baca13b71 URL: https://github.com/llvm/llvm-project/commit/0f3ed7a48dba2eb3ad726fc8f513159baca13b71 DIFF:

[Lldb-commits] [PATCH] D100515: [lldb] Add GetCodeAddressMask and GetDataAddressMask to Process

omjavaid added a comment. In D100515#2690225 , @jasonmolenda wrote: > Thanks Jonas, I think this change to Process can cover > > Omair's use case, where the number of bits are used hardcoded. > > The Darwin use case were ProcessGDBRemote,

[Lldb-commits] [PATCH] D100493: [lldb][AArch64] Don't check for VmFlags in smaps files

DavidSpickett added a comment. Looks like buildkite had issues calling back to Phab yesterday so the builds didn't signal here. This test wouldn't get run in those anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100493/new/

[Lldb-commits] [lldb] 71a45e7 - NFC put the armv6m entry with the other Cortex-M entries

Author: Jason Molenda Date: 2021-04-15T02:02:26-07:00 New Revision: 71a45e7c63285614364d3d5dfcb4d48da6e7535d URL: https://github.com/llvm/llvm-project/commit/71a45e7c63285614364d3d5dfcb4d48da6e7535d DIFF: https://github.com/llvm/llvm-project/commit/71a45e7c63285614364d3d5dfcb4d48da6e7535d.diff

[Lldb-commits] [PATCH] D100515: [lldb] Add GetCodeAddressMask and GetDataAddressMask to Process

DavidSpickett added a comment. > I don't feel strongly about the method name. Justin used > Process::GetPointerAuthenticationAddressMask which makes it sound specific to > ARM v8.3 ptrauth. The ARM v8.5 MTE tagging might be another use case (or TBI > as Omair has noted). I'd go with the

[Lldb-commits] [lldb] 01ad95f - Mark armv6m compat with armv7em; match armv7em being compat with armv6m

Author: Jason Molenda Date: 2021-04-15T01:30:51-07:00 New Revision: 01ad95ff2a7cc127eddf3832693bbd5c6c54f9ef URL: https://github.com/llvm/llvm-project/commit/01ad95ff2a7cc127eddf3832693bbd5c6c54f9ef DIFF: https://github.com/llvm/llvm-project/commit/01ad95ff2a7cc127eddf3832693bbd5c6c54f9ef.diff