[Lldb-commits] [PATCH] D105741: [trace] Add `thread trace export` command for Intel PT trace visualization

wallace added a comment. Pretty good. Just some minor nits. Once you rebase on top of the trace exporter plugin patch, this should be good to go. Comment at: lldb/test/API/commands/trace/TestTraceExport.py:54-56 +TODO: Once the "trace save" command is implemented,

[Lldb-commits] [PATCH] D106501: [trace] Add the definition of a TraceExporter plugin

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc1b4632528cb: [trace] Add the definition of a TraceExporter plugin (authored by Walter Erquinigo wall...@fb.com). Repository: rG LLVM Github

[Lldb-commits] [lldb] c1b4632 - [trace] Add the definition of a TraceExporter plugin

Author: Walter Erquinigo Date: 2021-07-26T18:01:50-07:00 New Revision: c1b4632528cb405c9ef94cff90bf43afe688a899 URL: https://github.com/llvm/llvm-project/commit/c1b4632528cb405c9ef94cff90bf43afe688a899 DIFF:

[Lldb-commits] [lldb] 1a3bf29 - [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

Author: Amy Huang Date: 2021-07-26T17:24:42-07:00 New Revision: 1a3bf2953a9209fdc4dbb6e99678e02a7fec019d URL: https://github.com/llvm/llvm-project/commit/1a3bf2953a9209fdc4dbb6e99678e02a7fec019d DIFF: https://github.com/llvm/llvm-project/commit/1a3bf2953a9209fdc4dbb6e99678e02a7fec019d.diff

[Lldb-commits] [PATCH] D105215: [lldb] Remove CPlusPlusLanguage from Mangled

clayborg added inline comments. Comment at: lldb/source/Core/Mangled.cpp:322 if (preference == ePreferDemangledWithoutArguments) { -return GetDemangledNameWithoutArguments(m_mangled, demangled); +if (Language *lang = Language::FindPlugin(GuessLanguage())) { +

[Lldb-commits] [PATCH] D106837: Create synthetic symbol names on demand to improve memory consumption and startup times.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. good luck with the build bots! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106837/new/ https://reviews.llvm.org/D106837

[Lldb-commits] [PATCH] D106837: Create synthetic symbol names on demand to improve memory consumption and startup times.

clayborg created this revision. clayborg added reviewers: JDevlieghere, wallace. Herald added subscribers: kristof.beyls, emaste. clayborg requested review of this revision. Herald added subscribers: lldb-commits, MaskRay. Herald added a project: LLDB. This is a resubmission of

[Lldb-commits] [PATCH] D106270: [DWARF5] Fix offset check when using .debug_names

shafik added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3024 -m_index->GetGlobalVariables( -dwarf_cu->GetNonSkeletonUnit(), [&](DWARFDIE die) { - VariableSP var_sp( So is the problem

[Lldb-commits] [PATCH] D106712: Remember to check whether the current thread is stopped for a no-stop signal

shafik added inline comments. Comment at: lldb/source/Target/Process.cpp:780 StopReason curr_thread_stop_reason = eStopReasonInvalid; -if (curr_thread) { +bool prefer_curr_thread = false; +if (curr_thread && curr_thread->IsValid()) {

[Lldb-commits] [PATCH] D106832: [lldb] [gdb-remote client] Avoid zero padding PID/TID in H packet

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3c3269559ba9: [lldb] [gdb-remote client] Avoid zero padding PID/TID in H packet (authored by mgorny). Herald added a project: LLDB. Repository:

[Lldb-commits] [lldb] 3c32695 - [lldb] [gdb-remote client] Avoid zero padding PID/TID in H packet

Author: Michał Górny Date: 2021-07-27T00:44:43+02:00 New Revision: 3c3269559ba9400224400b96c22b31812638de52 URL: https://github.com/llvm/llvm-project/commit/3c3269559ba9400224400b96c22b31812638de52 DIFF: https://github.com/llvm/llvm-project/commit/3c3269559ba9400224400b96c22b31812638de52.diff

[Lldb-commits] [PATCH] D106832: [lldb] [gdb-remote client] Avoid zero padding PID/TID in H packet

ted accepted this revision. ted added a comment. This revision is now accepted and ready to land. LGTM. Thanks Michał! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106832/new/ https://reviews.llvm.org/D106832 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D106832: [lldb] [gdb-remote client] Avoid zero padding PID/TID

mgorny created this revision. mgorny added reviewers: JDevlieghere, krytarowski, emaste, rovka, ted. mgorny requested review of this revision. Change SetCurrentThread*() logic not to include the zero padding in PID/TID that was a side effect of 02ef0f5ab483

[Lldb-commits] [PATCH] D105166: Fix expression evaluation result expansion in lldb-vscode

yinghuitan added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:1790 g_vsc.focus_tid = thread.GetThreadID(); +g_vsc.WillContinue(); thread.StepOver(); clayborg wrote: > Remove and handle in "eStateStopped" or "eStateRunning" as

[Lldb-commits] [PATCH] D105166: Fix expression evaluation result expansion in lldb-vscode

yinghuitan updated this revision to Diff 361815. yinghuitan marked 4 inline comments as done. yinghuitan added a comment. Fix the issue in setVariable request. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105166/new/

Re: [Lldb-commits] [PATCH] D105215: [lldb] Remove CPlusPlusLanguage from Mangled

Mostly I was reacting to your saying the "fully qualified name" idea was too much of a C++ specific thing and didn't belong in the Language abstraction. That doesn't seem to me right. Swift has module names & class namespaces, etc. And you might want to dial up all methods with some base

[Lldb-commits] [PATCH] D106553: [LLDB][GUI] Resolve paths in file/directory fields

clayborg added a comment. In D106553#2905223 , @OmarEmaraDev wrote: > @clayborg Did you check D106564 ? This is > the last patch needed to do the rebase. Just committed that one and also the one that selects the right

[Lldb-commits] [PATCH] D106564: [LLDB][GUI] Add Arch Field

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGed5b4dbd3952: [LLDB][GUI] Add Arch Field (authored by

[Lldb-commits] [lldb] ed5b4db - [LLDB][GUI] Add Arch Field

Author: Omar Emara Date: 2021-07-26T14:22:25-07:00 New Revision: ed5b4dbd3952ffa8970ae59faa7f7505cd28aa92 URL: https://github.com/llvm/llvm-project/commit/ed5b4dbd3952ffa8970ae59faa7f7505cd28aa92 DIFF: https://github.com/llvm/llvm-project/commit/ed5b4dbd3952ffa8970ae59faa7f7505cd28aa92.diff

[Lldb-commits] [PATCH] D100243: [LLDB][GUI] Expand selected thread tree item by default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfed25ddc1c3d: [LLDB][GUI] Expand selected thread tree item by default (authored by OmarEmaraDev, committed by clayborg). Repository: rG LLVM

[Lldb-commits] [lldb] fed25dd - [LLDB][GUI] Expand selected thread tree item by default

Author: Omar Emara Date: 2021-07-26T14:20:50-07:00 New Revision: fed25ddc1c3de59aa1de27e95b349f86896ccb79 URL: https://github.com/llvm/llvm-project/commit/fed25ddc1c3de59aa1de27e95b349f86896ccb79 DIFF: https://github.com/llvm/llvm-project/commit/fed25ddc1c3de59aa1de27e95b349f86896ccb79.diff

[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

jankratochvil accepted this revision. jankratochvil added a comment. This revision is now accepted and ready to land. Approved after removing the curly brackets. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp:136 continue; if

[Lldb-commits] [PATCH] D105215: [lldb] Remove CPlusPlusLanguage from Mangled

bulbazord added a comment. ping! @jingham I can change the name to `GetFullyQualifiedBaseName` if needed. Is there anything else here that should be changed or addressed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105215/new/

[Lldb-commits] [lldb] e42edce - [lldb][NFC] Delete unused and commented out DWARF constants

Author: Alex Langford Date: 2021-07-26T12:26:35-07:00 New Revision: e42edce4a349efeedde2ffd07a26a6335178d24b URL: https://github.com/llvm/llvm-project/commit/e42edce4a349efeedde2ffd07a26a6335178d24b DIFF: https://github.com/llvm/llvm-project/commit/e42edce4a349efeedde2ffd07a26a6335178d24b.diff

[Lldb-commits] [PATCH] D106553: [LLDB][GUI] Resolve paths in file/directory fields

OmarEmaraDev added a comment. @clayborg Did you check D106564 ? This is the last patch needed to do the rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106553/new/ https://reviews.llvm.org/D106553

[Lldb-commits] [PATCH] D106553: [LLDB][GUI] Resolve paths in file/directory fields

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa98f394e81f4: [LLDB][GUI] Resolve paths in file/directory fields (authored by OmarEmaraDev, committed by clayborg). Repository: rG LLVM Github

[Lldb-commits] [lldb] a98f394 - [LLDB][GUI] Resolve paths in file/directory fields

Author: Omar Emara Date: 2021-07-26T11:05:10-07:00 New Revision: a98f394e81f4dd70dc2a4a3a6640b10a6144cc3f URL: https://github.com/llvm/llvm-project/commit/a98f394e81f4dd70dc2a4a3a6640b10a6144cc3f DIFF: https://github.com/llvm/llvm-project/commit/a98f394e81f4dd70dc2a4a3a6640b10a6144cc3f.diff

[Lldb-commits] [PATCH] D106553: [LLDB][GUI] Resolve paths in file/directory fields

clayborg accepted this revision. clayborg added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:1308 } if (FileSystem::Instance().IsDirectory(file)) { SetError("Not a file!");

[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

jankratochvil added a comment. In D106355#2903655 , @kimanh wrote: > Ah, to make sure that I understand it correctly: using `gdb-add-index` would > help `ManualDWARFIndex` to generate a `.debug_names`? No. One could write hypothetical `lldb-add-index`

[Lldb-commits] [PATCH] D106194: Tests for: D100299: Be lazier about loading .dwo files

jankratochvil abandoned this revision. jankratochvil added a comment. It has been merged to D100299 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106194/new/ https://reviews.llvm.org/D106194

[Lldb-commits] [lldb] b71b250 - [test] Fix PayloadString: in lldb tests

Author: Fangrui Song Date: 2021-07-26T10:00:05-07:00 New Revision: b71b25008f2a746d11ed1db1f49a6461b387cc8a URL: https://github.com/llvm/llvm-project/commit/b71b25008f2a746d11ed1db1f49a6461b387cc8a DIFF: https://github.com/llvm/llvm-project/commit/b71b25008f2a746d11ed1db1f49a6461b387cc8a.diff

[Lldb-commits] [PATCH] D105470: [lldb] Clear children of ValueObject on value update

werat updated this revision to Diff 361649. werat added a comment. [clang-tidy] Always open files using UTF-8 encoding The encoding used for opening files depends on the OS and might be different from UTF-8 (e.g. on Windows it can be CP-1252). The documentation files use UTF-8 and might be

[Lldb-commits] [PATCH] D106194: Tests for: D100299: Be lazier about loading .dwo files

jankratochvil added a comment. @Eric yes, it would be better to merge it with your D100299 . In D106194#2894795 , @Eric wrote: > Instead of echoing into .c files, can we write the tests as .c files? It > seems to be a

[Lldb-commits] [PATCH] D105788: [LLDB] Silence warnings from ScriptedProcessPythonInterface.cpp

omjavaid added a comment. In D105788#2897981 , @mib wrote: > Hi @omjavaid , please let me know if you're still seeing the warnings. Thanks. Yes all warnings fixed now. Thanks for taking care of this. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D106270: [DWARF5] Fix offset check when using .debug_names

kimanh added a comment. Ping on this thread, any comment/guidance on this would help us a lot! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106270/new/ https://reviews.llvm.org/D106270 ___ lldb-commits

[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

kimanh added a comment. > If you do not want to debug those libraries cannot you just strip debug info > from them (`llvm-strip -g`)? Oh, stripping debug info may work. We're on the Chrome DevTools team and we're working on a DWARF-based debugging extension for C/C++. Ideally we'd like to

[Lldb-commits] [PATCH] D105180: [lldb][AArch64] Add memory tag writing to lldb-server

omjavaid added inline comments. Comment at: lldb/test/API/tools/lldb-server/memory-tagging/TestGdbRemoteMemoryTagging.py:56 # Run the packet stream context = self.expect_gdbremote_sequence() self.assertIsNotNone(context) DavidSpickett