[Lldb-commits] [PATCH] D113519: [lldb] [gdb-server] Fix fill_clamp to handle signed src types

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:776 + constexpr auto T_max = std::numeric_limits::max(); + dest = src >= 0 && static_cast(src) <= T_max ? src :

[Lldb-commits] [PATCH] D113519: [lldb] [gdb-server] Fix fill_clamp to handle signed src types

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:776 + constexpr auto T_max = std::numeric_limits::max(); + dest = src >= 0

[Lldb-commits] [PATCH] D108078: [lldb] Support gdbserver signals

labath accepted this revision. labath added inline comments. Comment at: lldb/test/API/functionalities/gdb_remote_client/TestGDBRemoteClient.py:486 + lldb.eStopReasonSignal) +# NB: this may need adjusting per current platform +

[Lldb-commits] [PATCH] D112107: [lldb] Fix Scripted ProcessLaunchInfo Argument nullptr deref

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks. This LGTM! Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.h:36 std::string m_class_name; -StructuredData::DictionarySP

[Lldb-commits] [PATCH] D112047: [lldb/test] Update TestScriptedProcess to use skinny corefiles

JDevlieghere added inline comments. Comment at: lldb/examples/python/scripted_process/stack_core_scripted_process.py:1 +import os,struct,signal + mib wrote: > JDevlieghere wrote: > > This should live next to the test. I don't see a point of shipping this to >

[Lldb-commits] [PATCH] D113362: [formatters] Add a libstdcpp formatter for forward_list and refactor list formatter

This revision was automatically updated to reflect the committed changes. Closed by commit rG577c1eecf8c4: [formatters] Add a libstdcpp formatter for forward_list and refactor list… (authored by danilashtefan, committed by Walter Erquinigo wall...@fb.com). Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 577c1ee - [formatters] Add a libstdcpp formatter for forward_list and refactor list formatter

Author: Danil Stefaniuc Date: 2021-11-09T21:33:08-08:00 New Revision: 577c1eecf8c4b078eecb57e1c5b8d86adfc3c08a URL: https://github.com/llvm/llvm-project/commit/577c1eecf8c4b078eecb57e1c5b8d86adfc3c08a DIFF:

[Lldb-commits] [PATCH] D113533: [LLDB] Remove access check of decl in TypeSystemClang.cpp

shafik added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:95 - // that Clang calls its internal Decl::AccessDeclContextSanity check. - decl->getAccess(); -#endif No, we don't care about the return value but we care

[Lldb-commits] [PATCH] D113533: [LLDB] Remove access check of decl in TypeSystemClang.cpp

zequanwu created this revision. zequanwu added reviewers: labath, shafik. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. As the deleted comment says, we don't care about the access specifier. I also encountered a crash at here

[Lldb-commits] [PATCH] D112047: [lldb/test] Update TestScriptedProcess to use skinny corefiles

mib updated this revision to Diff 386021. mib marked 2 inline comments as done. mib added a comment. Address @JDevlieghere comments and skip test for non x86_64 archs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112047/new/

[Lldb-commits] [PATCH] D112047: [lldb/test] Update TestScriptedProcess to use skinny corefiles

mib marked 3 inline comments as done. mib added inline comments. Comment at: lldb/examples/python/scripted_process/stack_core_scripted_process.py:1 +import os,struct,signal + JDevlieghere wrote: > This should live next to the test. I don't see a point of

[Lldb-commits] [PATCH] D113449: Revert "[lldb] Disable minimal import mode for RecordDecls that back FieldDecls"

rupprecht added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/PR52257.cpp:21 +}; +B b; teemperor wrote: > FWIW, I think probably should be an API test (for a bunch of reasons from not > relying on formatting output to remote device testing), but

[Lldb-commits] [PATCH] D112147: [lldb] Fix lookup for global constants in namespaces

shafik added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3281-3282 if ((parent_tag == DW_TAG_compile_unit || - parent_tag == DW_TAG_partial_unit) && + parent_tag == DW_TAG_partial_unit || + parent_tag ==

[Lldb-commits] [PATCH] D112109: [lldb/Plugins] Serialize ProcessLaunchInfo ScriptedProcess Dictionary

mib abandoned this revision. mib added a comment. Dropping this in favour of D112107 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112109/new/ https://reviews.llvm.org/D112109

[Lldb-commits] [PATCH] D112107: [lldb] Fix Scripted ProcessLaunchInfo Argument nullptr deref

mib updated this revision to Diff 386005. mib retitled this revision from "[lldb/Plugins] Make `ScriptedInterface::CreatePluginObject` more generic" to "[lldb] Fix Scripted ProcessLaunchInfo Argument nullptr deref". mib edited the summary of this revision. mib added a comment. Address

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

JDevlieghere added a comment. Rather than percolating up a JSON string, we should use `StructuredData` (and `SBStructuredData` at the SB API layer) and only convert it to JSON at the very last moment. Comment at: lldb/tools/driver/Driver.cpp:410 +} else { +

[Lldb-commits] [PATCH] D110804: Add a new command "target metrics".

clayborg abandoned this revision. clayborg added a comment. This was submitted as a series of patches that updated "statistics dump" to emit JSON: https://reviews.llvm.org/D111686 https://reviews.llvm.org/D112279 https://reviews.llvm.org/D112501 https://reviews.llvm.org/D112683

[Lldb-commits] [PATCH] D113487: [lldb] Refactor Platform::ResolveExecutable

clayborg added a comment. LGTM. I will ok soon if no one else chimes in! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113487/new/ https://reviews.llvm.org/D113487 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D113521: Allow lldb to launch a remote executable when there isn't a local copy

jingham created this revision. jingham added reviewers: clayborg, labath, jasonmolenda, JDevlieghere. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. lldb doesn't need to have a local copy of the binary that it is going to ask the

[Lldb-commits] [PATCH] D113400: [lldb-vscode] Add presentation hints for scopes

clayborg added a comment. nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113400/new/ https://reviews.llvm.org/D113400 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D112147: [lldb] Fix lookup for global constants in namespaces

clayborg added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3281-3282 if ((parent_tag == DW_TAG_compile_unit || - parent_tag == DW_TAG_partial_unit) && + parent_tag == DW_TAG_partial_unit || + parent_tag ==

[Lldb-commits] [PATCH] D113519: [lldb] [gdb-server] Fix fill_clamp to handle signed src types

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski, shafik. mgorny requested review of this revision. Fix the fill_clamp() function to handle signed source types. Make sure that the source value is always non-negative, and cast it to unsigned when verifying the

[Lldb-commits] [PATCH] D113449: Revert "[lldb] Disable minimal import mode for RecordDecls that back FieldDecls"

teemperor added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/PR52257.cpp:21 +}; +B b; FWIW, I think probably should be an API test (for a bunch of reasons from not relying on formatting output to remote device testing), but given this is just

[Lldb-commits] [PATCH] D113449: Revert "[lldb] Disable minimal import mode for RecordDecls that back FieldDecls"

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks for this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113449/new/ https://reviews.llvm.org/D113449

[Lldb-commits] [PATCH] D113449: Revert "[lldb] Disable minimal import mode for RecordDecls that back FieldDecls"

rupprecht added a comment. Given that this patch has been in tree for half a year, it'd be good to get confirmation here this can be reverted given there is now a test case for causing a crash. I got an offline comment that this is OK to revert, so if nobody has objections, I'll land sometime

[Lldb-commits] [PATCH] D107840: [lldb] [gdb-server] Implement the vFile:fstat packet

shafik added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:762 +static void fill_clamp(T , U src, typename T::value_type fallback) { + dest = src <= std::numeric_limits::max() ? src +

[Lldb-commits] [PATCH] D110578: [lldb] Add support for D programming language

ljmf00 added a comment. Since D111414 got merged, @teemperor can you land this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110578/new/ https://reviews.llvm.org/D110578

[Lldb-commits] [PATCH] D107840: [lldb] [gdb-server] Implement the vFile:fstat packet

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:762 +static void fill_clamp(T , U src, typename T::value_type fallback) { + dest = src <= std::numeric_limits::max() ? src +

[Lldb-commits] [PATCH] D108078: [lldb] Support gdbserver signals

mgorny updated this revision to Diff 385917. mgorny edited the summary of this revision. mgorny added a comment. Add fallback to `QThreadSuffixSupported` and a respective test. Improve the summary. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108078/new/

[Lldb-commits] [PATCH] D107840: [lldb] [gdb-server] Implement the vFile:fstat packet

shafik added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:762 +static void fill_clamp(T , U src, typename T::value_type fallback) { + dest = src <= std::numeric_limits::max() ? src +

[Lldb-commits] [PATCH] D112147: [lldb] Fix lookup for global constants in namespaces

tonkosi added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3281-3282 if ((parent_tag == DW_TAG_compile_unit || - parent_tag == DW_TAG_partial_unit) && + parent_tag == DW_TAG_partial_unit || + parent_tag ==

[Lldb-commits] [PATCH] D113362: [formatters] Add a libstdcpp formatter for forward_list and refactor list formatter

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113362/new/ https://reviews.llvm.org/D113362

[Lldb-commits] [PATCH] D113362: [formatters] Add a libstdcpp formatter for forward_list and refactor list formatter

danilashtefan updated this revision to Diff 385904. danilashtefan added a comment. Right size is returned and tests are unified! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113362/new/ https://reviews.llvm.org/D113362 Files:

[Lldb-commits] [PATCH] D113330: [LLDB][Breakpad] Make lldb understand INLINE and INLINE_ORIGIN records in breakpad.

zequanwu updated this revision to Diff 385903. zequanwu marked an inline comment as done. zequanwu added a comment. Use empty callsite_file or name if index is out of range. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113330/new/

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:337 + std::lock_guard guard(GetModuleMutex()); + if (!(name_type_mask & eFunctionNameTypeMethod)) +return; labath wrote: > How did you come to pick

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

zequanwu updated this revision to Diff 385896. zequanwu marked 3 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113163/new/ https://reviews.llvm.org/D113163 Files:

[Lldb-commits] [lldb] adc7d63 - [lldb] XFAIL TestPlatformKill on windows

Author: Pavel Labath Date: 2021-11-09T19:50:14+01:00 New Revision: adc7d63f46a70e68c60ecd4ad17f09eb6f4abbca URL: https://github.com/llvm/llvm-project/commit/adc7d63f46a70e68c60ecd4ad17f09eb6f4abbca DIFF: https://github.com/llvm/llvm-project/commit/adc7d63f46a70e68c60ecd4ad17f09eb6f4abbca.diff

[Lldb-commits] [lldb] 68a4d17 - Use yaml2obj instead of relying on invoking the Darwin system assembler.

Author: Adrian Prantl Date: 2021-11-09T10:47:26-08:00 New Revision: 68a4d179c2ac4c882f2d242b81748ceed66827ff URL: https://github.com/llvm/llvm-project/commit/68a4d179c2ac4c882f2d242b81748ceed66827ff DIFF: https://github.com/llvm/llvm-project/commit/68a4d179c2ac4c882f2d242b81748ceed66827ff.diff

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

werat updated this revision to Diff 385892. werat added a comment. Herald added a subscriber: JDevlieghere. Remove accidental code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113498/new/ https://reviews.llvm.org/D113498 Files:

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

werat created this revision. werat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Operands to `getelementptr` can be constants or constant expressions. Check that all operands can be constant-resolved and resolve them during the

[Lldb-commits] [lldb] 56f7da6 - Add a requires line to test.

Author: Adrian Prantl Date: 2021-11-09T10:16:03-08:00 New Revision: 56f7da6e0d29139d7684b2dc08901fefb64e4fa1 URL: https://github.com/llvm/llvm-project/commit/56f7da6e0d29139d7684b2dc08901fefb64e4fa1 DIFF: https://github.com/llvm/llvm-project/commit/56f7da6e0d29139d7684b2dc08901fefb64e4fa1.diff

[Lldb-commits] [PATCH] D113445: Support looking up absolute symbols

This revision was automatically updated to reflect the committed changes. Closed by commit rGc9881c7d99c6: Support looking up absolute symbols (authored by aprantl). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] c9881c7 - Support looking up absolute symbols

Author: Adrian Prantl Date: 2021-11-09T09:44:37-08:00 New Revision: c9881c7d99c6e4073ed8de11cd3450ef23bd66fc URL: https://github.com/llvm/llvm-project/commit/c9881c7d99c6e4073ed8de11cd3450ef23bd66fc DIFF: https://github.com/llvm/llvm-project/commit/c9881c7d99c6e4073ed8de11cd3450ef23bd66fc.diff

[Lldb-commits] [PATCH] D109101: [lldb] Add an option to specify a VFS overlay

JDevlieghere abandoned this revision. JDevlieghere added a comment. Looks like there's an easier way to test this, so no need to add another SB API. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109101/new/ https://reviews.llvm.org/D109101

[Lldb-commits] [PATCH] D113400: [lldb-vscode] Add presentation hints for scopes

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc8f0035ca99: [lldb-vscode] Add presentation hints for scopes (authored by werat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113400/new/

[Lldb-commits] [lldb] dc8f003 - [lldb-vscode] Add presentation hints for scopes

Author: Andy Yankovsky Date: 2021-11-09T17:50:46+01:00 New Revision: dc8f0035ca990fc5587bd508fed609f995e7c842 URL: https://github.com/llvm/llvm-project/commit/dc8f0035ca990fc5587bd508fed609f995e7c842 DIFF:

[Lldb-commits] [PATCH] D113400: [lldb-vscode] Add presentation hints for scopes

werat added a comment. Thanks! I have push permission, will land it myself in a bit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113400/new/ https://reviews.llvm.org/D113400 ___ lldb-commits mailing

Re: [Lldb-commits] [PATCH] D113400: [lldb-vscode] Add presentation hints for scopes

Cool. I hope that vscode catches up. Do you have push permissions or should I land this for you? Il Mar 9 Nov 2021, 2:16 AM Andy Yankovsky via Phabricator < revi...@reviews.llvm.org> ha scritto: > werat added a comment. > > In D113400#3117500 , @wallace

[Lldb-commits] [PATCH] D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime.

PatriosTheGreat added a comment. Thanks for review! Could you or someone else take this commit to master? I don't have a commit permissions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104413/new/ https://reviews.llvm.org/D104413 ___

[Lldb-commits] [PATCH] D113487: [lldb] Refactor Platform::ResolveExecutable

labath added inline comments. Comment at: lldb/source/Target/Platform.cpp:865 + +Status +Platform::ResolveRemoteExecutable(const ModuleSpec _spec, Next step is to merge this with the `if (!m_remote_platform_sp)` path in RemoteAwarePlatform::ResolveExecutable

[Lldb-commits] [PATCH] D113487: [lldb] Refactor Platform::ResolveExecutable

labath created this revision. labath added reviewers: JDevlieghere, jingham, clayborg, PatriosTheGreat. labath requested review of this revision. Herald added a project: LLDB. Module resolution is probably the most complex piece of lldb [citation needed], with numerous levels of abstraction, each

[Lldb-commits] [PATCH] D95710: [lldb/Commands] Add command options for ScriptedProcess to ProcessLaunch

mib added a comment. In D95710#3118346 , @labath wrote: > Sorry for grave digging, but my compiler just became smart enough to start > complaining about this. Haha, not at all! This wasn't called when I implemented it, but I stumbled into it in

[Lldb-commits] [PATCH] D113184: [lldb] Fix cross-platform kills

This revision was automatically updated to reflect the committed changes. Closed by commit rGa40929dcd295: [lldb] Fix cross-platform kills (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113184/new/

[Lldb-commits] [lldb] a40929d - [lldb] Fix cross-platform kills

Author: Pavel Labath Date: 2021-11-09T15:31:07+01:00 New Revision: a40929dcd295997736caf066758dd359216443c2 URL: https://github.com/llvm/llvm-project/commit/a40929dcd295997736caf066758dd359216443c2 DIFF: https://github.com/llvm/llvm-project/commit/a40929dcd295997736caf066758dd359216443c2.diff

[Lldb-commits] [PATCH] D95710: [lldb/Commands] Add command options for ScriptedProcess to ProcessLaunch

labath added a comment. Sorry for grave digging, but my compiler just became smart enough to start complaining about this. Comment at: lldb/source/API/SBLaunchInfo.cpp:392 + llvm::json::OStream s(stream.ref().AsRawOstream()); + dict_sp->Serialize(s); +

[Lldb-commits] [PATCH] D108078: [lldb] Support gdbserver signals

labath added a comment. It would be nice if the commit message/summary included more details about the differences in signal handling (the things we talked about on irc), but generally, I think this patch looks good. The only thing that's missing is interoperability with older lldb-compatible

[Lldb-commits] [PATCH] D112709: [lldb] Fix matchers for char array formatters

labath added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112709/new/ https://reviews.llvm.org/D112709 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D113174: [lldb] Summary provider for char flexible array members

labath added a comment. In D113174#3112464 , @shafik wrote: > In D113174#3109664 , @jingham wrote: > >> Regex Type summary matching happens after the ConstString matching. Enrico >> did it that way because the

[Lldb-commits] [PATCH] D113330: [LLDB][Breakpad] Make lldb understand INLINE and INLINE_ORIGIN records in breakpad.

labath added a comment. Looks pretty good. I might have split the record parsing functions into a separate patch, but this is not bad either. Just one comment about error handling. Comment at: lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:313-314 +

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

labath added a comment. Sorry for the delay. Just a couple of (hopefully final) requests. Comment at: lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:245 +addr_t address = record->Address + base; +SectionSP section_sp =

[Lldb-commits] [PATCH] D113362: [formatters] Add a libstdcpp formatter for forward_list and refactor list formatter

danilashtefan added inline comments. Comment at: lldb/examples/synthetic/gnu_libstdcpp.py:92 +return 1 +size = self.node_value_pointer_offset current = self.next wallace wrote: > let's better initialize

[Lldb-commits] [PATCH] D113400: [lldb-vscode] Add presentation hints for scopes

werat added a comment. In D113400#3117500 , @wallace wrote: > could you share a screenshot of how this looks like? Sure! Here are the screenshots of before/after in Visual Studio 2022. Before everything is in one place (in Locals Window): F20179455:

[Lldb-commits] [PATCH] D113362: [formatters] Add a libstdcpp formatter for forward_list and refactor list formatter

danilashtefan updated this revision to Diff 385744. danilashtefan marked 10 inline comments as done. danilashtefan added a comment. All the requested changes are done :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113362/new/

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

lawrence_danna updated this revision to Diff 385712. lawrence_danna edited the summary of this revision. lawrence_danna added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112973/new/ https://reviews.llvm.org/D112973

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

lawrence_danna updated this revision to Diff 385711. lawrence_danna added a comment. updated according to reviewer feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112973/new/ https://reviews.llvm.org/D112973 Files: