[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

hawkinsw added a comment. @JDevlieghere Thanks again for the feedback. I updated the patchset according to your comments. I left open one of your suggestions to get your feedback. Thanks again! Will Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

hawkinsw updated this revision to Diff 429411. hawkinsw added a comment. Updating the patchset according to the helpful feedback from @jdevlieghere. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124731/new/ https://reviews.llvm.org/D124731 Files:

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

hawkinsw marked 5 inline comments as done. hawkinsw added inline comments. Comment at: lldb/test/API/commands/breakpoint/set/address-nomodule/TestBreakpointAddressNoModule.py:11 +def get_address_from_symbol(self, symbol): +target =

[Lldb-commits] [PATCH] D125594: [lldb/API] Turn SBCompileUnit::GetIndexForLineEntry into FindLineEntryIndex (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG174cf2f74762: [lldb/API] Turn SBCompileUnit::GetIndexForLineEntry into FindLineEntryIndex… (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 174cf2f - [lldb/API] Turn SBCompileUnit::GetIndexForLineEntry into FindLineEntryIndex (NFC)

Author: Med Ismail Bennani Date: 2022-05-13T18:33:05-07:00 New Revision: 174cf2f7476224c167608290d27eac846834dace URL: https://github.com/llvm/llvm-project/commit/174cf2f7476224c167608290d27eac846834dace DIFF:

[Lldb-commits] [PATCH] D125594: [lldb/API] Turn SBCompileUnit::GetIndexForLineEntry into FindLineEntryIndex (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125594/new/ https://reviews.llvm.org/D125594

[Lldb-commits] [PATCH] D125594: [lldb/API] Turn SBCompileUnit::GetIndexForLineEntry into FindLineEntryIndex (NFC)

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a subscriber: arphaman. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch renames the `SBCompileUnit::GetIndexForLineEntry`

[Lldb-commits] [PATCH] D125589: [lldb] Don't swallow crashlog exceptions

mib accepted this revision. mib added inline comments. This revision is now accepted and ready to land. Comment at: lldb/examples/python/crashlog.py:1025-1027 -except Exception as e: -result.PutCString("error: python exception: %s" % e) -return

[Lldb-commits] [PATCH] D125589: [lldb] Don't swallow crashlog exceptions

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:1025-1027 -except Exception as e: -result.PutCString("error: python exception: %s" % e) -return mib wrote: > What

[Lldb-commits] [PATCH] D125589: [lldb] Don't swallow crashlog exceptions

mib added inline comments. Comment at: lldb/examples/python/crashlog.py:1025-1027 -except Exception as e: -result.PutCString("error: python exception: %s" % e) -return What about printing the exception backtrace and exiting cleaning instead

[Lldb-commits] [PATCH] D125589: [lldb] Don't swallow crashlog exceptions

JDevlieghere created this revision. JDevlieghere added a reviewer: mib. Herald added a project: All. JDevlieghere requested review of this revision. crashlog.py catches every exception in order to format them. This results in both the exception name as well as the backtrace getting swallowed.

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Looking great, just a few more fixes. Thanks for making the changes. Comment at: lldb/include/lldb/API/SBProcess.h:348 + /// \param[in] core_style - Specify

[Lldb-commits] [PATCH] D125219: [lldb][NFC] Simplify GenerateOptionUsage

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125219/new/ https://reviews.llvm.org/D125219

[Lldb-commits] [PATCH] D125218: [lldb][NFC] Make cmd a reference in GenerateOptionUsage

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125218/new/ https://reviews.llvm.org/D125218

[Lldb-commits] [PATCH] D125154: [lldb] Specify aguments of `image list`

JDevlieghere added a comment. LGTM PS: Small typo in your summary: `s/abot/about/`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125154/new/ https://reviews.llvm.org/D125154 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D125107: [lldb] Parallelize fetching symbol files in crashlog.py

JDevlieghere closed this revision. JDevlieghere added a comment. a8abb695859ad4e7fe695b9ee238a2b0cd00af7c CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125107/new/ https://reviews.llvm.org/D125107

[Lldb-commits] [lldb] a8abb69 - [lldb] Parallelize fetching symbol files in crashlog.py

Author: Jonas Devlieghere Date: 2022-05-13T12:25:41-07:00 New Revision: a8abb695859ad4e7fe695b9ee238a2b0cd00af7c URL: https://github.com/llvm/llvm-project/commit/a8abb695859ad4e7fe695b9ee238a2b0cd00af7c DIFF:

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

JDevlieghere added inline comments. Comment at: lldb/test/API/commands/breakpoint/set/address-nomodule/TestBreakpointAddressNoModule.py:11 +def get_address_from_symbol(self, symbol): +target = lldbutil.run_to_breakpoint_make_target(self, "a.out", True) +bp =

[Lldb-commits] [PATCH] D125434: Make a more convenient way to allow Darwin users to ignore certain Mach Exceptions

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:80-111 +// Static Variables +static uint32_t g_initialize_count = 0; + +void PlatformDarwin::Initialize() { + Platform::Initialize(); + + if (g_initialize_count++ == 0) {

[Lldb-commits] [PATCH] D125575: [lldb] [llgs] Implement non-stop style stop notification packets

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. Herald added a project: All. mgorny requested review of this revision. Implement the support for %Stop asynchronous notification packet format in LLGS. This does not implement full support for non-stop mode for

[Lldb-commits] [PATCH] D125437: [lldb/API] Add SBCompileUnit::GetIndexForLineEntry method to SB API

JDevlieghere added inline comments. Comment at: lldb/include/lldb/API/SBCompileUnit.h:37 + uint32_t GetIndexForLineEntry(lldb::SBLineEntry _entry, +bool exact = false) const; mib wrote: > JDevlieghere wrote: > > How's this

[Lldb-commits] [PATCH] D125437: [lldb/API] Add SBCompileUnit::GetIndexForLineEntry method to SB API

mib closed this revision. mib marked an inline comment as done. mib added a comment. Landed in a6926d576131c9ad849fef6f1d43134caab5025e Comment at: lldb/include/lldb/API/SBCompileUnit.h:37 + uint32_t

[Lldb-commits] [PATCH] D125437: [lldb/API] Add SBCompileUnit::GetIndexForLineEntry method to SB API

JDevlieghere added inline comments. Comment at: lldb/include/lldb/API/SBCompileUnit.h:37 + uint32_t GetIndexForLineEntry(lldb::SBLineEntry _entry, +bool exact = false) const; How's this different from `FindLineEntryIndex`? In

[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

paulkirth added a comment. It's probably fine to reland this after D125570 lands, since that should unblock us. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124673/new/ https://reviews.llvm.org/D124673

[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

MaskRay added a comment. In D124673#3512190 , @phosek wrote: > In D124673#3512070 , @MaskRay wrote: > >> In D124673#3512037 , @paulkirth >> wrote: >> >>> Hi, Sorry for

[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

phosek added a comment. In D124673#3512070 , @MaskRay wrote: > In D124673#3512037 , @paulkirth > wrote: > >> Hi, Sorry for the late notification, but I think this change may not apply >> correctly to all

[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

MaskRay added a comment. In D124673#3512037 , @paulkirth wrote: > Hi, Sorry for the late notification, but I think this change may not apply > correctly to all configs. > > We're seeing a breakage in Fuchsia's Clang CI builders: >

[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

paulkirth added a comment. Hi, Sorry for the late notification, but I think this change may not apply correctly to all configs. We're seeing a breakage in Fuchsia's Clang CI builders: https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8814329895908917697/overview

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

hawkinsw added a comment. Hello @labath and @JDevlieghere -- I hope that your Friday is going well! I'd love to make any other changes to this if necessary! Thanks for everything! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124731/new/

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

PatriosTheGreat updated this revision to Diff 429160. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125325/new/ https://reviews.llvm.org/D125325 Files: lldb/bindings/interface/SBProcess.i lldb/include/lldb/API/SBProcess.h lldb/source/API/SBProcess.cpp