[Lldb-commits] [PATCH] D152597: [lldb][NFCI] Remove StructuredData::Dictionary::GetValueForKeyAsString overloads involving ConstString

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. I thought `StructuredData::String` used a `ConstString` for storage but it actually uses a `std::string` instead. Makes sense to remove this then. LGTM! Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D152594: [lldb] Introduce DynamicRegisterInfo::CreateFromDict

mib added a comment. Are we replacing all the constructors that can fail by static methods ? Wouldn't it be easier to pass an `Status&` as an extra parameter ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152594/new/

[Lldb-commits] [PATCH] D152597: [lldb][NFCI] Remove StructuredData::Dictionary::GetValueForKeyAsString overloads involving ConstString

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, fdeazeve, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In an effort to keep the ConstString StringPool small,

[Lldb-commits] [PATCH] D152594: [lldb] Introduce DynamicRegisterInfo::CreateFromDict

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, jasonmolenda, mgorny. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I want to add some error handling to

[Lldb-commits] [lldb] aff35b2 - [lldb][NFCI] Replace some static ConstStrings with StringLiterals in Disassembler

Author: Alex Langford Date: 2023-06-09T15:38:48-07:00 New Revision: aff35b2f1ef5de1ec5c40e5dca3b88c556e03554 URL: https://github.com/llvm/llvm-project/commit/aff35b2f1ef5de1ec5c40e5dca3b88c556e03554 DIFF: https://github.com/llvm/llvm-project/commit/aff35b2f1ef5de1ec5c40e5dca3b88c556e03554.diff

[Lldb-commits] [PATCH] D152590: Streamline expression parser error messages

aprantl created this revision. aprantl added reviewers: jingham, kastiglione, JDevlieghere. Herald added a project: All. aprantl requested review of this revision. Currently the expression parser prints a mostly useless generic error before printing the compiler error: (lldb) p 1+x) error:

[Lldb-commits] [PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

MaskRay added a comment. In D151683#4409633 , @aaron.ballman wrote: > In D151683#4384017 , @erichkeane > wrote: > >> In D151683#4382408 , @philnik >> wrote: >> >>> No.

[Lldb-commits] [PATCH] D152582: [lldb] Change return type of UnixSignals::GetShortName

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Cool Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152582/new/ https://reviews.llvm.org/D152582

[Lldb-commits] [PATCH] D152569: [lldb] Introduce a tool to quickly generate projects with an arbitrary number of sources

mib added inline comments. Comment at: lldb/scripts/generate-project.py:23 +with open(header_path, "w") as f: +file_contents = ( +f"#ifndef _OBJ{index}_H\n" nit: Is it necessary to put it in a variable or could you have a multiline

[Lldb-commits] [PATCH] D152560: Make TestStepNodebug more robust against codegen changes

aprantl abandoned this revision. aprantl added a comment. According to an offline conversation with @jingham this is still not the expected behavior from the stepping engine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152560/new/ https://reviews.llvm.org/D152560

[Lldb-commits] [PATCH] D152569: [lldb] Introduce a tool to quickly generate projects with an arbitrary number of sources

bulbazord marked 3 inline comments as done. bulbazord added inline comments. Comment at: lldb/scripts/generate-project.py:175 +# Building Objects and their respective swiftmodule +f.write(f"$(OBJDIR)/%.o: %.swift objdir\n") +f.write("\t$(SWIFT_FE) -c

[Lldb-commits] [PATCH] D152569: [lldb] Introduce a tool to quickly generate projects with an arbitrary number of sources

bulbazord updated this revision to Diff 530084. bulbazord added a comment. - Converted some things to use multiline string literals - Converted some f-strings into string literals when they didn't need interpolation - Applied black formatting Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D152582: [lldb] Change return type of UnixSignals::GetShortName

bulbazord added a comment. In D152582#4410002 , @mib wrote: > Don't you need to update the callers as well ? Otherwise LGTM. ConstString can be implicitly converted to StringRef which is what's happening here. There are only 2 call sites, both pass in

[Lldb-commits] [PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

tstellar added a comment. In D141907#4409973 , @MaskRay wrote: > In D141907#4094748 , @MaskRay wrote: > >> [...] >> edeaf16f2c2f02d6e43312d48d26d354d87913f3 (2011) added the CMake variable >>

[Lldb-commits] [PATCH] D152560: Make TestStepNodebug more robust against codegen changes

aprantl added a comment. lldb) image dump line-table with-debug.c Line table for /Volumes/Data/llvm-project/lldb/test/API/functionalities/step-avoids-no-debug/with-debug.c in `a.out 0x00013d4c:

[Lldb-commits] [PATCH] D152582: [lldb] Change return type of UnixSignals::GetShortName

mib added a comment. Don't you need to update the callers as well ? Otherwise LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152582/new/ https://reviews.llvm.org/D152582 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D152582: [lldb] Change return type of UnixSignals::GetShortName

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The short names of each signal name and alias only exist as

[Lldb-commits] [PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

MaskRay added a comment. In D141907#4094748 , @MaskRay wrote: > [...] > edeaf16f2c2f02d6e43312d48d26d354d87913f3 (2011) added the CMake variable > `CLANG_RESOURCE_DIR` but did not explain why. > In the long term, the CMake variable `CLANG_RESOURCE_DIR`

[Lldb-commits] [PATCH] D152569: [lldb] Introduce a tool to quickly generate projects with an arbitrary number of sources

kastiglione added inline comments. Comment at: lldb/scripts/generate-project.py:69 +f.write(" {\n") +f.write(f" print(\"{index}\")\n") +f.write("}\n") Comment at: lldb/scripts/generate-project.py:116 +

[Lldb-commits] [PATCH] D152569: [lldb] Introduce a tool to quickly generate projects with an arbitrary number of sources

kastiglione added inline comments. Comment at: lldb/scripts/generate-project.py:175 +# Building Objects and their respective swiftmodule +f.write(f"$(OBJDIR)/%.o: %.swift objdir\n") +f.write("\t$(SWIFT_FE) -c -primary-file $< -I objs/ \\\n")

[Lldb-commits] [PATCH] D152569: [lldb] Introduce a tool to quickly generate projects with an arbitrary number of sources

kastiglione added inline comments. Comment at: lldb/scripts/generate-project.py:118-126 +f.write(f" $(OBJDIR)/main.o\n") +f.write("\n") +f.write("all: many-objects\n") +f.write("objdir:\n") +f.write("\tmkdir -p $(OBJDIR)\n") +

[Lldb-commits] [PATCH] D152579: [lldb] Symtab::SectionFileAddressesChanged should clear the file address map instead of name map

bulbazord created this revision. bulbazord added reviewers: jasonmolenda, JDevlieghere, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Currently, `SectionFileAddressesChanged` clears out the

[Lldb-commits] [PATCH] D152569: [lldb] Introduce a tool to quickly generate projects with an arbitrary number of sources

aprantl added a comment. That looks useful! Comment at: lldb/scripts/generate-project.py:175 +# Building Objects and their respective swiftmodule +f.write(f"$(OBJDIR)/%.o: %.swift objdir\n") +f.write("\t$(SWIFT_FE) -c -primary-file $< -I objs/ \\\n")

[Lldb-commits] [PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

beanz added inline comments. Comment at: clang/test/ParserHLSL/group_shared.hlsl:14 -// expected-error@+1 {{expected expression}} float groupshared [[]] i = 12; philnik wrote: > beanz wrote: > > aaron.ballman wrote: > > > philnik wrote: > > > > Should this

[Lldb-commits] [PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

philnik added inline comments. Comment at: clang/test/Parser/cxx-decl.cpp:316 #if __cplusplus >= 201103L -// expected-error@+3 {{expected}} +// expected-error@+2 {{expected}} // expected-error@-3 {{expected ';' after top level declarator}} aaron.ballman wrote:

[Lldb-commits] [PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

beanz added inline comments. Comment at: clang/test/ParserHLSL/group_shared.hlsl:14 -// expected-error@+1 {{expected expression}} float groupshared [[]] i = 12; aaron.ballman wrote: > philnik wrote: > > Should this also get an extension warning/should

[Lldb-commits] [lldb] 347a7b2 - [lldb][NFCI] Delete unused member from SymbolFileSymtab

Author: Alex Langford Date: 2023-06-09T11:53:52-07:00 New Revision: 347a7b2a89ce03d51a39d2380a520a27c2954af8 URL: https://github.com/llvm/llvm-project/commit/347a7b2a89ce03d51a39d2380a520a27c2954af8 DIFF: https://github.com/llvm/llvm-project/commit/347a7b2a89ce03d51a39d2380a520a27c2954af8.diff

[Lldb-commits] [PATCH] D152573: [lldb][NFCI] Remove use of ConstString from Listener

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The only place ConstString was used in Listener was for

[Lldb-commits] [PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

aaron.ballman added subscribers: beanz, clang-vendors. aaron.ballman added a comment. In D151683#4384017 , @erichkeane wrote: > In D151683#4382408 , @philnik wrote: > >> No. I guess, since you are asking I

[Lldb-commits] [PATCH] D152569: [lldb] Introduce a tool to quickly generate projects with an arbitrary number of sources

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, aprantl, jingham, fdeazeve, mib, kastiglione, clayborg. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The purpose of this

[Lldb-commits] [PATCH] D152476: [lldb] Remove lldb's DWARFAbbreviationDeclarationSet in favor of llvm's

bulbazord updated this revision to Diff 530021. bulbazord added a comment. Adjust formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152476/new/ https://reviews.llvm.org/D152476 Files:

[Lldb-commits] [PATCH] D152476: [lldb] Remove lldb's DWARFAbbreviationDeclarationSet in favor of llvm's

bulbazord added a comment. In D152476#4408654 , @fdeazeve wrote: > This is awesome! I believe you said there was no measurable perf diff? Yeah, my initial experiments measured no significant perf difference no matter how you built lldb. llvm's and

[Lldb-commits] [PATCH] D152560: Make TestStepNodebug more robust against codegen changes

aprantl created this revision. aprantl added reviewers: jingham, Michael137. Herald added a subscriber: kristof.beyls. Herald added a project: All. aprantl requested review of this revision. Depending on the compiler I've seen that for example the step-in command can do a column-step first

[Lldb-commits] [PATCH] D152476: [lldb] Remove lldb's DWARFAbbreviationDeclarationSet in favor of llvm's

aprantl accepted this revision. aprantl added a comment. Nice! Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAbbrev.cpp:61 void DWARFDebugAbbrev::GetUnsupportedForms( std::set _forms) const { + for (const auto : m_abbrevCollMap) { at some

[Lldb-commits] [PATCH] D152409: [lldb] Never print children if the max depth has been reached

aprantl added a comment. Would that be testable by implementing a python data formatter for a C struct that unconditionally returns an error? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152409/new/ https://reviews.llvm.org/D152409

[Lldb-commits] [PATCH] D152476: [lldb] Remove lldb's DWARFAbbreviationDeclarationSet in favor of llvm's

fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. This is awesome! I believe you said there was no measurable perf diff? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152476/new/

[Lldb-commits] [PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

sebastian-ne added inline comments. Comment at: cmake/Modules/GetClangResourceDir.cmake:15 + else() +string(REGEX MATCH "^[0-9]+" CLANG_VERSION_MAJOR ${PACKAGE_VERSION}) +set(ret_dir lib${LLVM_LIBDIR_SUFFIX}/clang/${CLANG_VERSION_MAJOR}) This fails in

[Lldb-commits] [PATCH] D152519: [lldb][AArch64] Add Scalable Matrix Extension option to QEMU launch script

DavidSpickett added a reviewer: omjavaid. DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. Strictly you could just use `--sve`, but it's nice to have an explicit option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D152519: [lldb][AArch64] Add Scalable Matrix Extension option to QEMU launch script

DavidSpickett created this revision. Herald added subscribers: ctetreau, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added subscribers: lldb-commits, alextsao1999. Herald added a project: LLDB. The Scalable Matrix Extension (SME) does not

[Lldb-commits] [PATCH] D152516: [lldb][AArch64] Add thread local storage tpidr register

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This register is used as the pointer to the current thread local

[Lldb-commits] [PATCH] D152364: [lldb] Rate limit progress reports -- different approach [WIP-ish]

labath added a comment. Actually, thinking about these "unique" events, I think it would be worth trying out sending the progress update events as "unique". Depending on where exactly in the pipeline the congestion happens, it might just be enough to fix the immediate problem. If the slow

[Lldb-commits] [PATCH] D152364: [lldb] Rate limit progress reports -- different approach [WIP-ish]

labath added a comment. In D152364#4406589 , @JDevlieghere wrote: > Continuing some of the discussion from D150805 > here as it mostly relates to this patch: > > In D150805#4402906