kamleshbhalui wrote:
> This uses `DataExtractor::GetMaxU64` which already does this under the hood.
> What does this do that isn't already being done? It may help if you add a
> test case to show what you are trying to fix.
The problem with GetMaxU64 is that it always returns uint64_t even
kamleshbhalui wrote:
There is not a test scenario in lldb itself.
https://github.com/llvm/llvm-project/pull/81451
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jason Molenda (jasonmolenda)
Changes
On arm64 machines, when there is a hardware breakpoint or watchpoint set, and
lldb has instruction-stepped a thread, and then done a Process::Resume, we will
sometimes receive an extra "instruction
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/81573
On arm64 machines, when there is a hardware breakpoint or watchpoint set, and
lldb has instruction-stepped a thread, and then done a Process::Resume, we will
sometimes receive an extra "instruction step
@@ -141,6 +145,24 @@ std::optional
SymbolLocatorDefault::LocateExecutableSymbolFile(
FileSystem::Instance().Resolve(file_spec);
debug_file_search_paths.AppendIfUnique(file_spec);
}
+#if defined(__FreeBSD__)
+// Add $LOCALBASE/lib/debug directory, where
+
@@ -141,6 +145,24 @@ std::optional
SymbolLocatorDefault::LocateExecutableSymbolFile(
FileSystem::Instance().Resolve(file_spec);
debug_file_search_paths.AppendIfUnique(file_spec);
}
+#if defined(__FreeBSD__)
+// Add $LOCALBASE/lib/debug directory, where
+
https://github.com/JDevlieghere approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/81565
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord updated
https://github.com/llvm/llvm-project/pull/81565
>From a1bb825c34a951a0d99ecf03fe86545ed43bbe42 Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Mon, 12 Feb 2024 19:05:55 -0800
Subject: [PATCH 1/2] [lldb][NFCI] Add header guard to PlatformRemoteAppleXR.h
https://github.com/cyndyishida approved this pull request.
LGTM, thanks!
https://github.com/llvm/llvm-project/pull/81565
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Alex Langford (bulbazord)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/81565.diff
1 Files Affected:
- (modified) lldb/source/Plugins/Platform/MacOSX/PlatformRemoteAppleXR.h (+5)
``diff
diff --git
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/81565
None
>From a1bb825c34a951a0d99ecf03fe86545ed43bbe42 Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Mon, 12 Feb 2024 19:05:55 -0800
Subject: [PATCH] [lldb][NFCI] Add header guard to PlatformRemoteAppleXR.h
https://github.com/jeffreytan81 updated
https://github.com/llvm/llvm-project/pull/81564
>From d65900f5e6169062fc0988b57fb5be2474789025 Mon Sep 17 00:00:00 2001
From: jeffreytan81
Date: Mon, 12 Feb 2024 18:08:23 -0800
Subject: [PATCH 1/2] Fix lldb crash while handling concurrent vfork()
---
dwblaikie wrote:
> > > I will aim to land this sometime tomorrow if there are no further
> > > objections
> >
> >
> > Per the documentation (
> > https://llvm.org/docs/CodeReview.html#code-review-workflow ), please don't
> > do this. Once it's sent for review, please wait for approval (ping
dwblaikie wrote:
> I am fine with telling people what to do and giving them a golden path to
> what is easiest for our debuggers. And I will suggest to everyone that they
> use `.debug` and `.dwp`, but if we want to only support this, this leaves the
> downloading of the `.debug` file
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff bc66e0cf9feb8f3c38fa2e33850b6c6e5477fb21
d65900f5e6169062fc0988b57fb5be2474789025 --
jimingham wrote:
> > I will aim to land this sometime tomorrow if there are no further objections
>
> Per the documentation (
> https://llvm.org/docs/CodeReview.html#code-review-workflow ), please don't do
> this. Once it's sent for review, please wait for approval (ping as needed,
> etc)
https://github.com/jeffreytan81 created
https://github.com/llvm/llvm-project/pull/81564
None
>From d65900f5e6169062fc0988b57fb5be2474789025 Mon Sep 17 00:00:00 2001
From: jeffreytan81
Date: Mon, 12 Feb 2024 18:08:23 -0800
Subject: [PATCH] Fix lldb crash while handling concurrent vfork()
---
@@ -4349,26 +4349,53 @@ SymbolFileDWARFDebugMap
*SymbolFileDWARF::GetDebugMapSymfile() {
const std::shared_ptr ::GetDwpSymbolFile()
{
llvm::call_once(m_dwp_symfile_once_flag, [this]() {
+// Create a list of files to try and append .dwp to.
+FileSpecList symfiles;
@@ -4349,26 +4349,53 @@ SymbolFileDWARFDebugMap
*SymbolFileDWARF::GetDebugMapSymfile() {
const std::shared_ptr ::GetDwpSymbolFile()
{
llvm::call_once(m_dwp_symfile_once_flag, [this]() {
+// Create a list of files to try and append .dwp to.
+FileSpecList symfiles;
dwblaikie wrote:
> I will aim to land this sometime tomorrow if there are no further objections
Per the documentation (
https://llvm.org/docs/CodeReview.html#code-review-workflow ), please don't do
this. Once it's sent for review, please wait for approval (ping as needed, etc)
before
@@ -895,6 +906,32 @@ def request_setFunctionBreakpoints(self, names,
condition=None, hitCondition=Non
}
return self.send_recv(command_dict)
+def request_dataBreakpointInfo(self, variablesReference, name):
+args_dict = {"variablesReference":
https://github.com/walter-erquinigo commented:
This looks great overall!
Could you split this PR into two? One with the refactoring and another one with
the new features? That would make reviewing easier
https://github.com/llvm/llvm-project/pull/81541
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/81541
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,360 @@
+"""
+This module implements a couple of utility classes to make writing
+lldb parsed commands more Pythonic.
+The way to use it is to make a class for your command that inherits from
ParsedCommandBase.
+That will make an LLDBOptionValueParser which you will
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/70734
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -805,19 +805,25 @@ let Command = "script add" in {
def script_add_function : Option<"function", "f">, Group<1>,
Arg<"PythonFunction">,
Desc<"Name of the Python function to bind to this command name.">;
- def script_add_class : Option<"class", "c">, Group<2>,
https://github.com/medismailben approved this pull request.
Awesome! Thanks for addressing my comments @jimingham :) LGTM!
https://github.com/llvm/llvm-project/pull/70734
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/jimingham closed
https://github.com/llvm/llvm-project/pull/81314
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: jimingham
Date: 2024-02-12T15:24:11-08:00
New Revision: c2b01c87dcc3ab59e7d466cbec795310a3d43fde
URL:
https://github.com/llvm/llvm-project/commit/c2b01c87dcc3ab59e7d466cbec795310a3d43fde
DIFF:
https://github.com/llvm/llvm-project/commit/c2b01c87dcc3ab59e7d466cbec795310a3d43fde.diff
@@ -0,0 +1,321 @@
+"""
+This module implements a couple of utility classes to make writing
+lldb parsed commands more Pythonic.
+The way to use it is to make a class for your command that inherits from
ParsedCommandBase.
+That will make an LLDBOptionValueParser which you will
@@ -0,0 +1,321 @@
+"""
+This module implements a couple of utility classes to make writing
+lldb parsed commands more Pythonic.
+The way to use it is to make a class for your command that inherits from
ParsedCommandBase.
+That will make an LLDBOptionValueParser which you will
@@ -805,19 +805,25 @@ let Command = "script add" in {
def script_add_function : Option<"function", "f">, Group<1>,
Arg<"PythonFunction">,
Desc<"Name of the Python function to bind to this command name.">;
- def script_add_class : Option<"class", "c">, Group<2>,
@@ -805,19 +805,25 @@ let Command = "script add" in {
def script_add_function : Option<"function", "f">, Group<1>,
Arg<"PythonFunction">,
Desc<"Name of the Python function to bind to this command name.">;
- def script_add_class : Option<"class", "c">, Group<2>,
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
41ea02261224446dadb1b1561d70137699255518...2743af56220630f55a0c5bc0a7a13806c817aaad
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Zequan Wu (ZequanWu)
Changes
This implements functionality to handle `DataBreakpointInfo` request and
`SetDataBreakpoints` request.
It doesn't handle the case when `name` is an expression, see Todo comment for
details.
This is based on
ZequanWu wrote:
I uploaded https://github.com/llvm/llvm-project/pull/81541 as reference for
reviewers to understand the motivation of this patch.
https://github.com/llvm/llvm-project/pull/80753
___
lldb-commits mailing list
https://github.com/ZequanWu created
https://github.com/llvm/llvm-project/pull/81541
This implements functionality to handle `DataBreakpointInfo` request and
`SetDataBreakpoints` request.
It doesn't handle the case when `name` is an expression, see Todo comment for
details.
This is based on
@@ -66,3 +66,47 @@ void Progress::ReportProgress() {
m_debugger_id);
}
}
+
+void ProgressManager::Initialize() {
+ lldbassert(!InstanceImpl() && "A progress report manager already exists.");
+ InstanceImpl().emplace();
+}
+
+void
felipepiovezan wrote:
I will aim to land this sometime tomorrow if there are no further objections
https://github.com/llvm/llvm-project/pull/79932
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
@@ -96,7 +96,9 @@ function(finish_swig_python swig_target
lldb_python_bindings_dir lldb_python_tar
${lldb_python_target_dir}
"utils"
FILES "${LLDB_SOURCE_DIR}/examples/python/in_call_stack.py"
- "${LLDB_SOURCE_DIR}/examples/python/symbolication.py")
+
https://github.com/bulbazord requested changes to this pull request.
This uses `DataExtractor::GetMaxU64` which already does this under the hood.
What does this do that isn't already being done? It may help if you add a test
case to show what you are trying to fix.
clayborg wrote:
What is the status of this PR? I think we will want this to make sure we don't
spam too many individual progress events. It can also be adpated for the new
categories after it goes in.
https://github.com/llvm/llvm-project/pull/75769
clayborg wrote:
Any chance we can get this in?
https://github.com/llvm/llvm-project/pull/81067
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg wrote:
What is the problem here? I tried to understand the description, but don't know
what the issue is? Can we test this?
https://github.com/llvm/llvm-project/pull/81451
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/kamleshbhalui updated
https://github.com/llvm/llvm-project/pull/81451
>From 51347e2de532261cfe980b299baeceb7747b7d48 Mon Sep 17 00:00:00 2001
From: Kamlesh Kumar
Date: Mon, 12 Feb 2024 13:30:32 +0530
Subject: [PATCH 1/2] [lldb] Store proper integer bitwidth in Scalar Type
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 7f40c5cc4e15a0a67b031f13370afc342a5dc14b
51347e2de532261cfe980b299baeceb7747b7d48 --
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Kamlesh Kumar (kamleshbhalui)
Changes
Storing Larger bitwidth causes problem when byteswapping.
---
Full diff: https://github.com/llvm/llvm-project/pull/81451.diff
1 Files Affected:
- (modified)
https://github.com/kamleshbhalui created
https://github.com/llvm/llvm-project/pull/81451
Storing Larger bitwidth causes problem when byteswapping.
>From 51347e2de532261cfe980b299baeceb7747b7d48 Mon Sep 17 00:00:00 2001
From: Kamlesh Kumar
Date: Mon, 12 Feb 2024 13:30:32 +0530
Subject: [PATCH]
48 matches
Mail list logo
