This revision was automatically updated to reflect the committed changes.
Closed by commit rL244850: Remove DNBConfig.h (authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D11971?vs=31902id=32011#toc
Repository:
rL LLVM
http://reviews.llvm.org/D11971
Files:
brucem added a comment.
I think this looks good to me if no one disagrees.
Repository:
rL LLVM
http://reviews.llvm.org/D13715
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
brucem added a subscriber: brucem.
brucem requested changes to this revision.
brucem added a reviewer: brucem.
Comment at: tools/lldb/source/Host/linux/HostThreadLinux.cpp:33
@@ -32,3 +32,3 @@
{
-#if (defined(__GLIBC__) && defined(_GNU_SOURCE)) || defined(__ANDROID__)
+#if
This revision was automatically updated to reflect the committed changes.
Closed by commit rL251171: Add initial gmake glue for the NetBSD platform
(authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13715?vs=37957=38289#toc
Repository:
rL LLVM
Author: brucem
Date: Fri Oct 23 20:28:24 2015
New Revision: 251171
URL: http://llvm.org/viewvc/llvm-project?rev=251171=rev
Log:
Add initial gmake glue for the NetBSD platform
Summary:
These changes aren't everything what is needed for the autotools target, but
it's significantly approaching it.
brucem added a comment.
It might be worthwhile to have a "janitor" where we can not enable things like
this so that it is more clear that this is something we'd like to clean up over
time.
It would be pretty easy to just have a `if (NOT LLDB_JANITOR_MODE AND
CXX_SUPPORTS_NO_STRICT_ALIASING)`
brucem added a comment.
+1 to what @labath said.
Users:
sas (Author)
dawn (Auditor)
http://reviews.llvm.org/rL250335
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: brucem
Date: Fri Oct 23 19:27:04 2015
New Revision: 251164
URL: http://llvm.org/viewvc/llvm-project?rev=251164=rev
Log:
Add initial CMake glue for the NetBSD platform
Summary:
These changes aren't everything what is needed for the CMake target, but it's
significantly approaching it.
Author: brucem
Date: Fri Oct 23 19:30:18 2015
New Revision: 251166
URL: http://llvm.org/viewvc/llvm-project?rev=251166=rev
Log:
[lldb-mi] Fix unused variable warning.
Modified:
lldb/trunk/tools/lldb-mi/MICmnLLDBDebugger.cpp
Modified: lldb/trunk/tools/lldb-mi/MICmnLLDBDebugger.cpp
URL:
brucem added a subscriber: brucem.
brucem added a comment.
You are correct: ``-E env`` is new after 3.0. (Not in 3.0, but it is in 3.2.)
I think the minimum supported cmake is actually older then 3.0 (2.8.something)
...
Users:
sas (Author)
dawn (Auditor)
http://reviews.llvm.org/rL250335
This revision was automatically updated to reflect the committed changes.
Closed by commit rL253153: Add more autotools/gmake NetBSD glue (authored by
brucem).
Changed prior to commit:
http://reviews.llvm.org/D14531?vs=39789=40222#toc
Repository:
rL LLVM
http://reviews.llvm.org/D14531
Author: brucem
Date: Sat Nov 14 20:00:09 2015
New Revision: 253153
URL: http://llvm.org/viewvc/llvm-project?rev=253153=rev
Log:
Add more autotools/gmake NetBSD glue
Summary: This diff approaches building the project natively on NetBSD with the
autoconf/gmake framework.
Patch by Kamil
brucem added a reviewer: clayborg.
brucem added a comment.
I'd like to land this given approval.
Repository:
rL LLVM
http://reviews.llvm.org/D14037
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
brucem added a reviewer: emaste.
brucem added a comment.
emaste, are you okay with this and willing to approve it?
It looks good to me.
Repository:
rL LLVM
http://reviews.llvm.org/D14042
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
brucem added inline comments.
Comment at: scripts/Python/buildSwigPython.py:293
@@ +292,3 @@
+# LLDBWrapPython.cpp file.
+# Args:vDictArg - (R) Program input parameters.
+# vstrSwigOpFileNamePath - (R) LLDBWrapPython.cpp file.
I shouldn't
brucem added a comment.
Even if it were, in some of the files, almost every line would change anyway
due to semicolons and then due to incorrect whitespace.
http://reviews.llvm.org/D14375
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
brucem added a comment.
Kamil, please rebase forward and I'll land it.
The semicolons in Python are gone now. And so is the need for that block of
Python at all.
Repository:
rL LLVM
http://reviews.llvm.org/D14042
___
lldb-commits mailing list
This revision was automatically updated to reflect the committed changes.
Closed by commit rL252396: Make lldb::endian::InlHostByteOrder() private.
(authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D14417?vs=39473=39630#toc
Repository:
rL LLVM
Author: brucem
Date: Fri Nov 6 22:40:13 2015
New Revision: 252396
URL: http://llvm.org/viewvc/llvm-project?rev=252396=rev
Log:
Make lldb::endian::InlHostByteOrder() private.
Summary:
Since this is within the lldb namespace, the compiler tries to
export a symbol for it. Unfortunately, since it
Author: brucem
Date: Sat Nov 7 09:31:54 2015
New Revision: 252403
URL: http://llvm.org/viewvc/llvm-project?rev=252403=rev
Log:
Add more NetBSD platform glue for lldb
Summary:
These changes are still incomplete, but we are almost there.
Changes:
- CMake and gmake code
- SWIG code
- minor code
This revision was automatically updated to reflect the committed changes.
Closed by commit rL252403: Add more NetBSD platform glue for lldb (authored by
brucem).
Changed prior to commit:
http://reviews.llvm.org/D14042?vs=39639=39640#toc
Repository:
rL LLVM
http://reviews.llvm.org/D14042
Author: brucem
Date: Thu Nov 5 17:48:41 2015
New Revision: 252238
URL: http://llvm.org/viewvc/llvm-project?rev=252238=rev
Log:
Fix cmake build on Mac OS X.
PlatformDarwin uses Host/XML.h which needs to find libxml2, and
so it needs to be told how to find the headers.
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL252250: Reuse native curses(8) library on NetBSD (authored
by brucem).
Changed prior to commit:
http://reviews.llvm.org/D14037?vs=39440=39444#toc
Repository:
rL LLVM
http://reviews.llvm.org/D14037
Author: brucem
Date: Thu Nov 5 18:21:18 2015
New Revision: 252250
URL: http://llvm.org/viewvc/llvm-project?rev=252250=rev
Log:
Reuse native curses(8) library on NetBSD
Summary:
The reason for it is limit of detecting ncurses on various systems. For
example, Ubuntu ships with and linkage from ,
brucem created this revision.
brucem added a reviewer: clayborg.
brucem added a subscriber: lldb-commits.
Herald added a subscriber: emaste.
Since this is within the lldb namespace, the compiler tries to
export a symbol for it. Unfortunately, since it is inlined, the
symbol is hidden and this
brucem created this revision.
brucem added reviewers: zturner, domipheus.
brucem added a subscriber: lldb-commits.
Remove per-platform variants of this in favor of just having
Windows and Unix. The code that was previously specific to
Linux can be further simplified and used on all non-Windows
This revision was automatically updated to reflect the committed changes.
Closed by commit rL252330: [swig] Remove
check_lldb_swig_executable_file_exists. (authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D14415?vs=39558=39562#toc
Repository:
rL LLVM
brucem updated this revision to Diff 39558.
brucem added a comment.
Instead of simplifying, just remove. Expand scope of removal as well.
http://reviews.llvm.org/D14415
Files:
scripts/Python/buildSwigPython.py
scripts/buildSwigWrapperClasses.py
Index: scripts/buildSwigWrapperClasses.py
brucem added a comment.
Well, I'm pretty sure ... but I don't know if someone in some configuration or
set of build arrangements might use it. It might also be used if we ever make
the Makefiles or xcode projects use these scripts.
http://reviews.llvm.org/D14415
brucem requested changes to this revision.
brucem added a comment.
This revision now requires changes to proceed.
This also has the whitespace changes and needs rebasing forward. (And a
question for someone about the nature of one of the changes.)
Comment at:
brucem requested changes to this revision.
brucem added a comment.
This revision now requires changes to proceed.
Could you rebase this forward so that it applies cleanly?
Repository:
rL LLVM
http://reviews.llvm.org/D12611
___
lldb-commits
brucem accepted this revision.
brucem added a comment.
This revision is now accepted and ready to land.
I can land this for you. I'd like it to go in as I have another patch myself
that addresses almost all of the Plugins directory, so if I land this, I'll
rebase on top of it and submit mine
brucem added a subscriber: brucem.
Comment at: tools/lldb-server/CMakeLists.txt:42
@@ +41,3 @@
+ if (LLDB_VERS_GENERATED_FILE)
+add_dependencies(lldb-server swig_wrapper)
+ endif()
Why is this needed?
Repository:
rL LLVM
http://reviews.llvm.org/D13535
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249671: Make CMake display more readable paths to Python
binaries on Windows (authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13520?vs=36764=36832#toc
Repository:
rL LLVM
brucem requested changes to this revision.
brucem added a comment.
This revision now requires changes to proceed.
Same issue here with whitespace and needing to be rebased forward.
Repository:
rL LLVM
http://reviews.llvm.org/D12257
___
Author: brucem
Date: Thu Oct 8 03:50:20 2015
New Revision: 249671
URL: http://llvm.org/viewvc/llvm-project?rev=249671=rev
Log:
Make CMake display more readable paths to Python binaries on Windows
Summary:
Previously CMake would display messages like these:
```
-- LLDB Found PythonExecutable:
brucem added a subscriber: brucem.
brucem requested changes to this revision.
brucem added a reviewer: brucem.
This revision now requires changes to proceed.
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:2108
@@ -2107,1 +2107,3 @@
brucem added a comment.
I think what needs to happen is that you take the `add_custom_command` and then
create a target that will execute the command and only do it once ... I'll
provide an example from something else shortly.
(I was about to request changes here when you committed it and
brucem added a comment.
I don't know what's broken for you. My build hasn't had any issues on Mac OS X
using cmake.
Repository:
rL LLVM
http://reviews.llvm.org/D13535
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
brucem added a comment.
I did NOT test this with a full rebuild as it is nearly my bedtime. I did test
it with an incremental build as well as rm'ing the generated file and touching
the (new) dependencies to make sure that the vers file got regenerated.
http://reviews.llvm.org/D13552
brucem created this revision.
brucem added reviewers: dawn, sas, clayborg, zturner.
brucem added a subscriber: lldb-commits.
This is Darwin only.
The symbol defined by ${LLDB_VERS_GENERATED_FILE} is used by
source/lldb.cpp, so anything that uses lldb.cpp (which is in
lldbBase) should also have
brucem added a comment.
The way to do this correctly is something like
ADD_CUSTOM_COMMAND(
OUTPUT whatever.output.file.c
COMMAND ... whatever ...
DEPENDS ... whatever ...
)
ADD_CUSTOM_TARGET(whatever-target-name
ALL
DEPENDS
brucem added a comment.
I have a full build from clean going with this. I'm pretty sure that it will be
fine.
I'll check this into SVN after I wake up if someone agrees that it looks good.
http://reviews.llvm.org/D13552
___
lldb-commits mailing
brucem added a comment.
I'd like to hear from @clayborg about the whitespace changes here.
Repository:
rL LLVM
http://reviews.llvm.org/D13574
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
brucem added a subscriber: brucem.
brucem added a comment.
Getting rid of a lot of the `#ifndef LLDB_DISABLE_PYTHON` checks had been on my
list of things I wanted to clean up. Since you regularly build with this
configuration (and I never do), I suspect that a lot more of those checks could
go
brucem created this revision.
brucem added reviewers: clayborg, jingham, jhibbits, emaste.
brucem added a subscriber: lldb-commits.
The StackUsesFrames and FunctionCallsChangeCFA virtual functions
aren't used anywhere and aren't overridden by anything.
They were introduced when the ABISysV_ppc*
brucem marked 2 inline comments as done.
brucem added a comment.
http://reviews.llvm.org/D13503
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
brucem added a comment.
There's nothing to test here short of "Does it compile?" as these functions
aren't actually used anywhere. I'm cleaning out dead virtuals in various
patches.
http://reviews.llvm.org/D13506
___
lldb-commits mailing list
Author: brucem
Date: Wed Oct 7 12:22:54 2015
New Revision: 249570
URL: http://llvm.org/viewvc/llvm-project?rev=249570=rev
Log:
Reduce header inclusion in Expression.
Reviewers: spyffe
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D1
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249570: Reduce header inclusion in Expression. (authored by
brucem).
Changed prior to commit:
http://reviews.llvm.org/D1?vs=36760=36762#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249563: Remove unused virtuals from ABISysV_ppc* (authored
by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13506?vs=36726=36753#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13506
Author: brucem
Date: Wed Oct 7 11:48:33 2015
New Revision: 249563
URL: http://llvm.org/viewvc/llvm-project?rev=249563=rev
Log:
Remove unused virtuals from ABISysV_ppc*
Summary:
The StackUsesFrames and FunctionCallsChangeCFA virtual functions
aren't used anywhere and aren't overridden by
brucem updated this revision to Diff 36760.
brucem added a comment.
Rebase forward.
http://reviews.llvm.org/D1
Files:
include/lldb/Expression/ExpressionParser.h
include/lldb/Expression/ExpressionVariable.h
include/lldb/Expression/FunctionCaller.h
brucem added a subscriber: brucem.
brucem added a comment.
I don't know much about this, but would it make sense for this to be using any
of the Value / SBValue and data formatter infrastructure?
Repository:
rL LLVM
http://reviews.llvm.org/D13699
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249452: Remove GetShortPluginName. (authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13463?vs=36602=36649#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13463
Files:
Author: brucem
Date: Tue Oct 6 15:15:27 2015
New Revision: 249452
URL: http://llvm.org/viewvc/llvm-project?rev=249452=rev
Log:
Remove GetShortPluginName.
Summary: This was deprecated and removed.
Reviewers: clayborg
Subscribers: lldb-commits
Differential Revision:
brucem created this revision.
brucem added reviewers: bhushan, tberghammer.
brucem added a subscriber: lldb-commits.
http://reviews.llvm.org/D13462
Files:
source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h
Index: source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h
brucem created this revision.
brucem added a reviewer: clayborg.
brucem added a subscriber: lldb-commits.
This was deprecated and removed.
http://reviews.llvm.org/D13463
Files:
source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.cpp
source/Plugins/ABI/MacOSX-arm64/ABIMacOSX_arm64.h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249806: Fix handling of LLDB_VERS_GENERATED_FILE. (authored
by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13552?vs=36851=36923#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13552
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249928: [LLDB] Fix Clang-tidy misc-use-override warnings in
some files in… (authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13574?vs=36894=37014#toc
Repository:
rL LLVM
Author: brucem
Date: Fri Oct 9 20:11:45 2015
New Revision: 249928
URL: http://llvm.org/viewvc/llvm-project?rev=249928=rev
Log:
[LLDB] Fix Clang-tidy misc-use-override warnings in some files in
include/lldb/Core; other minor fixes.
Summary:
This is second attempt based on current code.
I
Author: brucem
Date: Fri Oct 9 19:45:34 2015
New Revision: 249924
URL: http://llvm.org/viewvc/llvm-project?rev=249924=rev
Log:
Fix namespace closing comment.
This is closing namespace lldb_utility, not lldb.
Modified:
lldb/trunk/include/lldb/Utility/PseudoTerminal.h
Modified:
brucem added a subscriber: brucem.
brucem added a comment.
Unless someone else (@emaste?) objects, I think this looks fine to land and
iterate on trunk as discussed in the mailing list thread. Just one minor
comment based on cleanups that are on-going on trunk now.
Comment
brucem created this revision.
brucem added reviewers: clayborg, labath, emaste.
brucem added a subscriber: lldb-commits.
Herald added a subscriber: emaste.
EnablePluginLogging, GetPluginCommandHelp and ExecutePluginCommand aren't
implemented or used anywhere, so remove them from the Hexagon and
brucem added a subscriber: brucem.
brucem accepted this revision.
brucem added a reviewer: brucem.
brucem added a comment.
This revision is now accepted and ready to land.
lgtm.
will land shortly for you.
Repository:
rL LLVM
http://reviews.llvm.org/D13707
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250249: Remove definition of ~PlatformNetBSD(), since its
declaration is marked as '=… (authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13707?vs=37284=37298#toc
Repository:
rL
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249860: [debugserver,cmake] Add DEPENDS to custom commands.
(authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D13580?vs=36925=36965#toc
Repository:
rL LLVM
Author: brucem
Date: Tue Oct 6 05:17:34 2015
New Revision: 249387
URL: http://llvm.org/viewvc/llvm-project?rev=249387=rev
Log:
Fix segmentation fault in lldb_private::Symbols::LocateExecutableSymbolFile()
Summary:
When `module_spec.GetFileSpec().GetDirectory().AsCString()` returned a
`nullptr`
Author: brucem
Date: Fri Oct 9 10:37:10 2015
New Revision: 249840
URL: http://llvm.org/viewvc/llvm-project?rev=249840=rev
Log:
Remove long-forgotten plugin virtuals.
Summary:
EnablePluginLogging, GetPluginCommandHelp and ExecutePluginCommand aren't
implemented or used anywhere, so remove them
Author: brucem
Date: Tue Oct 13 00:04:13 2015
New Revision: 250146
URL: http://llvm.org/viewvc/llvm-project?rev=250146=rev
Log:
Preliminary NetBSD support
Summary:
This adds platform code without the cmake/gmake glue to the existing
infrastructure.
The missing and incompatibility ptrace(2)
Stepping one step back further in the thread ...
On Wed, Nov 18, 2015 at 8:35 AM, Zachary Turner via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Moving this back over to the list since I'm sure others have some input
> here. Also +lldb-dev since it has more visibility than
This revision was automatically updated to reflect the committed changes.
Closed by commit rL253151: Use library discovery for curses and panel (authored
by brucem).
Changed prior to commit:
http://reviews.llvm.org/D14529?vs=39787=40220#toc
Repository:
rL LLVM
Author: brucem
Date: Sat Nov 14 19:53:23 2015
New Revision: 253151
URL: http://llvm.org/viewvc/llvm-project?rev=253151=rev
Log:
Use library discovery for curses and panel
Summary:
This approach is tunable with custom paths for curses library.
It also detects whether there are requirements met.
Author: brucem
Date: Sat Nov 14 19:56:21 2015
New Revision: 253152
URL: http://llvm.org/viewvc/llvm-project?rev=253152=rev
Log:
Allow to override python-config executable name from command line
Summary: pkgsrc (on NetBSD) ships with python2.7-config.
Patch by Kamil Rytarowski. Thanks!
brucem created this revision.
brucem added a reviewer: clayborg.
brucem added a subscriber: lldb-commits.
This was previously only established within debugserver, but
there is a use of the VLA extension in source/Host/macosx/Symbols.cpp,
so ignore this warning globally.
brucem added a comment.
This touches random files across the tree, including lldb-mi. I wasn't sure how
best this should be reviewed or by who (despite it being pretty mechanical).
http://reviews.llvm.org/D12518
___
lldb-commits mailing list
brucem created this revision.
brucem added reviewers: ki.stfu, abidh.
brucem added a subscriber: lldb-commits.
find_first_of will look for any of the characters, not the full
string passed in. When looking for "--" then, we must use find
and not find_first_of.
http://reviews.llvm.org/D12517
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246529: [lldb-mi] Use find, not find_first_of, for "--".
(authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D12517?vs=33662=33663#toc
Repository:
rL LLVM
Author: brucem
Date: Mon Aug 31 23:36:54 2015
New Revision: 246529
URL: http://llvm.org/viewvc/llvm-project?rev=246529=rev
Log:
[lldb-mi] Use find, not find_first_of, for "--".
Summary:
find_first_of will look for any of the characters, not the full
string passed in. When looking for "--" then,
brucem created this revision.
brucem added a reviewer: clayborg.
brucem added a subscriber: lldb-commits.
When calling find_first_of and find_last_of on a single character,
we can instead just call find / rfind and make our intent more
clear.
http://reviews.llvm.org/D12518
Files:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246605: Use -Wno-vla-extension globally. (authored by
brucem).
Changed prior to commit:
http://reviews.llvm.org/D12515?vs=33660=33755#toc
Repository:
rL LLVM
http://reviews.llvm.org/D12515
Files:
Author: brucem
Date: Tue Sep 1 18:45:14 2015
New Revision: 246606
URL: http://llvm.org/viewvc/llvm-project?rev=246606=rev
Log:
[debugserver] Fix sign comparison warning.
Summary:
Comparing m_page_size against kInvalidPageSize was resulting in
a warning about comparing integers with different
Author: brucem
Date: Tue Sep 1 18:57:17 2015
New Revision: 246609
URL: http://llvm.org/viewvc/llvm-project?rev=246609=rev
Log:
Simplify find_first_of & find_last_of on single char.
Summary:
When calling find_first_of and find_last_of on a single character,
we can instead just call find / rfind
brucem created this revision.
brucem added reviewers: emaste, clayborg, labath, chaoren.
brucem added a subscriber: lldb-commits.
This also moves the xcode support files to be near or the same
as the ones used for cmake.
The source/API/liblldb.xcodes.exports differs from the
brucem added a comment.
This uses some machinery from LLVM's cmake scripts.
I'm not sure what happens with this on FreeBSD, NetBSD, etc.
http://reviews.llvm.org/D12599
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Author: brucem
Date: Mon Sep 7 08:03:07 2015
New Revision: 246969
URL: http://llvm.org/viewvc/llvm-project?rev=246969=rev
Log:
[www] Typo fixes.
Reviewers: clayborg, ki.stfu
Subscribers: tberghammer, danalbert, srhines, lldb-commits
Differential Revision: http://reviews.llvm.org/D12668
brucem added a comment.
zturner, was that an approval to land this?
http://reviews.llvm.org/D12667
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
brucem created this revision.
brucem added reviewers: clayborg, jingham.
brucem added a subscriber: lldb-commits.
The format string was not set up correctly as it was missing the %.
This resulted in a warning (correctly) that the data arguments were
not all used.
http://reviews.llvm.org/D12714
Author: brucem
Date: Tue Sep 8 19:56:25 2015
New Revision: 247111
URL: http://llvm.org/viewvc/llvm-project?rev=247111=rev
Log:
Fix log message warning in SBThread.
Summary:
The format string was not set up correctly as it was missing the %.
This resulted in a warning (correctly) that the data
Author: brucem
Date: Wed Sep 2 23:17:57 2015
New Revision: 246746
URL: http://llvm.org/viewvc/llvm-project?rev=246746=rev
Log:
Fix cmake build.
Added:
lldb/trunk/source/Plugins/ExpressionParser/CMakeLists.txt
lldb/trunk/source/Plugins/ExpressionParser/Clang/CMakeLists.txt
Modified:
brucem created this revision.
brucem added a reviewer: clayborg.
brucem added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
http://reviews.llvm.org/D12668
Files:
www/build.html
www/index.html
www/test.html
www/varformats.html
Index:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246821: SystemRuntime/MacOSX no longer need ObjCRuntime
header. (authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D12589?vs=33903=33992#toc
Repository:
rL LLVM
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246822: Only export public symbols with the cmake build.
(authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D12599?vs=33942=33993#toc
Repository:
rL LLVM
Author: brucem
Date: Thu Sep 3 19:00:41 2015
New Revision: 246822
URL: http://llvm.org/viewvc/llvm-project?rev=246822=rev
Log:
Only export public symbols with the cmake build.
Summary:
This also moves the xcode support files to be near or the same
as the ones used for cmake.
The
brucem added a comment.
tfiala, on Mac OS X with this change, the liblldb.dylib went from 58468408 to
53626572 bytes (release build).
http://reviews.llvm.org/D12599
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
brucem created this revision.
brucem added reviewers: clayborg, labath.
brucem added a subscriber: lldb-commits.
We currently link to this on all platforms, so don't need to re-include
it into the LLDB_USED_LIBS. Also don't need to special case building
it for every supported platform.
brucem added a subscriber: brucem.
brucem added a comment.
Yes, Ted Woodward and others have mentioned having this issue on the buildbots.
Repository:
rL LLVM
http://reviews.llvm.org/D12749
___
lldb-commits mailing list
Author: brucem
Date: Thu Sep 10 19:31:33 2015
New Revision: 247366
URL: http://llvm.org/viewvc/llvm-project?rev=247366=rev
Log:
Clean up building & linking of Process/elf-core.
Summary:
* cmake/LLDBDependencies.cmake: elf-core is already included
globally in LLDB_USED_LIBS, so it doesn't need
brucem added a subscriber: brucem.
brucem requested changes to this revision.
brucem added a reviewer: brucem.
This revision now requires changes to proceed.
Comment at: cmake/LLDBDependencies.cmake:152
@@ -153,1 +151,3 @@
+# On FreeBSD/NetBSD backtrace() is provided by
brucem added a subscriber: brucem.
Comment at: test/lang/go/goroutines/TestGoroutines.py:14
@@ +13,3 @@
+@python_api_test
+@skipIfRemote # Not remote test suit ready
+@skipUnlessGoInstalled
Minor typo: should be "suite"
Repository:
rL LLVM
1 - 100 of 185 matches
Mail list logo
