https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/79912
>From af9a5581702b5c9ca8009fc32c7ae10a1654d391 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Mon, 29 Jan 2024 15:29:46 -0800
Subject: [PATCH 1/2] [lldb][progress] Correctly check total for determin
@@ -39,7 +39,7 @@ class ProgressEventData : public EventData {
GetAsStructuredData(const Event *event_ptr);
uint64_t GetID() const { return m_id; }
- bool IsFinite() const { return m_total != UINT64_MAX; }
+ bool IsFinite() const { return m_total != 1; }
@@ -0,0 +1,125 @@
+//===-- ProgressReportTest.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/79912
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/79533
>From 10343b6cdad410e09546dd5a98e29d272300ed2e Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 25 Jan 2024 16:40:42 -0800
Subject: [PATCH 1/4] [lldb][progress][NFC] Add unit test for progress re
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/79533
>From 10343b6cdad410e09546dd5a98e29d272300ed2e Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 25 Jan 2024 16:40:42 -0800
Subject: [PATCH 1/4] [lldb][progress][NFC] Add unit test for progress re
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/79533
>From 10343b6cdad410e09546dd5a98e29d272300ed2e Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 25 Jan 2024 16:40:42 -0800
Subject: [PATCH 1/4] [lldb][progress][NFC] Add unit test for progress re
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/79533
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Chelsea Cassanova
Date: 2024-01-31T11:58:11-08:00
New Revision: 209fe1f3d70d1c4a20bb2687e0d0a94b1bbfa0c6
URL:
https://github.com/llvm/llvm-project/commit/209fe1f3d70d1c4a20bb2687e0d0a94b1bbfa0c6
DIFF:
https://github.com/llvm/llvm-project/commit/209fe1f3d70d1c4a20bb2687e0d0a94b1bbfa0c6.d
Author: Chelsea Cassanova
Date: 2024-01-31T15:19:39-08:00
New Revision: a5a8cbb110384825b99228891576f799082f200e
URL:
https://github.com/llvm/llvm-project/commit/a5a8cbb110384825b99228891576f799082f200e
DIFF:
https://github.com/llvm/llvm-project/commit/a5a8cbb110384825b99228891576f799082f200e.d
Author: Chelsea Cassanova
Date: 2024-01-31T15:31:52-08:00
New Revision: 40ebe522ea5fd56cb383e29c77373b1482d49c0f
URL:
https://github.com/llvm/llvm-project/commit/40ebe522ea5fd56cb383e29c77373b1482d49c0f
DIFF:
https://github.com/llvm/llvm-project/commit/40ebe522ea5fd56cb383e29c77373b1482d49c0f.d
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/80786
I tried adding a new unit test to the core test
suite (https://github.com/llvm/llvm-project/pull/79533) but it broke the test
suite on AArch64 Linux due to hitting an assertion for calling
`Debugger::Initi
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/80788
Incorporates the changes from
https://github.com/llvm/llvm-project/pull/80786 to use a once_flag from
`TestUtilities` instead of a local flag in order to prevent hitting an
assertion that the debugger was
chelcassanova wrote:
I did, I'm adding them as separate patches. DiagnosticEventTest.cpp could
probably go here since it's a simple change but ProgressEventTest doesn't exist
upstream yet since I had to revert so I think that at least should be it's own
PR>
https://github.com/llvm/llvm-projec
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/80786
>From 0d56057bc9904b2079324b21b3625def7e15b6c2 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Mon, 5 Feb 2024 18:41:14 -0800
Subject: [PATCH] [lldb][unittest] Add call_once flag to initialize debugg
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/80786
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/80791
>From 16e468b938ade09c57fd1eb7ea3db7b673836cb0 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Mon, 5 Feb 2024 19:00:52 -0800
Subject: [PATCH] Reland "[lldb][progress][NFC] Add unit test for progress
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/80788
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/80791
>From 4760c7ca48790f5f87de8e6ba2a5a3eea002 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Mon, 5 Feb 2024 19:00:52 -0800
Subject: [PATCH] Reland "[lldb][progress][NFC] Add unit test for progress
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/80791
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/81026
As part of the effort to improve progress reporting in LLDB
(https://discourse.llvm.org/t/rfc-improve-lldb-progress-reporting/75717) we
want a way to keep track of progress reports to see if they're ongoin
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/81026
>From a80637fe2471c3f1adc2b353cef41887bcd55a3c Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 6 Feb 2024 10:48:39 -0800
Subject: [PATCH] [lldb][progress][NFC] Add groundwork to keep track of
p
@@ -117,6 +127,7 @@ class Progress {
/// to ensure that we don't send progress updates after progress has
/// completed.
bool m_complete = false;
+ bool m_type;
chelcassanova wrote:
Holdover from when I used a bool for this value before switching an enu
@@ -9,26 +9,34 @@
#include "lldb/Core/Progress.h"
#include "lldb/Core/Debugger.h"
-#include "lldb/Utility/StreamString.h"
#include
using namespace lldb;
using namespace lldb_private;
std::atomic Progress::g_id(0);
+std::atomic Progress::g_refcount(1);
+std::unordere
@@ -99,6 +105,10 @@ class Progress {
private:
void ReportProgress();
static std::atomic g_id;
+ static std::atomic g_refcount;
+ /// Map that tracks each progress object and if we've seen its start and stop
+ /// events
+ static std::unordered_map g_map;
---
@@ -99,6 +105,10 @@ class Progress {
private:
void ReportProgress();
static std::atomic g_id;
+ static std::atomic g_refcount;
+ /// Map that tracks each progress object and if we've seen its start and stop
+ /// events
+ static std::unordered_map g_map;
---
@@ -9,26 +9,34 @@
#include "lldb/Core/Progress.h"
#include "lldb/Core/Debugger.h"
-#include "lldb/Utility/StreamString.h"
#include
using namespace lldb;
using namespace lldb_private;
std::atomic Progress::g_id(0);
+std::atomic Progress::g_refcount(1);
+std::unordere
chelcassanova wrote:
I'll start with this by changing this so that bookkeeping is done with the new
bit instead of being done in the constructor for `Progress`.
https://github.com/llvm/llvm-project/pull/81026
___
lldb-commits mailing list
lldb-commits
chelcassanova wrote:
The discussions happening here are talking about 2 major things, how to do the
bookkeeping of the map that keeps track of progress reports and where to do
that bookkeeping. I think it makes sense to split up this work into smaller
patches as such:
1. Since it's best to do
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/81169
This commit adds a new broadcast bit to the debugger. When in use, it will be
listened to for progress events that will be delivered and kept track of by
category as opposed to the current behaviour of com
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/81169
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -12,6 +12,7 @@
#include "lldb/Utility/ConstString.h"
#include "lldb/lldb-types.h"
#include
+#include
chelcassanova wrote:
I shouldn't need a sorted map so I'll go with StringMap for the updated patch
with the class that will handle the progress report ma
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/81026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/81319
Per discussions from https://github.com/llvm/llvm-project/pull/81026, it was
decided that having a class that manages a map of progress reports would be
beneficial in order to categorize them. This class i
@@ -119,6 +120,32 @@ class Progress {
bool m_complete = false;
};
+/// A class used to group progress reports by category. This is done by using a
+/// map that maintains a refcount of each category of progress reports that
have
+/// come in. Keeping track of progress repor
@@ -66,3 +66,47 @@ void Progress::ReportProgress() {
m_debugger_id);
}
}
+
+void ProgressManager::Initialize() {
+ lldbassert(!InstanceImpl() && "A progress report manager already exists.");
+ InstanceImpl().emplace();
+}
+
+void ProgressManager
@@ -66,3 +66,47 @@ void Progress::ReportProgress() {
m_debugger_id);
}
}
+
+void ProgressManager::Initialize() {
+ lldbassert(!InstanceImpl() && "A progress report manager already exists.");
+ InstanceImpl().emplace();
+}
+
+void ProgressManager
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/81319
>From f5ef07849c61ee9387f92376d5e1bd13bedc43e5 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 8 Feb 2024 15:31:33 -0800
Subject: [PATCH] [lldb][progress] Add progress manager class
Per discuss
@@ -66,3 +66,47 @@ void Progress::ReportProgress() {
m_debugger_id);
}
}
+
+void ProgressManager::Initialize() {
+ lldbassert(!InstanceImpl() && "A progress report manager already exists.");
+ InstanceImpl().emplace();
+}
+
+void ProgressManager
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/81319
>From f5ef07849c61ee9387f92376d5e1bd13bedc43e5 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 8 Feb 2024 15:31:33 -0800
Subject: [PATCH 1/2] [lldb][progress] Add progress manager class
Per dis
@@ -119,6 +120,32 @@ class Progress {
bool m_complete = false;
};
+/// A class used to group progress reports by category. This is done by using a
+/// map that maintains a refcount of each category of progress reports that
have
+/// come in. Keeping track of progress repor
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/81319
>From f5ef07849c61ee9387f92376d5e1bd13bedc43e5 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 8 Feb 2024 15:31:33 -0800
Subject: [PATCH 1/2] [lldb][progress] Add progress manager class
Per dis
@@ -66,3 +67,41 @@ void Progress::ReportProgress() {
m_debugger_id);
}
}
+
+ProgressManager &ProgressManager::InstanceImpl() {
+ static std::once_flag g_once_flag;
+ static ProgressManager *g_progress_manager = nullptr;
+ std::call_once(g_once_
@@ -66,3 +67,41 @@ void Progress::ReportProgress() {
m_debugger_id);
}
}
+
+ProgressManager &ProgressManager::InstanceImpl() {
+ static std::once_flag g_once_flag;
+ static ProgressManager *g_progress_manager = nullptr;
+ std::call_once(g_once_
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/81319
>From f5ef07849c61ee9387f92376d5e1bd13bedc43e5 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 8 Feb 2024 15:31:33 -0800
Subject: [PATCH 1/3] [lldb][progress] Add progress manager class
Per dis
@@ -119,6 +120,32 @@ class Progress {
bool m_complete = false;
};
+/// A class used to group progress reports by category. This is done by using a
+/// map that maintains a refcount of each category of progress reports that
have
+/// come in. Keeping track of progress repor
@@ -66,3 +67,41 @@ void Progress::ReportProgress() {
m_debugger_id);
}
}
+
+ProgressManager &ProgressManager::InstanceImpl() {
+ static std::once_flag g_once_flag;
+ static ProgressManager *g_progress_manager = nullptr;
+ std::call_once(g_once_
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/81319
>From f5ef07849c61ee9387f92376d5e1bd13bedc43e5 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 8 Feb 2024 15:31:33 -0800
Subject: [PATCH 1/4] [lldb][progress] Add progress manager class
Per dis
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/81319
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Chelsea Cassanova
Date: 2022-06-08T18:10:41-04:00
New Revision: 0f02dd34f22650d8af0070e7ad21632525e33da8
URL:
https://github.com/llvm/llvm-project/commit/0f02dd34f22650d8af0070e7ad21632525e33da8
DIFF:
https://github.com/llvm/llvm-project/commit/0f02dd34f22650d8af0070e7ad21632525e33da8.d
Author: Chelsea Cassanova
Date: 2022-06-15T14:55:43-04:00
New Revision: f3250da1b94fed260ea5da8264ba366c42aaf34c
URL:
https://github.com/llvm/llvm-project/commit/f3250da1b94fed260ea5da8264ba366c42aaf34c
DIFF:
https://github.com/llvm/llvm-project/commit/f3250da1b94fed260ea5da8264ba366c42aaf34c.d
Author: Chelsea Cassanova
Date: 2022-06-15T17:37:38-04:00
New Revision: 3ba71f1be1fb986e634debd8d17a69d2bb4c4eb7
URL:
https://github.com/llvm/llvm-project/commit/3ba71f1be1fb986e634debd8d17a69d2bb4c4eb7
DIFF:
https://github.com/llvm/llvm-project/commit/3ba71f1be1fb986e634debd8d17a69d2bb4c4eb7.d
Author: Chelsea Cassanova
Date: 2022-06-22T17:42:55-04:00
New Revision: 46be5faaf03466c3751f8a2882bef5a217e15926
URL:
https://github.com/llvm/llvm-project/commit/46be5faaf03466c3751f8a2882bef5a217e15926
DIFF:
https://github.com/llvm/llvm-project/commit/46be5faaf03466c3751f8a2882bef5a217e15926.d
Author: Chelsea Cassanova
Date: 2022-06-23T16:55:23-04:00
New Revision: 40aace59cc58ca438060cf4dfd97ba01ff4f0ebc
URL:
https://github.com/llvm/llvm-project/commit/40aace59cc58ca438060cf4dfd97ba01ff4f0ebc
DIFF:
https://github.com/llvm/llvm-project/commit/40aace59cc58ca438060cf4dfd97ba01ff4f0ebc.d
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/69516
This commit adds a boolean flag `is_discrete` is to progress reports in LLDB.
The flag is set to false by default and indicates if a progress event is
discrete, i.e. an operation that has no clear start an
@@ -25,8 +25,8 @@ def test_dwarf_symbol_loading_progress_report(self):
event = lldbutil.fetch_next_event(self, self.listener,
self.broadcaster)
ret_args = lldb.SBDebugger.GetProgressFromEvent(event)
self.assertGreater(len(ret_args), 0)
-message
@@ -2219,7 +2219,7 @@ void ObjectFileMachO::ParseSymtab(Symtab &symtab) {
const FileSpec &file = m_file ? m_file : module_sp->GetFileSpec();
const char *file_name = file.GetFilename().AsCString("");
LLDB_SCOPED_TIMERF("ObjectFileMachO::ParseSymtab () module = %s", file_na
@@ -1426,7 +1427,8 @@ void Debugger::ReportProgress(uint64_t progress_id,
std::string title,
if (debugger_sp)
PrivateReportProgress(*debugger_sp, progress_id, std::move(title),
std::move(details), completed, total,
-
https://github.com/chelcassanova edited
https://github.com/llvm/llvm-project/pull/69516
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -25,8 +25,8 @@ def test_dwarf_symbol_loading_progress_report(self):
event = lldbutil.fetch_next_event(self, self.listener,
self.broadcaster)
ret_args = lldb.SBDebugger.GetProgressFromEvent(event)
self.assertGreater(len(ret_args), 0)
-message
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/69516
>From 073ba299ab15c487bff28212563b5a103bdc5f60 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 18 Oct 2023 13:07:51 -0700
Subject: [PATCH 1/2] [lldb][progress] Add discrete boolean flag to progr
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/69516
>From 073ba299ab15c487bff28212563b5a103bdc5f60 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 18 Oct 2023 13:07:51 -0700
Subject: [PATCH 1/3] [lldb][progress] Add discrete boolean flag to progr
@@ -37,5 +37,8 @@ def
test_dwarf_symbol_loading_progress_report_structured_data(self):
event = lldbutil.fetch_next_event(self, self.listener,
self.broadcaster)
progress_data = lldb.SBDebugger.GetProgressDataFromEvent(event)
-message = progress_data.Ge
@@ -16,7 +16,7 @@ using namespace lldb_private;
std::atomic Progress::g_id(0);
-Progress::Progress(std::string title, uint64_t total,
+Progress::Progress(std::string title, bool is_discrete, uint64_t total,
chelcassanova wrote:
Yes it was, left it out by mis
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/69516
>From 073ba299ab15c487bff28212563b5a103bdc5f60 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 18 Oct 2023 13:07:51 -0700
Subject: [PATCH 1/4] [lldb][progress] Add discrete boolean flag to progr
@@ -16,9 +16,10 @@ using namespace lldb_private;
std::atomic Progress::g_id(0);
-Progress::Progress(std::string title, uint64_t total,
+Progress::Progress(std::string title, bool is_discrete, uint64_t total,
lldb_private::Debugger *debugger)
-: m_title
chelcassanova wrote:
"Aggregate" can work. These are moreso status updates than than they are
progress reports and I need to work on the documentation in the code that
explains what I'm trying to accomplish.
https://github.com/llvm/llvm-project/pull/69516
__
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/69516
>From 073ba299ab15c487bff28212563b5a103bdc5f60 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 18 Oct 2023 13:07:51 -0700
Subject: [PATCH 1/5] [lldb][progress] Add discrete boolean flag to progr
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/71081
The instructions for running single tests in the LLDB test suite used an older
directory structure from before the LLVM project became a monorepo. This commit
updates the references to these directories.
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/71081
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Chelsea Cassanova
Date: 2022-08-26T18:35:21-05:00
New Revision: 43d7320e7111784c613634e73f50c631a1b0b303
URL:
https://github.com/llvm/llvm-project/commit/43d7320e7111784c613634e73f50c631a1b0b303
DIFF:
https://github.com/llvm/llvm-project/commit/43d7320e7111784c613634e73f50c631a1b0b303.d
Author: Chelsea Cassanova
Date: 2022-08-26T22:15:38-05:00
New Revision: 53f1cc85e3de11ff91eb985332257d63dcf47ddc
URL:
https://github.com/llvm/llvm-project/commit/53f1cc85e3de11ff91eb985332257d63dcf47ddc
DIFF:
https://github.com/llvm/llvm-project/commit/53f1cc85e3de11ff91eb985332257d63dcf47ddc.d
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/111560
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/111763
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/111763
SBLanguages.h uses a uint16_t but is missing the include for ``, if
any file includes this without including that it will cause a build error so
this commit adds this include.
>From f652fa49979306cf38bdb
@@ -5,22 +5,21 @@
import os
HEADER = """\
-//===-- SBLanguages.h -*- C++ -*-===//
+//===-- SourceLanguageNames.h ---*- C++
-*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLV
https://github.com/chelcassanova edited
https://github.com/llvm/llvm-project/pull/111929
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova commented:
This looks good to me and I agree with the original feedback that led to this
change in the first place, though I'll also wait for any comments Adrian might
have.
https://github.com/llvm/llvm-project/pull/111929
__
chelcassanova wrote:
I was going to fix the dependency issue here to make sure that SBLanguages gets
generated before trying to build any of these targets, but talking with
@jimingham, this shouldn't have been included at all as `lldb-enumerations`
shouldn't be exposed to any SB layer componen
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/111560
SBTypeStaticField was missing from SBDefines, this commit adds the class there.
>From db7d2f7cc126e348e7c524f19196fca42a6142c9 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 8 Oct 2024 10:01:
chelcassanova wrote:
I'm just wondering, would this patch run into the same issue that I ran into on
https://github.com/llvm/llvm-project/pull/111907 where this could cause a clean
build to fail since the `SourceLangugageNames` file wouldn't be generated
before it gets included in `lldb-enumer
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/111907
This adds an include for SBLanguages.h in lldb-enumerations.h so that files
that need this enum do not have to explicitly include SBLanguages.
>From 133ace4b281abf205d35bbb6ed6ef7b2a39a8c2a Mon Sep 17 00:
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/111907
>From c179c081ff76ce53a0c13265b1e68eb682699415 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 10 Oct 2024 12:58:06 -0700
Subject: [PATCH] [lldb] Add include for SBLanguages in lldb-enumeration
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/111907
>From e4393924a46dc62f2edfae5675b48002042f2032 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 10 Oct 2024 12:58:06 -0700
Subject: [PATCH] [lldb] Add include for SBLanguages in lldb-enumeration
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/111907
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,32 @@
+"""
+Test that disabling breakpoints and viewing them in a list uses the correct
ANSI color settings when colors are enabled and disabled.
+"""
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test impo
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/91404
>From c683d86ea988e76500ed12d1ac102fc1cc091823 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 9 May 2024 11:08:29 -0700
Subject: [PATCH] [lldb][breakpoint] Grey out disabled breakpoints
This c
@@ -0,0 +1,32 @@
+"""
+Test that disabling breakpoints and viewing them in a list uses the correct
ANSI color settings when colors are enabled and disabled.
+"""
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test impo
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/91404
>From c4ee8ba1f6eff974614c9a98e660d22a1691bdb4 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 9 May 2024 11:08:29 -0700
Subject: [PATCH] [lldb][breakpoint] Grey out disabled breakpoints
This c
chelcassanova wrote:
I agree that those who want to change their colours in LLDB shouldn't have to
touch the ANSI suffix setting in order to do this. We do use settings for
changing the suffix in other places in LLDB, so if we were change how this
setting works then I think it's outside of the
chelcassanova wrote:
I also agree with how I was misusing the `pexpect` module here, I was way
overcomplicating things there by trying to model my test after the one that
drives the `expect` program instead of lldb itself 😅
https://github.com/llvm/llvm-project/pull/91404
_
@@ -0,0 +1,26 @@
+"""
+Test that disabling breakpoints and viewing them in a list uses the correct
ANSI color settings when colors are enabled and disabled.
+"""
+
+import lldb
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test im
chelcassanova wrote:
Adding myself as a reviewer here, I didn't know about either of these commands
and the behaviour described here is something I've noticed without knowing
exactly what was happening 😅 . The explanation for the docs looks good here so
this LGTM.
https://github.com/llvm/llvm
https://github.com/chelcassanova approved this pull request.
https://github.com/llvm/llvm-project/pull/110167
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/116434
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/116434
SBBreakpointName has a typedef for BreakpointHitCallback used in SetCallback(),
but this typedef has been commented out in SBBreakpointName and added instead
to SBDefines. Since SB API callbacks are place
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/126606
A new callback was added with the type
CommandReturnObjectCallbackResult, this commit namespaces that type to match
the format of other callback functions that have a non-primitive return type in
the lldb
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/126606
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -208,6 +209,110 @@ TEST_F(ProgressReportTest,
TestReportDestructionWithPartialProgress) {
EXPECT_EQ(data->GetMessage(), "Infinite progress: Report 2");
}
+TEST_F(ProgressReportTest, TestFiniteOverflow) {
+ ListenerSP listener_sp = CreateListenerFor(lldb::eBroadcastBitPr
https://github.com/chelcassanova approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/119377
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
201 - 300 of 608 matches
Mail list logo
