[Lldb-commits] [lldb] r244681 - Added missing files from checking regarding:

Author: gclayton Date: Tue Aug 11 16:49:32 2015 New Revision: 244681 URL: http://llvm.org/viewvc/llvm-project?rev=244681view=rev Log: Added missing files from checking regarding: http://reviews.llvm.org/D8712 Added: lldb/trunk/include/lldb/Symbol/TypeSystem.h

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Many changes. See inlined comments. Comment at: source/Core/Disassembler.cpp:1169-1187 @@ +1168,21 @@ + +/* + * MIPS: + * The bit #0 of

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

clayborg added a comment. The main thing is, we don't want to be like other debuggers that have all this code in many many places that check address bits by checking the Architecture and litter the code with bit strips and adding bits where needed. We want to support addresses correctly by

Re: [Lldb-commits] [PATCH] D12083: [LLGS] Avoid misrepresenting log lines as inferior output

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D12083 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D11962: Mark TestCModules as XFAIL on OSX

clayborg added a comment. No need to wait for Sean. http://reviews.llvm.org/D11962 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D11962: Mark TestCModules as XFAIL on OSX

clayborg accepted this revision. clayborg added a comment. Please commit. http://reviews.llvm.org/D11962 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [lldb] r245547 - [LLDB] Use llvm::APInt and llvm::APFloat in Scalar and RegisterValue

I agree that this change has caused many problems and is quite large to commit to a release branch with little testing. I do really want to get to a Scalar and RegisterValue that uses llvm::APInt and llvm::APFloat as soon as possible, but seeing as this patch has continually caused crashes it

Re: [Lldb-commits] [PATCH] D12218: Implement handling of `library:` keys in thread stop replies.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D12218 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D12233: Add absolute load address support for the DynamicLoader plugins

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D12233 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D12238: Add support for DW_FORM_GNU_[addr, str]_index

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D12238 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D12044: Fix resolution conflict between global and class static variables in C++.

clayborg added a comment. Please make sure that the following works after your changes: (lldb) r Process 35421 launched: '/private/tmp/a.out' (x86_64) Process 35421 stopped * thread #1: tid = 0xb659be, 0x00010f9d a.out main + 13, stop reason = breakpoint 1.1, queue =

Re: [Lldb-commits] [PATCH] D12100: [LLDB] Use llvm::APInt and llvm::APFloat in Scalar and RegisterValue

clayborg added a comment. Looks good. Repository: rL LLVM http://reviews.llvm.org/D12100 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12077: [MIPS] Move is 'or' instead of 'addu'.

clayborg resigned from this revision. clayborg removed a reviewer: clayborg. clayborg added a comment. I don't think I am the right person to review this as this is in LLVM. http://reviews.llvm.org/D12077 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D12203: Fix some format strings in ProcessGDBRemote.cpp.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D12203 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D12204: Understand absolute base addresses in ProcessGDBRemote::GetLoadedModuleList.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks fine. http://reviews.llvm.org/D12204 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D11930: [MIPS]Handle floating point and aggregate return types in SysV-mips [32 bit] ABI

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Init the variables and this is good to go. Comment at: source/Plugins/ABI/SysV-mips/ABISysV_mips.cpp:426-428 @@ -425,3 +425,5 @@ bool is_signed; +

[Lldb-commits] [lldb] r244683 - Fix a infinite loop when killing a process that is in the middle of loading shared libraries.

Author: gclayton Date: Tue Aug 11 17:07:46 2015 New Revision: 244683 URL: http://llvm.org/viewvc/llvm-project?rev=244683view=rev Log: Fix a infinite loop when killing a process that is in the middle of loading shared libraries. The issue was we were sending a qSymbol:: packet and it we were

Re: [Lldb-commits] [PATCH] D11519: [MIPS] Use qfThreadID if qC packet is not supported by target

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. I don't see how passing the target architecture's OS helps here since you aren't checking it for linux or any of the other OS's where pid == tid. This arch is likely to be unset

Re: [Lldb-commits] [PATCH] D10216: Initial diff for FreeBSD kernel debugging support

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good as long as the code is using the LLDB coding style which I believe has been addressed. http://reviews.llvm.org/D10216 ___

Re: [Lldb-commits] [PATCH] D11899: Fix AArch64 watchpoint handlers in NativeRegisterContextLinux_arm64

clayborg resigned from this revision. clayborg removed a reviewer: clayborg. clayborg added a comment. I will defer to Tamas Berghammer since I have no expertise is arm64 watchpoints. http://reviews.llvm.org/D11899 ___ lldb-commits mailing list

[Lldb-commits] [lldb] r245121 - Don't crash if we don't have a type system for a language.

Author: gclayton Date: Fri Aug 14 18:15:48 2015 New Revision: 245121 URL: http://llvm.org/viewvc/llvm-project?rev=245121view=rev Log: Don't crash if we don't have a type system for a language. Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp Modified:

Re: [Lldb-commits] [PATCH] D11987: Fix to handle AArch64 watchpoint exception before instruction being watched is executed

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D11987 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13940: Fix race conditions in Core/Timer

clayborg added a comment. Yes, please use any llvm system utilities when possible. And scratch the need for LLDB_THREAD_LOCAL at any point in the future and just use llvm::ThreadLocal all the time as thread local variables have already been abstracted by llvm. http://reviews.llvm.org/D13940

Re: [Lldb-commits] [PATCH] D13970: Add support for abstract domain sockets.

clayborg added a comment. In http://reviews.llvm.org/D13970#273267, @ovyalov wrote: > In http://reviews.llvm.org/D13970#273217, @clayborg wrote: > > > Looks good. At some point we should add these to the PluginMananger and > > have new instances found by having them register URL prefixes which

Re: [Lldb-commits] [PATCH] D14085: Make Socket to support plugin interface

clayborg added a comment. In http://reviews.llvm.org/D14085#275507, @zturner wrote: > I think most of the time they are used in a Connection class, but I don't > think it's necessarily guaranteed they will always be that way. > > I can think of at least one use case in the future where we will

Re: [Lldb-commits] [PATCH] D14111: Use "_$" prefix instead of "$" for dynamic checker function inserted by LLDB during expression evaluation

clayborg resigned from this revision. clayborg edited reviewers, added: spyffe, jingham; removed: clayborg. clayborg added a comment. Lets let Sean Callanan and Jim Ingham make sure this is good as they are the expression parser masters. Repository: rL LLVM http://reviews.llvm.org/D14111

Re: [Lldb-commits] [PATCH] D14126: Make lldb-gdbserver to take explicit socket scheme as command line argument

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Need to make a copy of socket_scheme in GDBRemoteCommunicationServerPlatform (save it to a std::string). Comment at:

[Lldb-commits] [lldb] r251537 - Make core files not crash when you load a core file into LLDB with just "lldb -c core".

Author: gclayton Date: Wed Oct 28 13:04:38 2015 New Revision: 251537 URL: http://llvm.org/viewvc/llvm-project?rev=251537=rev Log: Make core files not crash when you load a core file into LLDB with just "lldb -c core". To do this I added a few new ways to determine the OS from PT_NOTE notes in

[Lldb-commits] [lldb] r251555 - Don't crash when opening a fuzzed mach-o file that has bad dyld trie data.

Author: gclayton Date: Wed Oct 28 15:49:34 2015 New Revision: 251555 URL: http://llvm.org/viewvc/llvm-project?rev=251555=rev Log: Don't crash when opening a fuzzed mach-o file that has bad dyld trie data. Modified: lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp Modified:

[Lldb-commits] [lldb] r251310 - Re-use prologue parsing code that was already written instead of having two copies of code that parse line table prologues.

Author: gclayton Date: Mon Oct 26 12:16:50 2015 New Revision: 251310 URL: http://llvm.org/viewvc/llvm-project?rev=251310=rev Log: Re-use prologue parsing code that was already written instead of having two copies of code that parse line table prologues. Also since we always read in the DWARF

Re: [Lldb-commits] [PATCH] D14083: Fix race condition in process resume

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good as long as we always want to send the broadcast even if the continue packet fails to send. Comment at:

[Lldb-commits] [lldb] r250952 - Fix typo so that "./dotest.py --results-formatter=curses_results.Curses --results-file=/dev/stdout" works again.

Author: gclayton Date: Wed Oct 21 16:55:16 2015 New Revision: 250952 URL: http://llvm.org/viewvc/llvm-project?rev=250952=rev Log: Fix typo so that "./dotest.py --results-formatter=curses_results.Curses --results-file=/dev/stdout" works again. Modified: lldb/trunk/test/lldbcurses.py

Re: [Lldb-commits] [PATCH] D13948: [AppleObjCRuntime] Don't bother looking for the runtime on non-apple targets

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. This is really the fault of AppleObjCRuntimeV1::CreateInstance() and AppleObjCRuntimeV2::CreateInstance() not checking the triple to begin with, but this is a simple solution that will

Re: [Lldb-commits] [PATCH] D13942: Make SymbolFileDWARF::GetCachedSectionData thread safe

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D13942 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13940: Fix race conditions in Core/Timer

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D13940 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13970: Add support for abstract domain sockets.

clayborg accepted this revision. clayborg added a comment. Looks good. At some point we should add these to the PluginMananger and have new instances found by having them register URL prefixes which match up with CreateInstance methods that are given the URL. http://reviews.llvm.org/D13970

Re: [Lldb-commits] [PATCH] D13602: [LLDB] Fix Clang-tidy misc-use-override warnings in some files in include/lldb/Interpreter and Host; other minor fixes.

clayborg accepted this revision. clayborg added a comment. Looks good. I would venture to say just checkin any clang tidy things that aren't changing code functionality without need for review. Repository: rL LLVM http://reviews.llvm.org/D13602

[Lldb-commits] [lldb] r252622 - Fixed TypeMemberFunctionImpl to not use clang types directly but use the new CompilerDecl class to do the job in an abstract way.

Author: gclayton Date: Tue Nov 10 11:47:04 2015 New Revision: 252622 URL: http://llvm.org/viewvc/llvm-project?rev=252622=rev Log: Fixed TypeMemberFunctionImpl to not use clang types directly but use the new CompilerDecl class to do the job in an abstract way. Fixed a crash that would happen if

Re: [Lldb-commits] [PATCH] D14536: Add empty symbols to symtab for skipped symbols

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Symbols are the #1 most expensive item memory wise in LLDB right now. We remove many symbols in Mach-O and we set the m_uid of each symbol to the original symbol table index.

Re: [Lldb-commits] [PATCH] D14549: Use uniqueness of C++ fully-qualified names to resolve conflicts

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good! http://reviews.llvm.org/D14549 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D14633: [LLDB][MIPS] Clear bug 25194 - LLDB-Server Assertion raised when single stepping on MIPS

clayborg requested changes to this revision. clayborg added a comment. I agree with tberghammer. Repository: rL LLVM http://reviews.llvm.org/D14633 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D14631: [dwarf] Handle DWARF forms for address other than DW_FORM_GNU_addr_index and DW_FORM_addr.

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. This is not the right fix. Compilers that emit addresses with DW_FORM_data* forms are saying that this address is an offset from the DW_AT_low_pc so this function will not

Re: [Lldb-commits] [PATCH] D14633: [LLDB][MIPS] Clear bug 25194 - LLDB-Server Assertion raised when single stepping on MIPS

clayborg requested changes to this revision. This revision now requires changes to proceed. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:1378 @@ -1377,2 +1377,3 @@ GPR_linux_mips regs; +lldb_private::ArchSpec arch; ::memset(, 0,

Re: [Lldb-commits] [PATCH] D14633: [LLDB][MIPS] Clear bug 25194 - LLDB-Server Assertion raised when single stepping on MIPS

clayborg added a comment. GDB remote protocol specifies that register values are sent in target byte order. We shouldn't change this. A big endian system should not send things as little endian. That being said, the current register context assumes you have a buffer that can contain all

Re: [Lldb-commits] [PATCH] D14507: Make sure we use symbol flags to detect thumbness.

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. You should populate the m_address_class_map in ObjectFileELF::ParseSymbols() as this is where the m_address_class_map is already being populated. For ARM symbols, just check the

Re: [Lldb-commits] [PATCH] D14507: Make sure we use symbol flags to detect thumbness.

clayborg added a comment. See Inlined comment. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:975-997 @@ -974,5 +974,25 @@ { -// No entry in the address class map before the address. Return -// default address class for an address in a code

Re: [Lldb-commits] [PATCH] D14226: Fix to solve Bug 23139 & Bug 23560

clayborg resigned from this revision. clayborg removed a reviewer: clayborg. clayborg added a comment. I will defer to Jason Molenda. http://reviews.llvm.org/D14226 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r252005 - Fix a deadlock when connecting to a remote GDB server that might not support all packets that lldb-server or debugserver supports. The issue was the m_last_stop_packet_

Author: gclayton Date: Tue Nov 3 16:42:04 2015 New Revision: 252005 URL: http://llvm.org/viewvc/llvm-project?rev=252005=rev Log: Fix a deadlock when connecting to a remote GDB server that might not support all packets that lldb-server or debugserver supports. The issue was the

[Lldb-commits] [lldb] r252013 - All instance variables start with "m_". Fix "options" to be "m_options".

Author: gclayton Date: Tue Nov 3 17:23:59 2015 New Revision: 252013 URL: http://llvm.org/viewvc/llvm-project?rev=252013=rev Log: All instance variables start with "m_". Fix "options" to be "m_options". Modified: lldb/trunk/include/lldb/DataFormatters/ValueObjectPrinter.h

Re: [Lldb-commits] [PATCH] D13812: Increase default memory cache line size for android

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. I would rather you be able to ask the current platform for the default memory cache line size and have lldb_private::Process do this automatically on the first memory read if

Re: [Lldb-commits] [PATCH] D13662: Make dwarf parsing multi-threaded

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Just saw that patch, so this looks good then pending the other patch. http://reviews.llvm.org/D13662 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D13662: Make dwarf parsing multi-threaded

clayborg added a comment. BTW: if we can modify clang to produce the Apple accelerator tables, we won't need to do any of this indexing which will really speed up debugging! We only produce the Apple accelerator tables on Darwin, but we could on other systems. There is also a new version of

Re: [Lldb-commits] [PATCH] D13662: Make dwarf parsing multi-threaded

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Missing the TaskPool.h and TaskPool.cpp files? http://reviews.llvm.org/D13662 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D13727: Add task pool to LLDB

clayborg added a comment. Zach: If these are implementation details, lets get this in first and then worry about optimizations later. http://reviews.llvm.org/D13727 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r249625 - Don't do DWO tests on darwin as they aren't supported. If this is an error and they are supported, we need to add support _only_ if the clang compiler that is being use

Author: gclayton Date: Wed Oct 7 17:06:08 2015 New Revision: 249625 URL: http://llvm.org/viewvc/llvm-project?rev=249625=rev Log: Don't do DWO tests on darwin as they aren't supported. If this is an error and they are supported, we need to add support _only_ if the clang compiler that is being

Re: [Lldb-commits] [PATCH] D13537: Port native Python API to support 3.x

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Few minor changes. Comment at: source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:1183 @@ +1182,3 @@ +llvm::StringRef

[Lldb-commits] [lldb] r249605 - Another stripped test that requires darwin and a dSYM (no Dwarf or DWO).

Author: gclayton Date: Wed Oct 7 15:08:26 2015 New Revision: 249605 URL: http://llvm.org/viewvc/llvm-project?rev=249605=rev Log: Another stripped test that requires darwin and a dSYM (no Dwarf or DWO). Modified:

[Lldb-commits] [lldb] r249626 - Fix the TestCppNsImport test case for DWARF. It was failing for DWARF in .o files because SymbolFileDWARFDebugMap didn't implement the following function:

Author: gclayton Date: Wed Oct 7 17:07:33 2015 New Revision: 249626 URL: http://llvm.org/viewvc/llvm-project?rev=249626=rev Log: Fix the TestCppNsImport test case for DWARF. It was failing for DWARF in .o files because SymbolFileDWARFDebugMap didn't implement the following function: void

[Lldb-commits] [lldb] r249631 - Expected fail this test and supplied the radar number that is tracking the fix.

Author: gclayton Date: Wed Oct 7 17:36:52 2015 New Revision: 249631 URL: http://llvm.org/viewvc/llvm-project?rev=249631=rev Log: Expected fail this test and supplied the radar number that is tracking the fix. Modified: lldb/trunk/test/macosx/queues/TestQueues.py Modified:

[Lldb-commits] [lldb] r249600 - Fixed up some first responder issues and added menubar support that isn't in use yet.

Author: gclayton Date: Wed Oct 7 15:00:28 2015 New Revision: 249600 URL: http://llvm.org/viewvc/llvm-project?rev=249600=rev Log: Fixed up some first responder issues and added menubar support that isn't in use yet. Modified: lldb/trunk/test/curses_results.py

[Lldb-commits] [lldb] r249601 - Fix a test that should only be run with a dSYM file by adding @skipIfDwarf and using a new @skipIfDWO.

Author: gclayton Date: Wed Oct 7 15:01:13 2015 New Revision: 249601 URL: http://llvm.org/viewvc/llvm-project?rev=249601=rev Log: Fix a test that should only be run with a dSYM file by adding @skipIfDwarf and using a new @skipIfDWO. Modified:

[Lldb-commits] [lldb] r249604 - More fixes for binaries that we strip. When we strip a binary we can't do Dwarf or DWO.

Author: gclayton Date: Wed Oct 7 15:06:45 2015 New Revision: 249604 URL: http://llvm.org/viewvc/llvm-project?rev=249604=rev Log: More fixes for binaries that we strip. When we strip a binary we can't do Dwarf or DWO. Modified: lldb/trunk/test/lang/objc/hidden-ivars/TestHiddenIvars.py

[Lldb-commits] [lldb] r249613 - This test is useless. It doesn't work and it fails on MacOSX. Removing it.

Author: gclayton Date: Wed Oct 7 15:38:20 2015 New Revision: 249613 URL: http://llvm.org/viewvc/llvm-project?rev=249613=rev Log: This test is useless. It doesn't work and it fails on MacOSX. Removing it. Removed: lldb/trunk/test/functionalities/connect_remote/EchoServer.py

Re: [Lldb-commits] [PATCH] D13202: [LLDB] Fix display of value of a vector variables in watchpoint operations

clayborg accepted this revision. clayborg added a comment. Looks good. Repository: rL LLVM http://reviews.llvm.org/D13202 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13548: [LLDB][MIPS] fix watchpoint searched on client side for same masked variables

clayborg accepted this revision. clayborg added a comment. Add space in between if and opening ( and this is good to go. Repository: rL LLVM http://reviews.llvm.org/D13548 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13778: [SBValue] Add a method HasChildAtIndex.

clayborg added a comment. I would almost rather change the GetNumChildren() to take a "max" param: class SBValue { uint32_t GetNumChildren (); uint32_t GetNumChildren (uint32_t max = UINT32_MAX); }; We need to keep the other one so that our public API still has

Re: [Lldb-commits] [PATCH] D13778: [SBValue] Add a method HasChildAtIndex.

clayborg added a comment. For the public API you will need both and not have a default arg. http://reviews.llvm.org/D13778 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r250478 - More general fixes to the tree view and BoxedPanel.

Author: gclayton Date: Thu Oct 15 19:34:18 2015 New Revision: 250478 URL: http://llvm.org/viewvc/llvm-project?rev=250478=rev Log: More general fixes to the tree view and BoxedPanel. Modified: lldb/trunk/test/lldbcurses.py Modified: lldb/trunk/test/lldbcurses.py URL:

Re: [Lldb-commits] [PATCH] D13727: Add task pool to LLDB

clayborg added a comment. Stopping the threads is fine as it seems to be desired from most others. http://reviews.llvm.org/D13727 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13646: [LLDB] Don't use signo as key in Signals DenseMap, as signo are not unique

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. See inlined comments. Comment at: include/lldb/Target/UnixSignals.h:101-102 @@ -100,1 +100,4 @@ +ConstString +GetShortName(ConstString name) const; +

Re: [Lldb-commits] [PATCH] D13727: Add task pool to LLDB

clayborg added a comment. In http://reviews.llvm.org/D13727#268053, @zturner wrote: > The main thought I had was just that it would make the code simpler and > delegate more of the synchronization stuff to the library. But if we don't > get any of that benefit then I guess there's no point in

Re: [Lldb-commits] [PATCH] D13727: Add task pool to LLDB

clayborg added a comment. > Yes. But an implementation of std::async is either going to use a global > thread pool or it's not. If it does there's no problem, and if it doesn't, > it's going to create one thread for each call, and when the work in that > thread is done, the thread will exit.

Re: [Lldb-commits] [PATCH] D13727: Add task pool to LLDB

clayborg accepted this revision. clayborg added a comment. Very nice! I look forward to seeing this patch and the associated DWARF patches make it in! http://reviews.llvm.org/D13727 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13727: Add task pool to LLDB

clayborg added a comment. Yes, lets get this in an iterate on it afterwards! http://reviews.llvm.org/D13727 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13866: Remove more gcc warnings.

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Please don't check this in. If dwarf_r0 changes from 0 to another value, then this code will fail. We will need to live with these warnings. http://reviews.llvm.org/D13866

Re: [Lldb-commits] [PATCH] D13812: Increase default memory cache line size for android

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. The other way to do this would be to add a key/value pair to the qHostInfo like "memory_cache_line_byte_size" and return a value that makes sense for the current Andriod debug

Re: [Lldb-commits] [PATCH] D13859: [LLDB][LLGS Test] Check length of register, only when its available

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. We can't rely on any specific error codes since different GDB remote servers will hand back different errors for any packet. Do you have control over the MIPS debugserver? Is

[Lldb-commits] [lldb] r250770 - When calling FileSpec::AppendPathComponent() we don't need to include "." in the path if m_filename is set to exactly '.'. Previously this would cause a FileSpec object

Author: gclayton Date: Mon Oct 19 19:17:39 2015 New Revision: 250770 URL: http://llvm.org/viewvc/llvm-project?rev=250770=rev Log: When calling FileSpec::AppendPathComponent() we don't need to include "." in the path if m_filename is set to exactly '.'. Previously this would cause a FileSpec

Re: [Lldb-commits] [PATCH] D13877: [PlatformDarwin.cpp] Include for std::once_flag.

clayborg added a comment. Thanks for doing this. Repository: rL LLVM http://reviews.llvm.org/D13877 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r250772 - Fixed PlatformDarwin to locate Xcode by using HostInfo::GetProgramFileSpec(). This function returns the FileSpec to the program that is running the LLDB.framework or ll

Author: gclayton Date: Mon Oct 19 19:22:50 2015 New Revision: 250772 URL: http://llvm.org/viewvc/llvm-project?rev=250772=rev Log: Fixed PlatformDarwin to locate Xcode by using HostInfo::GetProgramFileSpec(). This function returns the FileSpec to the program that is running the LLDB.framework or

Re: [Lldb-commits] [PATCH] D13646: [LLDB] Don't use signo as key in Signals DenseMap, as signo are not unique

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Ok, makes sense then. Repository: rL LLVM http://reviews.llvm.org/D13646 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13662: Make dwarf parsing multi-threaded

clayborg added a comment. See inlined comments. Comment at: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2087-2088 @@ +2086,4 @@ +results.emplace_back(TaskPool::AddTask(parser_fn, cu_idx)); +for (auto& f : results) +f.wait(); +

Re: [Lldb-commits] [PATCH] D13662: Make dwarf parsing multi-threaded

clayborg added inline comments. Comment at: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2087-2088 @@ +2086,4 @@ +results.emplace_back(TaskPool::AddTask(parser_fn, cu_idx)); +for (auto& f : results) +f.wait(); +

Re: [Lldb-commits] [PATCH] D13903: [RenderScript] New commands to save/load RS allocations to file.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. Going forward there is no real need to review any new commands that only exist in the renderscript source files or plug-ins. If you change any code outside of the the

Re: [Lldb-commits] [PATCH] D12890: Add plugin.jit-loader.gdb.enable-jit-breakpoint property to make JIT loader breakpoint optional.

clayborg added a comment. So you are saying to have a setting that allows this plug-in to be enabled and have it set to false by default? That sounds good to me. It probably should be false on all platforms and anyone wanting JIT support should enable it? http://reviews.llvm.org/D12890

Re: [Lldb-commits] [PATCH] D13859: [LLDB][LLGS Test] Check length of register, only when its available

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Is there a list of error codes and what they mean for the GDB remote protocol? debugserver returns random errors and doesn't abide by any specific error codes. Quote from some

Re: [Lldb-commits] [PATCH] D13836: Fix write-after-close of file descriptor in ScriptInterpreterPython

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good to me. Wait for Enrico to OK as well. http://reviews.llvm.org/D13836 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13778: [SBValue] Add a method GetNumChildren(uint32_t max)

clayborg accepted this revision. clayborg added a comment. Accepted as long as Enrico is OK with this. http://reviews.llvm.org/D13778 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r250580 - Split getting the key from a window from the code that handles the key.

Author: gclayton Date: Fri Oct 16 18:34:40 2015 New Revision: 250580 URL: http://llvm.org/viewvc/llvm-project?rev=250580=rev Log: Split getting the key from a window from the code that handles the key. Modified: lldb/trunk/test/lldbcurses.py Modified: lldb/trunk/test/lldbcurses.py URL:

Re: [Lldb-commits] [PATCH] D13754: Split Socket class into Tcp/Udp/DomainSocket subclasses.

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Can we change "TcpSocket" to be "TCPSocket" and "UdpSocket" to be "UDPSocket" in all code and in the file names? Other than that it looks good. Comment at:

Re: [Lldb-commits] [PATCH] D13727: Add task pool to LLDB

clayborg added a comment. In http://reviews.llvm.org/D13727#268091, @tberghammer wrote: > I agree that parking the threads in the kernel should be very cheap (I am not > sure about Windows) but on high end multi core machines having 40+ threads > around just to wait for work is a bit strange

Re: [Lldb-commits] [PATCH] D13662: Make dwarf parsing multi-threaded

clayborg added a comment. std::async is fine as long as it doesn't blow out the threads on any supported systems. We should also test doing multiple std::async calls in different places in some test only code to make sure if we run 4 std::async calls at once on different threads that we don't

Re: [Lldb-commits] [PATCH] D13652: Change ConstString to support massive multi-threaded access

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. It would be nice to compute one hash per string and use that during insertion. I really like the patch, but can we avoid two string hashes? Comment at:

Re: [Lldb-commits] [PATCH] D13224: [DWARFASTParserClang] Strengthen incomplete type handling.

clayborg added a comment. So this fix is really to take care of the case where a class methods might be defined on only some class instances? Can you explain more of what this fixes? http://reviews.llvm.org/D13224 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D13247: RenderScript command for printing allocation information

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Back from vacation, sorry for the delay. Looks good. Repository: rL LLVM http://reviews.llvm.org/D13247 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D13154: [MIPS] Use Address::GetAddressClass() instead of elf flags to decide address space of an address

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Back from vacation, sorry for the delay. Looks good. Repository: rL LLVM http://reviews.llvm.org/D13154 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D12968: Fix for lldb-mi crash in Listener code if -exec-abort MI command was invoked without getting process stopped

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. This can't be the real fix for this. We must be able to trust the empty() function call. We must have someone playing with the collection without locking the mutex. Please find

Re: [Lldb-commits] [PATCH] D13202: [LLDB] Fix display of value of a vector variables in watchpoint operations

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Back from vacation, sorry for the delay. One quick fix as noted in inlined comments. Comment at: source/Breakpoint/Watchpoint.cpp:224-235 @@ -223,7 +223,14 @@

Re: [Lldb-commits] [PATCH] D13224: [DWARFASTParserClang] Strengthen incomplete type handling.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Thanks for the info, now the patch makes more sense. That is some really lame DWARF I must say, but alas we must deal with it. Looks good. http://reviews.llvm.org/D13224

Re: [Lldb-commits] [PATCH] D13241: [LLDB][MIPS] Fix hit_count for mips watchpoints

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Back from vacation, sorry for the delay. Looks good. Repository: rL LLVM http://reviews.llvm.org/D13241 ___ lldb-commits mailing list

  1   2   3   4   5   6   7   8   9   10   >