[Lldb-commits] [PATCH] D83858: [lldb] Desugar template specializations

jarin updated this revision to Diff 278200. jarin added a comment. Undo the infinite loop detection. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83858/new/ https://reviews.llvm.org/D83858 Files:

[Lldb-commits] [PATCH] D81465: [lldb] Fix and enable Windows minidump tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGfac5d05eb75f: [lldb] Fix and enable Windows minidump tests (authored by jarin). Changed prior to commit: https://reviews.llvm.org/D81465?vs=269609=269649#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D80755: Support build-ids of other sizes than 16 in UUID::SetFromStringRef

jarin updated this revision to Diff 268497. jarin added a comment. Exclude UUID strings ending with "-". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80755/new/ https://reviews.llvm.org/D80755 Files: lldb/include/lldb/Utility/UUID.h lldb/source/Interpreter/OptionValueUUID.cpp

[Lldb-commits] [PATCH] D80755: Support build-ids of other sizes than 16 in UUID::SetFromStringRef

This revision was automatically updated to reflect the committed changes. Closed by commit rG1beffc18886a: Support build-ids of other sizes than 16 in UUID::SetFromStringRef (authored by jarin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D81363: Disable remove-add module test on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG6143874f734b: [lldb] Disable remove-add module test on Windows (authored by jarin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81363/new/

[Lldb-commits] [PATCH] D81465: [lldb] Fix and enable Windows minidump tests

jarin created this revision. jarin added a reviewer: labath. jarin added a project: LLDB. Herald added a subscriber: lldb-commits. jarin edited the summary of this revision. SBFileSpec.fullpath always uses the forward slash to join the directory with the base name. This causes mismatches when

[Lldb-commits] [PATCH] D81465: [lldb] Fix and enable Windows minidump tests

jarin updated this revision to Diff 269609. jarin added a comment. Added a comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81465/new/ https://reviews.llvm.org/D81465 Files: lldb/test/API/functionalities/postmortem/minidump-new/TestMiniDumpUUID.py Index:

[Lldb-commits] [PATCH] D83858: [lldb] Desugar template specializations

This revision was automatically updated to reflect the committed changes. Closed by commit rG93ec6cd68426: [lldb] Desugar template specializations (authored by jarin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83858/new/

[Lldb-commits] [PATCH] D90318: Return actual type from SBType::GetArrayElementType

jarin accepted this revision. jarin added a comment. This revision is now accepted and ready to land. The code change looks good to me and it is in line with the change that Raphael and Greg wanted in https://reviews.llvm.org/D72133. As far as I remember, https://reviews.llvm.org/D72133 did not

[Lldb-commits] [PATCH] D73191: Only match mangled name in full-name function lookup (with accelerators)

jarin added a comment. Thanks for getting back to this, Raphael! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73191/new/ https://reviews.llvm.org/D73191 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a3556aa5563: [lldb] Add omitted abstract formal parameters in DWARF symbol files (authored by Jaroslav Sevcik ja...@chromium.org, committed by jarin). Changed prior to commit:

[Lldb-commits] [PATCH] D110570: [lldb] Refactor variable parsing in DWARF symbol file

jarin updated this revision to Diff 375538. jarin added a comment. Added the `/*can_create=*/` comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110570/new/ https://reviews.llvm.org/D110570 Files:

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

jarin added a comment. Just a few replies below; I am hoping to put the relevant code changes together tomorrow. In D110571#3027173 , @labath wrote: > I haven't looked at the actual code yet, so I could be off, but here are some > thoughts. > > In

[Lldb-commits] [PATCH] D110570: [lldb] Refactor variable parsing in DWARF symbol file

jarin added a comment. Thank you for the review! Does the separate method look more reasonable? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110570/new/ https://reviews.llvm.org/D110570 ___

[Lldb-commits] [PATCH] D110570: [lldb] Refactor variable parsing in DWARF symbol file

jarin updated this revision to Diff 375535. jarin added a comment. Separated ParseVariablesInFunctionContext's lambda into a method. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110570/new/ https://reviews.llvm.org/D110570 Files:

[Lldb-commits] [PATCH] D110570: [lldb] Refactor variable parsing in DWARF symbol file

jarin added a comment. Thank you for taking a look, shafik@. I hope you don't mind if I address your comments later, once a full review arrives from Pavel (or Johannes). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110570/new/

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

jarin updated this revision to Diff 375886. jarin added a comment. Added a C test (I have also verified that the C test fails without the SymbolFileDWARF patch). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110571/new/

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

jarin added a comment. In D110571#3030222 , @labath wrote: > In D110571#3030192 , @jarin wrote: > >> This still uses `frame variable` rather than `image lookup`, mostly because >> `frame variable` tests better

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

jarin added a comment. First of all, thank you, Greg and Pavel, for all the great feedback and discussion. I have followed all your suggestions (use plain method, use `image lookup`, added the additional tests). I have also packaged the C test, but as Greg notes I am not convinced it will keep

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

jarin added a comment. In D110571#3031846 , @clayborg wrote: > In D110571#3031140 , @jarin wrote: > >> For illustration: >> >> 0x100 DW_TAG_subprogram >>DW_AT_name "inlined_function" >>

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

jarin updated this revision to Diff 376124. jarin marked an inline comment as done. jarin added a comment. Improved the comment, as Greg suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110571/new/ https://reviews.llvm.org/D110571 Files:

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

jarin added a comment. In D110571#3033078 , @labath wrote: > Here's one more question. AIUI, lldb relies on the order of formal parameter > declarations in dwarf to establish the the function signature (dwarf doesn't > leave us much choice. This then

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

jarin updated this revision to Diff 376235. jarin marked an inline comment as done. jarin added a comment. Cache only global variables. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110571/new/ https://reviews.llvm.org/D110571 Files:

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

jarin added a comment. Thank you for the great comments, Pavel. I took a stab at merging the parameters without interleaving them with the locals. Let me know what you think; I can certainly put this back to the original state if you think this is a change for the worse. (I am sorry for the

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

jarin updated this revision to Diff 376501. jarin marked 5 inline comments as done. jarin added a comment. Addressed reviewer comments, separated merging of the abstract parameters into a function, prevented interleaving of parameters with locals. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

jarin updated this revision to Diff 375901. jarin added a comment. Changed the test to avoid running the process and use `image lookup` instead of `frame variable`. I think I would still slightly prefer `frame variable`, mostly because there seem to be differences between what `image lookup`

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

jarin updated this revision to Diff 377020. jarin marked 4 inline comments as done. jarin added a comment. Addressed Pavel's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110571/new/ https://reviews.llvm.org/D110571 Files:

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

jarin added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3545 + +DIEVector MergeBlockAbstractParameters(const DWARFDIE _die, + DIEVector &_dies) { labath wrote: > In llvm, we prefer

[Lldb-commits] [PATCH] D110570: [lldb] Refactor variable parsing in DWARF symbol file

jarin updated this revision to Diff 377474. jarin marked 2 inline comments as done. jarin added a comment. Avoid nullptr deref/ref. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110570/new/ https://reviews.llvm.org/D110570 Files:

[Lldb-commits] [PATCH] D110570: [lldb] Refactor variable parsing in DWARF symbol file

jarin added a comment. Pavel, could you take another look? Interestingly the null-deref problem was already fixed in the follow-up patch , maybe I just did not land quickly enough :-)). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110570/new/

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

jarin created this revision. jarin added a reviewer: labath. jarin added a project: LLDB. Herald added a subscriber: JDevlieghere. jarin requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. This change fixes a problem introduced

[Lldb-commits] [PATCH] D110570: [lldb] Refactor variable parsing in DWARF symbol file

jarin added a comment. Hi, could you possibly take a look at this change? The main motivation for this patch is to move the setup of the variable list for parsing children to the DIE node that corresponds to the block containing the children. This will be particularly important for

[Lldb-commits] [PATCH] D110570: [lldb] Refactor variable parsing in DWARF symbol file

jarin created this revision. jarin added a reviewer: labath. jarin added a project: LLDB. Herald added a subscriber: JDevlieghere. jarin requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. This is in preparation for a fix of

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

jarin added a comment. Hi, could you take a look at this change? Some discussion points: - In the ParseVariablesInFunctionContext method, we are using a lambda for the recursive parser. We could also use a function-local class or inner class of SymbolFileDWARF. Would any of these be

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

jarin added a comment. In D110571#3033481 , @labath wrote: > In D110571#3033282 , @jarin wrote: > >> In D110571#3033078 , @labath wrote: >> >>> Here's one more question.

[Lldb-commits] [PATCH] D110571: [lldb] Add omitted abstract formal parameters in DWARF symbol files

jarin updated this revision to Diff 375865. jarin added a comment. Rewrote the recursive parser to use a plain method. Pruned and annotated the test. Added other test cases: - all parameters unused, - inlining from two different functions, - stack trace. This still uses `frame variable`

[Lldb-commits] [PATCH] D115104: [lldb] Fix guessing of windows path style

jarin created this revision. jarin added a reviewer: labath. jarin requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Currently, only paths with length>3 are guessed as Windows paths. This prevents root paths (such as C:\) to be recognized

[Lldb-commits] [PATCH] D115104: [lldb] Fix guessing of windows path style

This revision was automatically updated to reflect the committed changes. Closed by commit rGf72ae5cba1d6: [lldb] Fix windows path guessing for root paths (authored by jarin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115104/new/

[Lldb-commits] [PATCH] D153043: [lldb] Fix handling of cfi_restore in the unwinder

This revision was automatically updated to reflect the committed changes. Closed by commit rG07b9e6ed0db2: [lldb] Fix handling of cfi_restore in the unwinder (authored by jarin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153043/new/

[Lldb-commits] [PATCH] D153043: [lldb] Fix handling of cfi_restore in the unwinder

jarin updated this revision to Diff 531987. jarin added a comment. Added a comment explaining that we are restoring the caller's value of the register. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153043/new/ https://reviews.llvm.org/D153043 Files:

[Lldb-commits] [PATCH] D153043: [lldb] Fix handling of cfi_restore in the unwinder

jarin added a comment. In D153043#4427660 , @Michael137 wrote: > Looks like this is failing on the Darwin x86_64 buildbots: > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/56510/execution/node/74/log/ > > Exit Code: 1 > > Command

[Lldb-commits] [PATCH] D153043: [lldb] Fix handling of cfi_restore in the unwinder

jarin created this revision. jarin added a reviewer: labath. jarin added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jarin requested review of this revision. Herald added a subscriber: lldb-commits. Currently, lldb's unwinder ignores cfi_restore opcodes

<    1   2