[Lldb-commits] [PATCH] D29126: [cmake] Remove VERSION property from executable targets

mgorny added a comment. Technically the patch looks sane; however, I suggest you wait for some input from the others. As for Gentoo, I don't think we ever really cared for LLDB being versioned — only clang. https://reviews.llvm.org/D29126 ___

[Lldb-commits] [PATCH] D29985: [lldb] [test] Fix finding LLDB tools when building stand-alone

mgorny updated this revision to Diff 88771. mgorny edited the summary of this revision. https://reviews.llvm.org/D29985 Files: lit/lit.cfg lit/lit.site.cfg.in Index: lit/lit.site.cfg.in === --- lit/lit.site.cfg.in +++

[Lldb-commits] [PATCH] D29985: [lldb] [test] Fix finding LLDB tools when building stand-alone

mgorny marked an inline comment as done. mgorny added a comment. Following @labath's suggestion, I've changed my approach a little. Now I'm using PATH lookup only for CC/CXX, while for remaining tools I'm using either llvm_tools_dir or lldb_tools_dir appropriately.

[Lldb-commits] [PATCH] D26249: [unittests] Split DWARF tests out of PDB, fix standalone build

mgorny updated this revision to Diff 82676. mgorny marked an inline comment as done. Herald added a subscriber: aprantl. https://reviews.llvm.org/D26249 Files: unittests/SymbolFile/CMakeLists.txt unittests/SymbolFile/DWARF/CMakeLists.txt unittests/SymbolFile/DWARF/Inputs/test-dwarf.cpp

[Lldb-commits] [PATCH] D26249: [unittests] Split DWARF tests out of PDB, fix standalone build

This revision was automatically updated to reflect the committed changes. Closed by commit rL290819: [unittests] Split DWARF tests out of PDB, fix standalone build (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D26249?vs=82676=82812#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D31367: Expression: add missing linkage to RuntimeDyld component

mgorny created this revision. mgorny added a project: LLDB. Add missing linkage from lldbExpression library to LLVMRuntimeDyld. Otherwise the build against shared LLVM libraries fails with: lib64/liblldbExpression.a(IRExecutionUnit.cpp.o):IRExecutionUnit.cpp:function

[Lldb-commits] [PATCH] D31369: PluginUnwindAssemblyX86: add missing linkage to MCDisasm

mgorny created this revision. mgorny added a project: LLDB. Add missing linkage of the lldbPluginUnwindAssemblyX86 to LLVMMCDisasm library. This fixes the following build failure when linking against shared libraries:

[Lldb-commits] [PATCH] D31367: Expression: add missing linkage to RuntimeDyld component

mgorny added a comment. In https://reviews.llvm.org/D31367#713472, @labath wrote: > We don't depend on the RuntimeDyld component of llvm directy -- we only use > it indirectly through the ExecutionEngine component. Shouldn't that be > reflected as a dependency in the build system somehow, so

[Lldb-commits] [PATCH] D31367: Expression: add missing linkage to RuntimeDyld component

mgorny added a comment. In https://reviews.llvm.org/D31367#714305, @beanz wrote: > Please revert your patch. It is *not* the right solution and is masking > underlying problems. Reverted in r299095. Now I'd really appreciate some help in figuring out how to fix it properly. >

[Lldb-commits] [PATCH] D31367: Expression: add missing linkage to RuntimeDyld component

This revision was automatically updated to reflect the committed changes. Closed by commit rL298776: Expression: add missing linkage to RuntimeDyld component (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D31367?vs=93041=93051#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D31369: PluginUnwindAssemblyX86: add missing linkage to MCDisasm

This revision was automatically updated to reflect the committed changes. Closed by commit rL298777: PluginUnwindAssemblyX86: add missing linkage to MCDisasm (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D31369?vs=93043=93052#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D31367: Expression: add missing linkage to RuntimeDyld component

mgorny added a comment. Well, I can confirm that the hack works for me. Not that I like it but if it's meant to be only temporary, I'm fine with any solution that works. Repository: rL LLVM https://reviews.llvm.org/D31367 ___ lldb-commits

[Lldb-commits] [PATCH] D31367: Expression: add missing linkage to RuntimeDyld component

mgorny reopened this revision. mgorny added a reviewer: chapuni. mgorny added a subscriber: chapuni. mgorny added a comment. This revision is now accepted and ready to land. Well, @chapuni disagrees on https://reviews.llvm.org/D36211. Which way should we go then? Repository: rL LLVM

[Lldb-commits] [PATCH] D36358: [lldb] [cmake] Add explicit linkage from Core to curses

mgorny added a comment. Ping. https://reviews.llvm.org/D36358 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D36358: [lldb] [cmake] Add explicit linkage from Core to curses

mgorny created this revision. The Core library calls functions provided by the curses library. Add an appropriate explicit LINK_LIBS to ${CURSES_LIBRARIES} to propagate the dependency correctly within the build system. It seems that so far the linkage was handled by some kind of implicit magic

[Lldb-commits] [PATCH] D36886: [unittests] Build LLVMTestingSupport for out-of-source builds

mgorny created this revision. mgorny added a project: LLDB. The Process/gdb-remote test now requires the LLVMTestingSupport library that is not installed by LLVM. As a result, when doing an out-of-source build it fails being unable to find the library. To solve that, build a local copy of the

[Lldb-commits] [PATCH] D36885: [cmake] Explicitly link dependency libraries in the Host library

mgorny created this revision. mgorny added a project: LLDB. Add explicit linkage to the necessary system libraries in the Host library. Otherwise, the library fails to build with -Wl,--as-needed. The system libraries ended up being listed on the linker command-line before the static libraries

[Lldb-commits] [PATCH] D36358: [lldb] [cmake] Add explicit linkage from Core to curses

This revision was automatically updated to reflect the committed changes. Closed by commit rL311122: [cmake] Add explicit linkage from Core to curses (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D36358?vs=109897=111561#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D36885: [cmake] Explicitly link dependency libraries in the Host library

mgorny added inline comments. Comment at: source/Host/CMakeLists.txt:166-168 + if (LIBXML2_FOUND) +list(APPEND EXTRA_LIBS ${LIBXML2_LIBRARIES}) + endif() zturner wrote: > Even if libxml is found, that doesn't mean the build is configured to use it, > does

[Lldb-commits] [PATCH] D36885: [cmake] Explicitly link dependency libraries in the Host library

This revision was automatically updated to reflect the committed changes. Closed by commit rL311354: [cmake] Explicitly link dependency libraries in the Host library (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D36885?vs=111708=112016#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D36886: [unittests] Build LLVMTestingSupport for out-of-source builds

This revision was automatically updated to reflect the committed changes. Closed by commit rL311355: [unittests] Build LLVMTestingSupport for out-of-source builds (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D36886?vs=111710=112017#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D47812: [lldb] [lit] Do not run Python tests w/ LLDB_DISABLE_PYTHON

This revision was automatically updated to reflect the committed changes. Closed by commit rL334080: [lit] Do not run Python tests w/ LLDB_DISABLE_PYTHON (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D47812: [lldb] [lit] Do not run Python tests w/ LLDB_DISABLE_PYTHON

mgorny created this revision. mgorny added reviewers: JDevlieghere, labath. Skip all Python-based tests as unsupported when LLDB_DISABLE_PYTHON is enabled. Otherwise, those tests simply fail being unable to import lldb module. https://reviews.llvm.org/D47812 Files: lit/CMakeLists.txt

[Lldb-commits] [PATCH] D41725: [lldb] [test] Fix missing HAVE_LIBZ for tests in stand-alone builds

mgorny added a comment. Well, it's actually more complex. In Gentoo we want to let the user choose whether he wants to build against zlib or without zlib support. So in the end there are two uses to be considered: 1. When the value is merely passed down from LLVM to indicate state of

[Lldb-commits] [PATCH] D41725: [lldb] [test] Fix missing HAVE_LIBZ for tests in stand-alone builds

mgorny added a comment. Maybe we could. I presumed people are using the separate variables for some reason. We'd have to check that it's properly sanitized when building in-tree and given to cmake though. https://reviews.llvm.org/D41725 ___

[Lldb-commits] [PATCH] D41726: [test] Use full PATH lookup for tools

This revision was automatically updated to reflect the committed changes. Closed by commit rL321932: [test] Use full PATH lookup for tools (authored by mgorny, committed by ). Changed prior to commit: https://reviews.llvm.org/D41726?vs=128609=128843#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D41725: [lldb] [test] Fix missing HAVE_LIBZ for tests in stand-alone builds

mgorny added a comment. I was talking of: source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp tools/debugserver/source/RNBRemote.cpp https://reviews.llvm.org/D41725

[Lldb-commits] [PATCH] D41725: [lldb] [test] Fix tests to use more portable LLVM_ENABLE_ZLIB

mgorny added a comment. In https://reviews.llvm.org/D41725#970926, @labath wrote: > In https://reviews.llvm.org/D41725#969388, @mgorny wrote: > > > I was talking of: > > > > source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp > >

[Lldb-commits] [PATCH] D41725: [lldb] [test] Fix tests to use more portable LLVM_ENABLE_ZLIB

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL322081: [test] Fix tests to use more portable LLVM_ENABLE_ZLIB (authored by mgorny, committed by ). Herald added a

[Lldb-commits] [PATCH] D42317: [Host] Respect LLVM_LIBDIR_SUFFIX when looking for LLDB plugins on Linux

mgorny added a comment. Disclaimer: I have never seen a plugin for LLDB. I've just noticed the wrong path in `strace` output and fixed it ;-). https://reviews.llvm.org/D42317 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D42317: [Host] Respect LLVM_LIBDIR_SUFFIX when looking for LLDB plugins on Linux

mgorny created this revision. mgorny added reviewers: k8stone, zturner, beanz. Fix the Linux plugin lookup path to include appropriate libdir suffix for the system. To accomplish this, store the value of LLVM_LIBDIR_SUFFIX in lldb/Host/Config.h as LLDB_LIBDIR_SUFFIX, and use this variable when

[Lldb-commits] [PATCH] D42317: [Host] Respect LLVM_LIBDIR_SUFFIX when looking for LLDB plugins on Linux

This revision was automatically updated to reflect the committed changes. Closed by commit rL323673: [Host] Respect LLVM_LIBDIR_SUFFIX when looking for LLDB plugins on Linux (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D42317: [Host] Respect LLVM_LIBDIR_SUFFIX when looking for LLDB plugins on Linux

mgorny added inline comments. Comment at: source/Host/linux/HostInfoLinux.cpp:208 bool HostInfoLinux::ComputeSystemPluginsDirectory(FileSpec _spec) { - FileSpec temp_file("/usr/lib/lldb/plugins", true); + FileSpec temp_file("/usr/lib" LLDB_LIBDIR_SUFFIX "/lldb/plugins",

[Lldb-commits] [PATCH] D41725: [lldb] [test] Fix missing HAVE_LIBZ for tests in stand-alone builds

mgorny created this revision. mgorny added reviewers: labath, zturner, beanz. The HAVE_LIBZ variable is not exported by LLVM, and therefore is not available for reuse in stand-alone builds of other tools. Redefine it based on the value of LLVM_ENABLE_ZLIB. The same change has been already

[Lldb-commits] [PATCH] D44379: [cmake] Fix standalone+LLVM_LINK_LLVM_DYLIB builds (pr36687)

mgorny added a comment. I can't test this right now but please make sure not to break linking to split shared libraries without dylib. https://reviews.llvm.org/D44379 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D44379: [cmake] Fix standalone+LLVM_LINK_LLVM_DYLIB builds (pr36687)

mgorny added a comment. Yes, full standalone. https://reviews.llvm.org/D44379 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D44379: [cmake] Fix standalone+LLVM_LINK_LLVM_DYLIB builds (pr36687)

mgorny added inline comments. Comment at: cmake/modules/LLDBConfig.cmake:354 + + check_library_exists(dl dlopen "" HAVE_LIBDL) + if (HAVE_LIBDL) krytarowski wrote: > A more portable form of this: > > ``` > foreach(lib ${CMAKE_DL_LIBS}) > list(APPEND

[Lldb-commits] [PATCH] D53402: [SymbolFileNativePDB] Fix missing linkage to DebugInfoCodeView

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL344746: [SymbolFileNativePDB] Fix missing linkage to DebugInfoCodeView (authored by mgorny, committed by ). Herald added

[Lldb-commits] [PATCH] D53402: [SymbolFileNativePDB] Fix missing linkage to DebugInfoCodeView

mgorny created this revision. mgorny added a reviewer: zturner. Herald added a subscriber: JDevlieghere. Repository: rLLDB LLDB https://reviews.llvm.org/D53402 Files: source/Plugins/SymbolFile/NativePDB/CMakeLists.txt Index: source/Plugins/SymbolFile/NativePDB/CMakeLists.txt

[Lldb-commits] [PATCH] D55837: [cmake] Make libcxx(abi) a dependency when building in-tree clang

mgorny added a comment. How does this affect platforms that use other ABI library than libcxxabi? How does this affect platforms that use libstdc++ as default C++ backend? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55837/new/

[Lldb-commits] [PATCH] D56531: [CMake] Replace use of llvm-config with LLVM and Clang CMake packages

mgorny added a comment. Please don't risk merging this before the branching. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56531/new/ https://reviews.llvm.org/D56531 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D56531: [CMake] Replace use of llvm-config with LLVM and Clang CMake packages

mgorny added inline comments. Comment at: cmake/modules/LLDBStandalone.cmake:9 + find_package(LLVM REQUIRED CONFIG +HINTS "${LLDB_PATH_TO_LLVM_BUILD}" NO_DEFAULT_PATH NO_CMAKE_FIND_ROOT_PATH) + find_package(Clang REQUIRED CONFIG labath wrote: > xiaobai

[Lldb-commits] [PATCH] D57193: [lldb] [Process/NetBSD] Add missing linkage to -lutil

mgorny created this revision. mgorny added a reviewer: krytarowski. Herald added a subscriber: abidh. Add missing linkage to fix build failure with LLD: ld: error: undefined symbol: kinfo_getvmmap >>> referenced by NativeProcessNetBSD.cpp >>>

[Lldb-commits] [PATCH] D57193: [lldb] [Process/NetBSD] Add missing linkage to -lutil

This revision was automatically updated to reflect the committed changes. Closed by commit rL352116: [Process/NetBSD] Add missing linkage to -lutil (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D57282: [cmake] Fix get_llvm_lit_path() to respect LLVM_EXTERNAL_LIT always

mgorny created this revision. mgorny added reviewers: EricWF, sgraenitz, zturner. Herald added a subscriber: christof. Refactor the get_llvm_lit_path() logic to respect LLVM_EXTERNAL_LIT, and require the fallback to be defined explicitly as LLVM_DEFAULT_EXTERNAL_LIT. This fixes building libcxx

[Lldb-commits] [PATCH] D57282: [cmake] Fix get_llvm_lit_path() to respect LLVM_EXTERNAL_LIT always

This revision was automatically updated to reflect the committed changes. Closed by commit rL352374: [cmake] Fix get_llvm_lit_path() to respect LLVM_EXTERNAL_LIT always (authored by mgorny, committed by ). Changed prior to commit: https://reviews.llvm.org/D57282?vs=183693=183855#toc

[Lldb-commits] [PATCH] D59606: [lldb] [WIP/RFC] Add missing retries on EINTR

mgorny updated this revision to Diff 191641. mgorny added a comment. Covered more callsites. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59606/new/ https://reviews.llvm.org/D59606 Files: lldb/source/Host/common/PseudoTerminal.cpp lldb/source/Host/common/Socket.cpp

[Lldb-commits] [PATCH] D59606: [lldb] Add missing EINTR handling

mgorny updated this revision to Diff 191644. mgorny marked 5 inline comments as done. mgorny retitled this revision from "[lldb] [WIP/RFC] Add missing retries on EINTR" to "[lldb] Add missing EINTR handling". mgorny edited the summary of this revision. mgorny added a comment. Thanks for the

[Lldb-commits] [PATCH] D59606: [lldb] Add missing EINTR handling

mgorny added inline comments. Comment at: lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp:255-258 +llvm::sys::RetryAfterSignal(-1, ::cfsetospeed, +, B115200); +llvm::sys::RetryAfterSignal(-1, ::cfsetispeed, +, B115200);

[Lldb-commits] [PATCH] D59606: [lldb] Add missing EINTR handling

mgorny updated this revision to Diff 191657. mgorny marked an inline comment as done. mgorny added a comment. Applied requested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59606/new/ https://reviews.llvm.org/D59606 Files: lldb/source/Host/common/PseudoTerminal.cpp

[Lldb-commits] [PATCH] D59606: [lldb] Add missing EINTR handling

mgorny marked 3 inline comments as done. mgorny added inline comments. Comment at: lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp:255-258 +llvm::sys::RetryAfterSignal(-1, ::cfsetospeed, +, B115200); +llvm::sys::RetryAfterSignal(-1,

[Lldb-commits] [PATCH] D59606: [lldb] Add missing EINTR handling

mgorny added a comment. Now, the curious thing is that so far I have 2 more test failures with this. I'll investigate closer, maybe it's just flakiness. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59606/new/ https://reviews.llvm.org/D59606

[Lldb-commits] [PATCH] D60325: [lldb] [Process/NetBSD] Fix wrongly mapping mm* registers

mgorny created this revision. mgorny added reviewers: krytarowski, labath. Fix mistake that mapped mm* registers into the space for xmm* registers, rather than the one shared with st* registers. In other words, 'register read mmN' now correctly shows the mmN register rather than part of xmmN.

[Lldb-commits] [PATCH] D60034: [lldb] [Process/elf-core] Support aarch64 NetBSD core dumps

mgorny created this revision. mgorny added reviewers: krytarowski, labath. Herald added subscribers: abidh, kristof.beyls, javed.absar. Herald added a project: LLDB. Include support for NetBSD core dumps from evbarm/aarch64 system, and matching test cases for them. Based on earlier work by Kamil

[Lldb-commits] [PATCH] D59972: [Python] Remove readline module

mgorny added a comment. WFM. We've been stripping it in Gentoo since the inception. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59972/new/ https://reviews.llvm.org/D59972 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D60034: [lldb] [Process/elf-core] Support aarch64 NetBSD core dumps

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB357399: [lldb] [Process/elf-core] Support aarch64 NetBSD core dumps (authored by mgorny, committed by ). Changed prior to commit: https://reviews.llvm.org/D60034?vs=193020=193092#toc Repository:

[Lldb-commits] [PATCH] D60034: [lldb] [Process/elf-core] Support aarch64 NetBSD core dumps

mgorny updated this revision to Diff 193020. mgorny added a comment. Reordered as requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60034/new/ https://reviews.llvm.org/D60034 Files:

[Lldb-commits] [PATCH] D59854: [Host] Add LibraryLoader abstraction around dlopen/LoadLibrary

mgorny added a comment. Is there a reason you can't reuse/extend `DynamicLibrary` from `LLVMSupport`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59854/new/ https://reviews.llvm.org/D59854 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D58630: [lldb] [test] Pass appropriate -L for just-built libc++

mgorny created this revision. mgorny added reviewers: krytarowski, labath, zturner. mgorny added a project: LLDB. Herald added a reviewer: EricWF. Herald added a subscriber: teemperor. Herald added a reviewer: serge-sans-paille. Pass appropriate -L flags pointing out to the LLVM library directory

[Lldb-commits] [PATCH] D58680: [lldb] [unittests] Silence -Wformat-zero-length warnings in UtilityTests

mgorny created this revision. mgorny added reviewers: labath, zturner, teemperor. mgorny added a project: LLDB. Herald added subscribers: jdoerfert, abidh. Silence zero-length format warnings in UtilityTests reported by GCC. Zero-length format strings are permitted by the standards, and are used

[Lldb-commits] [PATCH] D58630: [lldb] [test] Pass appropriate -L for just-built libc++

mgorny added a comment. In D58630#1410419 , @labath wrote: > Unfortunately I don't know of a substantially better way to solve. I have one > small improvement inline. Also, I take it this means running tests without a > libc++ checkout is not supported

[Lldb-commits] [PATCH] D58630: [lldb] [test] Pass appropriate -L&-Wl, -rpath for just-built libc++

mgorny updated this revision to Diff 188946. mgorny retitled this revision from "[lldb] [test] Pass appropriate -L for just-built libc++" to "[lldb] [test] Pass appropriate -L&-Wl,-rpath for just-built libc++". mgorny edited the summary of this revision. mgorny added a comment. Turns out

[Lldb-commits] [PATCH] D58871: [lldb] [lldbtest] Fix getBuildFlags() not to use libstdc++ on NetBSD

mgorny created this revision. mgorny added reviewers: krytarowski, labath. Herald added a subscriber: abidh. Herald added a reviewer: serge-sans-paille. Herald added a project: LLDB. Remove the code forcing -stdlib=libstdc++ on NetBSD in getBuildFlags() method. NetBSD uses libc++ everywhere

[Lldb-commits] [PATCH] D58871: [lldb] [lldbtest] Fix getBuildFlags() not to use libstdc++ on NetBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB355273: [lldb] [lldbtest] Fix getBuildFlags() not to use libstdc++ on NetBSD (authored by mgorny, committed by ). Changed prior to commit: https://reviews.llvm.org/D58871?vs=189040=189051#toc

[Lldb-commits] [PATCH] D42870: [lldb] [ObjectFile/ELF] Correct recognition of NetBSD images

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB354466: [lldb] [ObjectFile/ELF] Fix recognizing NetBSD images (authored by mgorny, committed by ). Herald added a

[Lldb-commits] [PATCH] D58517: [lldb] [test] Do not link -ldl on NetBSD

mgorny created this revision. mgorny added reviewers: krytarowski, labath, jasonmolenda, jingham. mgorny added a project: LLDB. Herald added a subscriber: abidh. Fix the load_* using test Makefiles not to link -ldl on NetBSD. There is no such a library on NetBSD, and dlopen() is available without

[Lldb-commits] [PATCH] D42870: [lldb] [ObjectFile/ELF] Correct recognition of NetBSD images

mgorny updated this revision to Diff 187350. mgorny added a comment. Reduced the test .yaml to the absolute minimum. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D42870/new/ https://reviews.llvm.org/D42870 Files: lldb/lit/Modules/ELF/Inputs/netbsd-amd64.core

[Lldb-commits] [PATCH] D42870: [lldb] [ObjectFile/ELF] Correct recognition of NetBSD images

mgorny updated this revision to Diff 187358. mgorny added a comment. Switched to use shorter identifiers. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D42870/new/ https://reviews.llvm.org/D42870 Files: lldb/lit/Modules/ELF/Inputs/netbsd-amd64.core

[Lldb-commits] [PATCH] D58517: [lldb] [test] Do not link -ldl on NetBSD

mgorny updated this revision to Diff 187826. mgorny edited the summary of this revision. mgorny added a comment. Switched to appending `-ldl` via Makefile.rules, using USE_LIBDL option. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58517/new/ https://reviews.llvm.org/D58517 Files:

[Lldb-commits] [PATCH] D58517: [lldb] [test] Do not link -ldl on NetBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rL354617: [lldb] [test] Do not link -ldl on NetBSD (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D58630: [lldb] [test] Pass appropriate -L&-Wl, -rpath for libc++ on NetBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rL355502: [lldb] [test] Pass appropriate -L-Wl,-rpath for libc++ on NetBSD (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [PATCH] D32149: Correct handling NetBSD core(5) files with threads

mgorny updated this revision to Diff 189503. mgorny added a comment. I've attempted to rebase Kamil's patch against the current sources. Please note that this is not the final version; I'll add a test case and PID reading later. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32149/new/

[Lldb-commits] [PATCH] D32149: [lldb] [Process] Add proper support for NetBSD core files with threads

mgorny updated this revision to Diff 189536. mgorny retitled this revision from "Correct handling NetBSD core(5) files with threads" to "[lldb] [Process] Add proper support for NetBSD core files with threads". mgorny edited the summary of this revision. mgorny added a comment. Updated to read

[Lldb-commits] [PATCH] D32149: [lldb] [Process] Add proper support for NetBSD core files with threads

mgorny updated this revision to Diff 189545. mgorny added a comment. Herald added a reviewer: serge-sans-paille. Herald added a subscriber: jdoerfert. Added two tests, more pending. Sadly, I wasn't able to reuse even the test cases since `-nostdlib` doesn't really work on NetBSD (resulting

[Lldb-commits] [PATCH] D58610: [lldb] [lit] Set LD_LIBRARY_PATH or alike for Suite tests

mgorny created this revision. mgorny added a reviewer: labath. mgorny added a project: LLDB. Herald added subscribers: abidh, fedor.sergeev. Set LD_LIBRARY_PATH or local platform's equivalent of it when running the 'Suite' tests. This is necessary when running tests inside build tree with

[Lldb-commits] [PATCH] D58630: [lldb] [test] Pass appropriate -L&-Wl, -rpath for libc++ on NetBSD

mgorny updated this revision to Diff 189364. mgorny retitled this revision from "[lldb] [test] Pass appropriate -L&-Wl,-rpath for just-built libc++" to "[lldb] [test] Pass appropriate -L&-Wl,-rpath for libc++ on NetBSD". mgorny edited the summary of this revision. mgorny added a comment.

[Lldb-commits] [PATCH] D58883: [lldb] [Process/gdb-remote] Use '127.0.0.1' in ConnectLocally()

mgorny created this revision. mgorny added reviewers: krytarowski, labath, JDevlieghere. Herald added a subscriber: abidh. Herald added a project: LLDB. Use '127.0.0.1' instead of 'localhost' in ConnectLocally() function as this is the specific address the server is bound to. Using 'localhost'

[Lldb-commits] [PATCH] D58883: [lldb] [Process/gdb-remote] Use '127.0.0.1' in ConnectLocally()

This revision was automatically updated to reflect the committed changes. Closed by commit rL355285: [lldb] [Process/gdb-remote] Use 127.0.0.1 in ConnectLocally() (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D58527: [lldb] [test] Mark failing tests XFAIL on NetBSD

mgorny added a comment. Thanks. I'm going to retest/update it for master first. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58527/new/ https://reviews.llvm.org/D58527 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D58680: [lldb] [unittests] Use non-empty format string for Timer()

mgorny updated this revision to Diff 188430. mgorny retitled this revision from "[lldb] [unittests] Silence -Wformat-zero-length warnings in UtilityTests" to "[lldb] [unittests] Use non-empty format string for Timer()". mgorny edited the summary of this revision. mgorny added a comment. Changed

[Lldb-commits] [PATCH] D58610: [lldb] [lit] Set LD_LIBRARY_PATH or alike for Suite tests

mgorny added a comment. Thank you for the review. When I find some more time, I'll try to convert this into utility function somewhere in lit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58610/new/ https://reviews.llvm.org/D58610 ___

[Lldb-commits] [PATCH] D58610: [lldb] [lit] Set LD_LIBRARY_PATH or alike for Suite tests

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB354920: [lldb] [lit] Set LD_LIBRARY_PATH or alike for Suite tests (authored by mgorny, committed by ). Changed prior to commit: https://reviews.llvm.org/D58610?vs=188399=188431#toc Repository:

[Lldb-commits] [PATCH] D58610: [lldb] [lit] Set LD_LIBRARY_PATH or alike for Suite tests

mgorny updated this revision to Diff 188399. mgorny edited the summary of this revision. mgorny added a comment. While working on other patches, I've noticed top-level lit.site.cfg* has SHLIBDIR which serves the same purpose as in clang. I've updated this patch to include it for Suite tests,

[Lldb-commits] [PATCH] D58680: [lldb] [unittests] Use non-empty format string for Timer()

mgorny added a comment. Heh, and I thought we're (NetBSD) the only ones getting it ;-). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58680/new/ https://reviews.llvm.org/D58680 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D58680: [lldb] [unittests] Use non-empty format string for Timer()

This revision was automatically updated to reflect the committed changes. Closed by commit rL354922: [lldb] [unittests] Use non-empty format string for Timer() (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D59427: [WIP] [lldb] [API] Split SBRegistry into smaller files

mgorny updated this revision to Diff 190984. mgorny retitled this revision from "[lldb] [API] Split SBRegistry into smaller files" to "[WIP] [lldb] [API] Split SBRegistry into smaller files". mgorny edited the summary of this revision. mgorny added a comment. Ok, here's my first attempt at

[Lldb-commits] [PATCH] D57475: [Reproducers] Add SBReproducer macros

mgorny added a comment. This is still breaking NetBSD buildbot: http://lab.llvm.org:8011/builders/netbsd-amd64/builds/19339/steps/ninja%20build%20local/logs/stdio FAILED: tools/lldb/source/API/CMakeFiles/liblldb.dir/SBHostOS.cpp.o /usr/bin/g++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND

[Lldb-commits] [PATCH] D32149: [lldb] [Process] Add proper support for NetBSD core files with threads

mgorny updated this revision to Diff 189658. mgorny edited the summary of this revision. mgorny added a comment. I've added one more test case, and added stop reason/signal checking for both threads. I think it's ready for review now. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D32149: [lldb] [Process] Add proper support for NetBSD core files with threads

This revision was automatically updated to reflect the committed changes. Closed by commit rL355736: [lldb] [Process] Add proper support for NetBSD core files with threads (authored by mgorny, committed by ). Changed prior to commit: https://reviews.llvm.org/D32149?vs=189658=189911#toc

[Lldb-commits] [PATCH] D59177: [lldb] [test] Make 2lwp_process_SIGSEGV test more portable

mgorny created this revision. mgorny added reviewers: labath, krytarowski. Herald added a subscriber: abidh. Herald added a reviewer: serge-sans-paille. Herald added a project: LLDB. Fix 2lwp_process_SIGSEGV NetBSD core test to terminate inside regular function rather than libc call, in order to

[Lldb-commits] [PATCH] D59427: [WIP] [lldb] [API] Split SBRegistry into smaller files

mgorny updated this revision to Diff 191124. mgorny added a comment. Does this look right? I've added temporary `*2` versions of the macros to make it build without having to port everything. If it looks fine, I'll go with other files. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D59427: [WIP] [lldb] [API] Split SBRegistry into smaller files

mgorny updated this revision to Diff 191125. mgorny added a comment. Hmm, actually with that local `R` declaration I don't have to have an additional set of macros ;-). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59427/new/ https://reviews.llvm.org/D59427 Files:

[Lldb-commits] [PATCH] D59606: [lldb] [WIP/RFC] Add missing retries on EINTR

mgorny added a comment. Hmm, I also see that LLVM has signal-safe `Process::SafelyCloseFileDescriptor()`. Should I use that, or just ignore potential issues with `close()`? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59606/new/

[Lldb-commits] [PATCH] D59606: [lldb] [WIP/RFC] Add missing retries on EINTR

mgorny updated this revision to Diff 191553. mgorny added a comment. Got rid of `close()` and `fclose()` wrapping, for now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59606/new/ https://reviews.llvm.org/D59606 Files: lldb/source/Host/common/Socket.cpp

[Lldb-commits] [PATCH] D59606: [lldb] [WIP/RFC] Add missing retries on EINTR

mgorny created this revision. mgorny added reviewers: labath, JDevlieghere, zturner. Herald added subscribers: ki.stfu, emaste. Herald added a project: LLDB. This is WIP on adding EINTR handling all over the place, via `llvm::sys::RetryAfterSignal()`. If you don't like this approach, please

[Lldb-commits] [PATCH] D59606: [lldb] [WIP/RFC] Add missing retries on EINTR

mgorny added a comment. In D59606#1436796 , @labath wrote: > The "problem" I have with this is that (IIRC) retrying close(2) on EINTR is > the *wrong* thing to do on linux (because the fd will be closed anyway, and > so we may end up closing someone

[Lldb-commits] [PATCH] D59427: [lldb] [Reproducer] Move SBRegistry registration into declaring files

mgorny added a comment. Hmm but the tests fail to build for me ;-). I'm going to update this shortly. Comment at: lldb/source/API/SBAddress.cpp:313 + LLDB_REGISTER_METHOD(lldb::SBSymbolContext, SBAddress, GetSymbolContext, + (uint3_t)); +

[Lldb-commits] [PATCH] D59427: [lldb] [Reproducer] Move SBRegistry registration into declaring files

mgorny added a comment. I'd also like to update the output of lldb-instr but I think that'd be better done in a separate patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59427/new/ https://reviews.llvm.org/D59427 ___ lldb-commits

[Lldb-commits] [PATCH] D59177: [lldb] [test] Make 2lwp_process_SIGSEGV test more portable

mgorny updated this revision to Diff 190004. mgorny added a comment. Updated as requested by @krytarowski CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59177/new/ https://reviews.llvm.org/D59177 Files:

[Lldb-commits] [PATCH] D59177: [lldb] [test] Make 2lwp_process_SIGSEGV test more portable

This revision was automatically updated to reflect the committed changes. Closed by commit rL355786: [lldb] [test] Make 2lwp_process_SIGSEGV test more portable (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

  1   2   3   4   5   6   7   8   9   10   >