[Lldb-commits] [PATCH] D154730: [lldb] Consider TAG_imported_declaration in DebugNamesIndex

Michael137 accepted this revision. Michael137 added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154730/new/ https://reviews.llvm.org/D154730 __

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When we build the Clang module compilation command (e.g., when a user requests i

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Michael137 added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/include/lldb/Target/Platform.h:492 + static llvm::Expected + GetSDKPathFromDebugInfo(Module &module); + I'm open to suggestions on where to put this API. `Platform` seem

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Michael137 updated this revision to Diff 543160. Michael137 added a comment. - Remove redundant headers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156020/new/ https://reviews.llvm.org/D156020 Files: lldb/include/lldb/Target/Platform.h lldb/

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Michael137 added inline comments. Comment at: lldb/include/lldb/Target/Platform.h:492 + static llvm::Expected + GetSDKPathFromDebugInfo(Module &module); + Michael137 wrote: > I'm open to suggestions on where to put this API. `Platform` seems a bit too > generi

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Michael137 added inline comments. Comment at: lldb/include/lldb/Target/Platform.h:479 +/// to an internal SDK +bool found_internal_sdk = false; + aprantl wrote: > These flags really only make sense in the context of an XcodeSDK, so why not > just return

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Michael137 updated this revision to Diff 543870. Michael137 added a comment. - Move into `PlatformDarwin` - Return `XcodeSDK` from `GetSDKPathFromDebugInfo` so it's easier to re-use from Swift plugin - Introduce `ResolveSDKPathFromDebugInfo` to be used from `PlatformDarwin` - Adjust tests Repos

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Michael137 updated this revision to Diff 543874. Michael137 added a comment. - Remove redundant header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156020/new/ https://reviews.llvm.org/D156020 Files: lldb/source/Plugins/Platform/MacOSX/Platform

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Michael137 updated this revision to Diff 543875. Michael137 added a comment. - Remove more headers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156020/new/ https://reviews.llvm.org/D156020 Files: lldb/source/Plugins/Platform/MacOSX/PlatformDarw

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Michael137 added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:1363 + XcodeSDK sdk; + for (unsigned i = 0; i < sym_file->GetNumCompileUnits(); ++i) +if (auto cu_sp = sym_file->GetCompileUnitAtIndex(i)) Only remaining qu

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Michael137 marked 2 inline comments as not done. Michael137 added inline comments. Comment at: lldb/include/lldb/Target/Platform.h:479 +/// to an internal SDK +bool found_internal_sdk = false; + Michael137 wrote: > aprantl wrote: > > These flags really on

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Michael137 updated this revision to Diff 543967. Michael137 marked an inline comment as not done. Michael137 added a comment. - Update unit-tests - Expand function docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156020/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Michael137 updated this revision to Diff 544350. Michael137 added a comment. - Parameterize tests - Return bool to indicate SDK mismatch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156020/new/ https://reviews.llvm.org/D156020 Files: lldb/sourc

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Michael137 updated this revision to Diff 544376. Michael137 added a comment. - Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156020/new/ https://reviews.llvm.org/D156020 Files: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp ll

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Michael137 updated this revision to Diff 544378. Michael137 added a comment. - EXPECT -> ASSERT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156020/new/ https://reviews.llvm.org/D156020 Files: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

This revision was automatically updated to reflect the committed changes. Closed by commit rGb0b2b6bab4d2: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D156447: [lldb] Split CTF parsing and type creation (NFC)

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/CTF/CTFTypes.h:108 + uint32_t size, std::vector values) + : CTFType(eEnum, uid, name), nelems(nelems), size(size) { +assert(values.size() == nelems); did you omit this

[Lldb-commits] [PATCH] D156447: [lldb] Split CTF parsing and type creation (NFC)

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/CTF/CTFTypes.h:108 + uint32_t size, std::vector values) + : CTFType(eEnum, uid, name), nelems(nelems), size(size) { +assert(values.size() == nelems); JDevlieghere wrote

[Lldb-commits] [PATCH] D156498: [lldb] Support recursive record types in CTF

Michael137 added a comment. Generally LGTM, just some clarifications questions Comment at: lldb/source/Plugins/SymbolFile/CTF/SymbolFileCTF.cpp:508 ctf_record.name.data(), tag_kind, eLanguageTypeC); + m_compiler_types[record_type.GetOpaqueQualTy

[Lldb-commits] [PATCH] D156606: [lldb] Improve memory usage by freeing CTF types (NFC)

Michael137 accepted this revision. Michael137 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156606/new/ https://reviews.llvm.org/D156606 ___ lldb-commits mailing list lldb

[Lldb-commits] [PATCH] D156774: [lldb] Parse enums while parsing a type

Michael137 added a comment. Thanks for addressing this. Can you add a test? Possibly in `lldb/test/API/lang/cpp/enum_types/`. Or `lldb/test/API/lang/cpp/const_static_integral_member/` Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3040 +case DW

[Lldb-commits] [PATCH] D156774: [lldb] Parse enums while parsing a type

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3040 +case DW_TAG_enumeration_type: +{ Michael137 wrote: > At first glance this seems OK but I'll want to check why the type doesn't get > resolv

[Lldb-commits] [PATCH] D156827: [lldb][test] Skip *-dbg-info-content API tests

Michael137 created this revision. Michael137 added reviewers: aprantl, iana, JDevlieghere. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. These tests started failing on the public build-bots recently

[Lldb-commits] [PATCH] D156827: [lldb][test] Skip *-dbg-info-content API tests

Michael137 updated this revision to Diff 546226. Michael137 added a comment. - Amend commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156827/new/ https://reviews.llvm.org/D156827 Files: lldb/test/API/commands/expression/import-std-m

[Lldb-commits] [PATCH] D156822: [lldb] Make IR interpretation interruptible

Michael137 accepted this revision. Michael137 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156822/new/ https://reviews.llvm.org/D156822 ___ lldb-commits mailing list lldb

[Lldb-commits] [PATCH] D156827: [lldb][test] Skip *-dbg-info-content API tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ce7831b4023: [lldb][test] Skip *-dbg-info-content API tests (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156827/new/ https://rev

[Lldb-commits] [PATCH] D156774: [lldb] Parse enums while parsing a type

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3040 +case DW_TAG_enumeration_type: +{ Michael137 wrote: > Michael137 wrote: > > At first glance this seems OK but I'll want to check why the type

[Lldb-commits] [PATCH] D156774: [lldb] Parse enums while parsing a type

Michael137 added a comment. Could you update the commit message with a description of the failure and summary of the fix? And change the title to something like `[lldb][DWARFASTParserClang] Resolve nested types when parsing structures` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D156774: [lldb] Parse enums while parsing a type

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3040 +case DW_TAG_enumeration_type: +{ Michael137 wrote: > Michael137 wrote: > > Michael137 wrote: > > > At first glance this seems OK but I'll wa

[Lldb-commits] [PATCH] D156774: [lldb][DWARFASTParserClang] Resolve nested types when parsing structures

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3040 +case DW_TAG_enumeration_type: +{ Endill wrote: > Michael137 wrote: > > Michael137 wrote: > > > Michael137 wrote: > > > > Michael137 wrote: >

[Lldb-commits] [PATCH] D157059: [lldb][PECOFF] Exclude alignment padding when reading section data

Michael137 added a comment. Hi, this is failing on swift-ci (runs on x86 bots) with the following error: /Users/ec2-user/jenkins/workspace/oss-lldb-incremental-macos-cmake/build/Ninja-ReleaseAssert+stdlib-Release/lldb-macosx-x86_64/unittests/ObjectFile/PECOFF/./ObjectFilePECOFFTests --gtest_f

[Lldb-commits] [PATCH] D156774: [lldb][DWARFASTParserClang] Resolve nested types when parsing structures

Michael137 added a comment. Are you still planning on moving this forward? Otherwise I could commandeer the revision to get this in. I do think it's a useful bug to address Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156774/new/ https://reviews.

[Lldb-commits] [PATCH] D156774: [lldb][DWARFASTParserClang] Resolve nested types when parsing structures

Michael137 added a comment. In D156774#4572967 , @Endill wrote: > In D156774#4572947 , @Michael137 > wrote: > >> Are you still planning on moving this forward? Otherwise I could commandeer >> the revision to get

[Lldb-commits] [PATCH] D157512: [lldb][PlatformDarwin] Only parse SDK from debug-info if target language is Objective-C

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a subscriber: kadircet. Herald added a project: All. Michael137 requested review of this revision. Herald added subscribers: lldb-commits, ilya-biryukov. Herald added a project: LLDB. The call to `HostInfoMacOSX::

[Lldb-commits] [PATCH] D157636: [lldb][test] Remove tests relying on deprecated std::char_traits specializations

Michael137 created this revision. Michael137 added reviewers: gribozavr2, JDevlieghere. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. (motivated by test failures after D157058

[Lldb-commits] [PATCH] D157636: [lldb][test] Remove tests relying on deprecated std::char_traits specializations

This revision was automatically updated to reflect the committed changes. Closed by commit rG487ab39a5082: [lldb][test] Remove tests relying on deprecated std::char_traits specializations (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D157992: [lldb][CPlusPlus][NFCI] Remove redundant construction of ClangASTImporter

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The usag

[Lldb-commits] [PATCH] D157992: [lldb][CPlusPlus][NFCI] Remove redundant construction of ClangASTImporter

This revision was automatically updated to reflect the committed changes. Closed by commit rG92d7254a989d: [lldb][CPlusPlus][NFCI] Remove redundant construction of ClangASTImporter (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D158172: [lldb][ClangASTImporter][NFC] Remove redundant calls to ASTImporter::Imported

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a su

[Lldb-commits] [PATCH] D158172: [lldb][ClangASTImporter][NFC] Remove redundant calls to ASTImporter::Imported

Michael137 updated this revision to Diff 551086. Michael137 added a comment. - Reword commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158172/new/ https://reviews.llvm.org/D158172 Files: lldb/source/Plugins/ExpressionParser/Clang/Cla

[Lldb-commits] [PATCH] D158172: [lldb][ClangASTImporter][NFC] Remove redundant calls to ASTImporter::Imported

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c3f1f42cbed: [lldb][ClangASTImporter][NFC] Remove redundant calls to ASTImporter::Imported (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D156774: [lldb][DWARFASTParserClang] Resolve nested types when parsing structures

Michael137 added a comment. In D156774#4601705 , @Endill wrote: > I tested this patch together with the following new code: > > uint32_t TypeSystemClang::GetNumMemberEnums(lldb::opaque_compiler_type_t > type) { > using EnumIt = > clang::DeclContex

[Lldb-commits] [PATCH] D156774: [lldb][DWARFASTParserClang] Resolve nested types when parsing structures

Michael137 added a comment. In D156774#4601767 , @Endill wrote: > In D156774#4601736 , @Michael137 > wrote: > >> What were your lldb commands when you tested this? > > `script import lldb; frame = lldb.thread.Get

[Lldb-commits] [PATCH] D156774: [lldb][DWARFASTParserClang] Resolve nested types when parsing structures

Michael137 added a comment. In D156774#4644503 , @Endill wrote: > Ping @Michael137 Sorry for the delay, just came back from vacation The change itself LGTM. Can we add a test though? We do have DWARFASTParserClang unittests: https://github.com/llvm/ll

[Lldb-commits] [PATCH] D156774: [lldb][DWARFASTParserClang] Resolve nested types when parsing structures

Michael137 added a comment. Also, I assume the extra changes to make the PointerIntPair formatter work will be in a follow-up patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156774/new/ https://reviews.llvm.org/D156774 __

[Lldb-commits] [PATCH] D129078: WIP: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Michael137 created this revision. Michael137 added reviewers: aprantl, jingham. Herald added a project: All. Michael137 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a project: LLDB. This patch adds support for

[Lldb-commits] [PATCH] D129078: WIP: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Michael137 added a comment. The is a draft for now, but feel free to comment on the approach. I'm still evaluating some other alternatives to this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129078/new/ https://reviews.llvm.org/D129078 ___

[Lldb-commits] [PATCH] D129078: WIP: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Michael137 updated this revision to Diff 442102. Michael137 added a comment. - [LLDB][Expression] Allow instantiation of IR Entity from ValueObject - WIP: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D129078: WIP: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Michael137 updated this revision to Diff 442104. Michael137 added a comment. Correct email config Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129078/new/ https://reviews.llvm.org/D129078 Files: lldb/include/lldb/Expression/UserExpression.h l

[Lldb-commits] [PATCH] D129078: WIP: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Michael137 planned changes to this revision. Michael137 added a comment. Remove from review queue for now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129078/new/ https://reviews.llvm.org/D129078 ___ ll

[Lldb-commits] [PATCH] D81471: [lldb] Add support for using integral const static data members in the expression evaluator

Michael137 added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ASTResultSynthesizer.cpp:249 // // For Lvalues // Minor: Should we update this documentation? Comment at: lldb/source/Plugins/SymbolFile/DWARF/DW

[Lldb-commits] [PATCH] D129078: WIP: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Michael137 updated this revision to Diff 442525. Michael137 added a comment. - [LLDB][NFC] Create variable for hardcoded alignment/size constants in materializer - [LLDB][Expression] Allow instantiation of IR Entity from ValueObject - Removed redundant m_object_pointer_type Repository: rG LLV

[Lldb-commits] [PATCH] D129078: WIP: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Michael137 updated this revision to Diff 442561. Michael137 added a comment. - Add `AddOneVariable` overload that takes `ValueObjectSP` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129078/new/ https://reviews.llvm.org/D129078 Files: lldb/includ

[Lldb-commits] [PATCH] D129078: WIP: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Michael137 updated this revision to Diff 442563. Michael137 added a comment. - Fixed doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129078/new/ https://reviews.llvm.org/D129078 Files: lldb/include/lldb/Expression/Materializer.h lldb/include

[Lldb-commits] [PATCH] D129078: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Michael137 added inline comments. Comment at: lldb/source/Expression/Materializer.cpp:777 + lldb::ValueObjectSP + GetValueObject(ExecutionContextScope *scope) const override { +return ValueObjectVariable::Create(scope, m_variable_sp); jingham wrote: > Naive

[Lldb-commits] [PATCH] D129078: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Michael137 updated this revision to Diff 442954. Michael137 added a comment. Herald added a subscriber: mgorny. - Add more documentation - Moved `GetLambdaValueObject` into common utility header - Added defensive check to `EntityVariable::GetValueObject` Repository: rG LLVM Github Monorepo CH

[Lldb-commits] [PATCH] D129364: [LLDB][DataFormatter] Add data formatter for libcxx std::unordered_map iterator

Michael137 created this revision. Michael137 added reviewers: aprantl, jingham. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a formatter for libcxx's `std::unordered_map` iterators.

[Lldb-commits] [PATCH] D129364: [LLDB][DataFormatter] Add data formatter for libcxx std::unordered_map iterator

Michael137 updated this revision to Diff 443212. Michael137 added a comment. - Fixed class documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129364/new/ https://reviews.llvm.org/D129364 Files: lldb/source/Plugins/Language/CPlusPlus/CPl

[Lldb-commits] [PATCH] D129367: [LLDB][ClangExpression] Remove unused StructVars::m_object_pointer_type

Michael137 created this revision. Michael137 added reviewers: jingham, aprantl. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This member variable was removed a while ago in 443427357f539f5ac97e664a

[Lldb-commits] [PATCH] D129367: [LLDB][ClangExpression] Remove unused StructVars::m_object_pointer_type

Michael137 added a comment. One potential functional change here would be the removal of `GetFullCompilerType` in the `$__lldb_objc_class` code path. Could probably just put it back since it's not immediately obvious how I'd test it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [PATCH] D129364: [LLDB][DataFormatter] Add data formatter for libcxx std::unordered_map iterator

Michael137 updated this revision to Diff 443227. Michael137 added a comment. - Cleaned up documentation further Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129364/new/ https://reviews.llvm.org/D129364 Files: lldb/source/Plugins/Language/CPlusP

[Lldb-commits] [PATCH] D129364: [LLDB][DataFormatter] Add data formatter for libcxx std::unordered_map iterator

Michael137 updated this revision to Diff 443430. Michael137 added a comment. - Fixed test case for const bucket iterator Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129364/new/ https://reviews.llvm.org/D129364 Files: lldb/source/Plugins/Langua

[Lldb-commits] [PATCH] D129078: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Michael137 updated this revision to Diff 443574. Michael137 added a comment. - Move helper into new namespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129078/new/ https://reviews.llvm.org/D129078 Files: lldb/include/lldb/Expression/Material

[Lldb-commits] [PATCH] D81471: [lldb] Add support for using integral const static data members in the expression evaluator

Michael137 added a comment. with latest changes LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81471/new/ https://reviews.llvm.org/D81471 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [PATCH] D129078: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Michael137 updated this revision to Diff 443707. Michael137 marked 9 inline comments as done. Michael137 added a comment. - Address stylistic/documentation comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129078/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D129078: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Michael137 added inline comments. Comment at: lldb/source/Expression/Materializer.cpp:432 +m_size = g_default_var_byte_size; +m_alignment = g_default_var_alignment; } aprantl wrote: > FWIW, the refactoring of EntityVariable could have been a separate

[Lldb-commits] [PATCH] D129078: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Michael137 updated this revision to Diff 443861. Michael137 added a comment. - `LocationExpressionIsValid` returns false for invalid ValueObjects - Add asserts to `EntityValueObject` overrides - Add docs for `AddValueObject` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [PATCH] D129078: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Michael137 marked an inline comment as done. Michael137 added inline comments. Comment at: lldb/source/Expression/Materializer.cpp:819 + + bool LocationExpressionIsValid() const override { return true; } + Michael137 wrote: > jingham wrote: > > Is this right? F

[Lldb-commits] [PATCH] D129364: [LLDB][DataFormatter] Add data formatter for libcxx std::unordered_map iterator

Michael137 updated this revision to Diff 443867. Michael137 marked 3 inline comments as done. Michael137 added a comment. - Address stylistic comments - Change test name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129364/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D129364: [LLDB][DataFormatter] Add data formatter for libcxx std::unordered_map iterator

Michael137 marked an inline comment as done. Michael137 added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:411 + ".__i_.__node_", nullptr, nullptr, + ValueObject::GetValueForExpressionPathOptions() +

[Lldb-commits] [PATCH] D129364: [LLDB][DataFormatter] Add data formatter for libcxx std::unordered_map iterator

This revision was automatically updated to reflect the committed changes. Closed by commit rGd1e9d0b27f3a: [LLDB][DataFormatter] Add data formatter for libcxx std::unordered_map iterator (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D129367: [LLDB][ClangExpression] Remove unused StructVars::m_object_pointer_type

Michael137 updated this revision to Diff 443880. Michael137 added a comment. - Default constructor for `StructVars` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129367/new/ https://reviews.llvm.org/D129367 Files: lldb/source/Plugins/ExpressionP

[Lldb-commits] [PATCH] D129367: [LLDB][ClangExpression] Remove unused StructVars::m_object_pointer_type

Michael137 marked an inline comment as done. Michael137 added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.h:356 struct StructVars { -StructVars() : m_result_name(), m_object_pointer_type(nullptr, nullptr) {} +StructVa

[Lldb-commits] [PATCH] D129367: [LLDB][ClangExpression] Remove unused StructVars::m_object_pointer_type

This revision was automatically updated to reflect the committed changes. Closed by commit rG4d26faa5262e: [LLDB][ClangExpression] Remove unused StructVars::m_object_pointer_type (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D129078: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Michael137 updated this revision to Diff 59. Michael137 marked an inline comment as done. Michael137 added a comment. - Address stylistic comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129078/new/ https://reviews.llvm.org/D129078 Files

[Lldb-commits] [PATCH] D129078: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Michael137 added a comment. After playing around with this some more I found an edge case with conditional breakpoints (in fact any place where we reuse an LLVMUserExpression). Modifying `lldb/test/API/functionalities/breakpoint/two_hits_one_actual` such that the helper method is inside a lambd

[Lldb-commits] [PATCH] D129078: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Michael137 updated this revision to Diff 445039. Michael137 added a comment. - Add test for conditional breakpoints on lambda captures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129078/new/ https://reviews.llvm.org/D129078 Files: lldb/include

[Lldb-commits] [PATCH] D129078: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Michael137 updated this revision to Diff 445202. Michael137 added a comment. - Add ValueObjectProvider so materializer doesn't use incorrect ValueObject when re-using UserExpressions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129078/new/ https:

[Lldb-commits] [PATCH] D129078: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Michael137 updated this revision to Diff 445259. Michael137 added a comment. - Remove now redundant m_lldb_value_object Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129078/new/ https://reviews.llvm.org/D129078 Files: lldb/include/lldb/Expressio

[Lldb-commits] [PATCH] D129078: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Michael137 updated this revision to Diff 445269. Michael137 added a comment. - Fix assertion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129078/new/ https://reviews.llvm.org/D129078 Files: lldb/include/lldb/Expression/Materializer.h lldb/inc

[Lldb-commits] [PATCH] D129078: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Michael137 updated this revision to Diff 445307. Michael137 added a comment. - Remove redundant moves Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129078/new/ https://reviews.llvm.org/D129078 Files: lldb/include/lldb/Expression/Materializer.h

[Lldb-commits] [PATCH] D129962: [LLDB][DataFormatter] Add support for std::__map_const_iterator

Michael137 created this revision. Michael137 added reviewers: aprantl, jingham. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds support for formatting `std::map::const_iterator`. It's

[Lldb-commits] [PATCH] D81471: [lldb] Add support for using integral const static data members in the expression evaluator

Michael137 added a comment. This seems to cause issues when `var->getType() == const llvm::APFloatBase::roundingMode`. Triggered assertion `Assertion failed: (type->isIntegerType() && "Illegal type in IntegerLiteral"), function IntegerLiteral, file Expr.cpp, line 892` when doing the following:

[Lldb-commits] [PATCH] D130213: [LLDB][ClangExpression] Fix evaluation of types with constant initialized enum typedefs

Michael137 created this revision. Michael137 added reviewers: aprantl, jingham, werat, labath. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `IntegerLiteral::Create` expects integer types. For that

[Lldb-commits] [PATCH] D130213: [LLDB][ClangExpression] Fix evaluation of types with constant initialized enum typedefs

Michael137 updated this revision to Diff 446305. Michael137 added a comment. - Remove redundant header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130213/new/ https://reviews.llvm.org/D130213 Files: lldb/source/Plugins/TypeSystem/Clang/TypeSys

[Lldb-commits] [PATCH] D81471: [lldb] Add support for using integral const static data members in the expression evaluator

Michael137 added a comment. Doing this instead: if (const EnumType *enum_type = llvm::dyn_cast(qt.getTypePtr()->getUnqualifiedDesugaredType())) { resolves the crash, though unclear if that's the right thing to do In D81471#3666071 , @Michael137 wrote:

[Lldb-commits] [PATCH] D130213: [LLDB][ClangExpression] Fix evaluation of types with constant initialized enum typedefs

Michael137 updated this revision to Diff 446315. Michael137 added a comment. - Add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130213/new/ https://reviews.llvm.org/D130213 Files: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.c

[Lldb-commits] [PATCH] D130213: [LLDB][ClangExpression] Fix evaluation of types with constant initialized enum typedefs

Michael137 updated this revision to Diff 446316. Michael137 added a comment. - Remove drive-by whitespace change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130213/new/ https://reviews.llvm.org/D130213 Files: lldb/source/Plugins/TypeSystem/Cla

[Lldb-commits] [PATCH] D130213: [LLDB][ClangExpression] Fix evaluation of types with constant initialized enum typedefs

Michael137 updated this revision to Diff 446418. Michael137 added a comment. - Reword commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130213/new/ https://reviews.llvm.org/D130213 Files: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.c

[Lldb-commits] [PATCH] D130213: [LLDB][ClangExpression] Fix initialization of static enum alias members

Michael137 added a comment. In D130213#3668109 , @werat wrote: > I've tried reproducing the test case with `lldb` built from HEAD on my Linux > machine and it seems to work without your patch: > > ❯ cat ~/src/cpp/const.cc > enum class ScopedEnum { >

[Lldb-commits] [PATCH] D130213: [LLDB][ClangExpression] Fix initialization of static enum alias members

Michael137 added a comment. In D130213#3668450 , @aprantl wrote: > @werat did you build with assertions enabled? > > This change looks fine to me, but it might be interesting to see where the > discrepancy between the platforms comes from. Interestingly

[Lldb-commits] [PATCH] D130213: [LLDB][ClangExpression] Fix initialization of static enum alias members

Michael137 added a comment. > Though I'm a little confused why the test does find > `ClassWithEnumAlias::enum_alias` despite it not being instantiated in `main` Oh nvm, probably just because clang++ on Darwin invokes dsymutil at the end. Whereas in the test suite we don't unless explicitly do

[Lldb-commits] [PATCH] D129962: [LLDB][DataFormatter] Add support for std::__map_const_iterator

Michael137 updated this revision to Diff 446464. Michael137 added a comment. - Add newline to flush printf buffer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129962/new/ https://reviews.llvm.org/D129962 Files: lldb/source/Plugins/Language/CPlu

[Lldb-commits] [PATCH] D129962: [LLDB][DataFormatter] Add support for std::__map_const_iterator

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6703812688b8: [LLDB][DataFormatter] Add support for std::__map_const_iterator (authored by Michael137). Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [PATCH] D130213: [LLDB][ClangExpression] Fix initialization of static enum alias members

This revision was automatically updated to reflect the committed changes. Closed by commit rG140bcd369b0f: [LLDB][ClangExpression] Fix initialization of static enum alias members (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D129078: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Michael137 updated this revision to Diff 446723. Michael137 added a comment. - Doxgyen format improvements Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129078/new/ https://reviews.llvm.org/D129078 Files: lldb/include/lldb/Expression/Materialize

[Lldb-commits] [PATCH] D130561: [LLDB][ClangExpression] Prevent nullptr namespace map access during logging

Michael137 created this revision. Michael137 added reviewers: aprantl, jingham. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Some codepaths lead to `namespace_map == nullptr` when we get to `ClangA

[Lldb-commits] [PATCH] D130561: [LLDB][ClangExpression] Prevent nullptr namespace map access during logging

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a412b3505f4: [LLDB][ClangExpression] Prevent nullptr namespace map access during logging (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D129078: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Michael137 closed this revision. Michael137 added a comment. Missed the differential link in the commits. This patch has been merged to main in following commits: 8184b252cdab2fbe44f766d6de28b29ebe4c8753 fcf4e252f4d992cade4bdfe5aed10ff96fa40202 317c8bf84d185c6b4a51a415c0deb7f8af661cb6 Re

[Lldb-commits] [PATCH] D131122: [lldb] Fixed a number of typos

Michael137 added a comment. FYI, there's a couple of instances of `sythetic` (instead of `synthetic`) around LLDB that could be included in this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131122/new/ https://reviews.llvm.org/D131122 __

  1   2   3   4   5   6   >