[Lldb-commits] [PATCH] D44042: Ensure that trailing characters aren't included in PECOFF section names

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. good catch https://reviews.llvm.org/D44042 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D68048: [WIP][RFC] Improve fetching the process list on the android platform

wallace abandoned this revision. wallace added a comment. This diff has created a good discussion and I have a better idea of what we should do to move forward:) - I figured out a way to improve the existing process fetching functionality of the lldb-server so that it can show all the nice

[Lldb-commits] [PATCH] D68314: [process info] Remove assert in DoGetGroupName

wallace created this revision. wallace added reviewers: clayborg, aadsm, xiaobai, labath. Herald added subscribers: lldb-commits, kristof.beyls, srhines. Herald added a project: LLDB. Disabling this assert prevents lldb-server from crashing, which prevents it from finding the user and group

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes and package name when necessary

wallace updated this revision to Diff 222739. wallace added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68289/new/ https://reviews.llvm.org/D68289 Files: lldb/source/Host/linux/Host.cpp Index: lldb/source/Host/linux/Host.cpp

[Lldb-commits] [PATCH] D68312: [gdb-remote] process properly effective uid

wallace created this revision. wallace added reviewers: labath, clayborg, aadsm, xiaobai. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Someone wrote SetEffectiveSetEffectiveGroupID instead of SetEffectiveUserID. After this fix, the android process list can show user

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes and package name when necessary

wallace marked 3 inline comments as done. wallace added inline comments. Comment at: lldb/source/Host/linux/Host.cpp:178-185 LLDB_LOG(log, "failed to read link exe link for {0}: {1}", pid, Status(errno, eErrorTypePOSIX)); -return false; +

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

wallace created this revision. wallace added reviewers: labath, xiaobai, aadsm, clayborg. Herald added subscribers: lldb-commits, atanasyan, kristof.beyls, arichardson, sdardis. Herald added a project: LLDB. For context: https://reviews.llvm.org/D68293 We need a way to show all the processes on

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

wallace added a comment. Btw, I couldn't find a better short command than 'x', but if you have a better suggestion, i'd be happy to accept it :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68354/new/ https://reviews.llvm.org/D68354

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes and package name when necessary

wallace updated this revision to Diff 222905. wallace added a comment. i'm learning arc... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68289/new/ https://reviews.llvm.org/D68289 Files: lldb/source/Host/linux/Host.cpp Index:

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes and package name when necessary

wallace updated this revision to Diff 222903. wallace added a comment. simplify this diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68289/new/ https://reviews.llvm.org/D68289 Files: lldb/source/Commands/CommandObjectPlatform.cpp

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes by relaxing some checks

wallace added a comment. I removed all android-specific logic from this diff, and relaxed most of the checks inside GetProcessAndStatInfo so that more processes are displayed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68289/new/

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes by relaxing some checks

wallace updated this revision to Diff 222908. wallace added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68289/new/ https://reviews.llvm.org/D68289 Files: lldb/source/Host/linux/Host.cpp Index: lldb/source/Host/linux/Host.cpp

[Lldb-commits] [PATCH] D68291: [process list] make the TRIPLE column wider

wallace updated this revision to Diff 222921. wallace added a comment. Herald added a subscriber: srhines. updated the unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68291/new/ https://reviews.llvm.org/D68291 Files:

[Lldb-commits] [PATCH] D68291: [process list] make the TRIPLE column wider

wallace created this revision. wallace added reviewers: clayborg, labath, xiaobai, aadsm. Herald added subscribers: lldb-commits, kristof.beyls. Herald added a project: LLDB. Now that `process list` works better on the android platform, the arch aarch64-unknown-linux-android appears quite often.

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes and package name when necessary

wallace updated this revision to Diff 222671. wallace added a comment. remove file accidentally included Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68289/new/ https://reviews.llvm.org/D68289 Files: lldb/source/Host/linux/Host.cpp Index:

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes and package name when necessary

wallace updated this revision to Diff 222673. wallace added a comment. - [process list] make the TRIPLE column wider Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68289/new/ https://reviews.llvm.org/D68289 Files: lldb/source/Host/linux/Host.cpp

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes and package name when necessary

wallace created this revision. wallace added reviewers: clayborg, aadsm, labath, xiaobai. Herald added subscribers: lldb-commits, kristof.beyls, krytarowski, srhines. Herald added a project: LLDB. By default `platform process list` only shows the processes of the current user that lldb-server

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes and package name when necessary

wallace updated this revision to Diff 222674. wallace added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68289/new/ https://reviews.llvm.org/D68289 Files: lldb/source/Host/linux/Host.cpp Index: lldb/source/Host/linux/Host.cpp

[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

wallace created this revision. wallace added reviewers: clayborg, aadsm, labath, xiaobai. Herald added subscribers: lldb-commits, atanasyan, JDevlieghere, kristof.beyls, arichardson, sdardis. Herald added a project: LLDB. wallace edited the summary of this revision. The qfProcessInfo and

[Lldb-commits] [PATCH] D65363: [lldb-vscode] add `launchCommands` to handle launch specific commands

wallace added inline comments. Comment at: lldb/trunk/tools/lldb-vscode/lldb-vscode.cpp:1280 // Reenable async events and start the event thread to catch async events. - g_vsc.debugger.SetAsync(true); + // g_vsc.debugger.SetAsync(true); } was this

[Lldb-commits] [PATCH] D69873: [lldb-vscode] support the completion request

wallace created this revision. wallace added reviewers: clayborg, aadsm. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. wallace edited the summary of this revision. The DAP has a completion request that has been unimplemented. It allows showing autocompletion tokens

[Lldb-commits] [PATCH] D69873: [lldb-vscode] support the completion request

wallace updated this revision to Diff 228937. wallace added a comment. set a return list limit of 50 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69873/new/ https://reviews.llvm.org/D69873 Files:

[Lldb-commits] [PATCH] D69873: [lldb-vscode] support the completion request

wallace updated this revision to Diff 228078. wallace added a comment. nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69873/new/

[Lldb-commits] [PATCH] D69873: [lldb-vscode] support the completion request

wallace updated this revision to Diff 228076. wallace added a comment. removed the results limit of 20 because it didn't work and I verified that returning a long list is displayed well on vscode. There's no need for this limit at this point. I also tested the cases that @teemperor mentioned

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

wallace marked an inline comment as done. wallace added inline comments. Comment at: lldb/source/Host/linux/Host.cpp:220-222 + if (process_info.GetNameAsStringRef().empty() && + !process_info.GetArg0().empty()) { +process_info.SetBundleID(process_info.GetArg0());

[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

wallace updated this revision to Diff 225269. wallace added a comment. addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68293/new/ https://reviews.llvm.org/D68293 Files: lldb/docs/lldb-gdb-remote.txt

[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

wallace marked an inline comment as done. wallace added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:1941 +process_info.GetArguments().Clear(); +process_info.SetArg0(" "); +break;

[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rG48a50ee0344d: [android/process list] support showing process arguments (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68293/new/

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce display_name

wallace updated this revision to Diff 225947. wallace retitled this revision from "[android/process info] Introduce bundle id" to "[android/process info] Introduce display_name". wallace edited the summary of this revision. wallace added a comment. Herald added a subscriber: kristof.beyls. now

[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

wallace marked 2 inline comments as done. wallace added inline comments. Comment at: lldb/docs/lldb-gdb-remote.txt:1456 +// separated by the character '-', where each argument is +// hex-encoded. // labath

[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

wallace marked an inline comment as done. wallace added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestPlatformClient.py:63-66 +self.assertRaises( +Exception, +lambda :

[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

wallace updated this revision to Diff 225082. wallace marked 2 inline comments as done. wallace added a comment. Add end to end test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68293/new/ https://reviews.llvm.org/D68293 Files:

[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

wallace updated this revision to Diff 225097. wallace added a comment. Addressed comments. It turns out from the definition of ProcessInfo that Arguments shuoldn't contain arg0, so I updated the code accordingly. I ran the test suite locally and I didn't see any failure caused due to that, so

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

wallace updated this revision to Diff 225112. wallace edited the summary of this revision. wallace added a comment. nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

wallace updated this revision to Diff 225107. wallace added a comment. Herald added a subscriber: krytarowski. now using bundle_id Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68968/new/ https://reviews.llvm.org/D68968 Files:

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

wallace updated this revision to Diff 225113. wallace added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68968/new/ https://reviews.llvm.org/D68968 Files: lldb/include/lldb/Utility/ProcessInfo.h

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes by relaxing some checks

This revision was automatically updated to reflect the committed changes. Closed by commit rGd04855f820c5: [lldb-server/android] Show more processes by relaxing some checks (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes by relaxing some checks

wallace updated this revision to Diff 224931. wallace added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68289/new/ https://reviews.llvm.org/D68289 Files: lldb/source/Host/linux/Host.cpp Index:

[Lldb-commits] [PATCH] D68968: [android/process list] use arg0 as fallback for process name

wallace created this revision. wallace added reviewers: labath, clayborg, aadsm. Herald added subscribers: lldb-commits, srhines. Herald added a project: LLDB. In systems like android, there are cases in which a process name can correspond to a package name (e.g. com.test.app), which is not an

[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

wallace updated this revision to Diff 224949. wallace added a comment. Herald added a subscriber: jfb. address comments Btw, @labath, could you point me to a example of a full end to end test like the attach one you mention? I haven't been able to find it :( Repository: rG LLVM Github

[Lldb-commits] [PATCH] D69400: [lldb] [Host/netbsd] Include argv[0] in process_info.GetArguments()

wallace added a comment. Supposedly Arguments shouldn't contain Arg0 (https://reviews.llvm.org/source/llvm-github/browse/master/lldb/include/lldb/Utility/ProcessInfo.h$96) I think you just need to change the dump method that prints to platform process list. I don't know if NetBSD is doing

[Lldb-commits] [PATCH] D69400: [lldb] [Host/netbsd] Set Arg0 for 'platform process list -v'

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. cool! thanks!! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69400/new/ https://reviews.llvm.org/D69400 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce display_name

wallace updated this revision to Diff 226744. wallace added a comment. now reading from comm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68968/new/ https://reviews.llvm.org/D68968 Files: lldb/docs/lldb-gdb-remote.txt

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce display_name

wallace marked an inline comment as done. wallace added inline comments. Comment at: lldb/source/Host/linux/Host.cpp:205-222 +static bool GetProcessNameFromStat(::pid_t pid, std::string& name) { + auto BufferOrError = getProcFile(pid, "stat"); + if (!BufferOrError) +return

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

wallace added a comment. man, thanks for your feedback! Indeed, i was trying to solve some problems that don't exist yet. Later when I add apk debugging support, I'll figure out what's the best way to retrieve apk specific information, but for now display_name is more than enough Repository:

[Lldb-commits] [PATCH] D69114: Disable TestProcessList on windows

wallace created this revision. wallace added a reviewer: stella.stamenova. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. wallace edited the summary of this revision. wallace added reviewers: clayborg, aadsm, labath. `platform process list -v` on windows doesn't show all

[Lldb-commits] [PATCH] D69114: Disable TestProcessList on windows

wallace added a comment. oh girl, i need to get a bugzilla account. I hope i can get it soon. If it takes too long I can send another patch with the updated comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69114/new/

[Lldb-commits] [PATCH] D69114: Disable TestProcessList on windows

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGe19dfa6745f6: Disable TestProcessList on windows (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D69114: Disable TestProcessList on windows

wallace updated this revision to Diff 225466. wallace added a comment. added bug link in the comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69114/new/ https://reviews.llvm.org/D69114 Files:

[Lldb-commits] [PATCH] D68968: [android/process info] Introduce bundle id

wallace added a comment. Thanks for your feedback and to @clayborg for an offline discussion we had. I'm going to add three new attributes to the ProcessInfo class, with corresponding parameters in the gdb-remote packet - display_name: This is a custom display name that the server can set for

[Lldb-commits] [PATCH] D68048: adbps

wallace created this revision. Herald added subscribers: lldb-commits, srhines. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68048 Files: lldb/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp

[Lldb-commits] [PATCH] D68048: [WIP][RFC] Improve fetching the process list on the android platform

wallace updated this revision to Diff 221837. wallace added a comment. remove unwanted files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68048/new/ https://reviews.llvm.org/D68048 Files:

[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

wallace updated this revision to Diff 223061. wallace added a comment. - Encoding differently the arguments. Now it shouldn't have any corner cases - I'm also sending from the server all the args, including arg0 - In the client, when displaying the process name, I'm using arg0 as fallback if the

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

wallace added a comment. damn, i'll rebase and try to fix it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68354/new/ https://reviews.llvm.org/D68354 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

wallace marked an inline comment as done. wallace added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestPlatformClient.py:30 +self.expect("platform process list -x", +startstr="1 matching

[Lldb-commits] [PATCH] D68312: [gdb-remote] process properly effective uid

wallace closed this revision. wallace added a comment. already committed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68312/new/ https://reviews.llvm.org/D68312 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes by relaxing some checks

wallace added a comment. thanks, @labath ! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68289/new/ https://reviews.llvm.org/D68289 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

wallace closed this revision. wallace added a comment. this was reverted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68354/new/ https://reviews.llvm.org/D68354 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D68662: Redo D68354 - [platform process list] add a flag for showing the processes of all users

wallace created this revision. wallace added reviewers: labath, clayborg, aadsm. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I don't know how the previous version worked on my machine. Maybe something changed in the meantime regarding the lldb's communication layer.

[Lldb-commits] [PATCH] D68291: [process list] make the TRIPLE column wider

This revision was automatically updated to reflect the committed changes. Closed by commit rL373670: [process list] make the TRIPLE column wider (authored by wallace, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

wallace updated this revision to Diff 223358. wallace added a comment. added a basic python test It was a nice learning experience and fortunately there was no need to add any intrusive code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68312: [gdb-remote] process properly effective uid

wallace updated this revision to Diff 223359. wallace added a comment. added a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68312/new/ https://reviews.llvm.org/D68312 Files:

[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

wallace updated this revision to Diff 223356. wallace added a comment. added a basic python test It was a nice learning experience and fortunately there was no need to add any intrusive code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

wallace added a comment. damn, i overwrote this patch lol Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68293/new/ https://reviews.llvm.org/D68293 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

wallace updated this revision to Diff 223376. wallace added a comment. added a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68293/new/ https://reviews.llvm.org/D68293 Files:

[Lldb-commits] [PATCH] D68314: [process info] Remove assert in DoGetGroupName

wallace closed this revision. wallace added a comment. This has been committed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68314/new/ https://reviews.llvm.org/D68314 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes by relaxing some checks

wallace updated this revision to Diff 223235. wallace added a comment. last nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68289/new/ https://reviews.llvm.org/D68289 Files: lldb/source/Host/linux/Host.cpp Index:

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes by relaxing some checks

This revision was automatically updated to reflect the committed changes. Closed by commit rL373758: [lldb-server/android] Show more processes and package name when necessary (authored by wallace, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes by relaxing some checks

wallace updated this revision to Diff 223236. wallace added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68289/new/ https://reviews.llvm.org/D68289 Files: lldb/source/Host/linux/Host.cpp Index:

[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

wallace added a comment. i'm reverting it, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68293/new/ https://reviews.llvm.org/D68293 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D68883: Revert "[platform process list] add a flag for showing the processes of all users"

wallace created this revision. wallace added reviewers: labath, aadsm, clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This reverts commit e4ac611cd787f3f0e727a394e96fb1a5c3b19ccb. There's a failure according to

[Lldb-commits] [PATCH] D68662: Redo D68354 - [platform process list] add a flag for showing the processes of all users

wallace added a comment. Good suggestion! I'll do that next time Thank you so much. I'm getting more used to all the llvm infrastructure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68662/new/ https://reviews.llvm.org/D68662

[Lldb-commits] [PATCH] D68662: Redo D68354 - [platform process list] add a flag for showing the processes of all users

wallace closed this revision. wallace added a comment. will update the previous diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68662/new/ https://reviews.llvm.org/D68662 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

wallace updated this revision to Diff 224656. wallace added a comment. now it should work, the test pass Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68354/new/ https://reviews.llvm.org/D68354 Files:

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

wallace updated this revision to Diff 224716. wallace added a comment. another try Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68354/new/ https://reviews.llvm.org/D68354 Files:

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

wallace updated this revision to Diff 224717. wallace added a comment. adding some logging for exceptions in the mock server Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68354/new/ https://reviews.llvm.org/D68354 Files:

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

wallace updated this revision to Diff 224722. wallace added a comment. i think i finally wrote something that works python 2 and 3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68354/new/ https://reviews.llvm.org/D68354 Files:

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

wallace updated this revision to Diff 224703. wallace added a comment. - update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68354/new/ https://reviews.llvm.org/D68354 Files:

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

wallace updated this revision to Diff 224721. wallace added a comment. after the logging finally found the bug, it's was an encoding issue due to a different python version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68354/new/

[Lldb-commits] [PATCH] D74377: [lldb-vscode] fix logging

wallace created this revision. wallace added a reviewer: clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This applies the patch clayborg sent me for fixing logging, which didn't include incoming messages from VSCode. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D74566: Fix lldb-vscode logging and enable logging for all lldb-vscode tests.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Cool Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74566/new/ https://reviews.llvm.org/D74566

[Lldb-commits] [PATCH] D73506: Bug fix

wallace added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:960 +int commit_points_index = -1; +for (uint32_t breakpoint_index = 0; breakpoint_index < commit_points.size(); breakpoint_index++) { + int breakpoint_position =

[Lldb-commits] [PATCH] D74264: [lldb-vscode] disable completions

wallace created this revision. wallace added a reviewer: clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Completion requests are causing some problems in the debugger, which is explained in the comment in the code. I'm disabling it for now until we have time to

[Lldb-commits] [PATCH] D74266: [lldb-vscode] remove deprecated trace option

wallace created this revision. wallace added a reviewer: clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This option is not used anymore and has been replaced by the env var LLDBVSCODE_LOG. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74266

[Lldb-commits] [PATCH] D74264: [lldb-vscode] disable completions

wallace added a comment. > These completion requests are also expected to be asynchronous right? Do we > have any support for this right now? Currently we will deadlock in > lldb-vscode handling the current completion until it completes right? To > properly handle completion, we will need to

[Lldb-commits] [PATCH] D74579: [don't review]Creating environment variable test for lldbd

wallace added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/environmentVariables/TestVSCode_environmentVariables.py:31-35 +found = False +for line in lines: +if line.startswith('PATH='): +found =

[Lldb-commits] [PATCH] D74579: [don't review]Creating environment variable test for lldbd

wallace requested changes to this revision. wallace added inline comments. This revision now requires changes to proceed. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/completions/TestVSCode_completions.py:26 @skipIfWindows -@skipIfDarwin # Skip

[Lldb-commits] [PATCH] D74636: [lldb-vscode] Add inheritEnvironment option

wallace requested changes to this revision. wallace added inline comments. This revision now requires changes to proceed. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:1380 auto envs = GetStrings(arguments, "env"); + if (launchWithDebuggerEnvironment) { +std::vector

[Lldb-commits] [PATCH] D74636: [lldb-vscode] Add inheritEnvironment option

wallace added a comment. Regarding implementation: The target.inherit-env setting is only effectively used by CommandObjectProcess when launching the target from the command line. lldb-vscode is not following the same codepath and not using that property. What about exposing the Platform's

[Lldb-commits] [PATCH] D74636: [lldb-vscode] Add inheritEnvironment option

wallace added a comment. The original intention of this is to have any working environment, as quite often complex programs require many environment variables that are common to most processes. Having the user specify each of those is a bit too much to ask for, and they are complaining because

[Lldb-commits] [PATCH] D76111: Create basic SBEnvironment class

wallace updated this revision to Diff 250108. wallace added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76111/new/ https://reviews.llvm.org/D76111 Files: lldb/bindings/headers.swig lldb/bindings/interface/SBEnvironment.i

[Lldb-commits] [PATCH] D76111: Create basic SBEnvironment class

wallace created this revision. wallace added reviewers: labath, clayborg. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. Inspired by https://reviews.llvm.org/D74636, I'm introducing a basic version of Environment in the API. More functionalities can be added as

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace updated this revision to Diff 256022. wallace added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76968/new/ https://reviews.llvm.org/D76968 Files:

[Lldb-commits] [PATCH] D77444: [commands] Support autorepeat in SBCommands

wallace updated this revision to Diff 256027. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77444/new/ https://reviews.llvm.org/D77444 Files: lldb/include/lldb/API/SBCommandInterpreter.h

[Lldb-commits] [PATCH] D77878: [lldb] Fix a typo in a test name

wallace created this revision. wallace added reviewers: labath, clayborg. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. Removing the Test prefix from the file name and its usages. The standard is using only Test as a suffix. This was correctly pointed out in

[Lldb-commits] [PATCH] D77452: [intel-pt] Improve the way the test determines whether to run

wallace updated this revision to Diff 257450. wallace added a comment. move the skipping logic to the actual test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77452/new/ https://reviews.llvm.org/D77452 Files:

[Lldb-commits] [PATCH] D77582: [CommandInterpreter] Implement UserCommandExists

wallace abandoned this revision. wallace added a comment. Will revisit it whenever I need it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77582/new/ https://reviews.llvm.org/D77582 ___ lldb-commits

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace added a comment. Ping ping. This will fix some existing issues reported by users :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76968/new/ https://reviews.llvm.org/D76968 ___ lldb-commits

[Lldb-commits] [PATCH] D77444: [commands] Support autorepeat in SBCommands

wallace updated this revision to Diff 255429. wallace added a comment. nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77444/new/ https://reviews.llvm.org/D77444 Files: lldb/include/lldb/API/SBCommandInterpreter.h

[Lldb-commits] [PATCH] D77444: [commands] Support autorepeat in SBCommands

wallace updated this revision to Diff 255426. wallace added a comment. Herald added a subscriber: mgorny. - Moved the test to gtest. It's much better this way and I learned gtest - Changed the API. Some notes: Within the scope of a subcommand, the subcommand doesn't know the parent's command

  1   2   3   4   5   6   7   8   9   10   >