[Lldb-commits] [PATCH] D150805: Rate limit progress reporting

rupprecht added a subscriber: labath. rupprecht added a comment. The other tricky part I missed before is this bit in between pulling the event off the listener queue and deciding to show it: auto *data = ProgressEventData::GetEventDataFromEvent(event_sp.get()); if (!data) return;

[Lldb-commits] [PATCH] D150805: Rate limit progress reporting

rupprecht added a comment. In D150805#4350849 , @JDevlieghere wrote: > I also like Jordan's rate limiting idea. In my mind that should be a property > of the broadcaster. Different tools (e.g. vscode vs the command line) could > specify different

[Lldb-commits] [PATCH] D150805: Proof of concept for reducing progress-reporting frequency.

rupprecht added a comment. This is a nice proof of concept, but I think we should go with a time-based approach to rate limit this. (Anyone else in LLDB know if we have some utils around to help with this?) e.g. if the first 1000 files are small and the last 1000 are large, the user will see

[Lldb-commits] [PATCH] D150639: [lldb] Define lldbassert based on NDEBUG instead of LLDB_CONFIGURATION_DEBUG

rupprecht added a comment. In D150639#4346649 , @JDevlieghere wrote: > In D150639#4346009 , @rupprecht > wrote: > >> +1 to being surprised this is not already the case >> >> Some other places should be updated

[Lldb-commits] [PATCH] D150639: [lldb] Define lldbassert based on NDEBUG instead of LLDB_CONFIGURATION_DEBUG

rupprecht accepted this revision. rupprecht added a comment. This revision is now accepted and ready to land. +1 to being surprised this is not already the case Some other places should be updated after this, e.g. lldb/source/Symbol/SymbolFile.cpp also has a use that can be trivially updated:

[Lldb-commits] [PATCH] D150392: [lldb-vscode] Fix handling of RestartRequest arguments.

rupprecht added a comment. Is there a test case you can add for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150392/new/ https://reviews.llvm.org/D150392 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D147805: [lldb-vscode] Fix two issues with runInTerminal test.

rupprecht accepted this revision. rupprecht added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147805/new/ https://reviews.llvm.org/D147805 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D147831: [lldb-vscode] Implement RestartRequest

rupprecht added inline comments. Comment at: lldb/tools/lldb-vscode/VSCode.h:146 + // arguments if we get a RestartRequest. + llvm::json::Object last_launch_or_attach_request; lldb::tid_t focus_tid; std::optional? And then we can raise an error if the

[Lldb-commits] [PATCH] D147805: [lldb-vscode] Fix two issues with runInTerminal test.

rupprecht added a reviewer: rupprecht. rupprecht added a comment. The `pid` plumbing looks fine for the happy case, but I think we could be more lenient if (for whatever reason) the pid flag isn't being set on non-Linux systems that won't actually be using it. Even on a Linux system, this is

[Lldb-commits] [PATCH] D147805: [lldb-vscode] Fix two issues with runInTerminal test.

rupprecht added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:3158 +#if defined(__linux__) + (void)prctl(PR_SET_PTRACER, PR_SET_PTRACER_ANY, 0, 0, 0); +#endif https://manpages.debian.org/bullseye/manpages-dev/prctl.2.en.html#PR_SET_PTRACER

[Lldb-commits] [PATCH] D146668: [lldb-server] Use Platform plugin corresponding to the host

rupprecht accepted this revision. rupprecht added a comment. This revision is now accepted and ready to land. Thanks! This indeed fixes the issue I'm seeing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146668/new/

[Lldb-commits] [PATCH] D146263: [lldb] Move UnixSignals creation into Platform plugins

rupprecht added inline comments. Comment at: lldb/source/Target/UnixSignals.cpp:39 + // If we have no host platform, be resilient and use default UnixSignals. + if (!host_platform_sp) +s_unix_signals_sp = std::make_shared(); bulbazord wrote: > rupprecht

[Lldb-commits] [PATCH] D146263: [lldb] Move UnixSignals creation into Platform plugins

rupprecht added inline comments. Comment at: lldb/source/Target/UnixSignals.cpp:39 + // If we have no host platform, be resilient and use default UnixSignals. + if (!host_platform_sp) +s_unix_signals_sp = std::make_shared(); I think the divergence might be

[Lldb-commits] [PATCH] D146263: [lldb] Move UnixSignals creation into Platform plugins

rupprecht added a comment. This seems to cause a regression on Linux where we no longer get the signal details. Given an intentionally-crashy test binary, such as: void crash() { // Allocate valid but non-accessible memory and attempt to write to it, // triggering a Segmentation

[Lldb-commits] [PATCH] D146590: [lldb] Update some uses of Python2 API in typemaps.

rupprecht added a comment. In D146590#4211763 , @bulbazord wrote: >> `lldb -o "script data=lldb.SBData(); data.SetDataFromUInt64Array([2**63])"` > > Just tried this, didn't crash LLDB but it does give me the OverflowError you > mentioned. Here's what

[Lldb-commits] [PATCH] D146590: [lldb] Update some uses of Python2 API in typemaps.

rupprecht added reviewers: bulbazord, mib. rupprecht added a comment. Can you add a regression test that invokes `lldb -o "script data=lldb.SBData(); data.SetDataFromUInt64Array([2**63])"`? Just a simple shell test should suffice. LGTM, but it'd be nice if someone else can look too. Adding some

[Lldb-commits] [PATCH] D145940: [lldb] Add test for unavailable registers

rupprecht accepted this revision. rupprecht added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/API/commands/register/register/TestRegistersUnavailable.py:43-53 +self.expect("register read --all", patterns=[ +

[Lldb-commits] [PATCH] D145940: [lldb] Add test for unavailable registers

rupprecht added a comment. Seems like most xml-based tests like this are in `lldb/test/API/functionalities/gdb_remote_client`, is there a reason this is not in that package too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145940/new/

[Lldb-commits] [PATCH] D145533: [lldb] Fix after __SVCount_t added for AArch64

rupprecht added a comment. 5195e14bc1222e1b3f1b7b43c04e1c1ac3504cb1 just landed the same thing as this, although it didn't put it in the sorted order. Feel free to land this if you remove the other entry. Repository: rG

[Lldb-commits] [PATCH] D144904: [Linux] Add kernel.yama.ptrace_scope note when ptrace fails to attach.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6db44e52ce47: [Linux] Add kernel.yama.ptrace_scope note when ptrace fails to attach. (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D144904: [Linux] Add kernel.yama.ptrace_scope note when ptrace fails to attach.

rupprecht added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:235 +std::error_code(errno, std::generic_category()), +"The current value of ptrace_scope is %d, which can cause ptrace to " +"fail to attach to a

[Lldb-commits] [PATCH] D144904: [Linux] Add kernel.yama.ptrace_scope note when ptrace fails to attach.

rupprecht updated this revision to Diff 501367. rupprecht marked an inline comment as done. rupprecht added a comment. - Fix comment typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144904/new/ https://reviews.llvm.org/D144904 Files:

[Lldb-commits] [PATCH] D144904: [Linux] Add kernel.yama.ptrace_scope note when ptrace fails to attach.

rupprecht created this revision. rupprecht added reviewers: jingham, DavidSpickett, labath. Herald added a project: All. rupprecht requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. A common reason for LLDB failing to attach to an

[Lldb-commits] [PATCH] D142140: [lldb] Remove legacy six module for py2->py3

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ed6d99a8311: [lldb] Remove legacy six module for py2-py3 (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142140/new/

[Lldb-commits] [PATCH] D142140: [lldb] Remove legacy six module for py2->py3

rupprecht created this revision. Herald added a project: All. rupprecht requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. LLDB only supports Python3 now, so the `six` shim for Python2 is no longer necessary. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D141174: [test] Add more tests for _regexp-break, the 'b' shortcut.

rupprecht created this revision. Herald added a project: All. rupprecht requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This test more exhaustively tests all the different shortcuts that `_regexp-break` provides. I have a follow up to

[Lldb-commits] [PATCH] D138344: [test][lldb-vscode] Relax assertion to allow multiple compile units returned.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3afe296c81b9: [test][lldb-vscode] Relax assertion to allow multiple compile units returned. (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D138344: [test][lldb-vscode] Relax assertion to allow multiple compile units returned.

rupprecht added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138344/new/ https://reviews.llvm.org/D138344 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D138892: [DataFormatter] Fix variant npos with `_LIBCPP_ABI_VARIANT_INDEX_TYPE_OPTIMIZATION` enabled.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c51ea3619e4: [DataFormatter] Fix variant npos with `_LIBCPP_ABI_VARIANT_INDEX_TYPE_OPTIMIZAT… (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D138892: [DataFormatter] Fix variant npos with `_LIBCPP_ABI_VARIANT_INDEX_TYPE_OPTIMIZATION` enabled.

rupprecht added a comment. I plan to land this now so we can remove this from our internal test exclusion list, but I'd be happy to address any post-commit feedback from other reviewers as a followup change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D129898: [test] Allow libc++ namespaces besides `__1`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7d26f9e1329f: [test] Allow libc++ namespaces besides `__1` (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D138850: [test] Implement layout for unstable std::string garbage formatter tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c10e9c77332: [test] Implement layout for unstable std::string garbage formatter tests. (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D138310: [NFC] Make headers self-contained.

This revision was automatically updated to reflect the committed changes. rupprecht marked an inline comment as done. Closed by commit rGcd02e78cd5cd: [NFC] Make headers self-contained. (authored by rupprecht). Changed prior to commit: https://reviews.llvm.org/D138310?vs=476502=478515#toc

[Lldb-commits] [PATCH] D138310: [NFC] Make headers self-contained.

rupprecht marked an inline comment as done. rupprecht added inline comments. Comment at: lldb/source/Plugins/Instruction/RISCV/RISCVInstructions.h:15 -#include "EmulateInstructionRISCV.h" #include "llvm/ADT/Optional.h" MaskRay wrote: > I assume that this is

[Lldb-commits] [PATCH] D138892: [DataFormatter] Fix variant npos with `_LIBCPP_ABI_VARIANT_INDEX_TYPE_OPTIMIZATION` enabled.

rupprecht updated this revision to Diff 478507. rupprecht added a comment. - Add comment about choice of 300 types - Use fixed-width types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138892/new/ https://reviews.llvm.org/D138892 Files:

[Lldb-commits] [PATCH] D138892: [DataFormatter] Fix variant npos with `_LIBCPP_ABI_VARIANT_INDEX_TYPE_OPTIMIZATION` enabled.

rupprecht created this revision. rupprecht added reviewers: labath, Michael137, kastiglione. Herald added a subscriber: arphaman. Herald added a project: All. rupprecht requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This data formatter

[Lldb-commits] [PATCH] D138850: [test] Implement layout for unstable std::string garbage formatter tests.

rupprecht created this revision. rupprecht added a reviewer: labath. Herald added a project: All. rupprecht requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The layout is essentially just reversed from the stable std::string layout.

[Lldb-commits] [PATCH] D138345: [test][lldb-vscode] Un-realpath coreFile test.

This revision was automatically updated to reflect the committed changes. Closed by commit rGae7a3e1c1d3e: [test][lldb-vscode] Un-realpath coreFile test. (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138345/new/

[Lldb-commits] [PATCH] D138345: [test][lldb-vscode] Un-realpath coreFile test.

rupprecht created this revision. rupprecht added a reviewer: wallace. Herald added a project: All. rupprecht requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. TestVSCode_coreFile looks for an exe/core file in the same directory as the test.

[Lldb-commits] [PATCH] D138344: [test][lldb-vscode] Relax assertion to allow multiple compile units returned.

rupprecht created this revision. rupprecht added reviewers: wallace, clayborg. Herald added a project: All. rupprecht requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I don't think the intent of this test is to make sure we only have one

[Lldb-commits] [PATCH] D129898: [test] Allow libc++ namespaces besides `__1`

rupprecht added a comment. In D129898#3656303 , @rupprecht wrote: > In D129898#3656268 , @JDevlieghere > wrote: > >> Seems like there's another instance of this in >> `TestForwardDeclFromStdModule.py`. > >

[Lldb-commits] [PATCH] D138310: [NFC] Make headers self-contained.

rupprecht created this revision. Herald added subscribers: frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb, arichardson. Herald added a

[Lldb-commits] [PATCH] D138181: [test] Allow skipTestIfFn to apply to entire classes for skipIfNoSBHeaders

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8be41c787f9e: [test] Allow skipTestIfFn to apply to entire classes for skipIfNoSBHeaders (authored by rupprecht). Repository: rG LLVM Github

[Lldb-commits] [PATCH] D138181: [test] Allow skipTestIfFn to apply to entire classes for skipIfNoSBHeaders

rupprecht added a comment. Thanks! Comment at: lldb/packages/Python/lldbsuite/test/decorators.py:146 +# reason is used for both args. +return unittest2.skipIf(reason, reason)(func) DavidSpickett wrote: > This would make more immediate

[Lldb-commits] [PATCH] D138181: [test] Allow skipTestIfFn to apply to entire classes for skipIfNoSBHeaders

rupprecht updated this revision to Diff 476137. rupprecht marked an inline comment as done. rupprecht added a comment. - Use named args to indicate reason is used as condition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138181/new/

[Lldb-commits] [PATCH] D138181: [test] Allow skipTestIfFn to apply to entire classes for skipIfNoSBHeaders

rupprecht created this revision. Herald added a project: All. rupprecht requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Some test cases are already marked @skipIfNoSBHeaders, but they make use of SBAPI headers in test setup. The setup

[Lldb-commits] [PATCH] D136798: [lldb] Explicitly open file to write with utf-8 encoding in crashlog.py

rupprecht accepted this revision. rupprecht added a comment. This revision is now accepted and ready to land. Two other places you might need to update as well Comment at: lldb/examples/python/crashlog.py:452 with open(path, 'r') as f: buffer = f.read()

[Lldb-commits] [PATCH] D133973: [test] Fix LLDB tests with just-built libcxx when using a target directory.

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb0eb9d8dd5a: [test] Fix LLDB tests with just-built libcxx when using a target directory. (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D133973: [test] Fix LLDB tests with just-built libcxx when using a target directory.

rupprecht added inline comments. Comment at: lldb/test/API/lit.cfg.py:178-179 + dotest_cmd += ['--libcxx-include-dir', config.libcxx_include_dir] + if is_configured('libcxx_include_target_dir'): +dotest_cmd += ['--libcxx-include-target-dir',

[Lldb-commits] [PATCH] D133973: [test] Fix LLDB tests with just-built libcxx when using a target directory.

rupprecht added inline comments. Comment at: lldb/test/API/lit.cfg.py:176 if platform.system() != 'Windows': -if is_configured('llvm_include_dir') and is_configured('llvm_libs_dir'): - dotest_cmd += ['--libcxx-include-dir', os.path.join(config.llvm_include_dir,

[Lldb-commits] [PATCH] D133973: [test] Fix LLDB tests with just-built libcxx when using a target directory.

rupprecht added a comment. In D133973#3793398 , @JDevlieghere wrote: > Do we need both `LIBCPP_INCLUDE_DIR` and `LIBCPP_INCLUDE_TARGET_DIR`? I see > we pass another `-cxx-isystem` flag, does this result in another search path > or does that replace

[Lldb-commits] [PATCH] D133973: [test] Fix LLDB tests with just-built libcxx when using a target directory.

rupprecht created this revision. rupprecht added reviewers: JDevlieghere, fdeazeve. Herald added a subscriber: mgorny. Herald added a project: All. rupprecht requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In certain configurations, libc++

[Lldb-commits] [PATCH] D133790: Fix heap-use-after-free when clearing DIEs in fission compile units.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1f3def30ca86: Fix heap-use-after-free when clearing DIEs in fission compile units. (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D133546: [lldb][fuzz] Allow expression fuzzer to be passed as a flag.

This revision was automatically updated to reflect the committed changes. rupprecht marked an inline comment as done. Closed by commit rG4fdda4f82d78: [lldb][fuzz] Allow expression fuzzer to be passed as a flag. (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D133546: [lldb][fuzz] Allow expression fuzzer to be passed as a flag.

rupprecht marked an inline comment as done. rupprecht added inline comments. Comment at: lldb/tools/lldb-fuzzer/lldb-expression-fuzzer/lldb-expression-fuzzer.cpp:66 ReportError( "no target path specified in with the LLDB_FUZZER_TARGET variable");

[Lldb-commits] [PATCH] D133546: [lldb][fuzz] Allow expression fuzzer to be passed as a flag.

rupprecht updated this revision to Diff 459844. rupprecht added a comment. - Update error message to reference the new command line flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133546/new/ https://reviews.llvm.org/D133546 Files:

[Lldb-commits] [PATCH] D131437: Don't index the skeleton CU when we have a fission compile unit.

rupprecht added a comment. In D131437#3751366 , @bkramer wrote: > This seems to trigger a use after free in `lldb-api :: > functionalities/thread/create_after_attach/TestCreateAfterAttach.py` > > asan log: > > ==4741==ERROR: AddressSanitizer:

[Lldb-commits] [PATCH] D133790: Fix heap-use-after-free when clearing DIEs in fission compile units.

rupprecht created this revision. rupprecht added reviewers: labath, clayborg. Herald added a project: All. rupprecht requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. D131437 caused heap-use-after-free

[Lldb-commits] [PATCH] D133628: [lldb/test][TestingSupport] Add a helper class to send all LLDB logs to stderr in unit tests.

rupprecht created this revision. Herald added a subscriber: mgorny. Herald added a project: All. rupprecht requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This helper class can be useful to see what `LLDB_LOG` messages are happening when

[Lldb-commits] [PATCH] D133393: [test] Use either `127.0.0.1` or `[::1]` to run in ipv6-only environments.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b988ff092a0: [test] Use either `127.0.0.1` or `[::1]` to run in ipv6-only environments. (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D133546: [lldb][fuzz] Allow expression fuzzer to be passed as a flag.

rupprecht created this revision. rupprecht added reviewers: cassanova, JDevlieghere, mib. Herald added a project: All. rupprecht requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The expression fuzzer checks an environment variable,

[Lldb-commits] [PATCH] D133393: [test] Use either `127.0.0.1` or `[::1]` to run in ipv6-only environments.

rupprecht updated this revision to Diff 458611. rupprecht added a comment. - Ip -> IP casing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133393/new/ https://reviews.llvm.org/D133393 Files:

[Lldb-commits] [PATCH] D133393: [test] Use localhost in place of 127.0.0.1 to run in ipv6-only environments.

rupprecht added a comment. In D133393#3773793 , @labath wrote: > I believe the reasons are still relevant. Basically the problem is that > listening on `localhost:x` creates two sockets (one for 127.0.0.1, one for > ::1), and there's no way to

[Lldb-commits] [PATCH] D133393: [test] Use localhost in place of 127.0.0.1 to run in ipv6-only environments.

rupprecht updated this revision to Diff 458609. rupprecht added a comment. - Add a GetLocalhostIp helper to socket host utilities Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133393/new/ https://reviews.llvm.org/D133393 Files:

[Lldb-commits] [PATCH] D133352: [lldb-server] Report launch error in vRun packets

rupprecht accepted this revision. rupprecht added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Host/posix/ProcessLauncherPosixFork.cpp:293 +r = llvm::sys::RetryAfterSignal(-1, read, pipe.GetReadFileDescriptor(), pos, +

[Lldb-commits] [PATCH] D133259: [lldb] Don't assume name of libc++ inline namespace in LibCxxUnorderedMap

rupprecht accepted this revision. rupprecht added a comment. Thanks again! Still looks good. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxxUnorderedMap.cpp:70 +static void consumeNamespace(llvm::StringRef ) { + // Delete past an inline namespace, if any:

[Lldb-commits] [PATCH] D133393: [test] Use localhost in place of 127.0.0.1 to run in ipv6-only environments.

rupprecht added a comment. I previously converted some tests to support running in ipv6-only environments in D87333 , but we weren't running these tests so I missed them. Looking at history, I see D58131 specifically changed

[Lldb-commits] [PATCH] D133393: [test] Use localhost in place of 127.0.0.1 to run in ipv6-only environments.

rupprecht created this revision. Herald added a project: All. rupprecht requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D133393 Files:

[Lldb-commits] [PATCH] D133259: [lldb] Don't assume name of libc++ inline namespace in LibCxxUnorderedMap

rupprecht added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxxUnorderedMap.cpp:76 +auto ident_end = +name.find_if_not([](char c) { return std::isalnum(c) || c == '_'; }); +if (ident_end != llvm::StringRef::npos && ident_end >= 1) {

[Lldb-commits] [PATCH] D133259: [lldb] Don't assume name of libc++ inline namespace in LibCxxUnorderedMap

rupprecht accepted this revision. rupprecht added a comment. This revision is now accepted and ready to land. LGTM -- I patched this in to verify it fixes the test failure we saw. However, and not something that needs to happen in this patch (you could though), but the test actually isn't

[Lldb-commits] [PATCH] D133181: [test] Remove problematic thread from MainLoopTest to fix flakiness

rupprecht added a comment. In D133181#3771747 , @labath wrote: > (I've reverted the pthread_kill part, as the mac build did not like it.) Thanks! I didn't get any buildbot notification; do LLDB build bots not send email? Repository: rG LLVM Github

[Lldb-commits] [PATCH] D133352: [lldb-server] Report launch error in vRun packets

rupprecht requested changes to this revision. rupprecht added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Host/posix/ProcessLauncherPosixFork.cpp:293 +r = llvm::sys::RetryAfterSignal(-1, read, pipe.GetReadFileDescriptor(), pos, +

[Lldb-commits] [PATCH] D133181: [test] Remove problematic thread from MainLoopTest to fix flakiness

This revision was automatically updated to reflect the committed changes. Closed by commit rG945bdb167ff5: [test] Remove problematic thread from MainLoopTest to fix flakiness (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D133181: [test] Remove problematic thread from MainLoopTest to fix flakiness

rupprecht added a comment. In D133181#3767072 , @labath wrote: > It might be a good idea to also change the `kill(getpid(), sig);` statements > into `raise(sig)` (a.k.a. `pthread_kill(pthread_self(), sig)`), so that > they're sent to a specific thread,

[Lldb-commits] [PATCH] D133181: [test] Remove problematic thread from MainLoopTest to fix flakiness

rupprecht updated this revision to Diff 457631. rupprecht added a comment. - Use pthread_kill to only kill the current thread Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133181/new/ https://reviews.llvm.org/D133181 Files:

[Lldb-commits] [PATCH] D133181: [test] Ensure MainLoop has time to start listening for signals.

rupprecht marked 2 inline comments as done. rupprecht added a comment. In D133181#3766319 , @labath wrote: >> AFAICT kill is entirely asynchronous > > This is not exactly true. POSIX describes this situation quite well (emphasis > mine): > >> If the

[Lldb-commits] [PATCH] D133181: [test] Ensure MainLoop has time to start listening for signals.

rupprecht updated this revision to Diff 457598. rupprecht added a comment. - Remove async call to avoid deadlock instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133181/new/ https://reviews.llvm.org/D133181 Files:

[Lldb-commits] [PATCH] D133181: [test] Ensure MainLoop has time to start listening for signals.

rupprecht created this revision. Herald added a project: All. rupprecht requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This test, specifically `TwoSignalCallbacks`, can be a little bit flaky, failing in around 5/2000 runs. My suspicion

[Lldb-commits] [PATCH] D129898: [test] Allow libc++ namespaces besides `__1`

rupprecht added a comment. In D129898#3656268 , @JDevlieghere wrote: > Seems like there's another instance of this in > `TestForwardDeclFromStdModule.py`. Added that one too. There is also this one:

[Lldb-commits] [PATCH] D129900: Update the __1 in TestForwardDeclFromStdModule.py

rupprecht abandoned this revision. rupprecht added a comment. Herald added a subscriber: JDevlieghere. Meant to update D129898 instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129900/new/

[Lldb-commits] [PATCH] D129898: [test] Allow libc++ namespaces besides `__1`

rupprecht updated this revision to Diff 445115. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129898/new/ https://reviews.llvm.org/D129898 Files:

[Lldb-commits] [PATCH] D129900: Update the __1 in TestForwardDeclFromStdModule.py

rupprecht created this revision. Herald added a project: All. rupprecht requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Depends on D129898 Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D129898: [test] Allow libc++ namespaces besides `__1`

rupprecht created this revision. Herald added a project: All. rupprecht requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The libc++ data formatter for `std::shared_ptr` allows any namespace, but the test asserts that it must be the default

[Lldb-commits] [PATCH] D114722: [LLDB] Fix Python GIL-not-held issues

rupprecht updated this revision to Diff 398652. rupprecht added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114722/new/ https://reviews.llvm.org/D114722 Files:

[Lldb-commits] [PATCH] D114722: [LLDB] Fix Python GIL-not-held issues

rupprecht created this revision. rupprecht added a reviewer: labath. rupprecht requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The GIL must be held when calling any Python C API functions. In multithreaded applications that use callbacks

[Lldb-commits] [PATCH] D113449: Revert "[lldb] Disable minimal import mode for RecordDecls that back FieldDecls"

This revision was automatically updated to reflect the committed changes. Closed by commit rG360d901bf047: Revert [lldb] Disable minimal import mode for RecordDecls that back FieldDecls (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D113449: Revert "[lldb] Disable minimal import mode for RecordDecls that back FieldDecls"

rupprecht added a comment. In D113449#3121070 , @teemperor wrote: > I actually didn't see that the patch deleted the TestCppReferenceToOuterClass > test. Could you just add a `@skipIf # Crashes` or so above its `def test...` > method? The test itself

[Lldb-commits] [PATCH] D113449: Revert "[lldb] Disable minimal import mode for RecordDecls that back FieldDecls"

rupprecht updated this revision to Diff 386227. rupprecht added a comment. - Use better test APIs, add test back w/ a @expectedFailure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113449/new/ https://reviews.llvm.org/D113449 Files:

[Lldb-commits] [PATCH] D113449: Revert "[lldb] Disable minimal import mode for RecordDecls that back FieldDecls"

rupprecht updated this revision to Diff 386114. rupprecht added a comment. - Switch crash repro from shell -> api test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113449/new/ https://reviews.llvm.org/D113449 Files:

[Lldb-commits] [PATCH] D113449: Revert "[lldb] Disable minimal import mode for RecordDecls that back FieldDecls"

rupprecht added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/PR52257.cpp:21 +}; +B b; teemperor wrote: > FWIW, I think probably should be an API test (for a bunch of reasons from not > relying on formatting output to remote device testing), but

[Lldb-commits] [PATCH] D113449: Revert "[lldb] Disable minimal import mode for RecordDecls that back FieldDecls"

rupprecht added a comment. Given that this patch has been in tree for half a year, it'd be good to get confirmation here this can be reverted given there is now a test case for causing a crash. I got an offline comment that this is OK to revert, so if nobody has objections, I'll land sometime

[Lldb-commits] [PATCH] D113449: Revert "[lldb] Disable minimal import mode for RecordDecls that back FieldDecls"

rupprecht created this revision. rupprecht added reviewers: labath, teemperor. Herald added a reviewer: shafik. rupprecht requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This reverts commit 3bf96b0329be554c67282b0d7d8da6a864b9e38f

[Lldb-commits] [PATCH] D106226: [lldb] Improve error message when "lldb attach" fails

rupprecht added a comment. In D106226#2891107 , @teemperor wrote: > Congrats on getting started on your first patch! I improving this error > message really seems like a good idea. > > From what I can see the error message here is identical to GDB's

[Lldb-commits] [PATCH] D100048: [lldb][Editline] Fix crash when navigating through empty command history.

rupprecht added a comment. In D100048#2879669 , @iii wrote: > lldb-arm-ubuntu (https://lab.llvm.org/buildbot/#/builders/17/builds/9015) > fails with: > > FAIL: LLDB > (/home/tcwg-buildslave/worker/lldb-arm-ubuntu/build/bin/clang-arm) :: >

[Lldb-commits] [PATCH] D102993: [lldb] Disable minimal import mode for RecordDecls that back FieldDecls

rupprecht added a comment. In D102993#2811902 , @rupprecht wrote: > In D102993#2811337 , @teemperor > wrote: > >> Sure I can take a look, but I don't see the immediate problem when looking >> at the backtrace.

[Lldb-commits] [PATCH] D102993: [lldb] Disable minimal import mode for RecordDecls that back FieldDecls

rupprecht added a comment. In D102993#2811337 , @teemperor wrote: > Sure I can take a look, but I don't see the immediate problem when looking at > the backtrace. > > I assume it takes some time to reduce the bug in Chrome? If you could get me > the

[Lldb-commits] [PATCH] D102993: [lldb] Disable minimal import mode for RecordDecls that back FieldDecls

rupprecht added a comment. This commit seems to be causing an LLDB crash. I'm still working on gathering info and reducing it, but maybe the crash reason is obvious to you given this stack trace: $ lldb -b -o "b ChromeMain" -o "r" -o "v" -o "p chrome_main_delegate"

[Lldb-commits] [PATCH] D101153: [lldb][NFC] Specify guidelines for API tests

rupprecht added a comment. LGTM too, thanks for writing this up! Comment at: lldb/docs/resources/test.rst:264 +:: +self.expect("expr 1 - 1", substrs=["0"]) + shafik wrote: > Maybe some more examples with alternatives would be helpful here. Also mentioning

[Lldb-commits] [PATCH] D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files.

rupprecht added a comment. In D97786#2693410 , @jingham wrote: > In D97786#2693381 , @cmtice wrote: > >> I had to revert this change because the test case broke the windows builder. >> What's the right way to

[Lldb-commits] [PATCH] D100795: [lldb] Fix RichManglingContext::FromCxxMethodName() leak

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb5e11f460b1: [lldb] Fix RichManglingContext::FromCxxMethodName() leak (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES

  1   2   3   >