[Lldb-commits] [PATCH] D148752: lldb: Fix usage of sve functions on arm64

2023-04-27 Thread Manoj Gupta via Phabricator via lldb-commits
manojgupta added a comment. Thanks, regarding sve from Linux headers, LLVM currently supports building with GCC 7.1 or clang 5.0 and both were released in 2017. SVE support in Linux kernel believe was added in Linux kernel 4.19 timeframe iso maybe late 2018. If SVE needs to be built from

[Lldb-commits] [PATCH] D148752: lldb: Fix usage of sve functions on arm64

2023-04-27 Thread Manoj Gupta via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGbe5f35e24f4c: lldb: Fix usage of sve functions on arm64 (authored by manojgupta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148752/new/

[Lldb-commits] [PATCH] D148752: lldb: Fix usage of sve functions on arm64

2023-04-21 Thread Manoj Gupta via Phabricator via lldb-commits
manojgupta added a comment. Are there any objecttions? This patch is only making a consistent use of pre-existing and already in-use APIs/struct defintions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148752/new/

[Lldb-commits] [PATCH] D148752: lldb: Fix usage of sve functions on arm64

2023-04-20 Thread Manoj Gupta via Phabricator via lldb-commits
manojgupta added a comment. I am building on ChromeOS. We only have headers from linux kernel 4.14 available in our build system (The actual running kernel could be a higher version). But given these functions/struct definitions (sve::) are already available and used, why are they not used

[Lldb-commits] [PATCH] D148752: lldb: Fix usage of sve functions on arm64

2023-04-19 Thread Manoj Gupta via Phabricator via lldb-commits
manojgupta created this revision. Herald added subscribers: ctetreau, omjavaid, kristof.beyls, tschuett. Herald added a project: All. manojgupta requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Use correct internal sve functions for arm64.

[Lldb-commits] [PATCH] D108053: [lldb] skip host build for lldb_tblgen with LLDB_TABLEGEN_EXE set

2021-08-13 Thread Manoj Gupta via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1f7b25ea76a9: [lldb] skip host build for lldb_tblgen with LLDB_TABLEGEN_EXE set (authored by manojgupta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D108053: [lldb] skip host build for lldb_tblgen with LLDB_TABLEGEN_EXE set

2021-08-13 Thread Manoj Gupta via Phabricator via lldb-commits
manojgupta added a comment. This is a local patch we have been carrying in Chrome OS. What we do to cross compile lldb-server: 1. Create host build to build tools like llvm-tblgen, clang-tblgen, lldb-tblgen 2. Cross compile llvm and clang libraries using the just build *tblgen. 3. Cross compile

[Lldb-commits] [PATCH] D108053: [lldb] skip host build for lldb_tblgen with LLDB_TABLEGEN_EXE set

2021-08-13 Thread Manoj Gupta via Phabricator via lldb-commits
manojgupta created this revision. manojgupta added reviewers: JDevlieghere, mstorsjo. Herald added a subscriber: mgorny. manojgupta requested review of this revision. Herald added a project: LLDB. When cross compiling lldb-server, do not create a host build for building lldb-tblgeb when

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

2020-03-23 Thread Manoj Gupta via Phabricator via lldb-commits
manojgupta added a comment. Thanks for the quick fix, verified that the crash is fixed on trunk. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

2020-03-20 Thread Manoj Gupta via Phabricator via lldb-commits
manojgupta added a comment. Still causing a crash using a previously supplied test https://bugs.chromium.org/p/chromium/issues/detail?id=1061533#c7. Any reason this was not tested with a previous repro? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

2020-03-12 Thread Manoj Gupta via Phabricator via lldb-commits
manojgupta added a comment. Hi, I see another crash with this change when building gdb. Reduced test case: struct type *a(type *, type *, long, long); enum b {}; static int empty_array(type *, int c) { type *d = a(__null, d, c, c - 1); } long e; b f() { empty_array(0, e); } Repros with: clang