[Lldb-commits] [PATCH] D100962: [lldb/Utility] Add SourceLocationSpec class (NFC)

mib updated this revision to Diff 341738. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100962/new/ https://reviews.llvm.org/D100962 Files: lldb/include/lldb/Core/SourceLocationSpec.h lldb/source/Core/CMakeLists.txt

[Lldb-commits] [PATCH] D100962: [lldb/Utility] Add SourceLocationSpec class (NFC)

mib updated this revision to Diff 341736. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100962/new/ https://reviews.llvm.org/D100962 Files: lldb/include/lldb/Core/SourceLocationSpec.h lldb/source/Core/CMakeLists.txt

[Lldb-commits] [PATCH] D100962: [lldb/Utility] Add SourceLocationSpec class (NFC)

mib updated this revision to Diff 341734. mib edited the summary of this revision. mib added a comment. Group the FileSpec, the Line and Column number into a `Declaration`. Remove factory function to use constructor and added an `IsValid` method (and boolean operator) Repository: rG LLVM

[Lldb-commits] [PATCH] D100962: [lldb/Utility] Add SourceLocationSpec class (NFC)

mib updated this revision to Diff 340210. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100962/new/ https://reviews.llvm.org/D100962 Files: lldb/include/lldb/Utility/SourceLocationSpec.h lldb/source/Utility/CMakeLists.txt

[Lldb-commits] [PATCH] D100962: [lldb/Utility] Add SourceLocationSpec class (NFC)

mib updated this revision to Diff 340202. mib added a comment. Fix unit test failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100962/new/ https://reviews.llvm.org/D100962 Files: lldb/include/lldb/Utility/SourceLocationSpec.h

[Lldb-commits] [PATCH] D100962: [lldb/Utility] Add SourceLocationSpec class (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100962/new/ https://reviews.llvm.org/D100962

[Lldb-commits] [PATCH] D100962: [lldb/Utility] Add SourceLocationSpec class (NFC)

mib updated this revision to Diff 340117. mib added a comment. Address @JDevlieghere comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100962/new/ https://reviews.llvm.org/D100962 Files: lldb/include/lldb/Utility/SourceLocationSpec.h

[Lldb-commits] [PATCH] D100962: [lldb/Utility] Add SourceLocationSpec class (NFC)

mib marked 7 inline comments as done. mib added inline comments. Comment at: lldb/source/Utility/SourceLocationSpec.cpp:59-61 +bool SourceLocationSpec::operator!=(const SourceLocationSpec ) const { + return !(*this == rhs); +} JDevlieghere wrote: > Isn't this

[Lldb-commits] [PATCH] D100962: [lldb/Utility] Add SourceLocationSpec class (NFC)

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Utility/SourceLocationSpec.h:13-15 +#include "lldb/lldb-defines.h" + +#include "llvm/ADT/Optional.h" Comment at: lldb/include/lldb/Utility/SourceLocationSpec.h:108-138 + ///

[Lldb-commits] [PATCH] D100962: [lldb/Utility] Add SourceLocationSpec class (NFC)

mib updated this revision to Diff 339867. mib edited the summary of this revision. mib added a comment. - Move boolean attributes to the end of the class. - Fix deleted default constructor issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D100962: [lldb/Utility] Add SourceLocationSpec class (NFC)

mib updated this revision to Diff 339743. mib marked an inline comment as done. mib edited the summary of this revision. mib added a comment. Addressed @JDevlieghere comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100962/new/

[Lldb-commits] [PATCH] D100962: [lldb/Utility] Add SourceLocationSpec class (NFC)

mib marked 9 inline comments as done. mib added inline comments. Comment at: lldb/include/lldb/Utility/SourceLocationSpec.h:160 + /// file_spec and line number. An empty \a pattern matches everything. + static bool Match(const SourceLocationSpec , +const

[Lldb-commits] [PATCH] D100962: [lldb/Utility] Add SourceLocationSpec class (NFC)

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Utility/SourceLocationSpec.h:184 + FileSpec m_file_spec; + uint32_t m_line; + llvm::Optional m_column; mib wrote: > JDevlieghere wrote: > > Are there situations where the line is optional too?

[Lldb-commits] [PATCH] D100962: [lldb/Utility] Add SourceLocationSpec class (NFC)

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/include/lldb/Utility/SourceLocationSpec.h:184 + FileSpec m_file_spec; + uint32_t m_line; + llvm::Optional m_column; JDevlieghere wrote: > Are there situations where the line is

[Lldb-commits] [PATCH] D100962: [lldb/Utility] Add SourceLocationSpec class (NFC)

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Utility/SourceLocationSpec.h:12-19 +#include + +#include "lldb/Utility/FileSpec.h" + +#include "llvm/ADT/Optional.h" + +#include Comment at:

[Lldb-commits] [PATCH] D100962: [lldb/Utility] Add SourceLocationSpec class (NFC)

mib created this revision. mib added reviewers: JDevlieghere, jingham. mib added a project: LLDB. Herald added a subscriber: mgorny. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch introduces a new utility class, SourceLocationSpec. A source location