[Lldb-commits] [PATCH] D121844: Applying clang-tidy modernize-use-equals-default over LLDB

This revision was automatically updated to reflect the committed changes. Closed by commit rG24f9a2f53db7: [LLDB] Applying clang-tidy modernize-use-equals-default over LLDB (authored by shafik). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D121844: Applying clang-tidy modernize-use-equals-default over LLDB

shafik updated this revision to Diff 419550. shafik marked 2 inline comments as done. shafik added a comment. - Rebased - Applied clang-format - Address Pavel's comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121844/new/ https://reviews.llvm.org/D121844 Files:

[Lldb-commits] [PATCH] D121844: Applying clang-tidy modernize-use-equals-default over LLDB

shafik marked 3 inline comments as done. shafik added inline comments. Comment at: lldb/source/Core/Value.cpp:667 -const ValueList ::operator=(const ValueList ) { +const ValueList ::operator=(const ValueList ) { // NOLINT(modernize-use-equals-default) m_values =

[Lldb-commits] [PATCH] D121844: Applying clang-tidy modernize-use-equals-default over LLDB

labath added inline comments. Comment at: lldb/source/Core/Value.cpp:667 -const ValueList ::operator=(const ValueList ) { +const ValueList ::operator=(const ValueList ) { // NOLINT(modernize-use-equals-default) m_values = rhs.m_values; shafik wrote: >

[Lldb-commits] [PATCH] D121844: Applying clang-tidy modernize-use-equals-default over LLDB

shafik marked 2 inline comments as done. shafik added inline comments. Comment at: lldb/source/Core/Value.cpp:667 -const ValueList ::operator=(const ValueList ) { +const ValueList ::operator=(const ValueList ) { // NOLINT(modernize-use-equals-default) m_values =

[Lldb-commits] [PATCH] D121844: Applying clang-tidy modernize-use-equals-default over LLDB

labath added a comment. (Please run clang-format before submitting) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121844/new/ https://reviews.llvm.org/D121844 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D121844: Applying clang-tidy modernize-use-equals-default over LLDB

labath accepted this revision. labath added inline comments. Comment at: lldb/source/Core/Value.cpp:667 -const ValueList ::operator=(const ValueList ) { +const ValueList ::operator=(const ValueList ) { // NOLINT(modernize-use-equals-default) m_values = rhs.m_values;

[Lldb-commits] [PATCH] D121844: Applying clang-tidy modernize-use-equals-default over LLDB

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121844/new/ https://reviews.llvm.org/D121844 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D121844: Applying clang-tidy modernize-use-equals-default over LLDB

shafik added inline comments. Comment at: lldb/source/Core/Value.cpp:667 -const ValueList ::operator=(const ValueList ) { +const ValueList ::operator=(const ValueList ) { // NOLINT(modernize-use-equals-default) m_values = rhs.m_values; I have to look into

[Lldb-commits] [PATCH] D121844: Applying clang-tidy modernize-use-equals-default over LLDB

shafik added a comment. We sure do have a lot of `CommandOptions` classes out there. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121844/new/ https://reviews.llvm.org/D121844 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D121844: Applying clang-tidy modernize-use-equals-default over LLDB

shafik created this revision. shafik added reviewers: labath, aprantl, JDevlieghere. Herald added a project: All. shafik requested review of this revision. Applied `modernize-use-equals-default ` clang-tidy check over LLDB. This check is already present in the lldb/.clang-tidy config.