I will update the master tonight.
Thanks
Galina
On Fri, Oct 12, 2018 at 12:36 PM Stella Stamenova
wrote:
> + Galina,
>
>
>
> Galina, is there anything we need to do for the buildbots to pick up the
> change that Vedant made?
>
>
>
> Thanks,
>
> -Stella
>
>
>
> *From:* v...@apple.com
>
Progress! The tests are running again and only a handful fail (some because of
FileCheck, others for various other reasons).
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/29816
It looks like there a number of tests that have failures unrelated to
FileCheck, so anyone
> On Oct 12, 2018, at 12:52 PM, Stella Stamenova via Phabricator
> wrote:
>
> stella.stamenova added a comment.
>
> The bots are now failing because lexists doesn't handle NoneType correctly:
>
>File
>
stella.stamenova added a comment.
The bots are now failing because lexists doesn't handle NoneType correctly:
File
"/lldb-buildbot/lldbSlave/buildWorkingDir/llvm/tools/lldb/packages/Python/lldbsuite/test/configuration.py",
line 191, in get_filecheck_path
if
They have to restart the master, Galina just did it yesterday so it might
happen again in a couple days
On Fri, Oct 12, 2018 at 12:36 PM Stella Stamenova
wrote:
> + Galina,
>
>
>
> Galina, is there anything we need to do for the buildbots to pick up the
> change that Vedant made?
>
>
>
> Thanks,
+ Galina,
Galina, is there anything we need to do for the buildbots to pick up the change
that Vedant made?
Thanks,
-Stella
From: v...@apple.com
Sent: Friday, October 12, 2018 12:34 PM
To: Stella Stamenova
Cc: Zachary Turner ; lldb-commits@lists.llvm.org;
Ah gotcha. For the public Darwin bots, we needed to specifically trigger a
Jenkins job to distribute Zorg updates to all our builders. This can be a bit
of a manual process, because you need to kill the jobs on the builders’ queues
to make sure they run the Zorg_Distribute job asap.
I’m not
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344401: [dotest] Make a missing FileCheck binary a warning,
not an error (authored by vedantk, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Thanks, I’ve been monitoring the bots also and it looks like they haven’t
picked up the zorg change yet. I don’t know if that’s supposed to just happen
or if there’s something that needs to be done or if there’s a schedule for when
they update.
Thanks,
-Stella
From: v...@apple.com
Sent:
stella.stamenova accepted this revision.
stella.stamenova added a comment.
This revision is now accepted and ready to land.
Thanks!
https://reviews.llvm.org/D53175
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
vsk updated this revision to Diff 169471.
vsk added a comment.
- Address comments from @stella.stamenova
https://reviews.llvm.org/D53175
Files:
lldb/packages/Python/lldbsuite/test/configuration.py
lldb/packages/Python/lldbsuite/test/dotest.py
All right, Committed r344396, I’ll keep an eye out for failures.
vedant
> On Oct 12, 2018, at 9:58 AM, Stella Stamenova wrote:
>
> Those changes look reasonable, but I don't know how to test it either. I
> would be in favor of checking it in because the buildbots are currently
> broken and
stella.stamenova requested changes to this revision.
stella.stamenova added a comment.
This revision now requires changes to proceed.
@vsk Could you also make the filecheck function explicitly fail when it doesn't
have a path to the binary? That way it will be fairly obvious what the problem
is
stella.stamenova added a comment.
@jasonmolenda That's not a bad idea. If you have a change ready, you could send
it for review ;)
https://reviews.llvm.org/D53175
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Those changes look reasonable, but I don't know how to test it either. I would
be in favor of checking it in because the buildbots are currently broken and
this can't make it worse, right?
-Original Message-
From: v...@apple.com
Sent: Thursday, October 11, 2018 3:56 PM
To: Stella
Can we get the Xcode build to generate lldb-dotest, just like the cmake build
does? That way there's no need to duplicate build system logic into dotest.py.
It would just live in one place, and we'd all invoke lldb-dotest the same way.
vedant
> On Oct 11, 2018, at 3:53 PM, Jason Molenda via
Does this look reasonable to you? I'm not sure how to test this.
diff --git a/zorg/buildbot/builders/LLDBBuilder.py
b/zorg/buildbot/builders/LLDBBuilder.py
index 5a1b2e87..62152924 100644
--- a/zorg/buildbot/builders/LLDBBuilder.py
+++ b/zorg/buildbot/builders/LLDBBuilder.py
@@ -270,6 +270,7 @@
jasonmolenda added a comment.
(obviously this would only be the behavior if a filecheck path was not
specified)
https://reviews.llvm.org/D53175
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
stella.stamenova added a comment.
The failing bots are not windows bots but Linux bots. It looks like you only
updated the configurations for xcode.
I think the file that needs to be updated is:
zorg\buildbot\builders\LLDBBuilder.py
https://reviews.llvm.org/D53175
> On Oct 11, 2018, at 3:30 PM, Stella Stamenova via Phabricator
> wrote:
>
> stella.stamenova added a comment.
>
> I spent a bit more time on this and I think I have a better idea of what's
> happening.
>
> Vedant added functionality so that we can use FileCheck-style checks inside
>
It's probably not, it's just that the --filecheck arg is missing. I wrote
things this way because I was advised that dotest.py shouldn't assume where
FileCheck is on the filesystem.
vedant
> On Oct 11, 2018, at 3:22 PM, Zachary Turner wrote:
>
> Why is FileCheck missing in the first place?
>
stella.stamenova added a comment.
I spent a bit more time on this and I think I have a better idea of what's
happening.
Vedant added functionality so that we can use FileCheck-style checks inside
non-lit LLDB tests. Part of that change was to require a parameter --filecheck
to be passed when
Why is FileCheck missing in the first place?
On Thu, Oct 11, 2018 at 3:13 PM Vedant Kumar via Phabricator <
revi...@reviews.llvm.org> wrote:
> vsk created this revision.
> vsk added reviewers: stella.stamenova, zturner.
>
> This allows bots which haven't updated to pass in --filecheck to
vsk created this revision.
vsk added reviewers: stella.stamenova, zturner.
This allows bots which haven't updated to pass in --filecheck to dotest.py to
run more tests. FileCheck-dependent tests will continue to fail.
https://reviews.llvm.org/D53175
Files:
24 matches
Mail list logo
